> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Michal Miroslaw
> Sent: Tuesday, December 13, 2016 1:08 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 06/13] null: fake PMD capabilities
>
> From: Paweł Małachowski <pawel.malachow...@atendesoftware.pl>
>
> Thanks to that change we can use Null PMD for testing purposes.
>
> Signed-off-by: Michał Mirosław <michal.miros...@atendesoftware.pl>
> ---
> drivers/net/null/rte_eth_null.c | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index 836d982..f32ba2a 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -284,6 +284,9 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t
> tx_queue_id,
> return 0;
> }
>
> +static void
> +eth_dev_void_ok(struct rte_eth_dev *dev __rte_unused) { return; }
> +
>
> static void
> eth_dev_info(struct rte_eth_dev *dev,
> @@ -304,6 +307,9 @@ eth_dev_info(struct rte_eth_dev *dev,
> dev_info->pci_dev = NULL;
> dev_info->reta_size = internals->reta_size;
> dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads;
> + /* We hereby declare we can RX-offload VLAN-s out of thin air and
> update checksums and VLANs before sinking packets in
> /dev/null */
> + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP;
> + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |
> DEV_TX_OFFLOAD_IPV4_CKSUM;
Hmm, how could it be supported if all that null PMD does on TX - just free the
packets?
Same question for RX.
Konstantin
> }
>
> static void
> @@ -477,7 +483,12 @@ static const struct eth_dev_ops ops = {
> .reta_update = eth_rss_reta_update,
> .reta_query = eth_rss_reta_query,
> .rss_hash_update = eth_rss_hash_update,
> - .rss_hash_conf_get = eth_rss_hash_conf_get
> + .rss_hash_conf_get = eth_rss_hash_conf_get,
> + /* Fake our capabilities */
> + .promiscuous_enable = eth_dev_void_ok,
> + .promiscuous_disable = eth_dev_void_ok,
> + .allmulticast_enable = eth_dev_void_ok,
> + .allmulticast_disable = eth_dev_void_ok
> };
>
> int
> --
> 2.10.2
