On 12/13/2016 1:52 PM, Andrew Rybchenko wrote: > On 12/13/2016 04:37 PM, Shreyansh Jain wrote: >> These callbacks now act as first layer of PCI interfaces from the Bus. >> Bus probe would enter the PMDs through the rte_driver->probe/remove >> callbacks, falling to rte_xxx_driver->probe/remove (Currently, all the >> drivers are rte_pci_driver). > > I think similar changes in drivers/net/sfc/sfc_ethdev.c (already in > dpdk-next-net) are required as well.
Yes, that change is required, but it is a little tricky because this patchset targets main tree where sfc is not merged yet, so this patch can't include required patches. I think it is possible to wait for this patch to be merged into main tree, and when next-net rebased on top of it, sfc can be patched individually. So, yes there is a work to do there, but I think it can be postponed a little. > >> Signed-off-by: Shreyansh Jain <shreyansh.j...@nxp.com> >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 8 ++++++++ >> drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ >> drivers/net/cxgbe/cxgbe_ethdev.c | 4 ++++ >> drivers/net/e1000/em_ethdev.c | 4 ++++ >> drivers/net/e1000/igb_ethdev.c | 8 ++++++++ >> drivers/net/ena/ena_ethdev.c | 4 ++++ >> drivers/net/enic/enic_ethdev.c | 4 ++++ >> drivers/net/fm10k/fm10k_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev.c | 4 ++++ >> drivers/net/i40e/i40e_ethdev_vf.c | 4 ++++ >> drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++++++ >> drivers/net/mlx4/mlx4.c | 4 +++- >> drivers/net/mlx5/mlx5.c | 1 + >> drivers/net/nfp/nfp_net.c | 4 ++++ >> drivers/net/qede/qede_ethdev.c | 8 ++++++++ >> drivers/net/szedata2/rte_eth_szedata2.c | 4 ++++ >> drivers/net/thunderx/nicvf_ethdev.c | 4 ++++ >> drivers/net/virtio/virtio_ethdev.c | 2 ++ >> drivers/net/vmxnet3/vmxnet3_ethdev.c | 4 ++++ >> 19 files changed, 86 insertions(+), 1 deletion(-) <...>
