Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public function

[Iremonger, Bernard]

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Monday, December 12, 2016 4:25 PM
> To: Iremonger, Bernard <bernard.iremon...@intel.com>;
> thomas.monja...@6wind.com; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 6/9] examples/ethtool: use ixgbe public
> function
> 
> On 12/12/2016 1:50 PM, Bernard Iremonger wrote:
> > Replace rte_eth_dev_set_vf_rxmode with
> rte_pmd_ixgbe_set_vf_rx_mode.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremon...@intel.com>
> > ---
> >  examples/ethtool/lib/rte_ethtool.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/examples/ethtool/lib/rte_ethtool.c
> b/examples/ethtool/lib/rte_ethtool.c
> > index a1f91d4..0e539f7 100644
> > --- a/examples/ethtool/lib/rte_ethtool.c
> > +++ b/examples/ethtool/lib/rte_ethtool.c
> > @@ -1,7 +1,7 @@
> >  /*-
> >   *   BSD LICENSE
> >   *
> > - *   Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
> > + *   Copyright(c) 2010-2016 Intel Corporation. All rights reserved.
> >   *   All rights reserved.
> >   *
> >   *   Redistribution and use in source and binary forms, with or without
> > @@ -36,6 +36,7 @@
> >  #include <rte_version.h>
> >  #include <rte_ethdev.h>
> >  #include <rte_ether.h>
> > +#include <rte_pmd_ixgbe.h>
> >  #include "rte_ethtool.h"
> >
> >  #define PKTPOOL_SIZE 512
> > @@ -354,7 +355,7 @@ rte_ethtool_net_set_rx_mode(uint8_t port_id)
> >
> >     /* Set VF vf_rx_mode, VF unsupport status is discard */
> >     for (vf = 0; vf < num_vfs; vf++)
> > -           rte_eth_dev_set_vf_rxmode(port_id, vf,
> > +           rte_pmd_ixgbe_set_vf_rxmode(port_id, vf,
> 
> Will these cause a build error if IXGBE_PMD is not enabled?

Yes, I will send a v4.

> 
> >                     ETH_VMDQ_ACCEPT_UNTAG, 0);
> >
> >     /* Enable Rx vlan filter, VF unspport status is discard */
> >
Regards,

Bernard.