The model is:
 rte_eal_init
 `--> calls rte_eal_bus_probe()
      This iterates over all the drivers and devices and matches them. For
      matched bus specific device-driver and calls:
      `-> rte_driver->probe()
          for all matched device/drivers (rte_bus->match() successful)
          This would be responsible for devargs related checks, eventually
          calling:
          `-> rte_xxx_driver->probe()
              which does all the work from eth_dev allocation to init.
              (Currently, eth_dev init is done by eth_driver->eth_dev_init,
                which would be removed soon)

Signed-off-by: Shreyansh Jain <shreyansh.j...@nxp.com>

--
v2:
 - No more bus->probe call

---
 lib/librte_eal/common/eal_common_bus.c | 50 +++++++++++++++++++++++++++++++++-
 1 file changed, 49 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/common/eal_common_bus.c 
b/lib/librte_eal/common/eal_common_bus.c
index 67b808b..469abac 100644
--- a/lib/librte_eal/common/eal_common_bus.c
+++ b/lib/librte_eal/common/eal_common_bus.c
@@ -195,11 +195,59 @@ rte_eal_bus_scan(void)
        return 0;
 }
 
+static int
+perform_probe(struct rte_bus *bus __rte_unused, struct rte_driver *driver,
+             struct rte_device *device)
+{
+       int ret;
+
+       if (!driver->probe) {
+               RTE_LOG(ERR, EAL, "Driver (%s) doesn't support probe.\n",
+                       driver->name);
+               /* This is not an error - just a badly implemented PMD */
+               return 0;
+       }
+
+       ret = driver->probe(driver, device);
+       if (ret < 0)
+               /* One of the probes failed */
+               RTE_LOG(ERR, EAL, "Probe failed for (%s).\n", driver->name);
+
+       /* In either case, ret <0 (error), ret > 0 (not supported) and ret = 0
+        * success, return ret
+        */
+       return ret;
+}
+
 /* Match driver<->device and call driver->probe() */
 int
 rte_eal_bus_probe(void)
 {
-       /* Until driver->probe is available, this is dummy implementation */
+       int ret;
+       struct rte_bus *bus;
+       struct rte_device *device;
+       struct rte_driver *driver;
+
+       /* For each bus registered with EAL */
+       TAILQ_FOREACH(bus, &rte_bus_list, next) {
+               TAILQ_FOREACH(device, &bus->device_list, next) {
+                       TAILQ_FOREACH(driver, &bus->driver_list, next) {
+                               ret = bus->match(driver, device);
+                               if (!ret) {
+                                       ret = perform_probe(bus, driver,
+                                                           device);
+                                       if (ret < 0)
+                                               return ret;
+
+                                       /* ret == 0 is success; ret >0 implies
+                                        * driver doesn't support the device.
+                                        * in either case, continue
+                                        */
+                               }
+                       }
+               }
+       }
+
        return 0;
 }
 
-- 
2.7.4

Reply via email to