Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Yuanhan Liu
On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > Please, we need a comment for each driver saying > > "it is OK, we do not need any checksum preparation for TSO" > > or > > "yes we have to implement tx_prepare or TSO will not work in this mode" > > Sorry for late. For virtio, I th

[dpdk-dev] Does DPDK 1.7.1 support jumboframes for VMXNET3

2016-12-07 Thread Kanika Singhal
Hi, I am a new to DPDK. My product is using DPDK 1.6 and it does not support jumbo frames for VMXNET3. I have to upgrade to 1.7.1, but i am not able to find info on whether the jumbo frame support is being added for VMXNET3 or not. I can see some jumbo frame related patches being posted for vm

Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation

2016-12-07 Thread Thomas Monjalon
2016-12-07 06:24, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > 2016-12-05 18:25, Akhil Goyal: > > FLib is a library which helps in making the descriptors which is > > understood by NXP's SEC hardware. > > This patch provides header files for command words which can be

Re: [dpdk-dev] [PATCH 11/32] net/dpaa2: add dpaa2 vfio support

2016-12-07 Thread Thomas Monjalon
2016-12-07 12:30, Hemant Agrawal: > On 12/7/2016 2:34 AM, Thomas Monjalon wrote: > > 2016-12-04 23:47, Hemant Agrawal: > >> Add support for using VFIO for dpaa2 based fsl-mc bus. > > > > Why do we need so much special code for interfacing VFIO on fsl-mc? > > Can you reuse some code from EAL VFIO? >

[dpdk-dev] [PATCH v2] eal: optimize aligned rte_memcpy

2016-12-07 Thread Zhihong Wang
This patch optimizes rte_memcpy for well aligned cases, where both dst and src addr are aligned to maximum MOV width. It introduces a dedicated function called rte_memcpy_aligned to handle the aligned cases with simplified instruction stream. The existing rte_memcpy is renamed as rte_memcpy_generic

Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test

2016-12-07 Thread Yang, Zhiyong
Hi, Maxime: > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 6, 2016 4:30 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: yuanhan@linux.intel.com; Richardson, Bruce > ; Ananyev, Konstantin > ; Pierre Pfister (ppfister) > > Subject:

Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test

2016-12-07 Thread Yuanhan Liu
On Wed, Dec 07, 2016 at 09:28:17AM +, Yang, Zhiyong wrote: > > >> Wouldn't be worth to also use rte_memset in Virtio PMD (not > > >> compiled/tested)? : > > >> > > > > > > I think rte_memset maybe can bring some benefit here, but , I'm not > > > clear how to enter the branch and test it. :)

Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

2016-12-07 Thread Yuanhan Liu
On Tue, Dec 06, 2016 at 01:24:40PM +0100, Maxime Coquelin wrote: > Having reference benchmarks is important in order to obtain > reproducible performance figures. > > This patch describes required steps to configure a PVP setup > using testpmd in both host and guest. > > Not relying on external v

Re: [dpdk-dev] [PATCH v2] virtio: tx with can_push when VERSION_1 is set

2016-12-07 Thread Yuanhan Liu
On Wed, Nov 30, 2016 at 09:18:42AM +, Pierre Pfister (ppfister) wrote: > Current virtio driver advertises VERSION_1 support, > but does not handle device's VERSION_1 support when > sending packets (it looks for ANY_LAYOUT feature, > which is absent). > > This patch enables 'can_push' in tx pat

Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test

2016-12-07 Thread Yang, Zhiyong
Hi, yuanhan: > -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, December 7, 2016 5:38 PM > To: Yang, Zhiyong > Cc: Maxime Coquelin ; dev@dpdk.org; > Richardson, Bruce ; Ananyev, Konstantin > ; Pierre Pfister (ppfister) > > Subject: Re: [dpdk-

Re: [dpdk-dev] [PATCH 0/4] eal/common: introduce rte_memset and related test

2016-12-07 Thread Yuanhan Liu
On Wed, Dec 07, 2016 at 09:43:06AM +, Yang, Zhiyong wrote: > > On Wed, Dec 07, 2016 at 09:28:17AM +, Yang, Zhiyong wrote: > > > > >> Wouldn't be worth to also use rte_memset in Virtio PMD (not > > > > >> compiled/tested)? : > > > > >> > > > > > > > > > > I think rte_memset maybe can bring

Re: [dpdk-dev] [PATCH 00/13] Introducing EAL Bus-Device-Driver Model

2016-12-07 Thread Shreyansh Jain
Hello David, On Wednesday 07 December 2016 02:22 AM, David Marchand wrote: "Big patchset and a lot of things to look at. Here is a first look at it. Thanks for comments. On Sun, Dec 4, 2016 at 11:11 AM, Shreyansh Jain wrote: In continuation to the RFC posted on 17/Nov [9], A series of pa

Re: [dpdk-dev] [PATCH 00/32] NXP DPAA2 PMD

2016-12-07 Thread Hemant Agrawal
On 12/7/2016 1:18 AM, Ferruh Yigit wrote: On 12/4/2016 6:16 PM, Hemant Agrawal wrote: The patch series adds NXP’s QorIQ-Layerscape DPAA2 Architecture based network SoC PMD. This version of the driver supports NXP LS208xA, LS204xA and LS108x families Network SoCs. DPAA2, or Data Path Accelerati

Re: [dpdk-dev] [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver

2016-12-07 Thread Hemant Agrawal
On 12/7/2016 2:38 AM, Thomas Monjalon wrote: 2016-12-06 19:49, Ferruh Yigit: On 12/4/2016 6:17 PM, Hemant Agrawal wrote: + if (rte_eal_process_type() == RTE_PROC_PRIMARY) { + eth_dev->data->dev_private = rte_zmalloc( + "ethdev pr

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ferruh Yigit
On 12/6/2016 6:25 PM, Yong Wang wrote: >> -Original Message- >> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] >> Sent: Sunday, December 4, 2016 4:11 AM >> To: Yong Wang ; Thomas Monjalon >> >> Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy >> ; Stephen Hurd >> ; Jan Me

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
Hi Ferruh, > > On 12/6/2016 6:25 PM, Yong Wang wrote: > >> -Original Message- > >> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > >> Sent: Sunday, December 4, 2016 4:11 AM > >> To: Yong Wang ; Thomas Monjalon > >> > >> Cc: Harish Patil ; dev@dpdk.org; Rahul Lakkireddy

Re: [dpdk-dev] [PATCH 11/32] net/dpaa2: add dpaa2 vfio support

2016-12-07 Thread Hemant Agrawal
On 12/7/2016 2:08 PM, Thomas Monjalon wrote: 2016-12-07 12:30, Hemant Agrawal: On 12/7/2016 2:34 AM, Thomas Monjalon wrote: 2016-12-04 23:47, Hemant Agrawal: Add support for using VFIO for dpaa2 based fsl-mc bus. Why do we need so much special code for interfacing VFIO on fsl-mc? Can you reu

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Adrien Mazarguil
On Tue, Dec 06, 2016 at 08:31:35PM +, Ananyev, Konstantin wrote: > > Hi Konstantin, > > > > On Tue, Dec 06, 2016 at 10:56:26AM +, Ananyev, Konstantin wrote: > > > > > > Hi Adrien, > > > > > > > > > > > On Mon, Dec 05, 2016 at 04:43:52PM +, Ananyev, Konstantin wrote: > > > > [...] > > >

Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

2016-12-07 Thread Shreyansh Jain
+ CC: David Marchand On Sunday 04 December 2016 11:47 PM, Hemant Agrawal wrote: The DPAA2 bus driver is a rte_bus driver which scans the fsl-mc bus. Signed-off-by: Hemant Agrawal --- drivers/net/Makefile| 2 +- drivers/net/dpaa2/Makefile | 60 ++

Re: [dpdk-dev] [PATCH] vhost: allow for many vhost user ports

2016-12-07 Thread Yuanhan Liu
On Thu, Dec 01, 2016 at 04:26:50PM +0100, Jan Wickbom wrote: > static int > -fdset_fill(fd_set *rfset, fd_set *wfset, struct fdset *pfdset) > +fdset_fill(struct pollfd *rwfds, struct fdset *pfdset) > { > struct fdentry *pfdentry; > - int i, maxfds = -1; > - int num = MAX_FDS; > - >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
Hi Yliu, > > On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > > Please, we need a comment for each driver saying > > > "it is OK, we do not need any checksum preparation for TSO" > > > or > > > "yes we have to implement tx_prepare or TSO will not work in this mode" > > > > > So

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Yuanhan Liu
On Wed, Dec 07, 2016 at 10:13:14AM +, Ananyev, Konstantin wrote: > > Hi Yliu, > > > > > On Tue, Dec 06, 2016 at 03:53:42PM +, Ferruh Yigit wrote: > > > > Please, we need a comment for each driver saying > > > > "it is OK, we do not need any checksum preparation for TSO" > > > > or > > >

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Ananyev, Konstantin
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: Wednesday, December 7, 2016 10:19 AM > To: Ananyev, Konstantin > Cc: Yigit, Ferruh ; Olivier Matz > ; Thomas Monjalon ; > dev@dpdk.org; Jan Medala ; Jakub Palider > ; Netanel Belgazal ; Evgeny > Schem

Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

2016-12-07 Thread Thomas Monjalon
2016-12-07 15:43, Shreyansh Jain: > IMO, the way Bus is kept is debatable. > - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus > patches) [1]? > - Should it a 'handler/driver' parallel to device drivers? > > I personally prefer a clean layer for buses with: > > - RTE_SDK/dr

[dpdk-dev] [PATCH] crypto/openssl: fix extra bytes being written at end of data

2016-12-07 Thread Piotr Azarewicz
Extra bytes are being written at end of data while process standard openssl cipher encryption. This behaviour is unexpected. This patch disable the padding feature in openssl library, which is causing the problem. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Signed-of

Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model

2016-12-07 Thread Van Haaren, Harry
> From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] Hi Jerin, Re v2 rte_event struct, there seems to be some changes in the struct layout and field sizes. I've investigated them, and would like to propose some changes to balance the byte-alignment and accessing of the fields. These cha

Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical scheduler

2016-12-07 Thread Alan Robertson
Hi Cristian, Looking at points 10 and 11 it's good to hear nodes can be dynamically added. We've been trying to decide the best way to do this for support of qos on tunnels for some time now and the existing implementation doesn't allow this so effectively ruled out hierarchical queueing for tu

Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model

2016-12-07 Thread Bruce Richardson
On Tue, Dec 06, 2016 at 09:22:15AM +0530, Jerin Jacob wrote: > In a polling model, lcores poll ethdev ports and associated > rx queues directly to look for packet. In an event driven model, > by contrast, lcores call the scheduler that selects packets for > them based on programmer-specified criter

Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine

2016-12-07 Thread Ferruh Yigit
On 11/23/2016 5:36 PM, Tomasz Kulasek wrote: > Added "csum txprep (on|off)" command which allows to switch to the > tx path using Tx preparation API. > > By default unchanged implementation is used. > > Using Tx preparation path, pseudo header calculation for udp/tcp/tso > packets from applicatio

[dpdk-dev] [PATCH] Force python scripts to run with python2

2016-12-07 Thread Martin Kletzander
With python3 being the default in some distributions/installations, shebang with just "python" will make the script run under version of python that the scripts are not written for. In order to fix that and mitigate future errors, use shebang properly and specify the python version. That way the

Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation

2016-12-07 Thread Akhil Goyal
-Original Message- From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] Sent: Wednesday, December 07, 2016 2:03 PM To: Akhil Goyal Cc: dev@dpdk.org; declan.dohe...@intel.com; pablo.de.lara.gua...@intel.com; Hemant Agrawal ; Horia Geantă Subject: Re: [PATCH 1/8] drivers/common/dpaa

Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine

2016-12-07 Thread Kulasek, TomaszX
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 12:14 > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > csum engine > > On 11/23/2016 5:36

Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine

2016-12-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Wednesday, December 7, 2016 11:14 AM > To: Kulasek, TomaszX ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > olivier.m...@6wind.com > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparat

Re: [dpdk-dev] [PATCH] Force python scripts to run with python2

2016-12-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Martin Kletzander > Sent: Wednesday, December 7, 2016 10:17 AM > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] Force python scripts to run with python2 > > With python3 being the default in some distributions/inst

Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine

2016-12-07 Thread Kulasek, TomaszX
Hi John, > -Original Message- > From: Mcnamara, John > Sent: Wednesday, December 7, 2016 13:01 > To: Yigit, Ferruh ; Kulasek, TomaszX > ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > csum engine

Re: [dpdk-dev] [PATCH 00/13] Introducing EAL Bus-Device-Driver Model

2016-12-07 Thread David Marchand
Hello Shreyansh, On Wed, Dec 7, 2016 at 10:55 AM, Shreyansh Jain wrote: > On Wednesday 07 December 2016 02:22 AM, David Marchand wrote: >>> 0002~0003: Introducing the basic Bus model and associated test case >>> 0005: Support insertion of device rather than addition to tail >> >> >> Patch 2

Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

2016-12-07 Thread David Marchand
On Wed, Dec 7, 2016 at 11:40 AM, Thomas Monjalon wrote: > 2016-12-07 15:43, Shreyansh Jain: >> IMO, the way Bus is kept is debatable. >> - should it be in EAL (lib/librte_eal/linuxapp/eal_pci.c like Bus >> patches) [1]? >> - Should it a 'handler/driver' parallel to device drivers? >> >> I pers

Re: [dpdk-dev] [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver for fsl-mc bus

2016-12-07 Thread Hemant Agrawal
> -Original Message- > From: David Marchand [mailto:david.march...@6wind.com] > Sent: Wednesday, December 07, 2016 5:52 PM > To: Thomas Monjalon > Cc: Shreyansh Jain ; Hemant Agrawal > ; dev@dpdk.org; Richardson, Bruce > > Subject: Re: [PATCH 10/32] net/dpaa2: introducing dpaa2 bus driver

Re: [dpdk-dev] [PATCH v2 02/32] net/i40e: add callback to user on VF to PF mbox msg

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > The callback asks the user application if it is allowed to > perform the mailbox messages. > > If the return value from user is RTE_PMD_I40E_MB_EVENT_PROCEED > then continue. If ACK or NACK, do nothing and send > not_supported to VF. > > Signed-off-by: We

[dpdk-dev] [PATCH v2] vhost: allow for many vhost user ports

2016-12-07 Thread Jan Wickbom
Currently select() is used to monitor file descriptors for vhostuser ports. This limits the number of ports possible to create since the fd number is used as index in the fd_set and we have seen fds > 1023. This patch changes select() to poll(). This way we can keep an packed (pollfd) array for the

Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-07 Thread Declan Doherty
On 05/12/16 15:12, Neil Horman wrote: On Fri, Dec 02, 2016 at 04:22:16PM +, Declan Doherty wrote: On 02/12/16 14:57, Bruce Richardson wrote: On Fri, Dec 02, 2016 at 03:31:24PM +0100, Thomas Monjalon wrote: 2016-12-02 14:15, Fan Zhang: This patch provides the initial implementation of the

Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine

2016-12-07 Thread Ananyev, Konstantin
Hi everyone, > -Original Message- > From: Kulasek, TomaszX > Sent: Wednesday, December 7, 2016 12:12 PM > To: Mcnamara, John ; Yigit, Ferruh > ; dev@dpdk.org > Cc: Ananyev, Konstantin ; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum >

Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

2016-12-07 Thread Kevin Traynor
On 12/06/2016 12:24 PM, Maxime Coquelin wrote: > Having reference benchmarks is important in order to obtain > reproducible performance figures. > > This patch describes required steps to configure a PVP setup > using testpmd in both host and guest. > > Not relying on external vSwitch ease integr

Re: [dpdk-dev] [PATCH v2 05/32] net/i40e: set TX loopback from PF

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Support enabling/disabling TX loopback from PF. > User can call the API on PF to enable/disable TX loopback > for all the PF and VFs. > > Signed-off-by: Wenzhuo Lu > --- > drivers/net/i40e/i40e_ethdev.c| 219 > ++

Re: [dpdk-dev] [PATCH 00/13] Introducing EAL Bus-Device-Driver Model

2016-12-07 Thread Shreyansh Jain
On Wednesday 07 December 2016 05:47 PM, David Marchand wrote: Hello Shreyansh, On Wed, Dec 7, 2016 at 10:55 AM, Shreyansh Jain wrote: On Wednesday 07 December 2016 02:22 AM, David Marchand wrote: 0002~0003: Introducing the basic Bus model and associated test case 0005: Support insertion

Re: [dpdk-dev] [PATCH 1/8] drivers/common/dpaa2: Run time assembler for Descriptor formation

2016-12-07 Thread Thomas Monjalon
2016-12-07 11:44, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > 2016-12-07 06:24, Akhil Goyal: > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2016-12-05 18:25, Akhil Goyal: > > > FLib is a library which helps in making the descriptors which is > > > u

Re: [dpdk-dev] [PATCH 00/13] Introducing EAL Bus-Device-Driver Model

2016-12-07 Thread Thomas Monjalon
2016-12-07 18:40, Shreyansh Jain: > Is there anything specific that you are looking for in patchset v2? > I was thinking of: > 0. fixing BSD compilation issue reported by CI > 1. improving the test_pci.c > 2. hotplugging > 3. trying to move PCI to drives/bus/pci/linux/* and resolving how > drivers

Re: [dpdk-dev] [PATCH] vhost: allow for many vhost user ports

2016-12-07 Thread Jan Wickbom
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > Sent: den 7 december 2016 11:13 > To: Jan Wickbom > Cc: dev@dpdk.org; Patrik Andersson R > Subject: Re: [PATCH] vhost: allow for many vhost user ports > > On Thu, Dec 01, 2016 at 04:26:50PM +0100, Jan Wickb

Re: [dpdk-dev] [PATCH v2 09/32] rte: add APIs for VF stats get/reset

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > This patch add below two APIs so that VF statistics > can be get/clear from PF side. > rte_eth_vf_stats_get. > rte_eth_vf_stats_reset. patch subject can have " ... from PF" both to be consistent with other patches and to clarify what it does: add APIS to g

Re: [dpdk-dev] [PATCH v2 10/32] net/i40e: implement ops for VF stats get/reset

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > This patch implement vf_stats_get and vf_stats_reset ops for i40e. > > Signed-off-by: Qi Zhang > --- <...> > +static int > +i40e_vf_stats_get(struct rte_eth_dev *dev, > + uint16_t vf, > + struct rte_eth_stats *stats) > +{ > +

Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-07 Thread Neil Horman
On Wed, Dec 07, 2016 at 12:42:15PM +, Declan Doherty wrote: > On 05/12/16 15:12, Neil Horman wrote: > > On Fri, Dec 02, 2016 at 04:22:16PM +, Declan Doherty wrote: > > > On 02/12/16 14:57, Bruce Richardson wrote: > > > > On Fri, Dec 02, 2016 at 03:31:24PM +0100, Thomas Monjalon wrote: > > >

Re: [dpdk-dev] [PATCH v2 15/32] net/i40e: add VF vlan strip func

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Add a function to configure vlan strip enable/disable for specific > SRIOV VF device. > > Signed-off-by: Chen Jing D(Mark) > --- <...> > + > +/* Set vlan strip on/off for specific VF from host */ > +int > +rte_pmd_i40e_set_vf_vlan_stripq(uint8_t port, u

Re: [dpdk-dev] [PATCH v2 16/32] net/i40e: add set VF VLAN insert function

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Support inserting VF VLAN id from PF. > User can call the API on PF to insert a VLAN id to a > specific VF. Same comment with prev patch, does it make sense to insert " from PF" to patch title? > > Signed-off-by: Bernard Iremonger > --- > drivers/net/i

Re: [dpdk-dev] [PATCH v2 12/32] net/i40e: set VF MAC from PF support

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > Support setting VF MAC address from PF. > User can call the API on PF to set a specific > VF's MAC address. > > This will reset the VF. > > Signed-off-by: Ferruh Yigit > --- <...> > > +/** > + * Set the VF MAC address. > + * > + * This will reset the

Re: [dpdk-dev] [PATCH v12 0/6] add Tx preparation

2016-12-07 Thread Alejandro Lucero
For NFP, we do not have TSO support yet, although it is coming and hopefully it will be within next release. Regarding this email thread, it is "it is OK, we do not need any checksum preparation for TSO" On Wed, Dec 7, 2016 at 10:03 AM, Ananyev, Konstantin < konstantin.anan...@intel.com> wrote:

Re: [dpdk-dev] [PATCH v2 17/32] net/i40e: set VF broadcast mode from PF

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Support enabling/disabling VF broadcast mode from PF. > User can call the API on PF to enable/disable a specific > VF's broadcast mode. > > Signed-off-by: Bernard Iremonger <...> > +int rte_pmd_i40e_set_vf_broadcast(uint8_t port, uint16_t vf_id, uint8_t

Re: [dpdk-dev] [PATCH v2 16/32] net/i40e: add set VF VLAN insert function

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 2:26 PM, Ferruh Yigit wrote: > On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: >> Support inserting VF VLAN id from PF. >> User can call the API on PF to insert a VLAN id to a >> specific VF. > > Same comment with prev patch, does it make sense to insert " from PF" to > patch title? > >> >>

Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-07 Thread Richardson, Bruce
> -Original Message- > From: Neil Horman [mailto:nhor...@tuxdriver.com] > Sent: Wednesday, December 7, 2016 2:17 PM > To: Doherty, Declan > Cc: Richardson, Bruce ; Thomas Monjalon > ; Zhang, Roy Fan ; > dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler cr

Re: [dpdk-dev] [PATCH v2 19/32] net/i40e: set VF VLAN filter from PF

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > add rte_pmd_i40e_set_vf_vlan_filter API. > User can call the API on PF to enable/disable > a set of VF's VLAN filters. > > Signed-off-by: Bernard Iremonger > --- > drivers/net/i40e/i40e_ethdev.c| 50 > +++ > drive

Re: [dpdk-dev] [PATCH] Force python scripts to run with python2

2016-12-07 Thread Thomas Monjalon
2016-12-07 12:04, Mcnamara, John: > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Martin Kletzander > > Sent: Wednesday, December 7, 2016 10:17 AM > > To: dev@dpdk.org > > Subject: [dpdk-dev] [PATCH] Force python scripts to run with python2 > > > > With pyth

Re: [dpdk-dev] [PATCH v2 03/12] crypto/armv8: Add core crypto operations for ARMv8

2016-12-07 Thread Thomas Monjalon
2016-12-07 04:54, Jerin Jacob: > On Tue, Dec 06, 2016 at 02:41:01PM -0800, Thomas Monjalon wrote: > > 2016-12-07 03:35, Jerin Jacob: > > > On Tue, Dec 06, 2016 at 10:42:51PM +0100, Thomas Monjalon wrote: > > > > 2016-12-07 02:48, Jerin Jacob: > > > > > On Tue, Dec 06, 2016 at 09:29:25PM +0100, Thom

Re: [dpdk-dev] [PATCH v2 22/32] app/testpmd: use multicast promiscuous mode on i40e

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF multicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 86 > + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files chang

Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive mode for VMDq

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Initialise VMDq in the init_port_config function in a similar > way to how it is done in the VMDq sample application. What is the effect of doing existing initialization? > > Signed-off-by: Bernard Iremonger > --- <...>

Re: [dpdk-dev] [PATCH v2 27/32] net/i40e: change version number to support Linux VF

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > i40e PF host only support to work with DPDK VF driver, Linux > VF driver is not supported. This change will enhance in version > number returned. > > Current version info returned won't be able to be recognized > by Linux VF driver, change to values that b

Re: [dpdk-dev] [PATCH v2 28/32] net/i40e: return correct vsi_id

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > PF host didn't return correct VSI id to VF. > This change fix it. This looks like a fix for current code, can you please update commit title and log to reflect the fix? > > Signed-off-by: Chen Jing D(Mark) > --- > drivers/net/i40e/i40e_pf.c | 3 +-- >

Re: [dpdk-dev] [PATCH v2 21/32] app/testpmd: use unicast promiscuous mode on i40e

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Add testpmd CLI to set VF unicast promiscuous mode on i40e. > > Signed-off-by: Wenzhuo Lu > --- > app/test-pmd/cmdline.c | 92 > + > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 +++ > 2 files changed

Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter and configure

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > When VF requested to configure TX queue, a few parameters are > missed to be configured in PF host. This change have more > fields parsed and configured for TX context. What is the effect of missing Tx paramters configured? If this cause a bug, this patch

Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter and configure

2016-12-07 Thread Chen, Jing D
Hi, Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:19 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 29/32] net/i40e: parse more VF parameter > and configure > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:

Re: [dpdk-dev] [PATCH v2 28/32] net/i40e: return correct vsi_id

2016-12-07 Thread Chen, Jing D
Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:16 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 28/32] net/i40e: return correct vsi_id > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > PF host didn't re

Re: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID

2016-12-07 Thread Ferruh Yigit
On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > Some CLIs don't check the input port ID, it > may cause segmentation fault (core dumped). Are these functions (that we are adding extra check) added with this patchset? If so why not add these checks where function implemented. If these functions are alre

Re: [dpdk-dev] [PATCH] Scheduler: add driver for scheduler crypto pmd

2016-12-07 Thread Declan Doherty
On 07/12/16 14:46, Richardson, Bruce wrote: -Original Message- From: Neil Horman [mailto:nhor...@tuxdriver.com] Sent: Wednesday, December 7, 2016 2:17 PM To: Doherty, Declan Cc: Richardson, Bruce ; Thomas Monjalon ; Zhang, Roy Fan ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Schedul

Re: [dpdk-dev] [PATCH v2 03/12] crypto/armv8: Add core crypto operations for ARMv8

2016-12-07 Thread Jerin Jacob
On Wed, Dec 07, 2016 at 04:00:07PM +0100, Thomas Monjalon wrote: > 2016-12-07 04:54, Jerin Jacob: > > On Tue, Dec 06, 2016 at 02:41:01PM -0800, Thomas Monjalon wrote: > > > 2016-12-07 03:35, Jerin Jacob: > > > > On Tue, Dec 06, 2016 at 10:42:51PM +0100, Thomas Monjalon wrote: > > > > > 2016-12-07 0

Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive mode for VMDq

2016-12-07 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 3:07 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v2 26/32] app/testpmd: initialize receive > mode for VMDq > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrot

Re: [dpdk-dev] [PATCH v2 3/6] eventdev: implement the northbound APIs

2016-12-07 Thread Jerin Jacob
On Tue, Dec 06, 2016 at 05:17:12PM +, Bruce Richardson wrote: > On Tue, Dec 06, 2016 at 09:22:17AM +0530, Jerin Jacob wrote: > > This patch implements northbound eventdev API interface using > > southbond driver interface > > > > Signed-off-by: Jerin Jacob > > --- > > + /* Re alloca

[dpdk-dev] [PATCH] net/ixgbe: fix typo in comment

2016-12-07 Thread Ferruh Yigit
Fixes: c03fcee9abbd ("ixgbe: remove CRC size from byte counters") Signed-off-by: Ferruh Yigit --- CC: sta...@dpdk.org --- drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c i

Re: [dpdk-dev] [PATCH] config: remove insecure warnings

2016-12-07 Thread Thomas Monjalon
2016-12-05 10:27, Bruce Richardson: > On Sun, Dec 04, 2016 at 11:17:06PM +0100, Thomas Monjalon wrote: > > There was an option CONFIG_RTE_INSECURE_FUNCTION_WARNING (disabled by > > default), which prevents from using some libc functions: > > sprintf, snprintf, vsnprintf, strcpy, strncpy, strcat, st

Re: [dpdk-dev] [PATCH v2 16/32] net/i40e: add set VF VLAN insert function

2016-12-07 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 2:26 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v2 16/32] net/i40e: add set VF VLAN insert > function > > On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: >

Re: [dpdk-dev] [PATCH v3] kni: avoid using lsb_release script

2016-12-07 Thread Thomas Monjalon
2016-11-25 12:24, Ferruh Yigit: > On 11/25/2016 12:22 PM, Robin Jarry wrote: > > The lsb_release script is part of an optional package which is not > > always installed. On the other hand, /etc/lsb-release is always present > > even on minimal Ubuntu installations. > > > > root@ubuntu1604:~# d

Re: [dpdk-dev] [PATCH v2 19/32] net/i40e: set VF VLAN filter from PF

2016-12-07 Thread Iremonger, Bernard
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 2:46 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Iremonger, Bernard > Subject: Re: [dpdk-dev] [PATCH v2 19/32] net/i40e: set VF VLAN filter from > PF > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > ad

[dpdk-dev] [RFC] pci: remove unused UNBIND support

2016-12-07 Thread Stephen Hemminger
No device driver sets the unbind flag in current public code base. Therefore it is good time to remove the unused dead code. Signed-off-by: Stephen Hemminger --- lib/librte_eal/bsdapp/eal/eal_pci.c | 9 lib/librte_eal/common/eal_common_pci.c | 5 - lib/librte_eal/common/inclu

Re: [dpdk-dev] [PATCH] ethdev: don't look for devices if none were found

2016-12-07 Thread Thomas Monjalon
2016-11-19 13:10, Anatoly Burakov: > Aside from avoiding doing useless work, this also fixes a segfault > when calling rte_eth_dev_get_port_by_name() whenever no devices > were found yet, and therefore rte_eth_dev_data wasn't yet allocated. > > Fixes: 9c5b8d8b9feb ("ethdev: clean port id retrieval

Re: [dpdk-dev] [PATCH v3] net/i40evf: fix reporting of imissed packets

2016-12-07 Thread Ferruh Yigit
On 12/6/2016 8:16 PM, Tom Crugnale wrote: > Missed packets on RX were erroneously being assigned to the ierrors > struct member. Change it to be assigned to imissed. > > Fixes: 4861cde4 ("i40e: new poll mode driver") > > Signed-off-by: Tom Crugnale > --- > v3: > * Fixed coding style issues > v2:

Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model

2016-12-07 Thread Jerin Jacob
On Tue, Dec 06, 2016 at 04:51:19PM +, Bruce Richardson wrote: > On Tue, Dec 06, 2016 at 09:22:15AM +0530, Jerin Jacob wrote: > > In a polling model, lcores poll ethdev ports and associated > > rx queues directly to look for packet. In an event driven model, > > by contrast, lcores call the sche

Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical scheduler

2016-12-07 Thread Dumitrescu, Cristian
Hi Steve, Thanks for your comments! > This seems to be more of an abstraction of existing QoS. Really? Why exactly do you say this, any particular examples? I think the current proposal provides an abstraction for far more features than librte_sched provides. The goal for this API is to be ab

Re: [dpdk-dev] [PATCH v2 02/12] lib: add cryptodev type for the upcoming ARMv8 PMD

2016-12-07 Thread Zbigniew Bodek
On 06.12.2016 21:27, Thomas Monjalon wrote: 2016-12-06 18:32, zbigniew.bo...@caviumnetworks.com: From: Zbigniew Bodek Add type and name for ARMv8 crypto PMD Signed-off-by: Zbigniew Bodek [...] --- a/lib/librte_cryptodev/rte_cryptodev.h +++ b/lib/librte_cryptodev/rte_cryptodev.h @@ -66,6 +6

[dpdk-dev] [PATCH v2] maintainers: update for qede PMD and bnx2x PMD

2016-12-07 Thread Rasesh Mody
Following Cavium's acquisition of QLogic we need to update all the qlogic PMD maintainer's entries to point to our new e-mail addresses. Update driver's maintainers as they are no longer working for Cavium. Thanks to Sony Chacko for his support and development of our various dpdk drivers. Signed-

[dpdk-dev] [PATCH v10] drivers/net:new TUN/TAP device PMD

2016-12-07 Thread Keith Wiles
The PMD allows for DPDK and the host to communicate using a raw device interface on the host and in the DPDK application. The device created is a Tap device with a L2 packet header. v10- Change the string name used to allow for multiple devices. v9 - Fix up the docs to use correct syntax v8 - Fix

Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical scheduler

2016-12-07 Thread Dumitrescu, Cristian
Hi Alan, Thanks for your comments! > Hi Cristian, > Looking at points 10 and 11 it's good to hear nodes can be dynamically added. Yes, many implementations allow on-the-fly remapping a node from one parent to another one, or simply adding more nodes post-initialization, so it is natural for t

Re: [dpdk-dev] [PATCH v2 02/12] lib: add cryptodev type for the upcoming ARMv8 PMD

2016-12-07 Thread Thomas Monjalon
2016-12-07 20:04, Zbigniew Bodek: > On 06.12.2016 21:27, Thomas Monjalon wrote: > > 2016-12-06 18:32, zbigniew.bo...@caviumnetworks.com: > >> From: Zbigniew Bodek > >> > >> Add type and name for ARMv8 crypto PMD > >> > >> Signed-off-by: Zbigniew Bodek > > [...] > >> --- a/lib/librte_cryptodev/rte

Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical scheduler

2016-12-07 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Tuesday, December 6, 2016 10:14 PM > To: Stephen Hemminger > Cc: dev@dpdk.org; Dumitrescu, Cristian > Subject: Re: [dpdk-dev] [RFC] ethdev: abstraction layer for QoS hierarchical > scheduler > > 201

Re: [dpdk-dev] [PATCH] vdev: fix missing alias check on uninit

2016-12-07 Thread Thomas Monjalon
2016-11-18 16:32, Anatoly Burakov: > Fixes: d63eed6b2dca ("eal: add driver name alias") > > Signed-off-by: Anatoly Burakov CC: sta...@dpdk.org Applied, thanks

Re: [dpdk-dev] [PATCH v10] drivers/net:new TUN/TAP device PMD

2016-12-07 Thread Aws Ismail
On Wed, Dec 7, 2016 at 2:38 PM, Keith Wiles wrote: > > Signed-off-by: Keith Wiles Tested-by: Aws Ismail

Re: [dpdk-dev] [PATCH v2] doc: introduce PVP reference benchmark

2016-12-07 Thread Mcnamara, John
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, December 6, 2016 12:25 PM > To: yuanhan@linux.intel.com; thomas.monja...@6wind.com; Mcnamara, John > ; Yang, Zhiyong ; > ktray...@redhat.com; dev@dpdk.org > Cc: Maxime Coquelin > Subject:

Re: [dpdk-dev] [PATCH v2 09/12] doc/armv8: update documentation about crypto PMD

2016-12-07 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > zbigniew.bo...@caviumnetworks.com > Sent: Wednesday, December 7, 2016 2:33 AM > To: De Lara Guarch, Pablo ; > jerin.ja...@caviumnetworks.com > Cc: dev@dpdk.org; Zbigniew Bodek > Subject: [dpdk-dev] [PATCH v2 09

Re: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID

2016-12-07 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 11:49 PM > To: Lu, Wenzhuo; dev@dpdk.org > Cc: Chen, Jing D > Subject: Re: [dpdk-dev] [PATCH v2 32/32] app/testpmd: fix invalid port ID > > On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > > Some CLIs don'

Re: [dpdk-dev] [PATCH] net/ixgbe: fix typo in comment

2016-12-07 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, December 8, 2016 1:20 AM > To: dev@dpdk.org > Cc: Zhang, Helin; Ananyev, Konstantin; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix typo in comment > > Fixes: c03f

Re: [dpdk-dev] [PATCH v2] eal: optimize aligned rte_memcpy

2016-12-07 Thread Yao, Lei A
Tested-by: Lei Yao - Apply patch to v16.11 I have tested the loopback performance for this patch on 3 following settings: CPU: IVB Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 CPU: HSW Fedora 21 Kernal: 4.1.13 gcc: 4.9.2 CPU:BDW Ubutnu16.04 Kernal: 4.4.0 gcc : 5.4.0 I can see 10%~20% performance gai

Re: [dpdk-dev] [PATCH v2 12/32] net/i40e: set VF MAC from PF support

2016-12-07 Thread Lu, Wenzhuo
Hi Ferruh, > -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, December 7, 2016 10:30 PM > To: Lu, Wenzhuo; dev@dpdk.org > Subject: Re: [PATCH v2 12/32] net/i40e: set VF MAC from PF support > > On 12/7/2016 3:31 AM, Wenzhuo Lu wrote: > > Support setting VF MAC address from PF. >

Re: [dpdk-dev] [PATCH v2 1/6] eventdev: introduce event driven programming model

2016-12-07 Thread Jerin Jacob
On Wed, Dec 07, 2016 at 10:57:13AM +, Van Haaren, Harry wrote: > > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > > Hi Jerin, Hi Harry, > > Re v2 rte_event struct, there seems to be some changes in the struct layout > and field sizes. I've investigated them, and would like to

[dpdk-dev] [PATCH 0/2] minor cleanups

2016-12-07 Thread Stephen Hemminger
Saw this while reviewing other changes Stephen Hemminger (2): eth: get rid of goto's in rte_eth_dev_detach sched/malloc: remove unnecesary return statements drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- lib/librte_eal/common/rte_malloc.c | 1 - lib/librte_ether/rte_ethdev.c |

  1   2   >