Hi everyone, > -----Original Message----- > From: Kulasek, TomaszX > Sent: Wednesday, December 7, 2016 12:12 PM > To: Mcnamara, John <john.mcnam...@intel.com>; Yigit, Ferruh > <ferruh.yi...@intel.com>; dev@dpdk.org > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; olivier.m...@6wind.com > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum > engine > > Hi John, > > > -----Original Message----- > > From: Mcnamara, John > > Sent: Wednesday, December 7, 2016 13:01 > > To: Yigit, Ferruh <ferruh.yi...@intel.com>; Kulasek, TomaszX > > <tomaszx.kula...@intel.com>; dev@dpdk.org > > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; > > olivier.m...@6wind.com > > Subject: RE: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > > csum engine > > > > > -----Original Message----- > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > > > Sent: Wednesday, December 7, 2016 11:14 AM > > > To: Kulasek, TomaszX <tomaszx.kula...@intel.com>; dev@dpdk.org > > > Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>; > > > olivier.m...@6wind.com > > > Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in > > > csum engine > > > > > > ... > > > <...> > > > > +cmdline_parse_inst_t cmd_csum_txprep = { > > > > + .f = cmd_csum_txprep_parsed, > > > > + .data = NULL, > > > > + .help_str = "enable/disable tx preparation path for csum > > > > engine: " > > > > + "csum txprep on|off", > > > > > > Can you please format help string as: > > > "cmd fixed_string fixed|string|options <variable>: Description" > > > see commit 26faac80327f > > > > > > above becomes: > > > "csum txprep on|off: Enable/Disable tx preparation path for csum engine" > > > > > > > > > Also, does this require an update to the testpmd docs? > > > > > > Yes, I think. I will add adequate description to the docs.
I suppose if we'll get tx_prepare() addressed on all PMDs DPDK support we can safely remove that command. Konstantin > > Tomasz
