Hi,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 12:14
> To: Kulasek, TomaszX <tomaszx.kula...@intel.com>; dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.anan...@intel.com>;
> olivier.m...@6wind.com
> Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in
> csum engine
>
> On 11/23/2016 5:36 PM, Tomasz Kulasek wrote:
> > Added "csum txprep (on|off)" command which allows to switch to the tx
> > path using Tx preparation API.
> >
> > By default unchanged implementation is used.
> >
> > Using Tx preparation path, pseudo header calculation for udp/tcp/tso
> > packets from application, and used Tx preparation API for packet
> > preparation and verification.
> >
> > Adding additional step to the csum engine costs about 3-4% of
> > performance drop, on my setup with ixgbe driver. It's caused mostly by
> > the need of reaccessing and modification of packet data.
> >
> > Signed-off-by: Tomasz Kulasek <tomaszx.kula...@intel.com>
> > Acked-by: Konstantin Ananyev <konstantin.anan...@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 49
> +++++++++++++++++++++++++++++++++++++++++++++++
> > app/test-pmd/csumonly.c | 33 ++++++++++++++++++++++++-------
> > app/test-pmd/testpmd.c | 5 +++++
> > app/test-pmd/testpmd.h | 2 ++
> > 4 files changed, 82 insertions(+), 7 deletions(-)
> >
> > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> > 63b55dc..373fc59 100644
> <...>
> > +cmdline_parse_inst_t cmd_csum_txprep = {
> > + .f = cmd_csum_txprep_parsed,
> > + .data = NULL,
> > + .help_str = "enable/disable tx preparation path for csum engine: "
> > + "csum txprep on|off",
>
> Can you please format help string as:
> "cmd fixed_string fixed|string|options <variable>: Description"
> see commit 26faac80327f
>
> above becomes:
> "csum txprep on|off: Enable/Disable tx preparation path for csum engine"
>
> <...>
Sure, thanks.
Tomasz
