2016-12-07 11:44, Akhil Goyal: > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > 2016-12-07 06:24, Akhil Goyal: > > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > > 2016-12-05 18:25, Akhil Goyal: > > > FLib is a library which helps in making the descriptors which is > > > understood by NXP's SEC hardware. > > > This patch provides header files for command words which can be used > > > for descritptor formation. > > > > It seems this code is old. Does it exist as a standalone library somewhere? > [Akhil] Let me correct here. This is not a library. This is a set of header > files.
Use the name you want but please be consistent. You said above: "FLib is a library" and now "This is not a library" Funny :) > Yes this is an old code. This is generally shipped with NXP SDK. > > > Where was it hosted before duplicating it in DPDK? > [Akhil] This is part of NXP SDK and also available at git.freescale.com. So it is not a DPDK code. It should be a standalone library (or set of headers) and packaged as well. > > Why do you want to have a common directory drivers/common/dpaa2/flib > > instead of a sub-directory in the crypto driver? > [Akhil] I agree with your suggestion. This can be maintained within > drivers/crypto as a common header files set for different NXP Architecture > crypto drivers. Yes it can be in drivers/crypto/ or not in DPDK at all.