Re: [PATCH v2] examples/l3fwd: add option to set Tx burst size

On 2025/2/20 1:01, Konstantin Ananyev wrote: On 2024/12/4 10:06, Jie Hai wrote: The application send packets only when the buffer is full, or the buffer is empty and the packets to be sent extends TX_PKT_BURST. The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST increase, while

[PATCH v2 06/16] net/zxdh: optimize MAC ops

optimize MAC ops Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 40 +- drivers/net/zxdh/zxdh_ethdev.h | 13 +++- drivers/net/zxdh/zxdh_ethdev_ops.c | 59 +-- drivers/net/zxdh/zxdh_msg.c| 118 + drivers/net/zxdh/

[PATCH v2 08/16] net/zxdh: optimize VLAN filter/offload ops

optimize VLAN filter/offload ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 42 +++-- drivers/net/zxdh/zxdh_msg.c| 81 + drivers/net/zxdh/zxdh_msg.h| 5 +- drivers/net/zxdh/zxdh_tables.c | 139 + d

[PATCH v2 03/16] net/zxdh: optimize link update process

optimize link update process. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev_ops.c b/drivers/net/zxdh/zxdh_ethdev_ops.c index 7ebb231362..83ea1188a0 100

[PATCH v2 05/16] net/zxdh: provided PF/VF msg intr callback

provided PF/VF msg intr callback. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 6 +- drivers/net/zxdh/zxdh_msg.c| 186 +++-- drivers/net/zxdh/zxdh_msg.h| 9 ++ drivers/net/zxdh/zxdh_tables.c | 17 +++ drivers/net/zxdh/zxdh_tables.h |

[PATCH v2 15/16] net/zxdh: provide ptypes FW version EEPROM ops

provide ptypes、FW version、EEPROM ops. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 2 + drivers/net/zxdh/zxdh_ethdev.c | 30 + drivers/net/zxdh/zxdh_ethdev_ops.c | 200 + drivers/net/zxdh/zxdh_ethdev_ops.h | 5 + drivers/net/zxdh/z

[PATCH v2 09/16] net/zxdh: optimize RSS/RETA hash config/update/get

optimize RSS hash config/update,RETA update/get. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 1 - drivers/net/zxdh/zxdh_msg.c| 129 + 2 files changed, 129 insertions(+), 1 deletion(-) diff --git a/drivers/net/zxdh/zxdh_ethdev_ops.c

[PATCH v2 10/16] net/zxdh: optimize MTU set ops

optimize MTU set ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev_ops.c | 8 ++--- drivers/net/zxdh/zxdh_msg.c| 42 + drivers/net/zxdh/zxdh_tables.h | 49 +++--- 3 files changed, 90 insertions(+), 9 deletions(-) diff

[PATCH v2 14/16] net/zxdh: provide extended stats ops implementations

provide extended stats ops implementations. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 1 + doc/guides/nics/zxdh.rst | 1 + drivers/net/zxdh/zxdh_ethdev.c | 3 + drivers/net/zxdh/zxdh_ethdev_ops.c | 265 - drivers/net/zxdh

[PATCH v2 13/16] net/zxdh: provided rxq/txq info get implementations

provided rxq/txq info get implementations. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_ethdev.c | 40 -- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/net/zxdh/zxdh_ethdev.c b/drivers/net/zxdh/zxdh_ethdev.c index 30ddb463a2..19c2

[PATCH v2 12/16] net/zxdh: provided CSUM/TSO/LRO config

provided CSUM/TSO/LRO config. Signed-off-by: Junlong Wang --- doc/guides/nics/features/zxdh.ini | 5 ++ doc/guides/nics/zxdh.rst | 3 + drivers/net/zxdh/zxdh_ethdev.c| 92 +++ drivers/net/zxdh/zxdh_msg.c | 15 + 4 files changed, 115 insertions

[PATCH v2 07/16] net/zxdh: optimize promisc ops

optimize promisc ops. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_msg.c| 62 ++ drivers/net/zxdh/zxdh_tables.c | 49 +++ drivers/net/zxdh/zxdh_tables.h | 3 +- 3 files changed, 113 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v2 02/16] net/zxdh: optimize queue res alloc/free process

optimize queue res alloc/free process. Signed-off-by: Junlong Wang --- drivers/net/zxdh/zxdh_common.c | 27 ++-- drivers/net/zxdh/zxdh_ethdev.c | 200 - drivers/net/zxdh/zxdh_ethdev.h | 14 +- drivers/net/zxdh/zxdh_ethdev_ops.c | 13 +- drivers/net/zxdh

[PATCH v2 00/16] net/zxdh: updated net zxdh driver

V2: - modify CI some error results(checkpatches warnings、Wrong headline format) - fix warnings when enable extra warnings. - modify apply memcpy script for coccinelle and unnecessary init and unneccessary cast of void when use malloc. V1: - updated net zxdh driver. optimize init an

Re: [PATCH] app/testpmd: fix out-of-bound reference in offload config

LGTM, Acked-by: Huisong Li 在 2025/2/21 4:44, Stephen Hemminger 写道: When configuring offloads, need to check the port id before indexing into the ports[] array. This can easily be done by moving the call to oh_dev_conf_get_print_err() to before the checks for port stopped. Fixes: c73a9071877a ("

Re: [PATCH] app/testpmd: fix fail to set queue number when attach device

在 2025/2/21 4:56, Stephen Hemminger 写道: On Tue, 18 Feb 2025 19:31:56 +0800 Huisong Li wrote: Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a new device. The root cause is that "port config all rxq " would check if all ports are stopped and the status of this port is

[PATCH 3/3] maintainers: update for Intel FPGA rawdev drivers

Change of maintainers' email for Intel FPGA rawdev drivers Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 979e8ffb07..82f6e2f917 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1540,7 +1540,7 @@ Rawdev Dr

[PATCH 2/3] maintainers: update for Intel FPGA bus drivers

Change of maintainers' email for Intel FPGA bus drivers. Signed-off-by: Rosen Xu --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index fc65715d39..979e8ffb07 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -621,7 +621,7 @@ M: Xueming Li

[PATCH 1/3] maintainers: update for Intel ipn3ke drivers

Change of maintainers' email for Intel ipn3ke drivers. Signed-off-by: Rosen Xu --- .mailmap| 2 +- MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index a03d3cfb59..59933f9bc3 100644 --- a/.mailmap +++ b/.mailmap @@ -1325,7 +1325,7 @@ Ro

RE: [EXTERNAL] [Patch v2] net/mana: use mana_local_data for tracking usage data for primary process

> The DPDK has converted to using the C11 atomic's so this should use that (i.e > RTE_ATOMIC() etc) instead of the older atomic primitives. > I have sent v3.

[Patch v3] net/mana: use mana_local_data for tracking usage data for primary process

From: Long Li The driver uses mana_shared_data for tracking usage count for primary process. This is not correct as the mana_shared_data is allocated by the primary and is meant to track usage of secondary process by the primary process. And it creates a race condition when the device is removed

[PATCH v1 20/32] net/ntnic: add clock init

Add initialization for the clock subsystem Signed-off-by: Serhii Iliushyk --- ...00D13_U62_Si5332-GM2-RevD-1_V5-Registers.h | 425 ++ .../net/ntnic/nthw/core/include/nthw_i2cm.h | 1 + .../nthw/core/include/nthw_pcm_nt400dxx.h | 14 + .../nthw/core/include/nthw_si5332_si

[PATCH] net/zxdh: remove unnecessary null free checks

Remove unnecessary checks for null pointer. Found by devtools/cocci/nullfree.cocci script. Signed-off-by: Stephen Hemminger --- drivers/net/zxdh/zxdh_ethdev.c | 3 +-- drivers/net/zxdh/zxdh_np.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/zxdh/zxdh_eth

[PATCH v1 31/32] net/ntnic: init IGAM and config PLL for FPGA

From: Danylo Vodopianov - Initialize IGAM module and check for its presence. - Enable system PLL using IGAM and check for PLL lock status. - Reset and configure TS PLL and check for lock status. - Force HIF soft reset and de-assert platform reset. - Enable RAB1 and RAB2 and perform RAB initializa

[PATCH v1 26/32] net/ntnic: add i2cm init

From: Danylo Vodopianov Create and initialize I2C for FPGA. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/nthw/core/include/nthw_i2cm.h | 2 + .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 7 ++ drivers/net/ntnic/nthw/core/nthw_i2cm.c | 82 +++ 3 files changed,

[PATCH v1 09/32] net/ntnic: add nim low power API

From: Danylo Vodopianov Add NIM reset and low power functions with presence check - Implement nim_set_reset function to handle NIM reset. - Implement set_nim_low_power function to manage NIM power state. - Add code to check NIM presence before performing reset. Signed-off-by: Danylo Vodopianov

[PATCH v1 06/32] net/ntnic: add line loopback init

From: Danylo Vodopianov Implement PHY host loopback configuration for Agilex FPGA Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 116 ++ drivers/net/ntnic/meson.build | 1 + drivers/net/ntnic/nim/i2c_nim.c |

[PATCH v1 32/32] net/ntnic: revert untrusted loop bound

The changes for untrusted loop bound breaks VLAN processing This reverts commit 36cd2cb0eea49813dd59ee1df2eb592e8ae5b6b4. Signed-off-by: Serhii Iliushyk --- drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ntnic/ntnic_

[PATCH v1 27/32] net/ntnic: add pca init

From: Danylo Vodopianov Add initialization for I2C mux and LED driver. Signed-off-by: Danylo Vodopianov --- .../ntnic/nthw/core/include/nthw_pca9532.h| 3 +++ .../nthw/core/include/nthw_si5332_si5156.h| 3 +++ .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 23 +++ dr

[PATCH v1 29/32] net/ntnic: add reset PHY init

From: Danylo Vodopianov Add initialization and logging for Phy Tile module. Signed-off-by: Danylo Vodopianov --- .../ntnic/nthw/core/include/nthw_phy_tile.h | 39 ++ .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 16 + drivers/net/ntnic/nthw/core/nthw_phy_tile.c | 598 ++

[PATCH v1 30/32] net/ntnic: add igam module init

From: Danylo Vodopianov Create and initialize IGAM module. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_igam.h | 37 +++ .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 4 ++ drivers/net/ntnic/nthw/co

[PATCH v1 28/32] net/ntnic: add pcal init

From: Danylo Vodopianov Add initialization for I/O expanders and configure TS settings. Signed-off-by: Danylo Vodopianov --- .../ntnic/nthw/core/include/nthw_pcal6416a.h | 3 + .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 69 +++ drivers/net/ntnic/nthw/core/nthw_pcal6416a.

[PATCH v1 24/32] net/ntnic: add nt400d13 PRM module reset

From: Danylo Vodopianov Reset platform and peripherals for PRM initialization. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/nthw/core/include/nthw_prm_nt400dxx.h | 2 ++ .../core/nt400dxx/reset/nthw_fpga_rst_nt400dxx.c| 13 + drivers/net/ntnic/nthw/core/nthw_prm_nt400dxx

[PATCH v1 25/32] net/ntnic: add SPI v3 support for FPGA

From: Danylo Vodopianov - Implement nthw_spi_v3 module with initialization, transfer, and utility functions. - Add nthw_spim and nthw_spis modules for SPI primary and secondary interfaces. - Include SPI v3 header files and update meson build configuration. - Implement AVR probe function to retrie

[PATCH v1 21/32] net/ntnic: add nt400d13 pcm init

From: Danylo Vodopianov Initialize and create PCM for FPGA and HIF modules Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/meson.build | 1 + .../nthw/core/include/nthw_pcm_nt400dxx.h | 24 +++- .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 18 ++ .../net/

[PATCH v1 19/32] net/ntnic: add PHY ftile reset

Add reset functions and reset procedure for module PHY FTILE Signed-off-by: Serhii Iliushyk --- .../ntnic/nthw/core/include/nthw_phy_tile.h | 12 ++ .../core/nt400dxx/reset/nthw_fpga_rst9574.c | 161 ++ drivers/net/ntnic/nthw/core/nthw_phy_tile.c | 38 + 3 files chang

[PATCH v1 23/32] net/ntnic: add nt400d13 PRM module init

From: Danylo Vodopianov Initialize RAB0 and create PRM for FPGA. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/meson.build | 1 + .../nthw/core/include/nthw_prm_nt400dxx.h | 30 + .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 11 + .../net/ntnic/

[PATCH v1 22/32] net/ntnic: add HIF clock test

From: Danylo Vodopianov Add HIF clock test with write/read verification. Signed-off-by: Danylo Vodopianov --- .../net/ntnic/nthw/core/include/nthw_hif.h| 3 + .../nt400dxx/reset/nthw_fpga_rst_nt400dxx.c | 20 + drivers/net/ntnic/nthw/core/nthw_hif.c| 82 +++

[PATCH v1 17/32] net/ntnic: add default reset setting for NT400D13

Add DDR4 reset and calibration completion handling. Signed-off-by: Serhii Iliushyk --- .../core/nt400dxx/reset/nthw_fpga_rst9574.c | 29 ++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c b/drivers/n

[PATCH v1 18/32] net/ntnic: add DDR calibration to reset stage

Add DDR4 reset and calibration functions for FPGA. Signed-off-by: Serhii Iliushyk --- .../core/nt400dxx/reset/nthw_fpga_rst9574.c | 95 +++ 1 file changed, 95 insertions(+) diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c b/drivers/net/ntnic/nthw/co

[PATCH v1 13/32] net/ntnic: add minimal initialization new NIC NT400D13

Add function and structures required to init the new NIC NT400D13 Signed-off-by: Serhii Iliushyk --- doc/guides/nics/ntnic.rst | 7 +- doc/guides/rel_notes/release_25_03.rst| 4 drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/i

[PATCH v1 16/32] net/ntnic: add setup for fpga reset

Initialize FPGA reset module and register fields. Signed-off-by: Serhii Iliushyk --- .../core/nt400dxx/reset/nthw_fpga_rst9574.c | 54 +++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/ntnic/nthw/core/nt400dxx/reset/nthw_fpga_rst9574.c b/drivers/net/ntnic/nthw/cor

[PATCH v1 08/32] net/ntnic: add port post init

From: Danylo Vodopianov Configure FEC and TX equalization for 100G NIM on Agilex FPGA Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 122 drivers/net/ntnic/nim/i2c_nim.c | 80 + drivers/net/ntnic/nim/i2c_nim.h |

[PATCH v1 14/32] net/ntnic: add minimal reset FPGA

Define and register FPGA reset operations. Signed-off-by: Serhii Iliushyk --- .../include/ntnic_nthw_fpga_rst_nt400dxx.h| 34 +++ drivers/net/ntnic/meson.build | 2 + .../nthw/core/nt400dxx/nthw_fpga_nt400dxx.c | 88 ++- .../core/nt400dxx/reset/nthw_fpg

[PATCH v1 05/32] net/ntnic: add host loopback init

From: Danylo Vodopianov Implement PHY line loopback configuration for Agilex FPGA Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 111 ++ .../ntnic/nthw/core/include/nthw_phy_tile.h | 1 + drivers/net/ntnic/nthw/core/nthw_phy_tile.c |

[PATCH v1 11/32] net/ntnic: add port init to the state machine

From: Danylo Vodopianov Handle NIM module insertion and initialization Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 33 +++ 1 file changed, 33 insertions(+) diff --git a/drivers/net/ntnic/link_mgmt/link_agx_100g/nt4ga_agx_link_100g.c b/

[PATCH v1 12/32] net/ntnic: add port disable API

From: Danylo Vodopianov Added logic to check if the administrative port state has changed. Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/ntnic/link_mgmt/link_agx_100g/nt4ga

[PATCH v1 10/32] net/ntnic: add link handling API

From: Danylo Vodopianov Add link state management and NIM reset functionality - Implement phy_get_link_state to retrieve PHY link state. - Implement adjust_maturing_delay to adjust link maturing delay. - Implement get/set to operate current link state. Signed-off-by: Danylo Vodopianov --- ...

[PATCH v1 07/32] net/ntnic: add 100 gbps port init

From: Danylo Vodopianov Initialize NIM and 100G port for Agilex FPGA Signed-off-by: Danylo Vodopianov --- .../link_agx_100g/nt4ga_agx_link_100g.c | 143 ++ drivers/net/ntnic/meson.build | 1 + .../net/ntnic/nthw/core/include/nthw_gmf.h| 2 + .../nt

[PATCH v1 03/32] net/ntnic: add rpf and gfg init

From: Danylo Vodopianov RPF and GFG modules initialization were added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/nt4ga_link.h| 2 + drivers/net/ntnic/include/nthw_gfg.h | 33 ++ .../link_agx_100g/nt4ga_agx_link_100g.c | 24 ++ drivers/net/ntnic/m

[PATCH v1 02/32] net/ntnic: add link state machine

From: Danylo Vodopianov Minimal 100g agx link state machine implementation was added. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/nt4ga_link.h| 5 + .../link_agx_100g/nt4ga_agx_link_100g.c | 111 ++ 2 files changed, 116 insertions(+) diff --g

[PATCH v1 04/32] net/ntnic: add agx setup for port

From: Danylo Vodopianov Initialize NIM and PHY settings for Agilex FPGA ports Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/include/ntnic_nim.h | 5 + .../link_agx_100g/nt4ga_agx_link_100g.c | 86 - drivers/net/ntnic/meson.build | 1 + driver

[PATCH v1 01/32] net/ntnic: add link agx 100g

From: Danylo Vodopianov Minimal implementation for link agx 100g was added. Add support for NT400D13 (Intel Agilex FPGA) link operations. Signed-off-by: Danylo Vodopianov --- drivers/net/ntnic/adapter/nt4ga_adapter.c | 9 .../link_agx_100g/nt4ga_agx_link_100g.c | 42 +++

[PATCH v1 00/32] add new adapter NT400D13

This patchset adds support for the new adapter NT400D13. Danylo Vodopianov (23): net/ntnic: add link agx 100g net/ntnic: add link state machine net/ntnic: add rpf and gfg init net/ntnic: add agx setup for port net/ntnic: add host loopback init net/ntnic: add line loopback init net/nt

[PATCH v4 08/10] test-pmd: declare lcore_count atomic

Compiling with MSVC results in the error below: app/test/test_ring_perf.c(197): error C7712: address argument to atomic operation must be a pointer to an atomic integer, 'volatile unsigned int *' is not valid The fix is to mark lcore_count as atomic. Signed-off-by: Andre Muezerie Signed

[PATCH v3 4/6] devtools: check ms linker map files

MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enhance the logic in the existing version.map files but that file is also passed to other tools on Linux, making this challenging. A simpler approach is to have an optional

Re: [PATCH v4 00/10] enable "app" to be compiled with MSVC

On Thu, 20 Feb 2025 13:30:54 -0800 Andre Muezerie wrote: > v4: > - add explanation about the expression used in __rte_constant during v3. > > v3: > - use clever expression with _Generic for __rte_constant and use it > where __builtin_constant_p was being used. > - use %u in csumonly.c and just

[PATCH v4 10/10] app: enable app directory to be compiled with MSVC

Enabled "app" directory to be compiled with MSVC along with all its contents. Removed flag Wno-deprecated-declarations which is not needed anymore. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson --- app/meson.build | 4 app/test-pmd/meson.build | 1 - 2 files changed, 5

[PATCH v4 0/2] dts: add stats checks test suite

v3: * fix name of the first patch v4: * rebase and refactor off next-dts Dean Marx (2): dts: add clearing port stats to testpmd shell dts: add port stats checks test suite dts/framework/remote_session/testpmd_shell.py | 57 -- dts/tests/TestSuite_port_stats_checks.py | 168 +++

[PATCH v4 06/10] test-pmd: avoid non-constant initializer

Compiling with MSVC results in errors like the one below: app/test-pmd/cmdline_flow.c(8819): error C2099: initializer is not a constant Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline_flow.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-

[PATCH v4 03/10] test-pmd: fix printf format string mismatch

Compiling with MSVC results in warnings like the one below: app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string '%d' requires an argument of type 'int', but variadic argument 1 has type 'uint64_t' Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/tes

[PATCH v4 09/10] test: add workaround for __builtin_constant_p in test_memcpy_perf

There's no MSVC equivalent for compiler extension __builtin_constant_p, so a workaround is needed. Signed-off-by: Andre Muezerie --- app/test/test_memcpy_perf.c | 54 ++--- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/app/test/test_memcpy_perf.c

[PATCH v4 07/10] test-pmd: don't return value from void function

Compiling with MSVC results in the warning below: app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed': 'void' function returning a value Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test-pmd/cmdline_flow.c | 12 -

[PATCH v4 01/10] eal: add workaround for __builtin_constant_p

There's no MSVC equivalent for compiler extension __builtin_constant_p, but the same result can be obtained through a clever expression using _Generic. This patch redefines the macro __rte_constant when msvc is used and uses it as a replacement for __builtin_constant_p. Signed-off-by: Andre Mueze

[PATCH v4 04/10] test-pmd: do explicit 64-bit shift to avoid implicit conversion

Compiling with MSVC results in warnings like the one below: app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?) Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test

[PATCH v4 05/10] test-pmd: avoid undefined behavior

Compiling with MSVC results in warnings like below: app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor directive in function-like macro argument list is undefined behavior Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test-pmd/cmdline.c | 12

[PATCH v4 00/10] enable "app" to be compiled with MSVC

v4: - add explanation about the expression used in __rte_constant during v3. v3: - use clever expression with _Generic for __rte_constant and use it where __builtin_constant_p was being used. - use %u in csumonly.c and just cast variables to unsigned int. v2: - use lcore_count as atomic always,

[PATCH v4 02/10] test_alarm: avoid warning about different qualifiers

Compiling with MSVC results in the warning below: app/test/test_alarm.c(54): warning C4090: 'function': different '_Atomic' qualifiers The fix is to use a macro to explicitly drop the qualifier. Signed-off-by: Andre Muezerie Signed-off-by: Chengwen Feng --- app/test/test_alarm.c | 12

[PATCH v4 2/2] dts: add port stats checks test suite

This patch adds a new test suite to DTS that validates the accuracy of the port statistics using testpmd. The functionality is tested by sending a packet of a fixed side to the SUT and verifying that the statistic for packets received, received bytes, packets sent, and sent bytes all update accordi

[PATCH v4 1/2] dts: add clearing port stats to testpmd shell

Methods currently exist for querying the statistics of a port in testpmd, but there weren't methods added for clearing the current statistics on a port. This patch adds methods that allow you to clear the statistics of a single port or all ports to account for situations where the user only wants t

Re: [PATCH] app/testpmd: fix fail to set queue number when attach device

On Tue, 18 Feb 2025 19:31:56 +0800 Huisong Li wrote: > Testpmd doesn't modify the Rx/Tx queue number of all ports after attach a > new device. The root cause is that "port config all rxq " would > check if all ports are stopped and the status of this port is still in > 'RTE_PORT_HANDLING'. This s

Re: [PATCH 0/2] fix testpmd DCB command

On Thu, 20 Feb 2025 15:06:49 +0800 Chengwen Feng wrote: > This patchset contains two commit which found when debug DCB module. > > Chengwen Feng (2): > app/testpmd: support display DCB all priority's TC map > app/testpmd: fix segment fault when config DCB > > app/test-pmd/cmdline.c | 6 +++

[PATCH] app/testpmd: fix out-of-bound reference in offload config

When configuring offloads, need to check the port id before indexing into the ports[] array. This can easily be done by moving the call to oh_dev_conf_get_print_err() to before the checks for port stopped. Fixes: c73a9071877a ("app/testpmd: add commands to test new offload API") Cc: sta...@dpdk.or

[PATCH v3 5/6] net: update use of versioning macros

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 6/6] mbuf: enable to be compiled with MSVC

Now that the issues preventing this lib from be compiled with MSVC are fixed it can be included in the compilation. The "net" library will automatically get compiled as well as it has a dependency on "mbuf" which will now get fulfilled. Signed-off-by: Andre Muezerie Acked-by: Bruce Richardson -

[PATCH v3 1/6] doc: update guide on versioning macros

Added explanation about new macro MAP_STATIC_BASE_SYMBOL. Signed-off-by: Andre Muezerie --- doc/guides/contributing/abi_versioning.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/contributing/abi_versioning.rst b/doc/guides/contributing/abi_versioning.rst index 7afd1c18

[PATCH v3 2/6] buildtools: update map_to_win.py to use optional map file

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 0/6] mbuf: enable to be compiled with MSVC

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v3 3/6] eal: update versioning macros

When compiling with MSVC the error below shows up due to function versioning: ../lib/net/rte_net_crc.c(418): error C2061: syntax error: identifier '__attribute__' MSVC allows alias function names to be exported, but the mechanism is different than the one used by gcc. It was considered to enh

[PATCH v9 06/15] common/cnxk: remove unused variable

A couple places in this code were generating warnings from PVS studio about memset potentially being ignored. This is because the ipv6_buf was declared but never used. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_npc_utils.c | 4 1 file changed, 4 deletions(-) diff --git a/

Re: [PATCH v7 2/4] lib: fix comparison between devices

On Wed, 12 Feb 2025 18:38:33 +0200 Shani Peretz wrote: > DPDK supports multiple formats for specifying buses, > (such as ":08:00.0" and "08:00.0" for PCI). > This flexibility can lead to inconsistencies when using one > format while running testpmd, then attempts to use the other > format in

[PATCH v9 09/15] crypto/qat: use secure free for keys

Regular memset maybe removed by compiler if done before a free function. Use new rte_free_sensitive instead. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/crypto/qat/qat_asym.c| 5 + drivers/crypto/qat/qat_sym_session.c | 8 2 files changed, 5 inse

Re: [PATCH v13 00/28] [v13]drivers/net Add Support mucse N10 Pmd Driver

Ran PVS studio against this patchset. The resulting warnings for drivers/net/rnp were: MESSAGES LocationCodeMessage Fails/Info rnp_mac.c (251) V610 Undefined behavior. Check the shift operator '>>='. The right operand ('' = [0..65535]) is greate

[PATCH v3 06/14] net/memif: remove unnecessary deref of function pointers

Since queue release functions are local to driver, prefer those over dereferencing the dev_ops table. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/memif/rte_eth_memif.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --gi

[PATCH v9 11/15] compress/octeontx: remove unnecessary memset

Calling memset before rte_free not necessary, and could be removed by the compiler. In this case, the data is not security sensitive so the memset can be removed. Some security scanning tools will flag this. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- drivers/compress/octeon

[PATCH v3 03/14] net/bonding: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/bonding/rte_eth_bond_pmd.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH v3 05/14] net/ipn3ke: remove unnecessary dereference

Since it is a function pointer, the expression *hw->f_mac_read and hw->f_mac_read are equivalent in C. Remove excession indentation here. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- drivers/net/intel/ipn3ke/ipn3ke_ethdev.c | 27 +

[PATCH v9 03/15] eal: add new secure free function

Although internally rte_free does poison the buffer in most cases, it is useful to have function that explicitly does this to avoid any security issues. Name of new API is chosen to be similar to Linux kernel kfree_sensitive() to make porting drivers easier. Signed-off-by: Stephen Hemminger Acke

RE: [PATCH] power: use hugepage memory for queue list entry structure

> > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, February 20, 2025 4:12 PM > > > To: lihuisong (C) > > > Cc: dev@dpdk.org; tho...@monjalon.net; david.h...@intel.com; > > > anatoly.bura...@intel.com; sivaprasad.tumm...@amd.com; > > > liuyonglong > > > Subje

[PATCH v3 14/14] security: remove unnecessary dereference

The expressions *instance->ops->set_pkt_metadata and instance->ops->set_pkt_metadata are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/security/rte_security.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a

[PATCH v3 13/14] regexdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/regexdev/rte_regexdev.c | 72 ++--- 1 file changed, 36 insertions(+), 36 de

[PATCH v3 12/14] mldev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent in C. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/mldev/rte_mldev.c | 88 +-- 1 file changed, 44 insertions(+), 44 de

[PATCH v3 11/14] rawdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_configure and dev->dev_ops->dev_configure are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/rawdev/rte_rawdev.c | 99 - 1 file changed, 48 insertions(+), 51 delet

[PATCH v3 10/14] dmadev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_get and dev->dev_ops->dev_info_get are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/dmadev/rte_dmadev.c | 38 +- 1 file changed, 17 ins

[PATCH v3 09/14] compressdev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->info_get are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/compressdev/rte_compressdev.c | 56 +++ 1 file changed, 28 insertions(+), 28 deletions(

[PATCH v3 08/14] crypto/scheduler: remove unnecessary dereference

The expression *dev->dev_ops->sym_session_get_size and dev->dev_ops->sym_session_get_size are equivalent. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- .../scheduler/rte_cryptodev_scheduler.c | 8 +++--- drivers/crypto/scheduler/scheduler_pmd_op

[PATCH v3 04/14] net/ixgbe: remove unnecessary dereference

The expression *dev->dev_ops->vlan_strip_queue_set and dev->dev_ops->vlan_strip_queue are equivalent in C. Signed-off-by: Stephen Hemminger Reviewed-by: Bruce Richardson Acked-by: Morten Brørup --- drivers/net/intel/ixgbe/rte_pmd_ixgbe.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(

[PATCH v3 07/14] cryptodev: remove unnecessary deref of function pointers

The expression *dev->dev_ops->dev_info_gets and dev->dev_ops->dev_info_gets are equivalent. Cleanup and remove unnecessary parenthesis as well. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/cryptodev/rte_cryptodev.c | 72 +--

[PATCH v3 01/14] ethdev: remove unnecessary deref on function pointers

The expression *dev->dev_ops->rx_queue_start and dev->dev_ops->rx_queue_start are equivalent. Remove the unnecessary asterisk and parenthesis. Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/ethdev/ethdev_driver.c |

[PATCH v3 02/14] eventdev: remover unnecessary deref on function pointers

The expression *dev_dev_ops->foo and dev->dev_ops->foo are equivalent. Cleanup the result by removing unneeded parenthesis and make lines compact. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup Acked-by: Bruce Richardson --- lib/eventdev/rte_event_crypto_adapter.c | 37 ++ lib/e

  1   2   >