Re: [PATCH v1] app/test-gpudev: improve tests' output

On Mon, Nov 15, 2021 at 3:53 PM wrote: > > From: Elena Agostini > > Signed-off-by: Elena Agostini > --- > app/test-gpudev/main.c | 90 ++ > 1 file changed, 55 insertions(+), 35 deletions(-) > > diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c

Re: [PATCH] examples/ptpclient: fix delay request message

Hello, On Wed, Nov 17, 2021 at 7:19 AM wrote: > > From: Vanshika Shukla > > The size of delay request message sent out by the DPDK > ptpclient application was observed to have extra length > than expected. Due to this, bad messages were observed > on the master side and delay response was not re

RE: [PATCH] app/testpmd: fix flow transfer proxy port handling

> -Original Message- > From: Ivan Malov > Sent: Tuesday, November 16, 2021 17:38 > To: dev@dpdk.org > Cc: David Marchand ; Ferruh Yigit > ; NBU-Contact-Thomas Monjalon > ; Andrew Rybchenko > ; Xiaoyun Li ; Ori > Kam > Subject: [PATCH] app/testpmd: fix flow transfer proxy port handling >

[PATCH v3] app/test-crypto-perf: fix segment size for IPsec operation

Application calculates segment size based on buffer size plus digest size only, But if the operation mode is IPsec then packet length can be increased by some more bytes depends upon the algorithm. In this patch, increasing segment size with RTE_PKTMBUF_HEADROOM when there is no user given segment

[PATCH v2 1/2] common/sfc_efx/base: support NIC DMA memory regions API

NIC DMA memory regions API allows to establish mapping of DMA addresses used by NIC to host IOVA understood by the host when IOMMU is absent and NIC cannot address entire host IOVA space because of too small DMA mask. The API does not allow to address entire host IOVA space, but allows arbitrary r

[PATCH v2 2/2] net/sfc: support regioned NIC DMA memory mapping type

From: Viacheslav Galaktionov DMA on SN1022 SoC requires extra mapping of the memory via MCDI. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Ivan Malov --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/net/sfc/meson.build| 1 + driv

[PATCH v2 0/2] net/sfc: support SN1022 SoC

I apologize for very late patch series. Of course, I'd be happy if the series is included in 21.11 since it is a final step to support SN1022 SoC. Now it is really late. A tiny excuse is that net/sfc part was 90% rewritten to use [1]. Many thanks to Dmitry. Solution with mempool event callback is

RE: [PATCH v2 12/12] app: remove unnecessary include of atomic header file

> Subject: Re: [PATCH v2 12/12] app: remove unnecessary include of atomic > header file > > On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong wrote: > > > > Remove the unnecessary rte_atomic.h included in app modules. > > > > Signed-off-by: Joyce Kong > > Reviewed-by: Ruifeng Wang > > After patch,

RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation

> -Original Message- > From: Akhil Goyal > Sent: Wednesday, November 17, 2021 12:06 PM > To: Gagandeep Singh ; dev@dpdk.org > Subject: RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec > operation > > > > Can you explain the calculation for 73 bytes in the code? > >

RE: Probing the expected state/support of DPDK@armhf

> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, November 16, 2021 8:06 PM > To: Christian Ehrhardt ; Ruifeng Wang > > Cc: Jan Viktorin ; dev ; Luca > Boccassi ; Honnappa Nagarahalli > ; nd > Subject: RE: Probing the expected state/support of DPDK@armhf > > > > > -Origin

RE: [EXT] [PATCH v2] app/test-crypto-perf: fix segment size for IPsec operation

> > Can you explain the calculation for 73 bytes in the code? > > Will it be sufficient for IPv6? > No, it will not cover IPv6, As currently only IPv4 test cases are there in the > app. > But I guess it covers all the scenario which are supported by the app. > 73 are the maximum bytes which can be

[PATCH] examples/ptpclient: fix delay request message

From: Vanshika Shukla The size of delay request message sent out by the DPDK ptpclient application was observed to have extra length than expected. Due to this, bad messages were observed on the master side and delay response was not received. This patch fixes this bug. Signed-off-by: Vanshika

Re: [PATCH] net/bnxt: fix to set Rx next cons in mbuf alloc fail case

On Tue, Nov 16, 2021 at 7:18 PM Somnath Kotur wrote: > > The driver internal variable to track the next consumer index on > the Rx ring was not being set if there was an mbuf allocation > failure. In that scenario, eventually it would fall out of sync > with the actual consumer index and raise a f

Re: [PATCH 0/4] fixes to TruFlow

On Tue, Nov 16, 2021 at 5:04 AM Venkat Duvvuru wrote: > > This patch set adds fixes to Truflow feature. Patchset applied to dpdk-next-net-brcm. Fixed typo in commit log on patch 3 during merge. Thanks > > Jay Ding (1): > net/bnxt: remove settings to support multiple session > > Kishore Padmana

Re: [PATCH 0/2] net/bnxt: minor performance fixes for AVX2 Rx

On Mon, Nov 15, 2021 at 10:24 AM Lance Richardson wrote: > > This series contains two minor performance fixes for the > bnxt AVX2 vecgtorized burst receive function. > > Lance Richardson (2): > net/bnxt: avoid unnecessary work in AVX2 Rx path > net/bnxt: remove software prefetches from AVX2 Rx

Re: [PATCH] doc: update for bnxt PMD

On Fri, Nov 5, 2021 at 11:46 AM Ajit Khaparde wrote: > > Updated support for RTE_FLOW_ACTION_TYPE_RSS. > > Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") > > Signed-off-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. Thanks > --- > doc/guides/rel_notes/release_21_11.rst | 1

[PATCH] net/bnxt: fix to set Rx next cons in mbuf alloc fail case

The driver internal variable to track the next consumer index on the Rx ring was not being set if there was an mbuf allocation failure. In that scenario, eventually it would fall out of sync with the actual consumer index and raise a false alarm on Thor needlessly causing a segmentation fault with

[PATCH v2] examples/l3fwd-power: add wakeup log

This patch adds a log in main telemetry loop to show the thread has woken up and begun to send and receive packets. Signed-off-by: Miao Li --- examples/l3fwd-power/main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index 6988a0

Re: [PATCH 10/10] raw/cnxk_gpio: support selftest

On Wed, 17 Nov 2021 01:21:55 +0100 Tomasz Duszynski wrote: > +static int > +cnxk_gpio_open_mem(void) > +{ > + int ret = 0, fd; > + > + fd = open("/dev/mem", O_RDWR | O_SYNC); > + if (fd < 0) > + ret = -errno; > + > + return ret; > +} This is a dangerous security viola

[PATCH 10/10] raw/cnxk_gpio: support selftest

Add support for performing selftest. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 11 + drivers/raw/cnxk_gpio/cnxk_gpio.c | 1 + drivers/raw/cnxk_gpio/cnxk_gpio.h | 2 + drivers/raw/cnxk_gpio/cnxk_gpio_selftest.c | 442 ++

[PATCH 09/10] raw/cnxk_gpio: support custom irq handlers

Add support for custom interrupt handlers. Custom interrupt handlers bypass kernel completely and are meant for fast and low latency access to GPIO state. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 21 +++ drivers/raw/cnxk_gpio/cnxk_gpio.c | 37

[PATCH 08/10] raw/cnxk_gpio: support standard GPIO operations

Add support for standard GPIO operations i.e ones normally provided by GPIO sysfs interface. Signed-off-by: Tomasz Duszynski --- doc/guides/rawdevs/cnxk_gpio.rst | 98 drivers/raw/cnxk_gpio/cnxk_gpio.c | 146 +++ drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 279

[PATCH 07/10] raw/cnxk_gpio: support dequeuing buffers

Add support for dequeuing buffers. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index c08ccdfbb8..244a625822 100644 ---

[PATCH 06/10] raw/cnxk_gpio: support enqueuing buffers

Add dummy support for enqueuing buffers. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 46 +++ drivers/raw/cnxk_gpio/cnxk_gpio.h | 1 + drivers/raw/cnxk_gpio/meson.build | 1 + drivers/raw/cnxk_gpio/rte_pmd_cnxk_gpio.h | 38

[PATCH 05/10] raw/cnxk_gpio: support queue release

Add support for queue release. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 34 +++ 1 file changed, 34 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 98b5dd9cd8..8ac3c5e1be 100644 ---

[PATCH 04/10] raw/cnxk_gpio: support queue setup

Add support for queue setup. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 80 +++ 1 file changed, 80 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index 84be7f861e..98b5dd9cd8 100644 --- a

[PATCH 03/10] raw/cnxk_gpio: support reading queue count

Add support for reading number of available queues. Single queue corresponds to GPIO. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index de

[PATCH 01/10] raw/cnxk_gpio: add GPIO driver skeleton

Add initial support for PMD that allows to control particular pins form userspace. Moreover PMD allows to attach custom interrupt handlers to controllable GPIOs. Main users of this PMD are dataplain applications requiring fast and low latency access to pin state. Signed-off-by: Tomasz Duszynski

[PATCH 02/10] raw/cnxk_gpio: support reading default queue conf

Add support for reading default queue configuration. Signed-off-by: Tomasz Duszynski --- drivers/raw/cnxk_gpio/cnxk_gpio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/raw/cnxk_gpio/cnxk_gpio.c b/drivers/raw/cnxk_gpio/cnxk_gpio.c index bcce4b8fb7..deedf98af2

[DPDK 22.02 PATCH 00/10] Add cnxk_gpio PMD

This series introduces a new rawdevice PMD which allows to manage userspace GPIOs and install custom GPIO interrupt handlers which bypass kernel. This is especially useful for applications that, besides providing standard dataplane functionality, want to have fast and low latency access to GPIO pin

Re: ethdev: hide internal structures

On Tue, 16 Nov 2021 14:58:08 -0800 Tyler Retzlaff wrote: > On Tue, Nov 16, 2021 at 01:25:10PM -0800, Stephen Hemminger wrote: > > On Tue, 16 Nov 2021 11:10:18 -0800 > > Tyler Retzlaff wrote: > > > > > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > > > > > rte

Re: [PATCH] net: add macro for VLAN header length

10/11/2021 18:40, Ferruh Yigit: > Multiple drivers are defining macros for VLAN header length, to remove > the redundancy defining macro in the ether header. > And updated drivers to use the new macro. > > Signed-off-by: Ferruh Yigit [...] > --- a/lib/net/rte_ether.h > +++ b/lib/net/rte_ether.h >

Re: ethdev: hide internal structures

On Tue, Nov 16, 2021 at 01:25:10PM -0800, Stephen Hemminger wrote: > On Tue, 16 Nov 2021 11:10:18 -0800 > Tyler Retzlaff wrote: > > > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > > > data st

Re: [PATCH 1/5] ci: test build with minimum configuration

16/11/2021 21:39, David Marchand: > On Tue, Nov 16, 2021 at 6:06 PM Thomas Monjalon wrote: > > > > 10/11/2021 17:48, David Marchand: > > > Disabling optional libraries was not tested. > > > Add a new target in test-meson-builds.sh and GHA. > > > > > > The Bluefield target is removed from test-meso

[PATCH 2/2] net/sfc: add missing printout labels for decr. TTL actions

Fixes: 60e53c078d01 ("net/sfc: support decrement IP TTL actions in transfer flows") Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc

[PATCH 1/2] net/sfc: add missing printout label for count action

Fixes: 96fd2bd69b58 ("net/sfc: support flow action count in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_mae.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/sfc_mae.c b/drive

Re: [PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

On Wed, 17 Nov 2021 03:04:59 + wrote: > From: Elena Agostini > > This patch introduces GPU memory in testpmd through the gpudev library. > Testpmd can be used for network benchmarks when using GPU memory > instead of regular CPU memory to send and receive packets. > This option is currently

RE: [PATCH v2 10/12] app/testpmd: remove atomic operations for port status

> > The port_status changes do not need to be handled atomically, as they are > modified during initialization or through the testpmd prompt instead of > multiple threads. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli > --- > app/test-pmd/testpm

Re: [PATCH] common/mlx5: decrease log level for hlist creation

On Tue, 16 Nov 2021 21:33:54 +0100 David Marchand wrote: > act_size = rte_align32pow2(size); > - DRV_LOG(WARNING, "Size 0x%" PRIX32 " is not power of 2, will " > + DRV_LOG(DEBUG, "Size 0x%" PRIX32 " is not power of 2, will " > "be aligne

RE: [PATCH v2 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

> > Convert rte_atomic usages to compiler atomic built-ins for polling sync in > pmd_perf test cases. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > app/test/test_pmd_perf.c | 14 ++ > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/app/test/t

Re: ethdev: hide internal structures

On Tue, 16 Nov 2021 11:10:18 -0800 Tyler Retzlaff wrote: > On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > > data structures that were used by public inline ethdev functions. > > Well behaving app

RE: [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync

> > Joyce, Honnappa, > > On Tue, Nov 16, 2021 at 10:43 AM Joyce Kong wrote: > > > > Convert rte_atomic usages to compiler atomic built-ins for lcore_state > > and collisions sync. > > > > Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to > > guarantee lcore_state initializ

[PATCH] examples/ntb: fix build dependency

Caught while building with -Ddisable_drivers=*/*. This example requires raw/ntb specific API. Fix dependency to avoid a compilation error: FAILED: examples/c590b3c@@dpdk-ntb@exe/ntb_ntb_fwd.c.o ccache gcc -Iexamples/c590b3c@@dpdk-ntb@exe -Iexamples -I../examples -Iexamples/ntb -I../examples/nt

Re: ethdev: hide internal structures

On Tue, Nov 16, 2021 at 08:07:49PM +, Ferruh Yigit wrote: > On 11/16/2021 5:54 PM, Tyler Retzlaff wrote: > > > >i thought someone was responsible for reviewing abi/api related changes > >on the board to understand the implications of changes like this? > > > > Sorry for the negative impact on

Re: [PATCH 1/5] ci: test build with minimum configuration

On Tue, Nov 16, 2021 at 6:06 PM Thomas Monjalon wrote: > > 10/11/2021 17:48, David Marchand: > > Disabling optional libraries was not tested. > > Add a new target in test-meson-builds.sh and GHA. > > > > The Bluefield target is removed from test-meson-builds.sh to save space > > and compilation ti

[PATCH] common/mlx5: decrease log level for hlist creation

Initialising mlx5 devices in OVS, I get the following logs: 2021-11-16T20:08:37Z|00021|dpdk|INFO|EAL: Probe PCI driver: mlx5_pci (15b3:101d) device: :3b:00.0 (socket 0) 2021-11-16T20:08:37Z|00022|dpdk|INFO|common_mlx5: RTE_MEM is selected. 2021-11-16T20:08:38Z|00023|dpdk|WARN|mlx5_pci: Size 0xF

Re: [PATCH v2 12/12] app: remove unnecessary include of atomic header file

On Tue, Nov 16, 2021 at 10:44 AM Joyce Kong wrote: > > Remove the unnecessary rte_atomic.h included in app modules. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang After patch, I still see: $ git grep rte_atomic.h app/ app/test/commands.c:#include app/test/test_atomic.c:#include ap

Re: [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync

Joyce, Honnappa, On Tue, Nov 16, 2021 at 10:43 AM Joyce Kong wrote: > > Convert rte_atomic usages to compiler atomic > built-ins for lcore_state and collisions sync. > > Also, move 'main_init_workers' outside of > 'timer_stress2_main_loop' to guarantee lcore_state > initialized correctly before t

RE: [PATCH v2 09/12] app/compress: use compiler atomic builtins for display sync

> > Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for > display sync. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Reviewed-by: Honnappa Nagarahalli > --- > app/test-compress-perf/comp_perf_test_common.h| 2 +- > .../comp_perf_test_cyclecount.c

Re: ethdev: hide internal structures

On 11/16/2021 5:54 PM, Tyler Retzlaff wrote: On Tue, Nov 16, 2021 at 09:32:15AM +, Ferruh Yigit wrote: Hi Tyler, It shouldn't be an API change, which API is changed? exported declarations that were consumed by the application were removed from an installed header. anything making referen

Re: [PATCH v1] app/test-gpudev: improve tests' output

16/11/2021 00:03, eagost...@nvidia.com: > From: Elena Agostini > > Signed-off-by: Elena Agostini Applied, thanks.

RE: [PATCH v2 03/12] test/timer: use compiler atomic builtins for sync

> > Convert rte_atomic usages to compiler atomic built-ins for lcore_state and > collisions sync. > > Also, move 'main_init_workers' outside of 'timer_stress2_main_loop' to > guarantee lcore_state initialized correctly before the threads launched. > > Signed-off-by: Joyce Kong > Reviewed-by:

RE: [PATCH] app/testpmd: fix flow transfer proxy port handling

Hi Ivan, > -Original Message- > From: Ivan Malov > Sent: Tuesday, November 16, 2021 5:38 PM > Subject: [PATCH] app/testpmd: fix flow transfer proxy port handling > > The current approach detects the proxy port on each port (re-)plug and > may spam the log with error messages if the PMD d

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

On Wed, Nov 17, 2021 at 12:44 AM Elena Agostini wrote: > > > From: Jerin Jacob > > > Date: Tuesday, 16 November 2021 at 20:09 > > > To: Ferruh Yigit > > > Cc: Elena Agostini , dev@dpdk.org , > > Slava Ovsiienko > > > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd > >

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

> From: Jerin Jacob > Date: Tuesday, 16 November 2021 at 20:09 > To: Ferruh Yigit > Cc: Elena Agostini , dev@dpdk.org , Slava > Ovsiienko > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > External email: Use caution opening links or attachments > > > On Tue, Nov

Re: ethdev: hide internal structures

On Tue, Nov 16, 2021 at 10:32:55AM +, Ananyev, Konstantin wrote: > > rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback are internal > data structures that were used by public inline ethdev functions. > Well behaving app should not access these data structures directly. > So, for well beh

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

On Tue, Nov 16, 2021 at 11:42 PM Ferruh Yigit wrote: > > On 11/16/2021 6:06 PM, Elena Agostini wrote: > > > From: Ferruh Yigit > > > > > Date: Tuesday, 16 November 2021 at 19:00 > > > > > To: Elena Agostini > > > > > Cc: dev@dpdk.org , Slava Ovsiienko > > > > > Subject: Re: [PATCH v2 1/1]

[PATCH v3 1/1] app/testpmd: add GPU memory option for mbuf pools

From: Elena Agostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine to ensure no workload is applie

[PATCH v3 0/1] app/testpmd: add GPU memory option for mbuf pools

From: Elena Agostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine to ensure no workload is applie

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

> > Could you, please, set "Author" correctly - "Elena Agostini > > "? > > Otherwise, we see in the git log: > > > > "Author: eagostini " > > > > Compare with: > > "Author: Bing Zhao " > > "Author: Viacheslav Ovsiienko " > > > > Also, please, see the codestyle issues, too many code lines far beyon

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

On 11/16/2021 6:06 PM, Elena Agostini wrote: > From: Ferruh Yigit > Date: Tuesday, 16 November 2021 at 19:00 > To: Elena Agostini > Cc: dev@dpdk.org , Slava Ovsiienko > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > External email: Use caution open

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

> From: Ferruh Yigit > Date: Tuesday, 16 November 2021 at 19:00 > To: Elena Agostini > Cc: dev@dpdk.org , Slava Ovsiienko > Subject: Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine > External email: Use caution opening links or attachments> > > On 11/11/2021 9:41 PM, eagos

Re: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

On 11/11/2021 9:41 PM, eagost...@nvidia.com wrote: --- a/app/test-pmd/meson.build +++ b/app/test-pmd/meson.build @@ -32,7 +32,7 @@ if dpdk_conf.has('RTE_HAS_JANSSON') ext_deps += jansson_dep endif -deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'bus_pci'] +deps += ['ethdev', '

Re: ethdev: hide internal structures

On Tue, Nov 16, 2021 at 09:32:15AM +, Ferruh Yigit wrote: > > Hi Tyler, > > It shouldn't be an API change, which API is changed? exported declarations that were consumed by the application were removed from an installed header. anything making reference to rte_eth_devices[] will no longer co

RE: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

> Could you, please, set "Author" correctly - "Elena Agostini > "? > Otherwise, we see in the git log: > > "Author: eagostini " > > Compare with: > "Author: Bing Zhao " > "Author: Viacheslav Ovsiienko " > > Also, please, see the codestyle issues, too many code lines far beyond 100 > chars. >

Re: [PATCH 5/5] build: select optional libraries

10/11/2021 18:34, Bruce Richardson: > On Wed, Nov 10, 2021 at 05:48:14PM +0100, David Marchand wrote: > > There is currently no way to know which libraries are optional. > > Introduce a enable_libs option (close to what we have for drivers) so > > that packagers or projects consuming DPDK can more

Re: [dpdk-dev] [PATCH] net/vmxnet3: add spinlocks to register command access

On 11/8/2021 8:23 AM, sahithi.sin...@oracle.com wrote: From: Sahithi Singam At present, there are no spinlocks around register command access. This resulted in a race condition when two threads running on two different cores invoked link_update function at the same time to get link status. Due t

Re: [PATCH 4/5] build: make pdump optional

10/11/2021 17:48, David Marchand: > This library can be made optional. > dumpcap and pdump applications depend on this library, check for > dependencies like what we have for examples. > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: [PATCH 3/5] build: make metrics libraries optional

10/11/2021 17:48, David Marchand: > metrics, bitratestats, jobstats and latencystats libraries can be made > optional as they provide standalone features. > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: [PATCH 2/5] build: make GRO/GSO optional

10/11/2021 17:48, David Marchand: > GRO and GSO integration in testpmd is relatively self contained and easy > to extract. > Those libraries can be made optional as they provide standalone > features. > > Signed-off-by: David Marchand Acked-by: Thomas Monjalon

Re: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup

On 11/16/2021 3:04 PM, Slava Ovsiienko wrote: -Original Message- From: Chengfeng Ye Sent: Tuesday, November 16, 2021 16:49 To: Matan Azrad ; Slava Ovsiienko ; Tzahi Oved ; ferruh.yi...@intel.com; Raslan Darawsheh Cc: dev@dpdk.org; Chengfeng Ye ; sta...@dpdk.org Subject: [PATCH v6] net/m

Re: [PATCH 1/5] ci: test build with minimum configuration

10/11/2021 17:48, David Marchand: > Disabling optional libraries was not tested. > Add a new target in test-meson-builds.sh and GHA. > > The Bluefield target is removed from test-meson-builds.sh to save space > and compilation time in exchange of the new target. OK to remove build-arm64-bluefield

Re: [PATCH v4 00/18] fix docbook and spelling errors

On Fri, Nov 12, 2021 at 1:02 AM Stephen Hemminger wrote: > > After finding a few typos in BPF, decided to cast a > wider net and fix lots more places. These are all contained > to typos in strings or comments. > Series squashed and applied, thanks. -- David Marchand

Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver

16/11/2021 17:30, Thomas Monjalon: > 16/11/2021 23:50, eagost...@nvidia.com: > > From: Elena Agostini > > > > This is the CUDA implementation of the gpudev library. > > Functionalities implemented through CUDA Driver API are: > > - Device probe and remove > > - Manage device memory allocations >

Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver

16/11/2021 16:58, Stephen Hemminger: > Minor comments, overall looks fine. > > > +/* CUDA Driver functions loaded with dlsym() */ > +CUresult CUDAAPI (*sym_cuInit)(unsigned int flags) = NULL; > +CUresult CUDAAPI (*sym_cuDriverGetVersion)(int *driverVersion) = NULL; > +CUresult CUDAAPI (*sym_cuGet

Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver

16/11/2021 16:58, Stephen Hemminger: > Minor comments, overall looks fine. > > > +/* CUDA Driver functions loaded with dlsym() */ > +CUresult CUDAAPI (*sym_cuInit)(unsigned int flags) = NULL; > +CUresult CUDAAPI (*sym_cuDriverGetVersion)(int *driverVersion) = NULL; > +CUresult CUDAAPI (*sym_cuGet

Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver

16/11/2021 23:50, eagost...@nvidia.com: > From: Elena Agostini > > This is the CUDA implementation of the gpudev library. > Functionalities implemented through CUDA Driver API are: > - Device probe and remove > - Manage device memory allocations > - Register/unregister external CPU memory in the

RE: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

Hi, Elena > -Original Message- > From: eagost...@nvidia.com > Sent: Thursday, November 11, 2021 23:42 > To: dev@dpdk.org > Cc: Elena Agostini > Subject: [PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd > engine > > From: eagostini Could you, please, set "Author" correctly -

Re: [dpdk-dev] [PATCH v1] maintainers: update for driver testing tool

On 11/16/2021 4:14 PM, Li, Xiaoyun wrote: -Original Message- From: Yigit, Ferruh Sent: Tuesday, November 16, 2021 16:01 To: Li, Xiaoyun ; Zhang, Yuying ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for driver testing tool On 10/19/2021 4:03 AM, Li, Xiaoyun wrote:

RE: [dpdk-dev] [PATCH v1] maintainers: update for driver testing tool

> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, November 16, 2021 16:01 > To: Li, Xiaoyun ; Zhang, Yuying > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1] maintainers: update for driver testing tool > > On 10/19/2021 4:03 AM, Li, Xiaoyun wrote: > >> -Original Message-

RE: [PATCH v2] common/mlx5: fix MPRQ mempool registration

Hi, > -Original Message- > From: Dmitry Kozlyuk > Sent: Tuesday, November 16, 2021 1:56 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Slava Ovsiienko > Subject: [PATCH v2] common/mlx5: fix MPRQ mempool registration > > Mempool registration code had a wrong assumption > t

Re: [dpdk-dev] [PATCH v1] maintainers: update for driver testing tool

On 10/19/2021 4:03 AM, Li, Xiaoyun wrote: -Original Message- From: Zhang, Yuying Sent: Tuesday, October 19, 2021 14:17 To: dev@dpdk.org; Li, Xiaoyun Cc: Zhang, Yuying Subject: [PATCH v1] maintainers: update for driver testing tool For test-pmd: - removing Xiaoyun Li - adding

Re: [PATCH v7 1/1] gpu/cuda: introduce CUDA driver

Minor comments, overall looks fine. +/* CUDA Driver functions loaded with dlsym() */ +CUresult CUDAAPI (*sym_cuInit)(unsigned int flags) = NULL; +CUresult CUDAAPI (*sym_cuDriverGetVersion)(int *driverVersion) = NULL; +CUresult CUDAAPI (*sym_cuGetProcAddress)(const char *symbol, + vo

[PATCH v2] doc: add mlx5 PMD flex item documentation

Describe firmware configuration requirements. List mlx5 hardware and PMD limitations. Signed-off-by: Gregory Etelson --- v2: Style fixes. --- doc/guides/nics/mlx5.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 5

Re: [PATCH v2 0/2] performance optimized for hns3 PMD

On 11/16/2021 1:22 AM, Min Hu (Connor) wrote: This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance doc/guides/nics/features/hns3.ini | 1 + drivers/net/hns3/hns3_rxtx.c

Re: [dpdk-dev] [PATCH 2/2] test: move RED to extra tests list

On Wed, Oct 27, 2021 at 4:05 PM David Marchand wrote: > > This test gives random failures, disable it. > See: https://bugs.dpdk.org/show_bug.cgi?id=826 > > Signed-off-by: David Marchand There was no objection and it helps stabilising CI (removing a random false positive). Series applied with one

Re: [PATCH v2 0/2] performance optimized for hns3 PMD

On 11/16/2021 3:12 PM, humin (Q) wrote: Hi, ferruh, I forgot it，please added it for me when you merged them.thank you. ack, adding it back in next-net. --

[PATCH] app/testpmd: fix flow transfer proxy port handling

The current approach detects the proxy port on each port (re-)plug and may spam the log with error messages if the PMD does not support flows. As testpmd is a debug tool, it must not do such implicit port handling. Instead, the new API should be called only when the user requests that. Revoke the

Re: [dpdk-dev] [PATCH] test: remove unnecessary test commands

On Wed, Oct 27, 2021 at 4:04 PM David Marchand wrote: > > EAL and rwlock tests have been split into smaller unit tests now listed > in meson. > Nothing is referencing eal_flags_autotest and rwlock_autotest anymore, > since we dropped the python wrapper. > > Fixes: 8c745bb62340 ("test: remove autot

Re: [PATCH v3] examples/flow_filtering: fix wrong comment

On Fri, Nov 12, 2021 at 7:37 AM Joyce Kong wrote: > > The 'IPv4' in the comment is to mark the code > snippet, while it made some confusion. Then > removing 'IPv4' description will be clearer. > > Fixes: 9a212dc06c7a ("doc: use code snippets in sample app guides") > Cc: sta...@dpdk.org I removed

RE: [PATCH v2 0/2] performance optimized for hns3 PMD

Hi, ferruh, I forgot it，please added it for me when you merged them.thank you. 胡敏 Hu Min Mobile: +86-13528728164 Email: humi...@huawei.com 发件人：Fengchengwen 收件人：Ferruh Yigit ;humin (Q) ;dev 抄 送：thomas 时 间：2021-11-16 23:04:08 主 题：RE:

Re: [PATCH v4] examples/multi_process: fix Rx packets distribution

On Wed, Nov 10, 2021 at 5:58 PM Gregory Etelson wrote: > > MP servers distributes Rx packets between clients according to > round-robin scheme. > > Current implementation always started packets distribution from > the first client. That procedure resulted in uniform distribution > in cases when Rx

Re: [PATCH] doc: add mlx5 PMD flex item documentation

16/11/2021 15:51, Gregory Etelson: > Describe firmware configuration requirements. > List mlx5 hardware and PMD limitations. That's a pity we missed documentation when adding the feature. Please a line "Fixes". [...] > +- Flex item API: > + > + - Firmware configuration: ``FLEX_PARSER_PROFILE_ENA

RE: [PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup

> -Original Message- > From: Chengfeng Ye > Sent: Tuesday, November 16, 2021 16:49 > To: Matan Azrad ; Slava Ovsiienko > ; Tzahi Oved ; > ferruh.yi...@intel.com; Raslan Darawsheh > Cc: dev@dpdk.org; Chengfeng Ye ; sta...@dpdk.org > Subject: [PATCH v6] net/mlx5: fix mutex unlock in txpp cl

RE: [PATCH v2 0/2] performance optimized for hns3 PMD

May be forgotten, I send v2 to him this morning, and maybe forgot adding the sign off. But the patch set is OK because we both check them. 发件人：Ferruh Yigit 收件人：humin (Q) ;dev 抄 送：thomas 时 间：2021-11-16 22:37:23 主 题：Re: [PATCH v2 0/2] performance optimized for hns3 PMD On 11/16/2021 1:22 AM, M

Re: [dpdk-dev] [PATCH v5 1/2] hash: split x86 and SW hash CRC intrinsics

On Fri, Nov 5, 2021 at 11:11 AM wrote: > > From: Pavan Nikhilesh > > Split x86 and SW hash crc intrinsics into a separate files. > > Signed-off-by: Pavan Nikhilesh > --- > v5 Changes: > - Move CRC functions to implementation specific files to remove >ifdef clutter. (Ruifeng) It is late fo

Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

On Mon, Nov 8, 2021 at 8:15 AM Ruifeng Wang wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Friday, November 5, 2021 4:57 PM > > To: Ruifeng Wang ; david.march...@redhat.com; > > jer...@marvell.com > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [dpdk-dev]

回复: [PATCH] net/mlx5: remove redundant "set used"

Hi, I send the v6 patch. Best regards, Chengfeng 发件人: YE Chengfeng 发送时间: 2021年11月12日 2:31 收件人: Slava Ovsiienko ; Ferruh Yigit ; dev@dpdk.org 抄送: Raslan Darawsheh ; Matan Azrad ; sta...@dpdk.org 主题: Re: [PATCH] net/mlx5: remove redundant "set used" Got it. 获

[PATCH] doc: add mlx5 PMD flex item documentation

Describe firmware configuration requirements. List mlx5 hardware and PMD limitations. Signed-off-by: Gregory Etelson --- doc/guides/nics/mlx5.rst | 16 1 file changed, 16 insertions(+) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 552e06c0db..bbeeb1a3d4

[PATCH v6] net/mlx5: fix mutex unlock in txpp cleanup

The lock sh->txpp.mutex was not correctly released on one path of cleanup function return, potentially causing the deadlock. Fixes: d133f4cdb7 ("net/mlx5: create clock queue for packet pacing") Cc: sta...@dpdk.org Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 30 ---

  1   2   >