> > Can you explain the calculation for 73 bytes in the code? > > Will it be sufficient for IPv6? > No, it will not cover IPv6, As currently only IPv4 test cases are there in the > app. > But I guess it covers all the scenario which are supported by the app. > 73 are the maximum bytes which can be added in > AES - SHA algo mode (41 +12 + 20 (including any padding))
Please explain and define macros appropriately so that we know what all is Covered in 73Bytes. Or why not increase it by RTE_PKTMBUF_HEADROOM. > > But it will also not cover other complex scenario like NAT-T, AH. > I have verified this change with aes-cbc-hmac-sha1 and aes-gcm algos for > 64,128,256, 512, 1280 bytes. > > What's your opinion on this? > I believe using RTE_PKTMBUF_HEADROOM will resolve most of the scenarios.
