Hi, > -----Original Message----- > From: Dmitry Kozlyuk <dkozl...@nvidia.com> > Sent: Tuesday, November 16, 2021 1:56 PM > To: dev@dpdk.org > Cc: Matan Azrad <ma...@nvidia.com>; Raslan Darawsheh > <rasl...@nvidia.com>; Slava Ovsiienko <viachesl...@nvidia.com> > Subject: [PATCH v2] common/mlx5: fix MPRQ mempool registration > > Mempool registration code had a wrong assumption > that it is always dealing with packet mempools > and always called rte_pktmbuf_priv_flags(), > which returned a random value for different types of mempools. > In particular, it could consider MPRQ mempools > as having externally pinned buffers, which is wrong. > Packet mempools cannot be reliably recognized, > but it is sufficient to check that the mempool is not a packet one, > so it cannot have externally pinned buffers. > Compare mempool private data size to that of packet mempools to check. > > Fixes: 690b2a88c2f7 ("common/mlx5: add mempool registration facilities") > Fixes: fec28ca0e3a9 ("net/mlx5: support mempool registration") > > Signed-off-by: Dmitry Kozlyuk <dkozl...@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viachesl...@nvidia.com> > --- > v2: improve logging, add ack.
Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh