On Tue, Nov 16, 2021 at 6:06 PM Thomas Monjalon <tho...@monjalon.net> wrote: > > 10/11/2021 17:48, David Marchand: > > Disabling optional libraries was not tested. > > Add a new target in test-meson-builds.sh and GHA. > > > > The Bluefield target is removed from test-meson-builds.sh to save space > > and compilation time in exchange of the new target. > > OK to remove build-arm64-bluefield. > We should also remove build-arm64-host-clang which has no benefit.
To be fair, I originally had no such change and added this following an offline discussion you and I had :-). But this is going farther than what this patch is about: testing disabling components through existing options. > And instead of adding a new target, can we reuse an existing one, > like build-clang-static or build-arm64-dpaa? Reusing means we lose some coverage of the existing target. I prefer adding a dedicated target. So I think I'll go back to my original idea and drop the bluefield change. To make this new target less space/cpu consuming (which impacts us, maintainers, when merging patches), I can make it a really minimalistic configuration: I would disable all drivers (but the net/null one used in test-null.sh). I don't mind looking into other target usefulness in test-meson-builds.sh, but as a followup series. -- David Marchand
