[dpdk-dev] [PATCH v9 5/5] net/enetfec: add features

2021-11-09 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 + doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 14 ++- drivers/net

[dpdk-dev] [PATCH v9 4/5] net/enetfec: add Rx/Tx support

2021-11-09 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v9 3/5] net/enetfec: support queue configuration

2021-11-09 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 222 +-

[dpdk-dev] [PATCH v9 2/5] net/enetfec: add UIO support

2021-11-09 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v9 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-09 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- v9: - Fix document build warning v8: - Rework of technical comments v7:

[dpdk-dev] [PATCH v9 0/5] drivers/net: add NXP ENETFEC driver

2021-11-09 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

Re: [dpdk-dev] Probing the expected state/support of DPDK@armhf

2021-11-09 Thread Christian Ehrhardt
On Tue, Nov 9, 2021 at 8:17 AM Ruifeng Wang wrote: > > > -Original Message- > > From: Christian Ehrhardt > > Sent: Monday, November 8, 2021 8:32 PM > > To: Jan Viktorin ; Ruifeng Wang > > ; dev > > Cc: Luca Boccassi > > Subject: Probing the expected state/support of DPDK@armhf > > > > H

Re: [dpdk-dev] RSS Hash suport in DPDK on Amazon ENA NICs broken?

2021-11-09 Thread Michał Krawczyk
+Shai śr., 10 lis 2021 o 00:34 fwefew 4t4tg <7532ya...@gmail.com> napisał(a): > > On AWS EC2 I configure: > > - c5n.metal instance > - Stock AWS AMI Ubuntu 20.04 LTS ($ cat /proc/version > Linux version 5.4.0-1045-aws) > - Apply the vfio pci driver from https://github.com/amzn/am > zn-drivers/tree

Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before device start

2021-11-09 Thread Jiang, YuX
> -Original Message- > From: Jiang, YuX > Sent: Tuesday, November 2, 2021 10:38 AM > To: 'Ferruh Yigit' ; Ajit Khaparde > ; Andrew Rybchenko > > Cc: Li, Xiaoyun ; Xu, Rosen ; > Ananyev, Konstantin ; Ivan Ilchenko > ; dpdk-dev > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix MTU configur

[dpdk-dev] [Bug 841] [dpdk-21.11] DPDK build failed with EXTRA_CFLAGS='-O1' on Ubuntu20.4.3 and Redhat8.4.

2021-11-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=841 longfengx.li...@intel.com (longfengx.li...@intel.com) changed: What|Removed |Added Resolution|--- |FIXED

Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v16 2/9] eal: add thread attributes

2021-11-09 Thread Stephen Hemminger
On Wed, 10 Nov 2021 04:20:52 + Tyler Retzlaff wrote: > > > > > > High performance applications benefit from an option to raise the > > > priority of their threads to avoid being preemted by other threads on > > > the system. If there are issues with realtime priority on some of the > > > p

[dpdk-dev] [PATCH v3] vhost: fix physical address mapping

2021-11-09 Thread Xuan Ding
When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 ("vhost: enable IOM

Re: [dpdk-dev] [PATCH v1 01/12] test/pmd_perf: use compiler atomic builtins for polling sync

2021-11-09 Thread Joyce Kong
> > > > > > Convert rte_atomic usages to compiler atomic built-ins for polling > > sync in pmd_perf test cases. > > > > Signed-off-by: Joyce Kong > > Reviewed-by: Ruifeng Wang > > --- > > app/test/test_pmd_perf.c | 12 +--- > > 1 file changed, 5 insertions(+), 7 deletions(-) > > > > di

[dpdk-dev] [PATCH] vhost: fix physical address mapping

2021-11-09 Thread Xuan Ding
When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 ("vhost: enable IOM

[dpdk-dev] [PATCH] failsafe: Bug fix to support secondary process attach to the device created by primary for RX and TX

2021-11-09 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/

[dpdk-dev] [PATCH v2] eventdev/eth_tx: fix queue_del function

2021-11-09 Thread Naga Harish K S V
This patch fixes heap-use-after-free reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=869 The application can use the queue_id as `-1` to delete all the queues of the eth_device that are added to tx_adapter instance. In above case, the queue_del api is trying to use number

[dpdk-dev] [PATCH] vhost: fix physical address mapping

2021-11-09 Thread Xuan Ding
When choosing IOVA as PA mode, IOVA is likely to be discontinuous, which requires page by page mapping for DMA devices. To be consistent, this patch implements page by page mapping instead of mapping at the region granularity for both IOVA as VA and PA mode. Fixes: 7c61fa08b716 ("vhost: enable IOM

[dpdk-dev] [PATCH] eventdev/eth_tx: fix queue_del function

2021-11-09 Thread Naga Harish K S V
This patch fixes heap-use-after-free reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=869 The application can use the queue_id as `-1` to delete all the queues of the eth_device that are added to tx_adapter instance. In above case, the queue_del api is trying to use number

Re: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: introduce DPAA DMA driver

2021-11-09 Thread Gagandeep Singh
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 9, 2021 8:15 PM > To: Gagandeep Singh > Cc: dev@dpdk.org; Nipun Gupta ; > david.march...@redhat.com; ferruh.yi...@intel.com; gak...@marvell.com; > Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: i

[dpdk-dev] [PATCH v2] vhost: fix packed ring descriptor update in async enqueue

2021-11-09 Thread Jiayu Hu
If the packet uses multiple descrptors and its descriptor indices are wrapped, the first descriptor flag is not updated last, which may cause virtio read the incomplete packet. For example, given a packet uses 64 descriptors, and virtio ring size is 256, and its descriptor indices is 224~255 and 0~

[dpdk-dev] [PATCH v2] common/cnxk: fix memory leak

2021-11-09 Thread Anoob Joseph
The memory allocated for temporarily keeping DPTR need to be freed after operation. Also, dptr need to be aligned to 8B. Fixes: 71213a8b773c ("common/cnxk: support CPT CTX write through microcode op") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph Reviewed-by: Nithin Kumar Dabilpuram Revi

[dpdk-dev] [PATCH] common/cnxk: fix memory leak

2021-11-09 Thread Anoob Joseph
The memory allocated for temporarily keeping DPTR need to be freed after operation. Also, dptr need to be aligned to 8B. Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through microcode op") Cc: scha...@marvell.com Signed-off-by: Anoob Joseph Reviewed-by: Nithin Kumar Dabilpuram

Re: [dpdk-dev] [PATCH v16 2/9] eal: add thread attributes

2021-11-09 Thread Stephen Hemminger
On Tue, 9 Nov 2021 19:04:17 -0800 Narcisa Ana Maria Vasile wrote: > > > I'll send a new version with a better commit message. > > > Thread priorities on both Linux-based and Windows platforms are > > > similarly > > > constructed from a class/policy + priority value. Currently in DPDK, >

Re: [dpdk-dev] [PATCH v16 8/9] eal: implement functions for thread barrier management

2021-11-09 Thread Narcisa Ana Maria Vasile
On Mon, Nov 08, 2021 at 06:07:34PM -0800, Narcisa Ana Maria Vasile wrote: > On Tue, Oct 12, 2021 at 06:32:09PM +0200, Thomas Monjalon wrote: > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > From: Narcisa Vasile > > > > > > Add functions for barrier init, destroy, wait. > > > > > > A portabl

Re: [dpdk-dev] [PATCH v16 9/9] Add unit tests for thread API

2021-11-09 Thread Narcisa Ana Maria Vasile
On Tue, Nov 09, 2021 at 09:32:08AM +0100, Thomas Monjalon wrote: > 09/11/2021 03:10, Narcisa Ana Maria Vasile: > > On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote: > > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > > From: Narcisa Vasile > > > > > > > > As a new API for threa

Re: [dpdk-dev] [PATCH v16 2/9] eal: add thread attributes

2021-11-09 Thread Narcisa Ana Maria Vasile
On Tue, Nov 09, 2021 at 09:27:09AM +0100, Thomas Monjalon wrote: > 09/11/2021 02:59, Narcisa Ana Maria Vasile: > > On Tue, Oct 12, 2021 at 06:12:21PM +0200, Thomas Monjalon wrote: > > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > > From: Narcisa Vasile > > > > > > > > Implement thread attri

[dpdk-dev] [PATCH v17 12/13] eal: implement functions for mutex management

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for mutex init, destroy, lock, unlock, trylock. Windows does not have a static initializer. Initialization is only done through InitializeCriticalSection(). To overcome this, RTE_INIT_MUTEX macro is added to replace static initialization of mutexes. The macro c

[dpdk-dev] [PATCH v17 13/13] app/test: add unit tests for mutex

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Verify that the mutex correctly locks/unlocks and protects the data. Check both static and dynamic mutexes. Signed-off-by: Narcisa Vasile --- app/test/test_threads.c |

[dpdk-dev] [PATCH v17 10/13] eal: implement functions for thread barrier management

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for barrier init, destroy, wait. A portable type is used to represent a barrier identifier. The rte_thread_barrier_wait() function returns the same value on all platforms. Signed-off-by: Narcisa Vasile --- lib/eal/common/rte_thread.c | 61 ++

[dpdk-dev] [PATCH v17 06/13] eal: add thread lifetime management

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for thread creation, joining, detaching. The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is

[dpdk-dev] [PATCH v17 07/13] app/test: add unit tests for rte_thread_self

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Test the rte_thread_self() functionality used to retrieve the thread id. Signed-off-by: Narcisa Vasile --- app/test/meson.build| 2 ++ app/test/test_threads.c | 63

[dpdk-dev] [PATCH v17 05/13] eal: implement thread priority management functions

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add functions for setting and getting the priority of a thread. Priorities on multiple platforms are similarly determined by a priority value and a priority class/policy. Currently in DPDK most threads operate at the OS-default priority level but there are cases when increas

[dpdk-dev] [PATCH v17 08/13] app/test: add unit tests for thread attributes

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Verify that affinity and priority can be set successfully. Signed-off-by: Narcisa Vasile --- app/test/test_threads.c | 125 1

[dpdk-dev] [PATCH v17 11/13] app/test: add unit tests for barrier

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Verify that the barrier correctly synchronizes all threads. Verify that the threads are unblocked after the required number of threads have called barrier_wait(). Signed

[dpdk-dev] [PATCH v17 09/13] app/test: add unit tests for thread lifetime management

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile As a new API for threading is introduced, a set of unit tests have been added to test the new interface. Verify that threads are created and cleaned up correctly. Signed-off-by: Narcisa Vasile --- app/test/test_threads.c | 29 + 1 file changed,

[dpdk-dev] [PATCH v17 04/13] eal: implement functions for thread affinity management

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement functions for getting/setting thread affinity. Threads can be pinned to specific cores by setting their affinity attribute. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/eal/common/rte_thread.c | 16 lib/eal/include/rte_thread.h |

[dpdk-dev] [PATCH v17 03/13] eal/windows: translate Windows errors to errno-style errors

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Add function to translate Windows error codes to errno-style error codes. The possible return values are chosen so that we have as much semantical compatibility between platforms as possible. Signed-off-by: Narcisa Vasile --- lib/eal/windows/rte_thread.c | 48 +

[dpdk-dev] [PATCH v17 02/13] eal: add thread attributes

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: - RTE_THREAD_PRIORITY_NORMAL - RTE_THREAD_PRIORITY_REALTIME_CRITICAL

[dpdk-dev] [PATCH v17 01/13] eal: add basic threading functions

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile Use a portable, type-safe representation for the thread identifier. Add functions for comparing thread ids and obtaining the thread id for the current thread. Signed-off-by: Narcisa Vasile --- lib/eal/common/meson.build| 1 + lib/eal/{unix => common}/rte_threa

[dpdk-dev] [PATCH v17 00/13] eal: Add EAL API for threading

2021-11-09 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL thread API **Problem Statement** DPDK currently uses the pthread interface to create and manage threads. Windows does not support the POSIX thread programming model, so it currently relies on a header file that hides the Windows calls under pthread matched interfaces. Gi

Re: [dpdk-dev] Questions about mmap in Asan APP

2021-11-09 Thread Min Hu (Connor)
在 2021/11/6 21:11, Thomas Monjalon 写道: 06/11/2021 10:27, Min Hu (Connor): Hi, Jonas Pfefferle and all, I met one questions: When I ran APP on Kasan OS, secondary process occasionally init failed. BTW: testpmd is built with Asan, that is to add "CFLAGS="-fsanitize=address -fno

[dpdk-dev] RSS Hash suport in DPDK on Amazon ENA NICs broken?

2021-11-09 Thread fwefew 4t4tg
On AWS EC2 I configure: - c5n.metal instance - Stock AWS AMI Ubuntu 20.04 LTS ($ cat /proc/version Linux version 5.4.0-1045-aws) - Apply the vfio pci driver from https://github.com/amzn/am zn-drivers/tree/master/userspace/dpdk/enav2-vfio-patch - Using DPDK code from head of main branch. I built us

[dpdk-dev] [PATCH v2] usertools/devbind: update octeontx2 DMA device

2021-11-09 Thread Radha Mohan Chintakuntla
The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver for the same device uses the dmadev. So this patch updates the device naming and lists it under dma devices section. Signed-off-by: Radha Mohan Chintakuntla --- Changes from v1: - Sort the names alphabetically usertools/dp

Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

2021-11-09 Thread Radha Mohan
On Tue, Nov 9, 2021 at 12:50 PM Thomas Monjalon wrote: > > 09/11/2021 17:55, Radha Mohan Chintakuntla: > > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver > > for the same device uses the dmadev. So this patch updates the device > > naming and lists it under dma devices se

Re: [dpdk-dev] [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync

2021-11-09 Thread Honnappa Nagarahalli
+ Ferruh Hi Joyce/Ferruh, I do not think the port_status changes need to be handled atomically. The changes to port_status do not seem to be happening from multiple threads. It seems to be getting modified during initialization or through the test pmd prompt. Do we really need atomic op

Re: [dpdk-dev] [PATCH v1 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-09 Thread Honnappa Nagarahalli
> > Convert rte_atomic_test_and_set usage to compiler atomic CAS operation for > display sync. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > app/test-compress-perf/comp_perf_test_common.h | 2 +- > app/test-compress-perf/comp_perf_test_cyclecount.c | 10 +++--- >

[dpdk-dev] [Bug 743] Building DPDK with gcc 11.1.1 Generates Multiple Warning Messages in the i40e PMD

2021-11-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=743 David Christensen (d...@linux.vnet.ibm.com) changed: What|Removed |Added Resolution|--- |FIXED St

Re: [dpdk-dev] [PATCH] test/bpf_convert: do not require DNS lookup

2021-11-09 Thread Luca Boccassi
On Tue, 2021-11-09 at 13:04 -0800, Stephen Hemminger wrote: > These tests are testing with strings with hostname (dpdk.org) > and this makes test code do a DNS lookup. In container test > runs, DNS is unavailable. Replace dpdk.org with the current > IP and IPV6 addresses. Actual addresses don't m

Re: [dpdk-dev] [PATCH] net/i40e: fix gcc 11 build warning on POWER architecture

2021-11-09 Thread David Christensen
Not sure if below patch also help to solve the issue you met on power arch, Looks like the error is same: "writing 1 byte into a region of size 0" would you help to check? commit 1b0f3a18145468c309bb5a8cb98a8aa29af059e7 Author: Ferruh Yigit Date: Fri Oct 29 11:37:01 20

Re: [dpdk-dev] [PATCH v1 08/12] app/crypto: use compiler atomic builtins for display sync

2021-11-09 Thread Honnappa Nagarahalli
> > Covert rte_atomic_test_and_set usage to compiler atomic CAS operation for ^^ Convert > display sync in crypto cases. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang With the above typo fixed, Reviewed-by: Honnappa Nagarahalli > --- > app/test-crypto-perf/cperf_test_la

Re: [dpdk-dev] [PATCH v1 06/12] test/func_reentrancy: use compiler atomic for data sync

2021-11-09 Thread Honnappa Nagarahalli
> > Convert rte_atomic usages to compiler atomic built-ins for data sync in > func_reentrancy test cases. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Looks good. Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_func_reentrancy.c | 27 +-- > 1 fi

Re: [dpdk-dev] [PATCH v1 04/12] test/stack_perf: use compiler atomics for lcore sync

2021-11-09 Thread Honnappa Nagarahalli
> > Convert rte_atomic usages to compiler atomic built-ins for lcore sync in > stack_perf test cases. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang Looks good Reviewed-by: Honnappa Nagarahalli > --- > app/test/test_stack_perf.c | 14 ++ > 1 file changed, 6 insertion

[dpdk-dev] [PATCH] test/bpf_convert: do not require DNS lookup

2021-11-09 Thread Stephen Hemminger
These tests are testing with strings with hostname (dpdk.org) and this makes test code do a DNS lookup. In container test runs, DNS is unavailable. Replace dpdk.org with the current IP and IPV6 addresses. Actual addresses don't matter the purpose of the test is to BPF code conversion, not any pac

Re: [dpdk-dev] [PATCH v1 03/12] test/timer: use compiler atomic builtins for sync

2021-11-09 Thread Honnappa Nagarahalli
> Subject: [PATCH v1 03/12] test/timer: use compiler atomic builtins for sync > > Convert rte_atomic usages to compiler atomic built-ins for lcore_state and > collisions sync. > > Signed-off-by: Joyce Kong > Reviewed-by: Ruifeng Wang > --- > app/test/test_timer.c | 28 -

Re: [dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

2021-11-09 Thread Thomas Monjalon
09/11/2021 17:55, Radha Mohan Chintakuntla: > The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver > for the same device uses the dmadev. So this patch updates the device > naming and lists it under dma devices section. > > Signed-off-by: Radha Mohan Chintakuntla > --- > user

[dpdk-dev] [Bug 880] [asan] mem: out of bound access in unit test

2021-11-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=880 Bug ID: 880 Summary: [asan] mem: out of bound access in unit test Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [dpdk-dev] [PATCH] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-09 Thread Honnappa Nagarahalli
> >> > >> This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining > why > >> a particular value was chosen. > >> > >> Signed-off-by: Vladimir Medvedkin > >> --- > >> lib/hash/rte_cuckoo_hash.h | 8 +++- > >> 1 file changed, 7 insertions(+), 1 deletion(-) > >> > >> diff --git a/li

Re: [dpdk-dev] [PATCH] hash: clarify comments for RTE_HASH_BUCKET_ENTRIES

2021-11-09 Thread Medvedkin, Vladimir
Hi Honnappa, On 08/11/2021 23:04, Honnappa Nagarahalli wrote: This patch adds a comment for RTE_HASH_BUCKET_ENTRIES explaining why a particular value was chosen. Signed-off-by: Vladimir Medvedkin --- lib/hash/rte_cuckoo_hash.h | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH] ethdev: fix device capability to string translation

2021-11-09 Thread Ferruh Yigit
On 11/9/2021 11:56 AM, Ali Alnubani wrote: -Original Message- From: Dmitry Kozlyuk Sent: Tuesday, November 9, 2021 11:01 AM To: dev@dpdk.org Cc: Ali Alnubani ; Xueming(Steven) Li ; NBU-Contact-Thomas Monjalon ; Ferruh Yigit ; Andrew Rybchenko Subject: [PATCH] ethdev: fix device capabili

Re: [dpdk-dev] [PATCH] hash: fix thash gfni implementation

2021-11-09 Thread Ji, Kai
> -Original Message- > From: dev On Behalf Of Vladimir Medvedkin > Sent: Tuesday, November 9, 2021 5:25 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; Ananyev, > Konstantin ; > lance.richard...@broadcom.com; Medvedkin, Vladimir > ; Wang, Yipeng1 > ; Gobriel,

[dpdk-dev] [PATCH] hash: fix thash gfni implementation

2021-11-09 Thread Vladimir Medvedkin
This patch replaces _mm512_set_epi8 with _mm512_set_epi32 due to the lack of support by some compilers. Also this patch checks if AVX512F is supported along with GFNI. This is done if the code is built on a platform that supports GFNI, but does not support AVX512. Fixes: 4fd8c4cb0de1 ("hash: add n

[dpdk-dev] [PATCH] usertools/devbind: update octeontx2 DMA device

2021-11-09 Thread Radha Mohan Chintakuntla
The octeontx2_dma rawdev driver is removed in DPDK-21.11. The new driver for the same device uses the dmadev. So this patch updates the device naming and lists it under dma devices section. Signed-off-by: Radha Mohan Chintakuntla --- usertools/dpdk-devbind.py | 11 ++- 1 file changed, 6

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread Medvedkin, Vladimir
Hi all, It looks like the problem caused by the lack of _mm512_set1_epi8() implementation inside the gcc8, however _mm512_set1_epi[16,32,64] has been implemented. I replaced it with _mm512_set1_epi32 and on gcc8 it builds fine. I'll send a fix soon. On 09/11/2021 17:22, Lance Richardson wrot

Re: [dpdk-dev] [EXT] [dpdk-dev v3] test/cryptodev: fix incomplete data length

2021-11-09 Thread Anoob Joseph
Hi Kai, Thanks for addressing the comments. Acked-by: Anoob Joseph > > -- > This patch fixes incorrect data lengths computation in cryptodev unit test. > Previously some data lengths were incorrectly set, which was insensitive

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread Lance Richardson
Based on the CI build logs, the target architecture was Skylake, which supports AVX512 but doesn't support GFNI. On Tue, Nov 9, 2021 at 11:15 AM Thomas Monjalon wrote: > > 09/11/2021 17:12, Lance Richardson: > > Do the machines used for the CentOS 8 CI builds support AVX512? > > Probably not. OK

Re: [dpdk-dev] [EXT] Re: [PATCH v7 4/5] net/enetfec: add Rx/Tx support

2021-11-09 Thread Apeksha Gupta
> -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 4, 2021 11:58 PM > To: Apeksha Gupta ; david.march...@redhat.com; > andrew.rybche...@oktetlabs.ru > Cc: dev@dpdk.org; Sachin Saxena ; Hemant Agrawal > > Subject: [EXT] Re: [PATCH v7 4/5] net/enetfec: add Rx/Tx support >

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread Thomas Monjalon
09/11/2021 17:12, Lance Richardson: > Do the machines used for the CentOS 8 CI builds support AVX512? Probably not. OK thank you. > The failing build is on an Ice Lake server with: > meson -Dmachine=native build > ninja -C build > > On Tue, Nov 9, 2021 at 11:08 AM Thomas Monjalon wrot

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread Lance Richardson
Do the machines used for the CentOS 8 CI builds support AVX512? The failing build is on an Ice Lake server with: meson -Dmachine=native build ninja -C build On Tue, Nov 9, 2021 at 11:08 AM Thomas Monjalon wrote: > > 09/11/2021 16:57, David Marchand: > > On Tue, Nov 9, 2021 at 4:53 PM L

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread Thomas Monjalon
09/11/2021 16:57, David Marchand: > On Tue, Nov 9, 2021 at 4:53 PM Lance Richardson > wrote: > > > > 21.11-rc2 builds are failing on CentOS 8.4, apparently because > > the intrinsic _mm512_set_epi8() is not defined in the GCC > > headers (see example below). > > Thanks for reporting Lance. > It r

Re: [dpdk-dev] [PATCH] doc: deprecation notice to remove octeontx2 drivers

2021-11-09 Thread Ferruh Yigit
On 11/9/2021 3:51 PM, jer...@marvell.com wrote: From: Jerin Jacob In the view of enabling unified driver for octeontx2(cn9k)/ octeontx3(cn10k), removing drivers/octeontx2 drivers and replace with drivers/cnxk/ which supports both octeontx2(cn9k) and octeontx3(cn10k) SoCs. This deprecation notic

Re: [dpdk-dev] Build failures in 21.11-rc2

2021-11-09 Thread David Marchand
On Tue, Nov 9, 2021 at 4:53 PM Lance Richardson wrote: > > 21.11-rc2 builds are failing on CentOS 8.4, apparently because > the intrinsic _mm512_set_epi8() is not defined in the GCC > headers (see example below). Thanks for reporting Lance. It rings a bell, think it was mentionned in the past. >

[dpdk-dev] [PATCH] doc: deprecation notice to remove octeontx2 drivers

2021-11-09 Thread jerinj
From: Jerin Jacob In the view of enabling unified driver for octeontx2(cn9k)/ octeontx3(cn10k), removing drivers/octeontx2 drivers and replace with drivers/cnxk/ which supports both octeontx2(cn9k) and octeontx3(cn10k) SoCs. This deprecation notice is to do following actions in DPDK v22.02 versi

Re: [dpdk-dev] [PATCH v4 1/5] dma/dpaa: introduce DPAA DMA driver

2021-11-09 Thread Thomas Monjalon
09/11/2021 05:39, Gagandeep Singh: > The DPAA DMA driver is an implementation of the dmadev APIs, > that provide means to initiate a DMA transaction from CPU. > The initiated DMA is performed without CPU being involved > in the actual DMA transaction. This is achieved via using > the QDMA controll

Re: [dpdk-dev] [PATCH v2] examples/multi_proces: fix Rx packets distribution

2021-11-09 Thread Thomas Monjalon
09/11/2021 12:49, Gregory Etelson: > Hello Thomas, > > > 09/11/2021 10:58, Gregory Etelson: > > > - uint8_t client = 0; > > > + /* > > > + * C99: All objects with static storage > > duration > > > + * shall be initialized (set to their initial > > values) before > > > + * pr

[dpdk-dev] [PATCH v5] ip_frag: add namespace

2021-11-09 Thread Konstantin Ananyev
Update public macros to have RTE_IP_FRAG_ prefix. Update DPDK components to use new names. Keep obsolete macro for compatibility reasons. Renamed experimental function ``rte_frag_table_del_expired_entries``to ``rte_ip_frag_table_del_expired_entries`` to comply with other public API naming conventio

Re: [dpdk-dev] [PATCH v2] examples/multi_proces: fix Rx packets distribution

2021-11-09 Thread Thomas Monjalon
09/11/2021 10:58, Gregory Etelson: > - uint8_t client = 0; > + /* > + * C99: All objects with static storage duration > + * shall be initialized (set to their initial values) before > + * program startup. > + */ Why adding this comment? > + static uint8_t client;

[dpdk-dev] [PATCH v8 5/5] net/enetfec: add features

2021-11-09 Thread Apeksha Gupta
This patch adds checksum and VLAN offloads in enetfec network poll mode driver. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- doc/guides/nics/enetfec.rst | 2 + doc/guides/nics/features/enetfec.ini | 3 ++ drivers/net/enetfec/enet_ethdev.c| 14 ++- drivers/net

[dpdk-dev] [PATCH v8 4/5] net/enetfec: add Rx/Tx support

2021-11-09 Thread Apeksha Gupta
This patch adds burst enqueue and dequeue operations to the enetfec PMD. Loopback mode is also added, compile time flag 'ENETFEC_LOOPBACK' is used to enable this feature. By default loopback mode is disabled. Basic features added like promiscuous enable, basic stats. Signed-off-by: Sachin Saxena

[dpdk-dev] [PATCH v8 3/5] net/enetfec: support queue configuration

2021-11-09 Thread Apeksha Gupta
This patch adds Rx/Tx queue configuration setup operations. On packet reception the respective BD Ring status bit is set which is then used for packet processing. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- drivers/net/enetfec/enet_ethdev.c | 222 +-

[dpdk-dev] [PATCH v8 2/5] net/enetfec: add UIO support

2021-11-09 Thread Apeksha Gupta
Implemented the fec-uio driver in kernel. enetfec PMD uses UIO interface to interact with "fec-uio" driver implemented in kernel for PHY initialisation and for mapping the allocated memory of register & BD from kernel to DPDK which gives access to non-cacheable memory for BD. Signed-off-by: Sachin

[dpdk-dev] [PATCH v8 1/5] net/enetfec: introduce NXP ENETFEC driver

2021-11-09 Thread Apeksha Gupta
ENETFEC (Fast Ethernet Controller) is a network poll mode driver for NXP SoC i.MX 8M Mini. This patch adds skeleton for enetfec driver with probe function. Signed-off-by: Sachin Saxena Signed-off-by: Apeksha Gupta --- MAINTAINERS| 7 ++ doc/guides/nics/enetfec.rst

[dpdk-dev] [PATCH v8 0/5] drivers/net: add NXP ENETFEC driver

2021-11-09 Thread Apeksha Gupta
This patch series introduce the enetfec driver, ENETFEC (Fast Ethernet Controller) is a network poll mode driver for the inbuilt NIC found in the NXP i.MX 8M Mini SoC. An overview of the enetfec driver with probe and remove are in patch 1. Patch 2 design UIO interface so that user space directly c

Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-09 Thread Thomas Monjalon
09/11/2021 11:11, Jerin Jacob: > On Fri, Oct 22, 2021 at 1:18 PM wrote: > > # Maximum feature description string length > > -feature_str_len = 30 > > +feature_str_len = 45 > > I hope this OK. I understand that without this it gives errors and > feature-length is not enough I don't think this is

Re: [dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB library

2021-11-09 Thread Walsh, Conor
> From: dev On Behalf Of Vladimir Medvedkin > Sent: Monday 8 November 2021 17:37 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 2/2] doc: add programmer's guide for the FIB > library > > Currently, programmer's guide for the FIB library is missing. > This commit adds it. > > Signed-off-by: Vlad

Re: [dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB library

2021-11-09 Thread Walsh, Conor
> From: dev On Behalf Of Vladimir Medvedkin > Sent: Monday 8 November 2021 17:37 > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] doc: add programmer's guide for the RIB > library > > Currently, programmer's guide for the RIB library is missing. > This commit adds it. > > Signed-off-by: Vlad

Re: [dpdk-dev] [PATCH] eventdev: fix Rx adapter stalls on event device backpressure

2021-11-09 Thread Kundapura, Ganapati
> -Original Message- > From: Mattias Rönnblom > Sent: 09 November 2021 13:58 > To: Kundapura, Ganapati ; > jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] eventdev: fix Rx adapter stalls on event device > backpressure > > On 2021-11-09

[dpdk-dev] [PATCH] net/iavf: fix xstats reset

2021-11-09 Thread Radu Nicolau
Wrong offset used to clear the extended stats section resulting in eth stats not being reset. Fixes: ccb49b834cd7 ("net/iavf: support xstats for inline IPsec crypto") Signed-off-by: Radu Nicolau --- drivers/net/iavf/iavf_ethdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

[dpdk-dev] [dpdk-dev v3] test/cryptodev: fix incomplete data length

2021-11-09 Thread Kai Ji
This patch fixes incorrect data lengths computation in cryptodev unit test. Previously some data lengths were incorrectly set, which was insensitive for crypto op unit tets but is critical for raw data path API unit tests. The patch addressed the issue by setting the correct data lengths for some t

Re: [dpdk-dev] [EXT] [dpdk-dev v2] test/cryptodev: fix incomplete data length

2021-11-09 Thread Anoob Joseph
Hi Kai, Minor nit inline. Thanks, Anoob > -Original Message- > From: dev On Behalf Of Kai Ji > Sent: Tuesday, November 9, 2021 3:57 PM > To: dev@dpdk.org > Cc: Kai Ji ; pablo.de.lara.gua...@intel.com; > adamx.dybkow...@intel.com; damianx.no...@intel.com > Subject: [EXT] [dpdk-dev] [dpdk

[dpdk-dev] [dpdk-dev v2] test/cryptodev: fix incomplete data length

2021-11-09 Thread Kai Ji
This patch fixes incorrect data lengths computation in cryptodev unit test. Previously some data lengths were incorrectly set, which was insensitive for crypto op unit tets but is critical for raw data path API unit tests. The patch addressed the issue by setting the correct data lengths for some t

Re: [dpdk-dev] [PATCH v5 1/4] doc: add skeleton for eventdevs feature matrices

2021-11-09 Thread Jerin Jacob
On Fri, Oct 22, 2021 at 1:18 PM wrote: > > From: Sunil Kumar Kori > > Patch adds skeleton for feature matrices for event dev > and Rx/Tx adapters. > > Along with, .ini files are added for all supported PMDs. > > Signed-off-by: Sunil Kumar Kori + Tree maintainers and eventdev adapter maintaine

[dpdk-dev] [PATCH] examples/ipsec-secgw: fix memory leaks

2021-11-09 Thread Radu Nicolau
Free telemetry structures when memory allocation or input parameter errors occur. Fixes: 3e7b7dd88021 ("examples/ipsec-secgw: support telemetry") Signed-off-by: Radu Nicolau --- examples/ipsec-secgw/ipsec-secgw.c | 65 ++ 1 file changed, 49 insertions(+), 16 deletions

[dpdk-dev] [PATCH v3] eal/arm64: support ASan

2021-11-09 Thread Volodymyr Fialko
This patch defines ASAN_SHADOW_OFFSET for arm64 according to the ASan documentation. This offset should cover all arm64 VMAs supported by ASan. Signed-off-by: Volodymyr Fialko Reviewed-by: David Marchand Acked-by: Jerin Jacob Acked-by: Ruifeng Wang --- Changes since v2: - added a comment that

Re: [dpdk-dev] [PATCH] eventdev/eth_tx: fix queue_del function

2021-11-09 Thread David Marchand
On Tue, Nov 9, 2021 at 10:24 AM Jayatheerthan, Jay wrote: > > -Original Message- > > From: Naga Harish K, S V > > Sent: Tuesday, November 9, 2021 1:04 PM > > To: jer...@marvell.com; Jayatheerthan, Jay > > Cc: dev@dpdk.org; sta...@dpdk.org > > Subject: [PATCH] eventdev/eth_tx: fix queue_d

[dpdk-dev] [PATCH 22.02 2/2] net/cnxk: add devargs for configuring SDP channel mask

2021-11-09 Thread psatheesh
From: Satheesh Paul This patch adds support to configure channel mask which will be used by rte flow when adding flow rules on SDP interfaces. Signed-off-by: Satheesh Paul --- doc/guides/nics/cnxk.rst | 21 ++ drivers/net/cnxk/cnxk_ethdev_devargs.c | 40 ++

[dpdk-dev] [PATCH 22.02 1/2] common/cnxk: support to set channel mask for SDP interfaces

2021-11-09 Thread psatheesh
From: Satheesh Paul ROC changes to support setting channel mask for SDP interfaces. Signed-off-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 13 + drivers/common/cnxk/roc_npc.h | 3 +++ drivers/common/cnxk/roc_npc_mcam.c | 10 ++ drivers/common/cnxk/roc_n

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread Huichao Cai
>You seem ok with this title, I'll go with it. -Thank you!

Re: [dpdk-dev] [PATCH] eventdev/eth_tx: fix queue_del function

2021-11-09 Thread Jayatheerthan, Jay
+ David Marchand, who reported this issue. The change looks good to me. You can add my ack. > -Original Message- > From: Naga Harish K, S V > Sent: Tuesday, November 9, 2021 1:04 PM > To: jer...@marvell.com; Jayatheerthan, Jay > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] event

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread David Marchand
On Tue, Nov 9, 2021 at 10:03 AM Huichao Cai wrote: > >It could (should?) have been a single patch. > --Yes, it can.I think the test unit is missing the offsets test content, so > add this patch, and can also test the previous patch. Too late, Thomas merged the fix in the library already. Please

Re: [dpdk-dev] [PATCH] test/ipfrag: add test content to the test unit

2021-11-09 Thread Huichao Cai
Hi Marchand I think it should be a matter of message text format, maybe I should send a link in text form, as follows: https://patchwork.dpdk.org/project/dpdk/patch/1635148553-50086-1-git-send-email-chcch...@163.com/ Thank you! Huichao Cai

  1   2   >