On Tue, Nov 09, 2021 at 09:32:08AM +0100, Thomas Monjalon wrote: > 09/11/2021 03:10, Narcisa Ana Maria Vasile: > > On Tue, Oct 12, 2021 at 06:33:16PM +0200, Thomas Monjalon wrote: > > > 09/10/2021 09:41, Narcisa Ana Maria Vasile: > > > > From: Narcisa Vasile <navas...@microsoft.com> > > > > > > > > As a new API for threading is introduced, > > > > a set of unit tests have been added to test the new interface. > > > > The tests verify that: > > > > * mutexes and barriers behave as expected > > > > * thread properties are applied correctly > > > > * the thread id is retrieved correctly > > > > * thread creation/destruction works properly > > > > > > Please make each test part of the patch implementing the feature. > > > Thanks > > > > > Makes sense, but most of these unit tests use rte_thread_create and > > rte_thread_join to handle the creation and cleanup of the threads > > that are being tested, so I'm forced to have this test patch at the end. > > You mean you cannot start the series with implementing these 2 functions?
Yes, rte_thread_create() depends on thread attributes. However, some of the other components can still be tested separately. I've broken it down in v17 to allow for better progressive testing, but the first 3 tests follow after the first 3 features. > > > I could still break it up into smaller patches, one for each test category > > (mutex, attributes, etc) if you want. > > I would like to see features built & tested atomically and progressively. >
