> -----Original Message----- > From: Jiang, YuX > Sent: Tuesday, November 2, 2021 10:38 AM > To: 'Ferruh Yigit' <ferruh.yi...@intel.com>; Ajit Khaparde > <ajit.khapa...@broadcom.com>; Andrew Rybchenko > <andrew.rybche...@oktetlabs.ru> > Cc: Li, Xiaoyun <xiaoyun...@intel.com>; Xu, Rosen <rosen...@intel.com>; > Ananyev, Konstantin <konstantin.anan...@intel.com>; Ivan Ilchenko > <ivan.ilche...@oktetlabs.ru>; dpdk-dev <dev@dpdk.org> > Subject: RE: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration before > device start > > > -----Original Message----- > > From: dev <dev-boun...@dpdk.org> On Behalf Of Ferruh Yigit > > Sent: Friday, October 29, 2021 2:23 AM > > To: Ajit Khaparde <ajit.khapa...@broadcom.com>; Andrew Rybchenko > > <andrew.rybche...@oktetlabs.ru> > > Cc: Li, Xiaoyun <xiaoyun...@intel.com>; Xu, Rosen > > <rosen...@intel.com>; Ananyev, Konstantin > > <konstantin.anan...@intel.com>; Ivan Ilchenko > > <ivan.ilche...@oktetlabs.ru>; dpdk-dev <dev@dpdk.org> > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix MTU configuration > > before device start > > > > On 10/25/2021 7:06 PM, Ajit Khaparde wrote: > > > On Sun, Oct 24, 2021 at 9:42 AM Andrew Rybchenko > > > <andrew.rybche...@oktetlabs.ru> wrote: > > >> > > >> There is no point to do rte_eth_dev_mtu_set() before configure > > >> since set MTU value is overwritten on configure anyway. So, setting > > >> of MTU before configure is rejected now on ethdev level. > > >> > > >> If testpmd is going to do configure (e.g. just after testpmd start > > >> with disabled devices start up or any configuration changes in > > >> stopped state which require reconfigure), just save requested MTU > > >> in device config to be applied on reconfigure. > > >> > > >> Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > > >> Fixes: be0433cf953c ("ethdev: forbid MTU set before device > > >> configure") > > >> > > >> Signed-off-by: Andrew Rybchenko <andrew.rybche...@oktetlabs.ru> > > > Acked-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > > > > > > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> > > > > Applied to dpdk-next-net/main, thanks. > verify patch > https://patches.dpdk.org/project/dpdk/patch/20211024164237.2116166-1- > andrew.rybche...@oktetlabs.ru/ on baseline > 6cc51b1293ceac4a77d4bf7ac91a8bbd59e1f78c > Test failed on nic XXV710 for 25GbE SFP28 158b/os Red Hat Enterprise Linux > 8.4
Hi Ferruh and Andrew, Since the patch https://patches.dpdk.org/project/dpdk/patch/20211024164237.2116166-1-andrew.rybche...@oktetlabs.ru/ Has been merged into dpdk21.11rc2 main branch, we verify the main, This bug(https://bugs.dpdk.org/show_bug.cgi?id=864) also can be reproduced, could you pls have a look again?