On 11/05, Yahui Cao wrote:
>If first rule is issued and then the second rule is issued with the same
>input set as first rule's, FDIR driver can't find there is an identical
>input set.
>
>Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
>Cc: beilei.x...@intel.com
>
>Signed-off-by: Yahui Cao
If the switch/fdir/hash module can't resolve a correct parser,
it should return error.
Fixes: 47d460d63233 ("net/ice: rework switch filter")
Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Signed-off-by: Simei Su
---
driver
testpmd will occur infinite loops when device hotplug remove.
We can fix the issue by using the pci generic remove function
Fixes: f2f4990eff94 ("net/ixgbe: release port upon close")
Signed-off-by: Di ChenxuX
v2:
reverted the code about ixgbe_vf_representor_uninit.
---
drivers/net/ixgbe/ixgbe_
testpmd will occur infinite loops when device hotplug remove.
We can fix the issue by using the pci generic remove function
Fixes: ac89d46096d5 ("net/i40e: release port upon close")
Signed-off-by: Di ChenxuX
v3:
reverted the code about i40e_vf_representor_uninit.
v2:
change the code in driver.
After enqueue function finished, packet index has been increased. Batch
enqueue function should retrieve mbuf structure pointed by that index.
Fixes: 0294211bb6dc ("vhost: optimize packed ring enqueue")
Signed-off-by: Marvin Liu
---
lib/librte_vhost/virtio_net.c | 3 ++-
1 file changed, 2 inser
Hi
From: Andrew Rybchenko
> On 11/6/19 9:58 AM, Matan Azrad wrote:
> >
> >
> > From: Andrew Rybchenko
> >> On 11/5/19 5:05 PM, Matan Azrad wrote:
> >>> From: Andrew Rybchenko
> On 11/3/19 6:16 PM, Matan Azrad wrote
> > From: Andrew Rybchenko
> >> On 11/3/19 9:57 AM, Matan Azrad wrote:
> -Original Message-
> From: Su, Simei
> Sent: Thursday, November 7, 2019 1:47 PM
> To: Zhang, Qi Z ; Ye, Xiaolong ;
> Yang, Qiming
> Cc: dev@dpdk.org; Su, Simei
> Subject: [PATCH v3] net/ice: fix segmentation fault with a wrong package
>
> This patch fixes core dump issue when enter
> -Original Message-
> From: Cao, Yahui
> Sent: Tuesday, November 5, 2019 9:37 PM
> To: Yang, Qiming ; Lu, Wenzhuo
>
> Cc: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui
> ; Ye, Xiaolong ; Xing, Beilei
>
> Subject: [PATCH v2] net/ice: fix FDIR tunnel profile existence check
>
> If first rule
Hi Bernard, PSB.
> -Original Message-
> From: Iremonger, Bernard
> Sent: Wednesday, November 6, 2019 6:41 PM
> To: Dekel Peled ; Mcnamara, John
> ; Kovacevic, Marko
> ; nhor...@tuxdriver.com;
> ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov,
> Anatoly ; xuanziya...@huawei
> -Original Message-
> From: Ye, Xiaolong
> Sent: Thursday, November 7, 2019 1:46 PM
> To: Di, ChenxuX
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming
> ; Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove
>
> On 11/07, Di, ChenxuX wrote:
> >Hi,
> >
Hi, Hideyuki
> -Original Message-
> From: Hideyuki Yamashita
> Sent: Thursday, November 7, 2019 6:46
> To: Slava Ovsiienko
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/7] net/mlx5: support for flow action on
> VLAN header
>
> Hi Slava,
>
> Thanks for your response.
>
> 1. As
On 11/07, Di, ChenxuX wrote:
>Hi,
>
>> -Original Message-
>> From: Ye, Xiaolong
>> Sent: Thursday, November 7, 2019 11:11 AM
>> To: Di, ChenxuX
>> Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming
>> ; Yigit, Ferruh
>> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove
>>
This patch fixes core dump issue when entering safe mode with a
wrong ice.pkg. In safe mode, rte_flow is not supported and it
won't initialize any flow engine.
Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling")
Signed-off-by: Simei Su
---
drivers/net/ice/ice_ethdev.c | 13 +++
Hi, Anatoly
Thank you for advices. This problem will happen in both VFIO and UIO, I will
modify both according to your advices and test them.
I did some tests with mmap() on my system, when I provided address not
page-aligned, mmap() could return page-aligned address too, but the code will
ret
Hi,
> -Original Message-
> From: Ye, Xiaolong
> Sent: Thursday, November 7, 2019 11:11 AM
> To: Di, ChenxuX
> Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming
> ; Yigit, Ferruh
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove
>
> Hi,
>
> On 11/07, Di, ChenxuX wrote:
> -Original Message-
> From: Ye, Xiaolong
> Sent: Thursday, November 7, 2019 11:30 AM
> To: Wang, ShougangX
> Cc: dev@dpdk.org; Yang, Qiming ; Xing, Beilei
> ; Cao, Yahui ; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wild pointer
>
> On 11/07, Ye Xiaolong wrote:
> >On
The original design is to use rte_mbuf::udata64 to save the metadata of
protocol extraction which has network protocol data fields and type, a
private API is used to decode this metadata.
Use the dynamic mbuf field and flags to register the needed fields in
mbuf, to avoid overwriting 'rte_mbuf::ud
Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1
of CMD field in Tx descriptor of AVX Tx path according to Spec.
Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf")
Signed-off-by: Leyi Rong
---
drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++--
1 file changed, 3 insertions(+), 2
On Wed, Nov 6, 2019 at 2:57 PM Subrahmanyam Nilla wrote:
>
> System DPI Packet Interface Unit (SDP) is a co-processor
> of OCTEON TX2 which provides PCIe endpoint support for a
> remote host to DMA packets into and out of the OCTEON TX2 SoC.
> SDP interface comes in to live only when it is connect
On Thu, Nov 7, 2019 at 4:03 AM Alex Williamson
wrote:
>
> On Thu, 31 Oct 2019 18:03:53 +0100
> Thomas Monjalon wrote:
>
> > We don't get enough attention on this topic.
> > Let me rephrase the issue and the proposals with more people Cc'ed.
> >
> > We are talking about SR-IOV VFs in VMs
> > with
Hi Slava,
Thanks for your response.
1. As you pointed out, it was configuration issue
(CONFIG_RTE_LIBRTE_MLX5_DEBUG=y)!
When I turned out the configuration, 19.11 rc1 recognized Connect-X5
corrcetly.
Thanks for your help.
2. How about the question I put in my previouse email
(how to create flo
Members Attending
-
Bruce
Ferruh
Hemant (chair)
Honnapa
Jerin
Kevin
Konstantin
Maxime
Olivier
Stephen
Thomas
NOTE: The technical board meetings every second Wednesday on IRC channel
#dpdk-board, at 3pm UTC. Meetings are public and DPDK community members are
welcome to attend.
On 11/07, Ye Xiaolong wrote:
>On 11/05, Wang ShougangX wrote:
>>To avoid wild pointer, pointers should be set to NULL after free them.
>>
>>Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director")
>>Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
>>Cc: sta...@dpdk.org
Hi Yipeng,
Thanks for changing the state to 'New'. Yes this patch was wrongly Superseded.
Regards,
Amit
> -Original Message-
> From: Ferruh Yigit
> Sent: Tuesday, November 5, 2019 10:07 PM
> To: Wang, Yipeng1 ; Amit Gupta
> ; Gobriel, Sameh ;
> Thomas Monjalon
> Cc: dev@dpdk.org; Davi
On 11/05, Wang ShougangX wrote:
>The removal of FDIR profile should start from ICE_FLTR_PTYPE_NONF_IPV4_UDP.
>
>Fixes: 109e8e06249e ("net/ice: configure HW flow director rule")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Wang ShougangX
>---
> drivers/net/ice/ice_fdir_filter.c | 7 ++-
> 1 file chang
On 11/05, Wang ShougangX wrote:
>To avoid wild pointer, pointers should be set to NULL after free them.
>
>Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director")
>Fixes: 84dc7a95a2d3 ("net/ice: enable flow director engine")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Wang ShougangX
>
On 11/06, Qi Zhang wrote:
>The ptype bitmap calculation for GRE packet is modified by misktake due to
>commit fc845a9d78ce
>("net/ice/base: fix ptype mapping pollution from GTP flow")
>which is target for GTP packet. The patch rollback that part of code.
>
>Fixes: fc845a9d78ce ("net/ice/base: fix p
Hi, Anatoly
We map BAR's with arbitrary addresses, so i don't think we can do much here -
if mmap() returns page-unaligned addresses on platforms with 64K sizes, it's
not our fault.
Maybe we have some misunderstanding here. mmap() returns page-aligned
on my system, but the man page of
Hi,
On 11/07, Di, ChenxuX wrote:
>Hi, Xiaolong
>
>About pf and vf for fm10k, e1000, igb, ixgbe, ice, i40e; only i40e pf and
>ixgbe vf use
For fm10k, e1000, igb, ice, please check whether they have called
rte_eth_dev_release_port
in the remove ops.
>Rte_eth_dev_destory() in their remove functi
Hi, Xiaolong
About pf and vf for fm10k, e1000, igb, ixgbe, ice, i40e; only i40e pf and ixgbe
vf use
Rte_eth_dev_destory() in their remove function, others have already use the
generic remove function.
I have send another patch about ixgbe because they fix different commits.
Thanks
Di Chenxu
From: Pavan Nikhilesh
use RTE_DIM to calculate array size.
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
---
lib/librte_ethdev/rte_ethdev.c| 8 +++-
lib/librte_ip_frag/ip_frag_internal.c | 5 ++---
lib/librte_port/rte_port_eventdev.c | 4 ++--
lib/librte_port/rte_p
From: Pavan Nikhilesh
use RTE_DIM macro to calculate array size.
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
---
examples/ip_pipeline/parser.c | 2 +-
examples/ipv4_multicast/main.c | 6 +-
examples/l3fwd-power/main.c| 18 --
examples/l3fwd/l3fwd_em.
From: Pavan Nikhilesh
Use RTE_DIM macro to calculate array size
Suggested-by: David Marchand
Signed-off-by: Pavan Nikhilesh
---
v2 Changes:
--
- remove macros that are used only once.(David)
app/test-pmd/cmdline.c| 2 +-
app/test-pmd/icmpecho.c | 2 +-
app/
On 11/06, Di ChenxuX wrote:
>testpmd will occur infinite loops when device hotplug remove.
>We can fix the issue by using the pci generic remove function
>
>Fixes: ac89d46096d5 ("net/i40e: release port upon close")
>
>Signed-off-by: Di ChenxuX
>
>v2:
>change the code in driver.
>---
> drivers/net/
From: Pavan Nikhilesh
Add support to set supported ptypes for octeontx2.
Signed-off-by: Pavan Nikhilesh
---
v4 Changes:
--
- Rebase onto series
http://patches.dpdk.org/project/dpdk/list/?series=7302.
v3 Changes:
--
- Actually update doc file.
v2 Changes:
--
>On Mon, Oct 28, 2019 at 10:09 AM wrote:
>>
>> From: Pavan Nikhilesh
>>
>> Use RTE_DIM macro to calculate array size
>>
>> Suggested-by: David Marchand
>> Signed-off-by: Pavan Nikhilesh
>
>Ah, I was not expecting this soon.
>Thanks for looking at it.
>
>
>> ---
>> app/test-pmd/cmdline.c
Hi Maxime,
> -Original Message-
> From: Maxime Coquelin
> Sent: Wednesday, October 23, 2019 4:23 PM
> To: Gavin Hu (Arm Technology China) ; dev@dpdk.org
> Cc: nd ; david.march...@redhat.com; tiwei@intel.com;
> tho...@monjalon.net; rasl...@mellanox.com; ma...@mellanox.com;
> shah...@me
Hi, Paul
> -Original Message-
> From: Stillwell Jr, Paul M
> Sent: Thursday, November 7, 2019 12:10 AM
> To: Su, Simei ; Zhang, Qi Z ; Ye,
> Xiaolong ; Yang, Qiming
> Cc: dev@dpdk.org; Su, Simei
> Subject: RE: [dpdk-dev] [PATCH v2] net/ice: fix segmentation fault for RSS
> init
>
> Di
On Thu, 31 Oct 2019 18:03:53 +0100
Thomas Monjalon wrote:
> We don't get enough attention on this topic.
> Let me rephrase the issue and the proposals with more people Cc'ed.
>
> We are talking about SR-IOV VFs in VMs
> with a PF managed on the host by DPDK.
> The PF driver is either a (1) bifur
06/11/2019 22:53, David Marchand:
> On Tue, Nov 5, 2019 at 4:15 PM Anatoly Burakov
> wrote:
> >
> > Currently, externally created heaps are supposed to be automatically
> > mapped for VFIO DMA by EAL, however they only do so if, at the time of
> > heap creation, VFIO is initialized and has at leas
On Tue, Nov 5, 2019 at 4:15 PM Anatoly Burakov
wrote:
>
> Currently, externally created heaps are supposed to be automatically
> mapped for VFIO DMA by EAL, however they only do so if, at the time of
> heap creation, VFIO is initialized and has at least one device
> available. If no devices are av
The test works by creating a token comprised of random data
and a CRC8 value, using the rte_atomicXX_exchange to exchange
the new token for a previously generated token, and then
verifying that the exchanged data is intact (i.e. the CRC8
is still correct for the data).
Signed-off-by: David Christe
On Thu, Oct 24, 2019 at 2:18 PM Anatoly Burakov
wrote:
>
> The rte_vfio_dma_map/unmap API's have been marked as deprecated in
> release 19.05. Remove them.
>
> Signed-off-by: Anatoly Burakov
> ---
>
> Notes:
> Although `rte_vfio_dma_map` et al. was marked as deprecated in our
> documentation
Hi,
Please find the techboard comments below.
06/11/2019 10:22, Ray Kinsella:
> On 06/11/2019 09:06, Thomas Monjalon wrote:
> > 06/11/2019 09:49, Ray Kinsella:
> >> On 06/11/2019 00:11, Thomas Monjalon wrote:
> >>> 05/11/2019 16:24, Ray Kinsella:
> +#. Major ABI versions are declared every **
On 11/6/19 10:02 AM, Marvin Liu wrote:
> As doc mentioned, Rx/Mac/vlan filters are all supported by best effort.
> These control commands should return success.
>
> Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device
> emulation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Marv
On 11/4/19 5:36 PM, Jin Yu wrote:
> A vhost-user-blk example that support inflight feature. It uses the
> new APIs that introduced in the first patch, so it can show how these
> APIs work to support inflight feature.
>
> Signed-off-by: Jin Yu
> ---
> v1 - add the case.
> v2 - add the rte_vhost
On 11/4/19 12:15 PM, Marvin Liu wrote:
> Packets data are directly copied when doing batch enqueue, add missed
> dirty page logging after memory copy.
>
> Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
>
> Signed-off-by: Marvin Liu
> ---
> lib/librte_vhost/virtio_net.c | 4
On Tue, Nov 5, 2019 at 10:17 AM David Marchand
wrote:
>
> On Tue, Nov 5, 2019 at 9:05 AM Hemant Agrawal wrote:
> >
> > This patch bump the supported SDK and MC firmware version
> > to the latest.
> >
> > Signed-off-by: Hemant Agrawal
[snip]
> > diff --git a/doc/guides/platform/dpaa2.rst b/doc/
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: sta
On 11/4/19 11:13 AM, Marvin Liu wrote:
> Log feature is disabled in vhost user, so that log address was invalid
> when checking. Check whether log address is valid can work around it.
> Log address should also be translated in packed ring virtqueue.
>
> Fixes: 04cfc7fdbfca ("vhost: translate in
On 10/30/19 10:24 AM, Marvin Liu wrote:
> Virtio spec only set rule that packed ring maximum size is up to 2^15
> entries. Should not limit packed ring size to power of two.
>
> Fixes: aea29aa5d37b ("net/virtio: enable packed virtqueues by default")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Mar
On Tue, Nov 5, 2019 at 10:17 AM David Marchand
wrote:
> On Tue, Nov 5, 2019 at 9:05 AM Hemant Agrawal wrote:
> >
> > dpaa and dpaa2 config have evolved to be same. The same binary
> > can now work across the platforms. So, there is no need to maintain
> > two different build configs.
> > The dpaa
On 10/30/19 10:24 AM, Marvin Liu wrote:
> Virtio spec only set rule that packed ring maximum size is up to 2^15
> entries. Should not limit packed ring size to power of two.
>
> Fixes: 708e14d8b9ac ("vhost: advertize packed ring layout support")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Marvin
On 11/6/19 9:05 PM, David Marchand wrote:
> Maxime,
>
> On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
> wrote:
>>
>> Hi Jin,
>>
>> On 10/30/19 10:40 AM, Jin Yu wrote:
>>> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
>>> So we need the librte_hash to be compiled before vhost.
>>> A
On 11/4/19 12:15 PM, Marvin Liu wrote:
> Packets data are directly copied when doing batch enqueue, add missed
> dirty page logging after memory copy.
>
> Fixes: ad3df6dcc0fc ("vhost: add packed ring batch enqueue")
>
> Signed-off-by: Marvin Liu
> ---
> lib/librte_vhost/virtio_net.c | 4
On 11/4/19 5:36 PM, Jin Yu wrote:
> A vhost-user-blk example that support inflight feature. It uses the
> new APIs that introduced in the first patch, so it can show how these
> APIs work to support inflight feature.
>
> Signed-off-by: Jin Yu
> ---
> v1 - add the case.
> v2 - add the rte_vhost
On Wed, Nov 6, 2019 at 8:57 PM David Christensen
wrote:
> @@ -459,9 +595,43 @@ test_atomic(void)
> printf("128-bit compare and swap failed\n");
> return -1;
> }
> -#endif
>
> return 0;
> }
> +#endif
> +
> + /*
> +* Test 16/32/64bit at
On 11/4/19 9:47 AM, Adrian Moreno wrote:
> On 11/4/19 11:13 AM, Marvin Liu wrote:
>> Log feature is disabled in vhost user, so that log address was invalid
>> when checking. Check whether log address is valid can work around it.
>> Log address should also be translated in packed ring virtqueue.
Maxime,
On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
wrote:
>
> Hi Jin,
>
> On 10/30/19 10:40 AM, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> > So we need the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 35
Hi Jin,
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> C
The test works by creating a token comprised of random data
and a CRC8 value, using the rte_atomicXX_exchange to exchange
the new token for a previously generated token, and then
verifying that the exchanged data is intact (i.e. the CRC8
is still correct for the data).
Signed-off-by: David Christe
On 11/6/19 10:02 AM, Marvin Liu wrote:
> As doc mentioned, Rx/Mac/vlan filters are all supported by best effort.
> These control commands should return success.
>
> Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device
> emulation")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Marv
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: sta
The port library should be build after eventdev library.
Fixes: 5d92c4e5 ("port: add eventdev port type")
Signed-off-by: Rahul Shah
---
lib/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Makefile b/lib/Makefile
index 5d04ab915..2c2b80ac3 100644
--- a/lib/Makefile
+++ b/lib/Ma
From: Pavan Nikhilesh
Add `rte_eth_dev_set_ptypes` function that will allow the application
to inform the PMD about reduced range of packet types to handle.
Based on the ptypes set PMDs can optimize their Rx path.
-If application doesn’t want any ptype information it can call
`rte_eth_dev_set_pt
From: Pavan Nikhilesh
Disable packet type parsing as l2fwd doesn't rely on packet types.
Signed-off-by: Pavan Nikhilesh
---
examples/l2fwd/Makefile| 1 +
examples/l2fwd/main.c | 2 ++
examples/l2fwd/meson.build | 1 +
3 files changed, 4 insertions(+)
diff --git a/examples/l2fwd/Makef
From: Pavan Nikhilesh
Add command to set supported ptype mask.
Usage:
set port ptype_mask
Disable ptype parsing by default.
Signed-off-by: Pavan Nikhilesh
---
app/test-pmd/cmdline.c | 83 +
app/test-pmd/testpmd.c | 5 ++
From: Pavan Nikhilesh
Split port initialization sequence based on event device capabilities.
Signed-off-by: Pavan Nikhilesh
---
examples/eventdev_pipeline/main.c | 128 -
.../pipeline_worker_generic.c | 129 ++
.../eventdev_pipeline/p
From: Pavan Nikhilesh
Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload
flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result
into the mbuf.
Signed-off-by: Pavan Nikhilesh
---
examples/eventdev_pipeline/pipeline_worker_generic.c | 3 +++
1 file changed
From: Pavan Nikhilesh
Some PMDs cannot work when certain offloads are enable/disabled, as a
workaround PMDs auto enable/disable offloads internally and expose it
through dev->data->dev_conf.rxmode.offloads.
After device specific dev_configure is called compare the requested
offloads to the offlo
From: Pavan Nikhilesh
Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash
delivery.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Andrew Rybchenko
Reviewed-by: Hemant Agrawal
Acked-by: Jerin Jacob
Acked-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 6 +-
d
From: Pavan Nikhilesh
Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used
to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also
`ol_flags:PKT_RX_RSS`.
Add new packet type set function `rte_eth_dev_set_ptypes`,
allows application to inform PMDs about the packe
From: Pavan Nikhilesh
Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`.
PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation
by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.
Signed-off-by: Pavan Ni
On 05/11/2019 17:10, Ferriter, Cian wrote:
>
>
>> -Original Message-
>> From: Kevin Traynor
>> Sent: Tuesday 5 November 2019 16:41
>> To: David Marchand
>> Cc: dev ; Ferriter, Cian ; dpdk
>> stable ; Yigit, Ferruh
>> Subject: Re: [dpdk-dev] [PATCH 1/9] net/pcap: fix argument checks
>>
Some variables are commented out. Remove them.
Fixes: d548ef513cd7 ("event/opdl: add unit tests")
Cc: sta...@dpdk.org
Signed-off-by: Kevin Traynor
Acked-by: Liang Ma
---
drivers/event/opdl/opdl_test.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/event/opdl/opdl_test.c b/driver
This commented out todo and code is old. Remove it.
Fixes: b7435d660a8c ("net/bnxt: add ntuple filtering support")
Cc: sta...@dpdk.org
Signed-off-by: Kevin Traynor
Acked-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/bnxt/
These struct members and variable were commented out. Remove them.
Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
Fixes: c820468ac99c ("net/ipn3ke: support TM")
Cc: rosen...@intel.com
Cc: sta...@dpdk.org
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
drivers/net/ipn3ke/ipn3ke
This code is commented out. Remove it.
Fixes: 43e610bb8565 ("compress/octeontx: introduce octeontx zip PMD")
Cc: ss...@marvell.com
Cc: sta...@dpdk.org
Signed-off-by: Kevin Traynor
Reviewed-by: David Marchand
---
drivers/compress/octeontx/include/zip_regs.h | 8
1 file changed, 8 delet
Previously rx/tx_queues were passed into eth_from_pcaps_common()
as ptrs and were checked for being NULL.
In commit da6ba28f0540 ("net/pcap: use a struct to pass user options")
that changed to pass in a ptr to a pmd_devargs_all which contains
the rx/tx_queues.
The parameter checking was not updat
Coverity complains that this statement is not needed as the goto
label is on the next line anyway. Remove the if statement.
653ret = ipn3ke_cfg_parse_i40e_pf_ethdev(afu_name, pf_name);
CID 337930 (#1 of 1): Identical code for different branches
(IDENTICAL_BRANCHES)identical_branches:
Coverity is complaining about identical code regardless of which branch
of the if else is taken. Functionally it means an error will always be
returned if this if else is hit. Remove the else branch.
CID 337928 (#1 of 1): Identical code for different branches
(IDENTICAL_BRANCHES)identical_
Coverity complains that ctrl_flags is set to NULL at the start
of the function and it may not have been set before there is a
jump to fc_success and it is dereferenced.
Check for NULL before dereference.
312fc_success:
CID 344983 (#1 of 1): Explicit null dereferenced
(FORWARD_NULL)7. var_de
Patches 1-4 are Coverity fixes.
Patches 5-8 are removing commented out code.
v2:
- 1/8: removed added NULL check for devargs_all
- 2/8: fixed headline to common/cpt
- v1 3/9 'net/bnxt: remove logically dead code'
removed as duplicate patch already applied
Kevin Traynor (8):
net/pcap: fix arg
Thanks a lot Anatoly.
Will the same solution work with DPDK 19.02 as well? We 're actually using
DPDK 19.02 for memory allocations for SPDK 19.07.
DPDK 19.11 may not be supported by SPDK 19.07 we 're currently using.
I 'll definitely test if the patch works with DPDK 19.02
Thanks again for your
Thanks Anatoly & David.
The main patch provided by Anatoly is not compatible with DPDK 19.02.
So I had to make following patch and verified it to be working with DPDK
19.02 & SPDK 19.07 combination.
--
From: Pawel Modrak
Merge all vesions in linker version script files to DPDK_20.0.
This commit was generated by running the following command:
:~/DPDK$ buildtools/update-abi.sh 20.0
Signed-off-by: Pawel Modrak
Signed-off-by: Anatoly Burakov
Acked-by: Bruce Richardson
---
.../rte_pmd_bbdev_f
Hi Bernard,
>Hi Pavan,
>
>> -Original Message-
>> From: pbhagavat...@marvell.com
>> Sent: Tuesday, October 29, 2019 3:37 PM
>> To: Yigit, Ferruh ;
>arybche...@solarflare.com;
>> jer...@marvell.com; Lu, Wenzhuo ; Wu,
>Jingjing
>> ; Iremonger, Bernard
>> ; Mcnamara, John
>> ; Kovacevic, Mar
On 11/6/2019 2:49 PM, Flavia Musatescu wrote:
> Fix the RTE_IPV4_VHL_DEF macro that represents the value
> for the IPv4 VHL and Minimum IHL header fields according to
> rfc791.
>
> Fixes: 2318d8d54565 ("net: define IPv4 IHL and VHL")
> Cc: saleh...@mellanox.com
> Cc: sta...@dpdk.org
>
> Signed-of
> -Original Message-
> From: Wisam Monther
> Sent: Wednesday, November 6, 2019 11:39
> To: Slava Ovsiienko
> Cc: Wisam Monther ; dev@dpdk.org; Moti
> Haimovsky
> Subject: [PATCH] net/mlx5: add missing ptype for geneve tunnel
>
> HW ptype are missing TUNNEL_GENEVE support
>
> Fixes: e59
On 10/31/2019 6:22 PM, Ori Kam wrote:
>
>
>> -Original Message-
>> From: Xiaoyu Min
>> Sent: Thursday, October 31, 2019 12:11 PM
>> To: Ori Kam ; Adrien Mazarguil
>> ; Wenzhuo Lu ;
>> Jingjing Wu ; Bernard Iremonger
>>
>> Cc: dev@dpdk.org; sta...@dpdk.org
>> Subject: [PATCH] app/testpmd
While reg_c[meta] can be copied to reg_b simply by modify-header
action (it is supported by hardware), it is not possible to copy
reg_c[mark] to the STE flow_tag as flow_tag is not a metadata
register and this is not supported by hardware. Instead, it
should be manually set by a flow per each uniqu
Values set by MARK and SET_META actions should be carried over
to the VF representor in case of flow miss on Tx path. However,
as not all metadata registers are preserved across the different
domains (NIC Rx/Tx and E-Switch FDB), as a workaround, those
values should be carried by reg_c's which are
Add support of new rte_flow item and action - TAG and SET_TAG. TAG is
a transient value which can be kept during flow matching.
This is supported through device metadata register reg_c[]. Although
there are 8 registers are available on the current mlx5 device,
some of them can be reserved for firm
The NIC might support up to 8 extensive metadata registers.
These registers are supposed to be used by multiple features.
There is register id query routine to allow determine which
register is actually used by specified feature.
Signed-off-by: Viacheslav Ovsiienko
Acked-by: Matan Azrad
---
dri
The mlx5 hardware has some limitations and flow might
require to be split into multiple internal subflows.
For example this is needed to provide the meter object
sharing between multiple flows or to provide metadata
register copying before final queue/rss action.
The multiple features might requir
Flow MARK item is newly supported along with MARK action. MARK
action and item are supported on both Rx and Tx. It works on the
metadata reg_c[] only if extensive flow metadata register is
supported. Without the support, MARK action behaves same as
before - valid only on Rx and no MARK item is vali
If the extensive metadata registers are supported,
it can be regarded inclusively that the extensive
metadata support is possible. E.g. metadata register
copy action, supporting 16 modify header actions,
reserving register across different steering domain
(FDB and NIC) and so on.
This patch handle
This patch moves metadata from completion descriptor
to appropriate dynamic mbuf field.
Signed-off-by: Yongseok Koh
Signed-off-by: Viacheslav Ovsiienko
Acked-by: Matan Azrad
---
drivers/net/mlx5/mlx5_prm.h | 6 --
drivers/net/mlx5/mlx5_rxtx.c | 5 +
drivers/n
META item is supported on both Rx and Tx. 'transfer' attribute
is also supported. SET_META action is also added.
Due to restriction on reg_c[meta], various bit width might be
available. If devarg parameter dv_xmeta_en=1, the META uses
metadata register reg_c[0], which may be required for internal
The metadata registers reg_c provide support for TAG and
SET_TAG features. Although there are 8 registers are available
on the current mlx5 devices, some of them can be reserved.
The availability should be queried by iterative trial-and-error
implemented by mlx5_flow_discover_mreg_c() routine.
If
1 - 100 of 257 matches
Mail list logo
