Hi Bernard, PSB. > -----Original Message----- > From: Iremonger, Bernard <bernard.iremon...@intel.com> > Sent: Wednesday, November 6, 2019 6:41 PM > To: Dekel Peled <dek...@mellanox.com>; Mcnamara, John > <john.mcnam...@intel.com>; Kovacevic, Marko > <marko.kovace...@intel.com>; nhor...@tuxdriver.com; > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > Anatoly <anatoly.bura...@intel.com>; xuanziya...@huawei.com; > cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; Lu, Wenzhuo > <wenzhuo...@intel.com>; Ananyev, Konstantin > <konstantin.anan...@intel.com>; Matan Azrad <ma...@mellanox.com>; > Shahaf Shuler <shah...@mellanox.com>; Slava Ovsiienko > <viachesl...@mellanox.com>; rm...@marvell.com; > shsha...@marvell.com; maxime.coque...@redhat.com; Bie, Tiwei > <tiwei....@intel.com>; Wang, Zhihong <zhihong.w...@intel.com>; > yongw...@vmware.com; Thomas Monjalon <tho...@monjalon.net>; Yigit, > Ferruh <ferruh.yi...@intel.com>; arybche...@solarflare.com; Wu, Jingjing > <jingjing...@intel.com> > Cc: dev@dpdk.org > Subject: RE: [PATCH v3 0/3] support API to set max LRO packet size > > Hi Dekel, > > > -----Original Message----- > > From: Dekel Peled <dek...@mellanox.com> > > Sent: Wednesday, November 6, 2019 2:28 PM > > To: Mcnamara, John <john.mcnam...@intel.com>; Kovacevic, Marko > > <marko.kovace...@intel.com>; nhor...@tuxdriver.com; > > ajit.khapa...@broadcom.com; somnath.ko...@broadcom.com; Burakov, > > Anatoly <anatoly.bura...@intel.com>; xuanziya...@huawei.com; > > cloud.wangxiao...@huawei.com; zhouguoy...@huawei.com; Lu, > Wenzhuo > > <wenzhuo...@intel.com>; Ananyev, Konstantin > > <konstantin.anan...@intel.com>; ma...@mellanox.com; > > shah...@mellanox.com; viachesl...@mellanox.com; > rm...@marvell.com; > > shsha...@marvell.com; maxime.coque...@redhat.com; Bie, Tiwei > > <tiwei....@intel.com>; Wang, Zhihong <zhihong.w...@intel.com>; > > yongw...@vmware.com; tho...@monjalon.net; Yigit, Ferruh > > <ferruh.yi...@intel.com>; arybche...@solarflare.com; Wu, Jingjing > > <jingjing...@intel.com>; Iremonger, Bernard > > <bernard.iremon...@intel.com> > > Cc: dev@dpdk.org > > Subject: [PATCH v3 0/3] support API to set max LRO packet size > > > > This series implements support and use of API for configuration and > > validation of max size for LRO aggregated packet. > > > > v2: Updated ethdev patch per review comments. > > v3: Updated ethdev and testpmd patches per review comments. > > My comments on the v2 testpmd patch have not been addressed in the v3 > patch.
I accepted your comment about update of function usage(), and added it in v3. I replied your other comments in v2 reply email, and didn't see additional response. Regards, Dekel > > > > > Dekel Peled (3): > > ethdev: support API to set max LRO packet size > > net/mlx5: use API to set max LRO packet size > > app/testpmd: use API to set max LRO packet size > > > > app/test-pmd/cmdline.c | 73 > > +++++++++++++++++++++++++++++ > > app/test-pmd/config.c | 2 + > > app/test-pmd/parameters.c | 7 +++ > > app/test-pmd/testpmd.c | 1 + > > doc/guides/nics/features.rst | 2 + > > doc/guides/nics/mlx5.rst | 2 + > > doc/guides/rel_notes/deprecation.rst | 4 -- > > doc/guides/rel_notes/release_19_11.rst | 8 ++++ > > doc/guides/testpmd_app_ug/run_app.rst | 5 ++ > > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 9 ++++ > > drivers/net/bnxt/bnxt_ethdev.c | 1 + > > drivers/net/hinic/hinic_pmd_ethdev.c | 1 + > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 + > > drivers/net/ixgbe/ixgbe_vf_representor.c | 1 + > > drivers/net/mlx5/mlx5.h | 3 ++ > > drivers/net/mlx5/mlx5_ethdev.c | 1 + > > drivers/net/mlx5/mlx5_rxq.c | 5 +- > > drivers/net/qede/qede_ethdev.c | 1 + > > drivers/net/virtio/virtio_ethdev.c | 1 + > > drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + > > lib/librte_ethdev/rte_ethdev.c | 44 +++++++++++++++++ > > lib/librte_ethdev/rte_ethdev.h | 4 ++ > > 22 files changed, 172 insertions(+), 6 deletions(-) > > > > -- > > 1.8.3.1 > > Regards, > > Bernard.
