On Wed, Oct 30, 2019 at 07:07:23PM +0800, Marvin Liu wrote:
> Log feature is disabled in vhost user, so that log address was invalid
> when checking. Check whether log address is valid can workaround it.
> Also log address should be translated in packed ring virtqueue.
>
> Fixes: 04cfc7fdbfca ("vh
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Wednesday, October 30, 2019 8:39 AM
> To: Ori Kam ; John McNamara
> ; Marko Kovacevic
> ; Thomas Monjalon ;
> Ferruh Yigit
> Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org
> Subject: Re: [dpdk-dev] [PAT
macsec setting is not valid when port is stopped.
In order to make it valid, the patch changes the setting
to where port is started.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Sun GuinanX
---
v5:
* modified function name
v4:
* Deleted e
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Wednesday, October 30, 2019 1:22 PM
> To: Min, JiaqiX
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/ice: fix setting max frame size
>
> Hi, Jiaqi
>
> On 10/29, Min JiaqiX wrote:
> >Max frame si
Hi Ori,
On 10/29/19 10:39 PM, Ori Kam wrote:
On 10/28/19 9:44 PM, Ori Kam wrote:
On 10/27/19 3:24 PM, Ori Kam wrote:
+ if (rte_eth_dev_is_rx_hairpin_queue(dev, i))
The condition should be more tricky if we resetup hairpin queue.
I.e. we should check if i is rx_queue_id a
Hi, Xiaolong
> -Original Message-
> From: Ye, Xiaolong
> Sent: Tuesday, October 29, 2019 1:07 PM
> To: Min, JiaqiX
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix setting max frame size
>
> On 10/29, Min, JiaqiX wrote:
> >Hi Xiaolong,
> >
> >> -Original Message--
On 10/29/19 9:30 PM, Thomas Monjalon wrote:
29/10/2019 18:19, Slava Ovsiienko:
From: Andrew Rybchenko
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
+* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, static
+metadata
+ mbuf field will be removed i
From: Vamsi Attunuru
LBK interface does not support any flow control related
HW configurations.
Skip flow control set requests on LBK bound ethports.
Signed-off-by: Harman Kalra
Signed-off-by: Vamsi Attunuru
---
V2 change:
* Updated log type.
drivers/net/octeontx2/otx2_flow_ctrl.c | 13
Hi Thierry,
> -Original Message-
> From: Thierry Herbelot
> Sent: Tuesday, October 29, 2019 6:32 PM
> To: dev@dpdk.org
> Cc: Thomas Monjalon ; Gagandeep Singh
>
> Subject: [PATCH] drivers/net: only compile PFE and ENETC when DPAA was
> selected
>
> PFE and ENETC depend on DPAA features.
On 10/30, Ying Wang wrote:
>Flow director rule can't be created when the flow table is nearly full.
>The patch fixed this issue to enable created flows reaching the maximum
>number.
>
>Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director")
>
>Signed-off-by: Ying Wang
>---
> driv
Hi, Guinan
[snip]
On 10/30, Sun GuinanX wrote:
>+
>+void
>+ixgbe_dev_macsec_register_set(struct rte_eth_dev *dev,
I'd prefer to keep ixgbe_dev_macsec_register_enable since when it comes to
HW register, `enable` is more accurate then `set` for this routine.
And same for the below function, pre
Hi, Jiaqi
On 10/29, Min JiaqiX wrote:
>Max frame size is not set to HW, so packets above the MTU
>do not get dropped by HW. The patch fixed the issue.
>
>Fixes: 50370662b727 ("net/ice: support device and queue ops")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Min JiaqiX
>Reviewed-by: Xiaolong Ye
Sor
From: Pavan Nikhilesh
Since the number of Ethernet ports have gone up, print the pci bdf along
with the routes.
This is also helpful for cases where whitelisting order is honored.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd_lpm.c | 16
1 file changed, 12 insertions
From: Pavan Nikhilesh
Increase the number of routes from 8 to 16 that are statically added for
lpm and em mode as most of the SoCs support more than 8 interfaces.
Signed-off-by: Pavan Nikhilesh
---
examples/l3fwd/l3fwd_em.c | 72 ++
examples/l3fwd/l3fwd_lpm
On 10/30, Simei Su wrote:
>This patch corrects key_len and queues check. The key_len and queues
>are not supported to configure for RSS in rte_flow.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Simei Su
>---
> drivers/net/ice/ice_hash.c | 10 --
On 10/30, Qi Zhang wrote:
>A new gtp flow's profile will capture other profile's non-gtp ptypes
>which is unexpected. For example, an RSS flow for inner IP / UDP on
>regular tunnel packet's behaviour will changed by a following GTP RSS
>rule when inner IP is the only inputset, since all tunnel ptyp
> -Original Message-
> From: Jerin Jacob
> Sent: Wednesday, October 30, 2019 12:38
> To: Yigit, Ferruh
> Cc: Thomas Monjalon ; Wang, Haiyue
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemmin
On Tue, Oct 29, 2019 at 10:29 PM Ferruh Yigit wrote:
>
> On 10/26/2019 7:58 AM, Jerin Jacob wrote:
> > On Sat, Oct 26, 2019 at 3:57 AM Thomas Monjalon wrote:
> >>
> >> 25/10/2019 18:02, Jerin Jacob:
> >>> On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon
> >>> wrote:
> 25/10/2019 16:08, Ferr
On Wed, Oct 30, 2019 at 12:21 AM Thomas Monjalon wrote:
>
> In a virtual environment, the network controller may have to configure
> some SR-IOV VF parameters for security reasons.
Just to understand, Could you explain more details/examples for
security reasons?
>
> When the PF (host port) is dr
Hi Olivier,
> -Original Message-
> From: Vamsi Krishna Attunuru
> Sent: Tuesday, October 29, 2019 10:55 PM
> To: Olivier Matz ; dev@dpdk.org
> Cc: Anatoly Burakov ; Andrew Rybchenko
> ; Ferruh Yigit ;
> Giridharan, Ganesan ; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda ;
> Stephe
macsec setting is not valid when port is stopped.
In order to make it valid, the patch changes the setting
to where port is started.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Sun GuinanX
---
v4:
* Deleted extra comments
* Modified func
Log feature is disabled in vhost user, so that log address was invalid
when checking. Check whether log address is valid can workaround it.
Also log address should be translated in packed ring virtqueue.
Fixes: 04cfc7fdbfca ("vhost: translate incoming log address to gpa")
Signed-off-by: Marvin Li
Hi, Xiaolong
On 10/29, Sun GuinanX wrote:
> >macsec setting is not valid when port is stopped.
> >In order to make it valid, the patch changes the setting to where port
> >is started.
> >
> >Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
> >Cc: sta...@dpdk.org
> >
> >Signed-of
On 10/30, Simei Su wrote:
>This patch corrects logic error for checking rss->types to match
>pattern in RSS action parser.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>Cc: sta...@dpdk.org
>
>Signed-off-by: Simei Su
>---
> drivers/net/ice/ice_hash.c | 14 +++---
> 1 file changed,
> -Original Message-
> From: Su, Simei
> Sent: Wednesday, October 30, 2019 10:52 AM
> To: Zhang, Qi Z ; Xing, Beilei ;
> Yang, Qiming
> Cc: dev@dpdk.org; Ye, Xiaolong ; Su, Simei
> ; sta...@dpdk.org
> Subject: [PATCH] net/ice: correct key len and queues check for RSS
>
> This patch co
> -Original Message-
> From: Su, Simei
> Sent: Wednesday, October 30, 2019 10:50 AM
> To: Zhang, Qi Z ; Xing, Beilei ;
> Yang, Qiming
> Cc: dev@dpdk.org; Ye, Xiaolong ; Su, Simei
> ; sta...@dpdk.org
> Subject: [PATCH] net/ice: correct RSS types check error
>
> This patch corrects logi
macsec setting is not valid when port is stopped.
In order to make it valid, the patch changes the setting
to where port is started.
Fixes: 597f9fafe13b ("app/testpmd: convert to new Tx offloads API")
Cc: sta...@dpdk.org
Signed-off-by: Sun GuinanX
---
v3:
* Deleted extra comments
* Modified the
This patch corrects key_len and queues check. The key_len and queues
are not supported to configure for RSS in rte_flow.
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: sta...@dpdk.org
Signed-off-by: Simei Su
---
drivers/net/ice/ice_hash.c | 10 --
1 file changed, 4 insertions(
As doc mentioned, promisc and multicast are by-default supported in
virtio pmd. Mac/vlan filter are supported by best effort. These control
messages should return success.
Fixes: f9b9d1a55775 ("net/virtio-user: add multiple queues in device emulation")
Cc: sta...@dpdk.org
Signed-off-by: Marvin Li
This patch corrects logic error for checking rss->types to match
pattern in RSS action parser.
Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
Cc: sta...@dpdk.org
Signed-off-by: Simei Su
---
drivers/net/ice/ice_hash.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
di
> -Original Message-
> From: Bie, Tiwei
> Sent: Tuesday, October 29, 2019 8:28 PM
> To: Liu, Yong
> Cc: maxime.coque...@redhat.com; Wang, Zhihong ;
> dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [PATCH v3] net/virtio: fix multicast and promisc mode enable
> failure
>
> On Tue, Oct 29, 2
Flow director rule can't be created when the flow table is nearly full.
The patch fixed this issue to enable created flows reaching the maximum
number.
Fixes: 1a2fc1799f09 ("net/ice: reject duplicated flow for flow director")
Signed-off-by: Ying Wang
---
drivers/net/ice/ice_fdir_filter.c | 1 +
> -Original Message-
> From: Jiang, JunyuX
> Sent: Tuesday, October 29, 2019 10:24 AM
> To: dev@dpdk.org
> Cc: Chas Williams ; Yang, Qiming ;
> Jiang, JunyuX ; sta...@dpdk.org
> Subject: [PATCH v4] net/bonding: fix invalid port using
>
> Port validation should be prior to getting device
Hi All:
This patch fixes a issue when DPDK 802.3ad bonding rx_machine enters EXPIRED
state, but the opposite SWITCH lacp ignores distributing and collecting bit, so
the SWITCH still sends packets to DPDK and all these packets are dropped.
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c
b
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Jin Yu
---
V2 - add the
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: sta...@dpdk.org
Signed-off-by: Jin Yu
---
V2 - add the
Virtio spec only set rule that packed ring maximum size is up to 2^15
entries. Should not limit packed ring size to power of two.
Fixes: aea29aa5d37b ("net/virtio: enable packed virtqueues by default")
Cc: sta...@dpdk.org
Signed-off-by: Marvin Liu
---
drivers/net/virtio/virtio_ethdev.c | 4 ++--
Virtio spec only set rule that packed ring maximum size is up to 2^15
entries. Should not limit packed ring size to power of two.
Fixes: 708e14d8b9ac ("vhost: advertize packed ring layout support")
Cc: sta...@dpdk.org
Signed-off-by: Marvin Liu
---
lib/librte_vhost/vhost_user.c | 14
> -Original Message-
> From: Bie, Tiwei
> Sent: Tuesday, October 29, 2019 9:36 PM
> To: Yu, Jin
> Cc: dev@dpdk.org; sta...@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] vhost: fix compile error
>
> On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> > Compile librte_vhost/vhost_cryp
A new gtp flow's profile will capture other profile's non-gtp ptypes
which is unexpected. For example, an RSS flow for inner IP / UDP on
regular tunnel packet's behaviour will changed by a following GTP RSS
rule when inner IP is the only inputset, since all tunnel ptypes has
been shifted from the f
> -Original Message-
> From: Hunt, David
> Sent: Tuesday, October 29, 2019 7:40 PM
> To: dev@dpdk.org
> Cc: Yao, Lei A ; Hunt, David
> Subject: [PATCH v1] examples/vm_power: fix no PCI option for guest cli
>
> If there are no ports available to the guest cli application, it will exit
Hello DPDK Community,
14 Days and counting!
Please join us at DPDK Summit North America, November 12th and 13th, in
Mountain View, CA.
Hear from DPDK leaders and contributors in the community, with speakers
from Intel, Mellanox, Nvidia, NTT, NEC, Microsoft, Huawe, ZTE and many
others. Check out
Hi Andrew,
> -Original Message-
> From: Andrew Rybchenko
> Sent: Tuesday, October 29, 2019 9:39 AM
> To: Ori Kam ; John McNamara
> ; Marko Kovacevic
> ; Thomas Monjalon ;
> Ferruh Yigit
> Cc: dev@dpdk.org; jingjing...@intel.com; step...@networkplumber.org
> Subject: Re: [dpdk-dev] [PATCH
Currently, metadata can be set on egress path via mbuf tx_metadata field
with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata.
This patch extends the metadata feature usability.
1) RTE_FLOW_ACTION_TYPE_SET_META
When supporting multiple tables, Tx metadata can also be set by a r
Allow to configure the default MAC address of a VF
via its representor port in the host.
This patch is a stub to demonstrate how to implement a VF operation.
The real code is not implemented.
Signed-off-by: Thomas Monjalon
---
drivers/net/mlx5/mlx5.c | 6 ++
drivers/net/mlx5/mlx5.h
The API to set a default MAC address is extended
to support a VF ID as port ID.
In order to be supported by a driver,
the related vf_ops must be implemented.
Signed-off-by: Thomas Monjalon
---
lib/librte_ethdev/rte_ethdev.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff
In a virtual environment, the network controller may have to configure
some SR-IOV VF parameters for security reasons.
When the PF (host port) is driven by DPDK (OVS-DPDK case),
we face two different cases:
- driver is bifurcated (Mellanox case),
so the VF can be configured via t
In a virtual environment, the network controller may have to configure
some SR-IOV VF parameters for security reasons.
When the PF (host port) is driven by DPDK (OVS-DPDK case),
we face two different cases:
- driver is bifurcated (Mellanox case),
so the VF can be configured via the kerne
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, October 29, 2019 20:30
> To: Slava Ovsiienko
> Cc: Andrew Rybchenko ; dev@dpdk.org;
> Matan Azrad ; olivier.m...@6wind.com; Ori Kam
>
> Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata
>
> 29/10/2019 18:19, Sla
29/10/2019 18:19, Slava Ovsiienko:
> From: Andrew Rybchenko
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, static
> > > +metadata
> > > + mbuf field will be removed in 20.02, metadat
From: Vamsi Attunuru
VF index needs to be checked against maxvf count
before incrementing it for preparing pf_func.
Fixes: 520270d518 ("net/octeontx2: support PF and VF action")
Signed-off-by: Vamsi Attunuru
---
drivers/net/octeontx2/otx2_flow_parse.c | 4 ++--
1 file changed, 2 insertions(+)
From: Vamsi Attunuru
LBK interface does not support any flow control related
HW configurations.
Skip flow control set requests on LBK bound ethports.
Signed-off-by: Harman Kalra
Signed-off-by: Vamsi Attunuru
---
drivers/net/octeontx2/otx2_flow_ctrl.c | 13 +
1 file changed, 13 in
> -Original Message-
> From: Olivier Matz
> Sent: Tuesday, October 29, 2019 18:34
> To: Slava Ovsiienko
> Cc: dev@dpdk.org; Thomas Monjalon ; Matan
> Azrad ; Ori Kam ; Yongseok
> Koh
> Subject: Re: [PATCH v4] ethdev: extend flow metadata
>
> On Tue, Oct 29, 2019 at 05:25:22PM +0100, Oli
Hi, Olivier
Thanks a lot for the review.
> -Original Message-
> From: Olivier Matz
> Sent: Tuesday, October 29, 2019 18:25
> To: Slava Ovsiienko
> Cc: dev@dpdk.org; Thomas Monjalon ; Matan
> Azrad ; Ori Kam ; Yongseok
> Koh
> Subject: Re: [PATCH v4] ethdev: extend flow metadata
>
> Hi
On Tue, Oct 29, 2019 at 01:59:00PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > When populating a mempool, ensure that objects are not located across
> > several pages, except if user did not request iova contiguous objects.
>
> I think it breaks distribution acros
>>lib/librte_ethdev/rte_ethdev.c | 59 ++
>> 1 file changed, 59 insertions(+)
>>
>>diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
>>index 3f45b9e9c..8c58da91c 100644
>>--- a/lib/librte_ethdev/rte_ethdev.c
>>+++ b/lib/librte_ethdev/rte_eth
Hi Olivier,
> -Original Message-
> From: Olivier Matz
> Sent: Monday, October 28, 2019 7:31 PM
> To: dev@dpdk.org
> Cc: Anatoly Burakov ; Andrew Rybchenko
> ; Ferruh Yigit ;
> Giridharan, Ganesan ; Jerin Jacob Kollanukkaran
> ; Kiran Kumar Kokkilagadda
> ; Stephen Hemminger
> ; Thomas Mon
Hi, Andrew
Thank you for the review.
> -Original Message-
> From: Andrew Rybchenko
> Sent: Tuesday, October 29, 2019 18:22
> To: Slava Ovsiienko ; dev@dpdk.org
> Cc: Thomas Monjalon ; Matan Azrad
> ; olivier.m...@6wind.com; Ori Kam
> ; Yongseok Koh
> Subject: Re: [dpdk-dev] [PATCH v4] e
On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > In rte_mempool_populate_default(), we determine the page size,
> > which is needed for calc_size and allocation of memory.
> >
> > Move this in a function and export it, it will be used
On Tue, Oct 29, 2019 at 01:25:10PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > The previous commit reduced the amount of required memory when
> > populating the mempool with non iova-contiguous memory.
> >
> > Since there is no big advantage to have a fully iova-c
On Tue, Oct 29, 2019 at 01:09:01PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > The size returned by rte_mempool_op_calc_mem_size_default() is aligned
> > to the specified page size. Therefore, with big pages, the returned size
> > can be much more that what we real
Hi Andrew,
On Tue, Oct 29, 2019 at 12:21:27PM +0300, Andrew Rybchenko wrote:
> On 10/28/19 5:01 PM, Olivier Matz wrote:
> > rte_mempool_populate_virt() currently requires that both addr
> > and length are page-aligned.
> >
> > Remove this uneeded constraint which can be annoying with big
> > huge
On 10/26/2019 7:58 AM, Jerin Jacob wrote:
> On Sat, Oct 26, 2019 at 3:57 AM Thomas Monjalon wrote:
>>
>> 25/10/2019 18:02, Jerin Jacob:
>>> On Fri, Oct 25, 2019 at 9:15 PM Thomas Monjalon wrote:
25/10/2019 16:08, Ferruh Yigit:
> On 10/25/2019 10:36 AM, Thomas Monjalon wrote:
>> 15/10
On 10/29/19 6:37 PM, pbhagavat...@marvell.com wrote:
From: Pavan Nikhilesh
Some PMDs cannot work when certain offloads are enable/disabled, as a
workaround PMDs auto enable/disable offloads internally and expose it
through dev->data->dev_conf.rxmode.offloads.
After device specific dev_configur
23/10/2019 04:54, Joyce Kong:
> There are a lot functions of bit operations scattered in PMDs,
> consolidate them into a common API family and applied in different
> PMDs to reduce code duplication.
Please, could you look at what Adrien did in the Mellanox PMD?
http://code.dpdk.org/dpdk/latest/so
On Tue, Oct 29, 2019 at 05:25:22PM +0100, Olivier Matz wrote:
> Hi Slava,
>
> Looks good to me overall. Few minor comments below.
>
> On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote:
> > Currently, metadata can be set on egress path via mbuf tx_metadata field
> > with PKT_TX_
On 10/29/19 6:50 PM, Stephen Hemminger wrote:
On Thu, 27 Jun 2019 16:18:20 +0800
Ziyang Xuan wrote:
+#
+# Compile burst-oriented HINIC PMD driver
+#
+CONFIG_RTE_LIBRTE_HINIC_PMD=n
The most common naming convention for drivers is:
CONFIG_RTE_LIBRTE_PMD_XXX
so please use that.
It looks like
Hi Slava,
Looks good to me overall. Few minor comments below.
On Sun, Oct 27, 2019 at 06:40:36PM +, Viacheslav Ovsiienko wrote:
> Currently, metadata can be set on egress path via mbuf tx_metadata field
> with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata.
>
> This patch
On 10/27/19 9:40 PM, Viacheslav Ovsiienko wrote:
Currently, metadata can be set on egress path via mbuf tx_metadata field
with PKT_TX_METADATA flag and RTE_FLOW_ITEM_TYPE_META matches metadata.
This patch extends the metadata feature usability.
1) RTE_FLOW_ACTION_TYPE_SET_META
When supporting
On Tue, Oct 29, 2019 at 1:21 PM Flavio Leitner wrote:
> On Tue, 29 Oct 2019 10:02:57 +0100
> David Marchand wrote:
> > Using rte_malloc() means that the allocation can end up on any numa
> > node. This external buffer might end up on a different node than the
> > mbuf (which resides on mp->socket
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 23:59
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemminge
On Tue, Oct 29, 2019 at 9:12 PM Wang, Haiyue wrote:
>
> > -Original Message-
> > From: Jerin Jacob
> > Sent: Tuesday, October 29, 2019 22:09
> > To: Wang, Haiyue
> > Cc: Thomas Monjalon ; Yigit, Ferruh
> > ; dpdk-dev
> > ; Ye, Xiaolong ; Kinsella, Ray
> > ;
> > Iremonger, Bernard ; Sun
On 10/28/19 10:23 PM, Jiang JunyuX wrote:
Port validation should be prior to getting device data
to avoid segment fault. This patch fixed the segment fault
caused by invalid port using.
Fixes: 6d72657ce379 ("net/bonding: add other aggregator modes")
Fixes: 112891cd27e5 ("net/bonding: add dedicat
On Thu, 27 Jun 2019 16:18:20 +0800
Ziyang Xuan wrote:
> +#
> +# Compile burst-oriented HINIC PMD driver
> +#
> +CONFIG_RTE_LIBRTE_HINIC_PMD=n
The most common naming convention for drivers is:
CONFIG_RTE_LIBRTE_PMD_XXX
so please use that.
> -Original Message-
> From: Jerin Jacob
> Sent: Tuesday, October 29, 2019 22:09
> To: Wang, Haiyue
> Cc: Thomas Monjalon ; Yigit, Ferruh
> ; dpdk-dev
> ; Ye, Xiaolong ; Kinsella, Ray
> ;
> Iremonger, Bernard ; Sun, Chenmin
> ; Andrew
> Rybchenko ; Slava Ovsiienko
> ; Stephen Hemminge
From: Pavan Nikhilesh
Add DEV_RX_OFFLOAD_RSS_HASH flag for all PMDs that support RSS hash
delivery.
Signed-off-by: Pavan Nikhilesh
Reviewed-by: Andrew Rybchenko
Reviewed-by: Hemant Agrawal
Acked-by: Jerin Jacob
Acked-by: Ajit Khaparde
---
drivers/net/bnxt/bnxt_ethdev.c | 8 +++-
From: Pavan Nikhilesh
Add command to set supported ptype mask.
Usage:
set port ptype_mask
Disable ptype parsing by default.
Signed-off-by: Pavan Nikhilesh
---
app/test-pmd/cmdline.c | 80 +
app/test-pmd/testpmd.c | 6 ++
From: Pavan Nikhilesh
Since pipeline_generic uses `rte_mbuf::hash::rss` add the new Rx offload
flag `DEV_RX_OFFLOAD_RSS_HASH` to inform PMD to copy the RSS hash result
into the mbuf.
Signed-off-by: Pavan Nikhilesh
---
examples/eventdev_pipeline/main.c | 128 -
.../p
From: Pavan Nikhilesh
Disable packet type parsing as l2fwd doesn't rely on packet types.
Signed-off-by: Pavan Nikhilesh
---
examples/l2fwd/Makefile| 1 +
examples/l2fwd/main.c | 2 ++
examples/l2fwd/meson.build | 1 +
3 files changed, 4 insertions(+)
diff --git a/examples/l2fwd/Makef
From: Pavan Nikhilesh
Some PMDs cannot work when certain offloads are enable/disabled, as a
workaround PMDs auto enable/disable offloads internally and expose it
through dev->data->dev_conf.rxmode.offloads.
After device specific dev_configure is called compare the requested
offloads to the offlo
From: Pavan Nikhilesh
Add new Rx offload flags `DEV_RX_OFFLOAD_RSS_HASH` These flags can be used
to enable/disable PMD writes to rte_mbuf fields `hash.rss` and also
`ol_flags:PKT_RX_RSS` and `ol_flags:PKT_RX_FDIR`.
Add new packet type set function `rte_eth_dev_set_supported_ptypes`,
allows appli
From: Pavan Nikhilesh
Add `rte_eth_dev_set_supported_ptypes` function that will allow the
application to inform the PMD the packet types it is interested in.
Based on the ptypes set PMDs can optimize their Rx path.
-If application doesn’t want any ptype information it can call
`rte_eth_dev_set_s
From: Pavan Nikhilesh
Add new Rx offload flag `DEV_RX_OFFLOAD_RSS_HASH` which can be used to
enable/disable PMDs write to `rte_mbuf::hash::rss`.
PMDs notify the validity of `rte_mbuf::hash:rss` to the applcation
by enabling `PKT_RX_RSS_HASH ` flag in `rte_mbuf::ol_flags`.
Signed-off-by: Pavan Ni
On Fri, Oct 25, 2019 at 6:45 PM Yigit, Ferruh
wrote:
>
> On 8/22/2019 9:18 AM, Jakub Grajciar wrote:
> > Zero-copy slave support for memif PMD.
> > Slave interface exposes DPDK memory to
> > master interface. Only single file segments
> > are supported (EAL option --single-file-segments).
Do you
On 10/26/2019 5:23 PM, Thomas Monjalon wrote:
> 26/10/2019 11:23, Wang, Haiyue:
>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
>>> 26/10/2019 06:40, Wang, Haiyue:
From: Thomas Monjalon [mailto:tho...@monjalon.net]
> 25/10/2019 18:02, Jerin Jacob:
>> On Fri, Oct 25, 2019 at 9:15
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘filter_idx’ may be used uninitialized in this function
[-Werror=maybe-uninitia
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘link’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘transceiver_type’ may be used uninitialized in this function
[-Werror=maybe-un
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘stats.greatest_free_size’ may be used uninitialized in this
function [-Werror=
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘features’ may be used uninitialized in this function
[-Werror=maybe-uninitiali
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘chunk’ may be used uninitialized in this function
[-Werror=maybe-uninitialized
This patch fixes 'maybe-uninitialized' warnings reported by compiler
when using LTO.
Compiler warning pointing to this error (with LTO enabled):
error: ‘kg_cfg.extracts[0].masks[0].mask’ may be used uninitialized in
this function [-Werror=maybe-uninitialized]
extr->masks[j].mask = cfg->extract
This patch fixes documentation of versioning macros so that they are
aligned with their implementation (no underscore is added by macros).
Signed-off-by: Andrzej Ostruszka
Acked-by: Neil Horman
---
doc/guides/contributing/versioning.rst | 4 ++--
lib/librte_eal/common/include/r
Every implementation of a particular version of given symbol needs to be
marked in its declaration as such (using `__vsym` macro). This patch
fixes this and also clarifies the documentation about that.
Signed-off-by: Andrzej Ostruszka
Acked-by: Neil Horman
---
doc/guides/contributing/versionin
During LTO build compiler reports some 'false positive' warnings about
variables being possibly used uninitialized. This patch silences these
warnings.
Exemplary compiler warning to suppress (with LTO enabled):
error: ‘service_id’ may be used uninitialized in this function
[-Werror=maybe-uninitia
Fix the logic for the case of event queue allowing all schedule types.
Compiler warning pointing to this error (with LTO enabled):
error: ‘sched_type’ may be used uninitialized in this function
[-Werror=maybe-uninitialized]
if ((ret < 0 && ret != -EOVERFLOW) ||
Fixes: 6750b21bd6af ("eventdev: a
This patch adds an option to enable link time optimization. In addition
to LTO option itself (-flto) fat-lto-objects are being used. This is
because during the build pmdinfogen scans the generated ELF objects to
find this_pmd_name* symbol in symbol table. Without fat-lto-objects gcc
produces ELF
This patch series adds an option to make use of link time optimization
(if compiler has support for it). It is split as follows:
- 1st patch is just a minor doc fix for versioning macros
- 2nd patch fixes missing __vsym annotations (needed for LTO)
- 3rd is the LTO enablement
- remaining patches a
> > > >
> > >
> > > How about *_str_* style ?
> >
> > _name kind of implies it the string. may be _mode is good as it is short.
> >
> > > int
> > > rte_eth_rx_burst_mode_str_get(uint16_t port_id, uint16_t queue_id,
> > > char *buf, int buflen)
> >
>
> About the
On 27/10/2019 18:35, Thomas Monjalon wrote:
06/08/2019 13:18, Thomas Monjalon:
26/07/2019 12:15, Burakov, Anatoly:
So it's biased towards scaling up quickly, but it's doing that over a
period. Please correct me if i'm wrong as i'm not really familiar with
this codebase, but, assuming the wind
1 - 100 of 156 matches
Mail list logo
