> -----Original Message----- > From: Thomas Monjalon <tho...@monjalon.net> > Sent: Tuesday, October 29, 2019 20:30 > To: Slava Ovsiienko <viachesl...@mellanox.com> > Cc: Andrew Rybchenko <arybche...@solarflare.com>; dev@dpdk.org; > Matan Azrad <ma...@mellanox.com>; olivier.m...@6wind.com; Ori Kam > <or...@mellanox.com> > Subject: Re: [dpdk-dev] [PATCH v4] ethdev: extend flow metadata > > 29/10/2019 18:19, Slava Ovsiienko: > > From: Andrew Rybchenko <arybche...@solarflare.com> > > > > --- a/doc/guides/rel_notes/deprecation.rst > > > > +++ b/doc/guides/rel_notes/deprecation.rst > > > > +* ethdev: DEV_TX_OFFLOAD_MATCH_METADATA will be removed, > static > > > > +metadata > > > > + mbuf field will be removed in 20.02, metadata feature will use > > > > +dynamic mbuf > > > > + field and flag instead. > > > > + > > > > > > Isn't it breaking stable API/ABI? Should target release be 20.11? > > > > tx_metadata is in union, it should not be ABI break. > > And we propose to remove tx_metadata at all in 19.11 and share the > > dynamic metadata field between Rx and Tx METAdata. > > Yes please, let's remove tx_metadata from mbuf now, while adding > metadata dynamic field. > I am sure nobody will complain that we sanitized this feature before > releasing DPDK 19.11 LTS.
OK, I'll extend this patch to small series and update tx_metadata in the dedicated commit (to simplify reviewing either). With best regards, Slava
