> -----Original Message----- > From: Olivier Matz <olivier.m...@6wind.com> > Sent: Tuesday, October 29, 2019 18:34 > To: Slava Ovsiienko <viachesl...@mellanox.com> > Cc: dev@dpdk.org; Thomas Monjalon <tho...@monjalon.net>; Matan > Azrad <ma...@mellanox.com>; Ori Kam <or...@mellanox.com>; Yongseok > Koh <ys...@mellanox.com> > Subject: Re: [PATCH v4] ethdev: extend flow metadata > > On Tue, Oct 29, 2019 at 05:25:22PM +0100, Olivier Matz wrote: > > Hi Slava, > > > > Looks good to me overall. Few minor comments below.
[snip] > > I forgot: can you please document the goal/usage of these field and flag > here? Not necessarily a detailed explanation, but a high level view: > what is transported, when it is registered, ... > Even the brief explanation is wordy, because it involves some metadata features history, I will think how I could elaborate the description. With best regards, Slava
