On Tue, Oct 29, 2019 at 1:21 PM Flavio Leitner <f...@sysclose.org> wrote: > On Tue, 29 Oct 2019 10:02:57 +0100 > David Marchand <david.march...@redhat.com> wrote: > > Using rte_malloc() means that the allocation can end up on any numa > > node. This external buffer might end up on a different node than the > > mbuf (which resides on mp->socket_id node). > > Only if there is no memory in the local socket. It seems better than a > failure to me.
This won't fail, but you don't know how it will impact the application. We are moving from a model where the vhost library used a mempool with a fixed number of buffers on a known socket to a model where we can't guarantee how much memory vhost will eat, and where the allocations happen. I am just scared we will get bitten by random allocation failures on a system that was "used to run fine". -- David Marchand
