On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > On 10/28/19 5:01 PM, Olivier Matz wrote: > > In rte_mempool_populate_default(), we determine the page size, > > which is needed for calc_size and allocation of memory. > > > > Move this in a function and export it, it will be used in next > > commit. > > > > Signed-off-by: Olivier Matz <olivier.m...@6wind.com> > > One question below: > Reviewed-by: Andrew Rybchenko <arybche...@solarflare.com> > > [snip] > > > diff --git a/lib/librte_mempool/rte_mempool_version.map > > b/lib/librte_mempool/rte_mempool_version.map > > index 17cbca460..4eff2767d 100644 > > --- a/lib/librte_mempool/rte_mempool_version.map > > +++ b/lib/librte_mempool/rte_mempool_version.map > > @@ -56,5 +56,6 @@ DPDK_18.05 { > > EXPERIMENTAL { > > global: > > + rte_mempool_get_page_size; > > rte_mempool_ops_get_info; > > }; > > Should internal function be here? >
Good question. Let me ask a friend ;)