Re: [dpdk-dev] [PATCH v8 00/13] vhost packed ring performance optimization

2019-10-23 Thread Maxime Coquelin
I get some checkpatch warnings, and build fails with clang. Could you please fix these issues and send v9? Thanks, Maxime ### [PATCH] vhost: try to unroll for each loop WARNING:CAMELCASE: Avoid CamelCase: <_Pragma> #78: FILE: lib/librte_vhost/vhost.h:47: +#define vhost_for_each_try_unroll(iter,

Re: [dpdk-dev] [PATCH v2] ethdev: extend flow metadata

2019-10-23 Thread Slava Ovsiienko
Hi, Olivier > > [snip] > > > > > > +int > > > > +rte_flow_dynf_metadata_register(void) > > > > +{ > > > > + int offset; > > > > + int flag; > > > > + > > > > + static const struct rte_mbuf_dynfield desc_offs = { > > > > + .name = MBUF_DYNF_METADATA_NAME, > > > > +

Re: [dpdk-dev] [PATCH 00/15] Introduce Virtio vDPA driver

2019-10-23 Thread Maxime Coquelin
On 8/29/19 9:59 AM, Maxime Coquelin wrote: > vDPA allows to offload Virtio Datapath processing by supported > NICs, like IFCVF for example. > > The control path has to be handled by a dedicated vDPA driver, > so that it can translate Vhost-user protocol requests to > proprietary NICs registers

Re: [dpdk-dev] [PATCH v3] net/i40e: fix exception with multi-driver

2019-10-23 Thread Ye Xiaolong
On 10/08, alvinx.zh...@intel.com wrote: >From: Alvin Zhang > >If support-multi-driver is enabled, the global registers should not >be configured. But with the current code base, if creating a flow >with rte_flow API, the global register GLQF_FD_MSK may be changed. > >Fixes: cfdfca493cae ("net/i40e

Re: [dpdk-dev] [PATCH v8 07/13] vhost: flush enqueue updates by cacheline

2019-10-23 Thread Maxime Coquelin
On 10/22/19 12:08 AM, Marvin Liu wrote: > Buffer vhost packed ring enqueue updates, flush ring descs if buffered > content filled up one cacheline. Thus virtio can receive packets at a > faster frequency. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks, Maxime

Re: [dpdk-dev] [PATCH v8 06/13] vhost: add packed ring batch dequeue

2019-10-23 Thread Maxime Coquelin
On 10/22/19 12:08 AM, Marvin Liu wrote: > Add batch dequeue function like enqueue function for packed ring, batch > dequeue function will not support chained descritpors, single packet > dequeue function will handle it. > > Signed-off-by: Marvin Liu Reviewed-by: Maxime Coquelin Thanks, Maxi

Re: [dpdk-dev] [PATCH v8 03/13] vhost: try to unroll for each loop

2019-10-23 Thread Maxime Coquelin
On 10/22/19 12:08 AM, Marvin Liu wrote: > Create macro for adding unroll pragma before for each loop. Batch > functions will be contained of several small loops which can be > optimized by compilers' loop unrolling pragma. > > Signed-off-by: Marvin Liu > Reviewed-by: Maxime Coquelin Thanks

Re: [dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue

2019-10-23 Thread Ye Xiaolong
On 10/24, Yahui Cao wrote: >Reverse the src and dest notion, since the HW expects them to be from Tx >perspective where as the input from user is from Rx filter view. > >Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy") > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.

[dpdk-dev] [PATCH 18/18] net/bnxt: call bnxt_uninit_locks from bnxt_uninit_resources

2019-10-23 Thread Somnath Kotur
From: Venkat Duvvuru Currently, bnxt_uninit_locks is called inside bnxt_dev_uninit. However, the more appropriate place to call it is inside bnxt_uninit_resources. This is more logical, as all the resources uninitialization is happening inside bnxt_uninit_resources. Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH 17/17] net/bnxt: fix mbuf free when clearing Tx queue

2019-10-23 Thread Somnath Kotur
From: Lance Richardson When freeing pending transmit mbufs, use rte_pktmbuf_free_seg() instead of rte_pktmbuf_free(), otherwise linked mbufs may be freed more than once. Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Somnath Kotur Signed-off

[dpdk-dev] [PATCH 16/16] net/bnxt: fix a possible memory leak

2019-10-23 Thread Somnath Kotur
From: Kalesh AP During hot fw upgrade or error recovery, driver does cleanup and reallocation of resources. But driver reallocates memory for ring group info table without freeing the allocated memory during device init. Fix this memory leak by moving the freeing of ring group info table to bnxt

[dpdk-dev] [PATCH 14/16] net/bnxt: add PCI IDs for 57500 series NPAR devices

2019-10-23 Thread Somnath Kotur
From: Kalesh AP Add PCI IDs for 57500 series NPAR devices Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 6 ++ drivers/net/bnxt/bnxt_ethdev.c | 6 ++ 2 files changed, 12 insertions(+) diff --git a/drivers/net/bnx

[dpdk-dev] [PATCH 13/16] net/bnxt: add more checks for fw reset

2019-10-23 Thread Somnath Kotur
From: Kalesh AP Added check for fw reset or fw errors in few more routines. While processing the events, if it is fw fatal or non-fatal event, there is no need to process the remaining events as driver triggers recovery mechanism. Also added a check for fw reset or fatal error in bnxt_disable_in

[dpdk-dev] [PATCH 12/16] net/bnxt: fix segfault after removing and adding the slaves

2019-10-23 Thread Somnath Kotur
From: Santoshkumar Karanappa Rastapur On removing the slave interface, slave_remove in bonding module calls _rte_eth_dev_reset which in turn frees both Tx and Rx queues. 1. segfault is seen after removing/adding the slave interface and starting bond interface. In this below path, when mtu is set

[dpdk-dev] [PATCH 15/16] net/bnxt: add a wrapper function for thor device check

2019-10-23 Thread Somnath Kotur
From: Kalesh AP This patch adds a wrapper function bnxt_thor_device() which checks for the pci device is Thor family. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur Reviewed-by: Santoshkumar Karanappa Rastapur Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ethdev.c | 24 +++

[dpdk-dev] [PATCH 09/16] net/bnxt: fix to use HWRM_CFA_L2_FILTER as the filter_type for non-ntuple flows

2019-10-23 Thread Somnath Kotur
From: Rahul Gupta Use HWRM_CFA_L2_FILTER filter_type, as its checked during SRC MAC filter creation in bnxt_create_l2_filter(). Fixes: f1a9687b7b352 ("net/bnxt: create SMAC filter only for L2 flows") Signed-off-by: Rahul Gupta Reviewed-by: Somnath Kotur Reviewed-by: Ajit Kumar Khaparde Signe

[dpdk-dev] [PATCH 11/16] net/bnxt: fix to check for zero mac address while parsing flow arguments

2019-10-23 Thread Somnath Kotur
Add another check to flag zero mac address while validating/parsing the flow arguments Fixes: 74defda79 ("net/bnxt: allow only unicast MAC address filter creation") Reviewed-by: Venkat Duvvuru Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_flow.c | 12 +--- 1 file changed, 9 in

[dpdk-dev] [PATCH 08/16] net/bnxt: fix a possible race between start and interrupt handler

2019-10-23 Thread Somnath Kotur
From: Kalesh AP During port start, driver enables interrupts. At the end of port start driver schedules the alarm for fw health check. This can cause race between interrupt handler and schedule fw health check alarm thread which falsely detects FW error. Fixes: 241f043a3c8f ("net/bnxt: handle fi

[dpdk-dev] [PATCH 10/16] net/bnxt: expose some missing counters in port statistics

2019-10-23 Thread Somnath Kotur
Rx/Tx Port statistics record PFC enabled frames for each priority. Modify the Rx/Tx port stats array to report these as well. Fixes: bfb9c226 ("net/bnxt: support xstats get/reset") Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_stats.c | 32

[dpdk-dev] [PATCH 05/16] net/bnxt: fix RSS configuration failure for thor-based controllers

2019-10-23 Thread Somnath Kotur
From: Santoshkumar Karanappa Rastapur rss_table structure stores receive, completion ring IDs for Thor based controllers and receive queue id for others. Below commit accidentally left the old code and hence was always overwriting receive ring id with queue id for Thor. This causes subsequent VNI

[dpdk-dev] [PATCH 07/16] net/bnxt: use mac index, while checking for default mac

2019-10-23 Thread Somnath Kotur
From: Venkat Duvvuru bnxt_set_hwrm_vnic_filters programs default mac addr and the same default mac is added by mac_add_addr_op routine as well. This redundant mac add is avoided by checking if the default mac is already added. However, that check is wrong. The check should consider the mac index

[dpdk-dev] [PATCH 04/16] net/bnxt: fix to write the correct MTU to FW

2019-10-23 Thread Somnath Kotur
From: Ajit Khaparde We are currently writing the MAX supported MTU size even though the MTU passed by the application is a different value. Configure the application specified MTU instead. Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") Signed-off-by: Ajit Kh

[dpdk-dev] [PATCH 00/18] bnxt patchset with bug fixes

2019-10-23 Thread Somnath Kotur
Please apply. Ajit Khaparde (3): net/bnxt: fix to set MAX RSS contexts for maximal reservation net/bnxt: fix to write the correct MTU to FW net/bnxt: update HWRM API to version 1.10.1.6 Kalesh AP (6): net/bnxt: fix unused value in free filter mem net/bnxt: fix a possible race between st

[dpdk-dev] [PATCH 03/16] net/bnxt: fix to set MAX RSS contexts for maximal reservation

2019-10-23 Thread Somnath Kotur
From: Ajit Khaparde Configure max RSS contexts in case the firmware indicates a maximal resource reservation strategy. Fixes: 6d8109bcb398 ("net/bnxt: check VF resources if resource manager is enabled) Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Signed-off-by: Somnath Kotur ---

[dpdk-dev] [PATCH 02/16] net/bnxt: fix ping failure with MTU change

2019-10-23 Thread Somnath Kotur
From: Santoshkumar Karanappa Rastapur Driver was setting maximum receive unit differently in bnxt_mtu_set_op and bnxt_hwrm_vnic_alloc. Moreover firmware adds the 4 bytes for FCS. Fixed it by setting correct maximum receive unit value. Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Santoshkumar

[dpdk-dev] [PATCH 01/16] net/bnxt: fix unused value in free filter mem

2019-10-23 Thread Somnath Kotur
From: Kalesh AP This patch fixes the coverity UNUSED_VALUE issue. Coverity issue: 349938 Fixes: 49d0709b257f ("net/bnxt: delete and flush L2 filters cleanly") Signed-off-by: Kalesh AP Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_filter.c | 4

Re: [dpdk-dev] [PATCH] net/ice: fix IPv6 dest mac unsupported issue

2019-10-23 Thread Ye Xiaolong
On 10/23, Yahui Cao wrote: >Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy") > >Signed-off-by: Yahui Cao >--- > drivers/net/ice/ice_fdir_filter.c | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/net/ice/ice_fdir_filter.c >b/drivers/net/ice/ice_fdir_filter.c >index 80da6e

[dpdk-dev] Please help about testpmd bonding

2019-10-23 Thread Hekai Wang
Hi I hit a trouble when i create a testpmd bond in guest and want to get some help from you. Here is the detail FIrst create vm Install dpdk in vm attach i40e vf to vm start testpmd in vm and create bonding with the ports which was attached before . :: [ 00:41:36 ] :: [ BEGIN ] :: Running 'vi

[dpdk-dev] [PATCH] net/ice: fix IPv6 UDP port matching failure issue

2019-10-23 Thread Yahui Cao
Reverse the src and dest notion, since the HW expects them to be from Tx perspective where as the input from user is from Rx filter view. Fixes: 2dbef0825ef7 ("net/ice: add FDIR create and destroy") Signed-off-by: Yahui Cao --- drivers/net/ice/ice_fdir_filter.c | 4 ++-- 1 file changed, 2 inser

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Shahaf Shuler
Wednesday, October 23, 2019 4:34 PM, Olivier Matz: > Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags > > Hi Shahaf, > > On Wed, Oct 23, 2019 at 12:00:30PM +, Shahaf Shuler wrote: > > Hi Olivier, > > > > Thursday, October 17, 2019 5:42 PM, Olivier Matz: > > > Subject:

Re: [dpdk-dev] [PATCH 0/8] eBPF arm64 JIT support

2019-10-23 Thread Jerin Jacob
On Sat, Oct 5, 2019 at 8:09 PM Jerin Jacob wrote: > > > >> > > >> This might be one avenue if all kernel JIT contributors would be on > > >> board. > > >> Another option I'm wondering could be to extend the bpf() syscall in > > >> order > > >> to pass down a description of context and helper map

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs

2019-10-23 Thread Gavin Hu (Arm Technology China)
> -Original Message- > From: Honnappa Nagarahalli > Sent: Thursday, October 24, 2019 1:30 AM > To: Morten Brørup ; Joyce Kong (Arm > Technology China) ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; jer...@marvell.com; > ravi1.ku...@amd.com; xuanziya...@huawei.com; > cloud.wangxiao...@hua

[dpdk-dev] [PATCH] app/testpmd: fix Tx checksum problem when TSO enabled

2019-10-23 Thread Peng Huang
This patch fixed the TX checksum value problem when enabled TSO in tunnel packets, because outer UDP checksum calculation depend on the TSO configuration. depend on patch: app/testpmd: enable GTP header parse and Tx checksum offload Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in check

[dpdk-dev] [PATCH 0/2] IXGBE vector PMD on AArch64 complement

2019-10-23 Thread Ruifeng Wang
Packet type parse is missing in AArch64 vector PMD. Add the missing part. Besides, remove macro not used any more. Ruifeng Wang (2): net/ixgbe: add ptype parse for aarch64 vector PMD net/ixgbe: remove unused macro in aarch64 vector PMD drivers/net/ixgbe/ixgbe_ethdev.c| 2 +- drivers

[dpdk-dev] [PATCH 2/2] net/ixgbe: remove unused macro in aarch64 vector PMD

2019-10-23 Thread Ruifeng Wang
Fixes: ed838a5fe957 ("net/ixgbe: use intrinsics to count packet in NEON Rx") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Gavin Hu --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/ne

[dpdk-dev] [PATCH 1/2] net/ixgbe: add ptype parse for aarch64 vector PMD

2019-10-23 Thread Ruifeng Wang
Ptype parse is missing in aarch64 vector PMD. It makes packet type info provided by NIC get lost, thus requires extra CPU cycles to do this. Add the parse process to utilize NIC hardware capability. In test with l3fwd (removed port conf DEV_RX_OFFLOAD_CHECKSUM), observed over 3% performance gain.

Re: [dpdk-dev] [PATCH] vhost: delete vhost scsi example

2019-10-23 Thread Yu, Jin
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Wednesday, October 23, 2019 9:52 PM > To: Yu, Jin > Cc: dev ; Liu, Changpeng ; > Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong > Subject: Re: [dpdk-dev] [PATCH] vhost: delete vhost scsi example > > On

[dpdk-dev] [PATCH v2] vhost: delete vhost scsi example

2019-10-23 Thread Jin Yu
This example is too old and SPDK will not maintain this example anymore. Also SPDK has submitted a new vhost example vhost-blk. We will keep on maintaining vhost-blk and It shows the packed ring and live recovery support. Signed-off-by: Jin Yu --- V2 - delete the left trace --- MAINTAINERS

[dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove

2019-10-23 Thread Di ChenxuX
Hotplug remove cause infinite loops. Fix by canceling port_close before port_detach function when rmv_port_callback. Fixes: ac89d46096d5 ("net/i40e: release port upon close") Signed-off-by: Di ChenxuX --- app/test-pmd/testpmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/app/test-pmd/te

Re: [dpdk-dev] [PATCH v9 0/2] mbuf: add bulk free function

2019-10-23 Thread Thomas Monjalon
23/10/2019 12:11, Morten Brørup: > Add function for freeing a bulk of mbufs. > > Add unit test for functions for allocating and freeing a bulk of mbufs. > > Morten Brørup (2): > mbuf: add bulk free function > mbuf: add unit test for bulk alloc/free functions Applied, thanks

Re: [dpdk-dev] [PATCH v6 2/4] doc: changes to abi policy introducing major abi versions

2019-10-23 Thread Thomas Monjalon
27/09/2019 18:54, Ray Kinsella: > This policy change introduces major ABI versions, these are > declared every year, typically aligned with the LTS release > and are supported by subsequent releases in the following year. No, the ABI number may stand for more than one year. > This change is inten

Re: [dpdk-dev] [PATCH] config: set RTE_KNI_PREEMPT_DEFAULT in meson

2019-10-23 Thread Thomas Monjalon
18/09/2019 12:32, Bruce Richardson: > On Tue, Sep 17, 2019 at 10:11:04PM +0300, Igor Ryzhov wrote: > >CCing Bruce, maintainer of the meson build system. > >It's a simple patch to make meson behavior consistent with make > >behavior. > >CONFIG_RTE_KNI_PREEMPT_DEFAULT is set to "y" in

Re: [dpdk-dev] [dpdk-stable] [PATCH 7/9 v2] mempool/dpaa2: panic on endless loop in mbuf release

2019-10-23 Thread Thomas Monjalon
17/10/2019 14:44, Nipun Gupta: > From: Radu Bulie > + rte_panic("bman release retry exceeded, low > fbpr?\n"); You are not supposed to call rte_panic in a library. Please replace with a smoother abort.

Re: [dpdk-dev] [PATCH v10] ethdev: add HIGIG2 key field to flow API

2019-10-23 Thread Thomas Monjalon
22/10/2019 06:16, kirankum...@marvell.com: > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -101,7 +101,8 @@ The public API headers are grouped by topics: >[GSO](@ref rte_gso.h), >[frag/reass] (@ref rte_ip_frag.h), >[LPM IPv4 route] (@

Re: [dpdk-dev] [PATCH v2 0/4] synchronise meson warnings with make

2019-10-23 Thread Thomas Monjalon
07/10/2019 16:30, Bruce Richardson: > The warnings used when building DPDK with make were stricter than those > used with meson, so this patchset aligns the two as far as is possible, > while also adding in -Wextra as a general compile flag. > > The one difference is that with "make" we allow diff

Re: [dpdk-dev] [dpdk-stable] 18.11.3 (LTS) patches review and test

2019-10-23 Thread Abhishek Marathe
Hi Kevin, We ran DPDK 18.11.2 and 18.11.3-rc1 and got the same results for both that is “PERF-DPDK-MULTICORE-PPS-F32” failed. With the current situation it seems like Multicore and DPDK 18.11.3 does not work well on Azure. There are no errors in DPDK execution logs or Kernel logs. We are still

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-10-23 Thread Rajesh Ravi
Hi Anatoly, I tried calling rte_vfio_dma_map() but, it failed for me because vfio_dma_mem_map() failed with error:VFIO support not initialized because: default_vfio_cfg->vfio_iommu_type=NULL ( container_dma_map calls vfio_dma_mem_map with vfio_cfg = default_vfio_cfg ) call sequence: rte_vfio

Re: [dpdk-dev] [PATCH] eal: add option --iso-cmem for external custom memory

2019-10-23 Thread Rajesh Ravi
Thanks Anatoly for prompt response. Sorry for the delayed response, I took some time to reverify with SPDK. Infact, I do want the iommu mapping to be performed. I don't want it to be bypassed by type1_map() [lib/librte_eal/linuxapp/eal/eal_vfio.c] for external memory. Then, if I understood correc

Re: [dpdk-dev] [PATCH 0/3] RFC: Support disabling DPDK drivers in meson builds

2019-10-23 Thread Thomas Monjalon
25/09/2019 20:01, Luca Boccassi: > On Wed, 2019-09-25 at 15:55 +0100, Bruce Richardson wrote: > > Bruce Richardson (3): > > build: align variable names between drivers and libs > > build: process dependencies before main build check > > build: support disabling drivers with meson > > Series-

Re: [dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11

2019-10-23 Thread Stephen Hemminger
On Wed, 23 Oct 2019 20:54:12 +0200 David Marchand wrote: > Let's prepare for the ABI freeze. > > The first patches are about changes that had been announced before (with > a patch from Stephen that I took as it is ready as is from my pov). > > The malloc_heap structure from the memory subsystem

Re: [dpdk-dev] [PATCH v2] net/mlx: remove pedantic definition for icc

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 12:31 PM, Raslan Darawsheh wrote: > Trying to compile mlx5 pmd in debug mode with icc > will lead to compilation failures due to the fact that > icc doesn't have support for the pragma of pedantic. What would you think about following patch title: net/mlx: fix icc build And should

Re: [dpdk-dev] [PATCH v2 0/4] net definitions fixes

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 2:39 PM, David Marchand wrote: > Small patchset with fixes after inspecting the librte_net. > I copied sta...@dpdk.org in the 2nd patch for information only. > For series, Reviewed-by: Ferruh Yigit Series applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH] ethdev: fix include for ether header file

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 3:01 PM, Thomas Monjalon wrote: > 23/10/2019 14:53, Ciara Power: >> The include for rte_ether.h in each of these files should not use >> quotes, as the header file is not in the librte_ethdev directory. These >> are now updated to use <> symbols, to search directories pre-designated

Re: [dpdk-dev] [RFC v6 2/6] lib/ring: apis to support configurable element size

2019-10-23 Thread Honnappa Nagarahalli
> > On Sun, Oct 20, 2019 at 07:22:56PM -0500, Honnappa Nagarahalli wrote: > > Current APIs assume ring elements to be pointers. However, in many use > > cases, the size can be different. Add new APIs to support configurable > > ring element sizes. > > > > Signed-off-by: Honnappa Nagarahalli > > R

Re: [dpdk-dev] [PATCH v4 1/2] lib/ring: apis to support configurable element size

2019-10-23 Thread Honnappa Nagarahalli
> > > > > > I have applied your > > > > suggestion in 6/6 in v6 along with my corrections. The > > > > rte_ring_elem test cases are added in 3/6. I have verified that they are > running fine (they are done for 64b alone, will add more). Hopefully, there > are > no more errors. > > > > Applied v6

[dpdk-dev] [PATCH v2 12/12] eal: make the global configuration private

2019-10-23 Thread David Marchand
Now that all elements of the rte_config structure have (deinlined) accessors, we can hide it. Signed-off-by: David Marchand --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/eal_common_mcfg.c | 1 + lib/librte_eal/common/eal_private.h | 32 +

[dpdk-dev] [PATCH v2 10/12] eal: deinline lcore APIs

2019-10-23 Thread David Marchand
Those functions are used to setup or take control decisions. Move them into the EAL common code and put them directly in the stable ABI. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 38 lib/librte_eal/common/include/rte_lcore.h | 41 +

[dpdk-dev] [PATCH v2 08/12] log: hide internal log structure

2019-10-23 Thread David Marchand
No need to expose rte_logs, hide it and remove it from the current ABI. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- Changelog since v1: - updated release notes, --- doc/guides/rel_notes/release_19_11.rst | 2 ++ lib/librte_eal/common/eal_common_log.c | 23 -

[dpdk-dev] [PATCH v2 09/12] test/mem: remove dependency on EAL internals

2019-10-23 Thread David Marchand
Rather than dereference the mem_config internal structure, we can rely on the rte_memzone_walk API and count memzones. Signed-off-by: David Marchand --- app/test/test_memzone.c | 50 ++--- 1 file changed, 31 insertions(+), 19 deletions(-) diff --git a

[dpdk-dev] [PATCH v2 07/12] log: add log stream accessor

2019-10-23 Thread David Marchand
Define an accessor so that users can write their debug message to the same stream than the rte_log infrastructure. Use it in the qat infrastructure. Signed-off-by: David Marchand --- Changelog since v1: - use ternary operator, --- drivers/common/qat/qat_logs.c | 3 +-- drivers/common

[dpdk-dev] [PATCH v2 11/12] eal: factorize lcore role code in common code

2019-10-23 Thread David Marchand
This code belongs to the lcore API, move the prototype to the right header, then factorize the code into the common code. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_lcore.c | 10 ++ lib/librte_eal/common/include/rte_eal.h | 11 --- lib/librte_eal/common

[dpdk-dev] [PATCH v2 06/12] pci: remove deprecated functions

2019-10-23 Thread David Marchand
Those functions have been deprecated since 17.11 and have 1:1 replacement. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 7 - doc/guides/rel_notes/release_19_11.rst | 6 + lib/librte_pci/rte_pci.c | 19 -- lib/librte_pci/rte_pci.h

[dpdk-dev] [PATCH v2 00/12] EAL and PCI ABI changes for 19.11

2019-10-23 Thread David Marchand
Let's prepare for the ABI freeze. The first patches are about changes that had been announced before (with a patch from Stephen that I took as it is ready as is from my pov). The malloc_heap structure from the memory subsystem can be hidden. The PCI library had some forgotten deprecated APIs that

[dpdk-dev] [PATCH v2 05/12] net/bonding: use non deprecated PCI API

2019-10-23 Thread David Marchand
rte_eal_compare_pci_addr has been deprecated since v17.11. Convert to rte_pci_addr_cmp. Fixes: c848b518bbc7 ("net/bonding: support bifurcated driver in eal") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/bonding/rte_eth_bond_args.c | 5 ++--- 1 file changed, 2 insertions(+),

[dpdk-dev] [PATCH v2 04/12] mem: hide internal heap header

2019-10-23 Thread David Marchand
Let's avoid exporting structures without an identified usecase. Signed-off-by: David Marchand --- app/test-pmd/testpmd.c | 1 - lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_memcfg.h | 3 ++- lib/librte_eal/common/inclu

[dpdk-dev] [PATCH v2 02/12] eal: remove deprecated CPU flags check function

2019-10-23 Thread David Marchand
Remove rte_cpu_check_supported as announced previously. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/eal_common_cpuflags.c | 11 --- lib/librt

[dpdk-dev] [PATCH v2 03/12] eal: remove deprecated malloc virt2phys function

2019-10-23 Thread David Marchand
Remove rte_malloc_virt2phy as announced previously. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 --- doc/guides/rel_notes/release_19_11.rst | 3 +++ lib/librte_eal/common/include/rte_malloc.h | 7 --- 3 files changed, 3 insertions(+), 10 deletions(-)

[dpdk-dev] [PATCH v2 01/12] eal: make lcore config private

2019-10-23 Thread David Marchand
From: Stephen Hemminger The internal structure of lcore_config does not need to be part of visible API/ABI. Make it private to EAL. Rearrange the structure so it takes less memory (and cache footprint). Signed-off-by: Stephen Hemminger Signed-off-by: David Marchand --- Based on Stephen v8: ht

Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library

2019-10-23 Thread Honnappa Nagarahalli
> > > From: Jerin Jacob > > > > > > Update the armv8 crypto PMD maintainership. > > > > > > https://github.com/caviumnetworks/armv8_crypto external crypto the > > > library will not be maintained and probably removed soon therefor > > > updating the PMD documentation to reflect the same. > > > > >

Re: [dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 9:45 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) wrote: > > >> -Original Message- >> From: Anand Sunkad >> Sent: Thursday, October 17, 2019 3:21 PM >> To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) >> >> Cc: dev@dpdk.org; Vivek Gupt

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix missing geneve flow item in raw encap

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 2:46 PM, Ori Kam wrote: > > >> -Original Message- >> From: dev On Behalf Of Wisam Monther >> Sent: Thursday, October 17, 2019 11:14 AM >> To: wenzhuo...@intel.com; dev@dpdk.org >> Cc: Wisam Monther ; roman.zhu...@oktetlabs.ru; >> sta...@dpdk.org >> Subject: [dpdk-dev] [PATC

Re: [dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection

2019-10-23 Thread Burakov, Anatoly
On 22-Oct-19 8:34 PM, David Marchand wrote: RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used with xen dom0 support (dropped for some time now). Closely looking at this, the code was changed later and ensures that the socket id is in the [0..RTE_MAX_NUMA_NODES] range anyway.

Re: [dpdk-dev] [PATCH v3] lib/librte_eal/linuxapp: fix runtime config mmap issue

2019-10-23 Thread Burakov, Anatoly
On 23-Oct-19 11:42 AM, Li Han wrote: In rte_eal_config_reattach(),the secondary mmap may fail due to the rte_mem_cfg_addr already be used by others.do the change just as the rte_fbarray_init() do.if no base_virtaddr,use the default 0x1. v2/v3: -fix code style issues Signed-off-by: Li Ha

Re: [dpdk-dev] [PATCH v2] net/memif: fix invalid unix domain address length

2019-10-23 Thread Ferruh Yigit
On 10/23/2019 9:07 AM, Jakub Grajciar wrote: > Define MEMIF_SOCKET_UN_SIZE to size of unix domain socket address. > Report error in case of longer path. > > Fixes: b923866c6974 ("net/memif: allow for full key size in socket name") > Cc: step...@networkplumber.org > > Signed-off-by: Jakub Grajciar

Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library

2019-10-23 Thread Jerin Jacob
On Wed, Oct 23, 2019 at 10:42 PM Honnappa Nagarahalli wrote: > > On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, > wrote: > > > > > > > From: Jerin Jacob > > > > Update the armv8 crypto PMD maintainership. > > > > https://github.com/caviumnetworks/armv8_crypto external crypto the library >

Re: [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs

2019-10-23 Thread Honnappa Nagarahalli
> > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong (Arm > > Technology China) > > Sent: Wednesday, October 23, 2019 5:08 AM > > > > > > > -Original Message- > > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Joyce Kong > > > > >

Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library

2019-10-23 Thread Jerin Jacob
On Wed, Oct 23, 2019 at 10:42 PM Honnappa Nagarahalli wrote: > > On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, > wrote: > > > > > > > From: Jerin Jacob > > > > Update the armv8 crypto PMD maintainership. > > > > https://github.com/caviumnetworks/armv8_crypto external crypto the library >

[dpdk-dev] [PATCH] app/test: decrease iterations in reciprocal division test

2019-10-23 Thread pbhagavatula
From: Pavan Nikhilesh Decrease max iterations in reciprocal division test to reduce the runtime. Update fast_test_names to include reciprocal division. Signed-off-by: Pavan Nikhilesh --- app/test/meson.build| 2 +- app/test/test_reciprocal_division.c | 2 +- 2 files changed, 2

Re: [dpdk-dev] [PATCH v6] app/testpmd: enable GTP header parse and Tx checksum offload

2019-10-23 Thread Ferruh Yigit
On 10/22/2019 4:45 PM, Ferruh Yigit wrote: > On 10/22/2019 5:26 PM, Ting Xu wrote: >> This patch enables testpmd to forward GTP packet in csum fwd mode. >> A GTP header structure (without optional fields and extension header) >> is defined in new rte_gtp.h. A parser function in testpmd is added. >>

Re: [dpdk-dev] Armv8_crypto PMD future.

2019-10-23 Thread Honnappa Nagarahalli
> > > > > > 22/10/2019 22:19, Honnappa Nagarahalli: > > > From: Akhil Goyal > > > > We can have 2 possible solutions to this situation > > > > > > > > 1. Arm host it somewhere and let people contribute to that. > > > > 2. Integrate it inside DPDK repo. > > > > > > [Honnappa] I don't have any iss

Re: [dpdk-dev] [PATCH] maintainers: update for armv8 crypto library

2019-10-23 Thread Honnappa Nagarahalli
On Wed, 23 Oct, 2019, 2:02 am Honnappa Nagarahalli, mailto:honnappa.nagaraha...@arm.com>> wrote: > > From: Jerin Jacob mailto:jer...@marvell.com>> > > Update the armv8 crypto PMD maintainership. > > https://github.com/caviumnetworks/armv8_crypto external crypto the library > will not be maintain

Re: [dpdk-dev] [PATCH v1 1/1] kernel/linux: introduce vfio_pf kernel module

2019-10-23 Thread Jerin Jacob
On Wed, Oct 16, 2019 at 5:07 PM Jerin Jacob wrote: > > > > > > > > > > no-iommu case is different where we cannot screw Linux netdev driver, you > > > can create a damage to your self that's an acceptable compromise. > > > > > > In this case, when DPDK PF bound application dies then it will impac

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-23 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Gavin Hu (Arm Technology China) > Sent: Thursday, October 24, 2019 12:20 AM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > step...@networkplumber.org; hemant.agra...@nxp.com; > jer...@marvell.com; pbhagavat...@marvell.

Re: [dpdk-dev] [PATCH v7 2/7] eal: add the APIs to wait until equal

2019-10-23 Thread Gavin Hu (Arm Technology China)
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Friday, October 18, 2019 12:44 AM > To: Gavin Hu (Arm Technology China) ; > dev@dpdk.org > Cc: nd ; tho...@monjalon.net; > step...@networkplumber.org; hemant.agra...@nxp.com; > jer...@marvell.com; pbhagavat...@marvell

[dpdk-dev] [PATCH] event/octeontx2: use wfe while waiting for head

2019-10-23 Thread pbhagavatula
From: Pavan Nikhilesh Use wfe to save power while waiting for tag to become head. SSO signals EVENTI to allow cores to exit from wfe when they are waiting for specific operations in which one of them is setting HEAD bit in GWS_TAG. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/ot

[dpdk-dev] [PATCH] event/octeontx2: remove hotspots by prefetching data

2019-10-23 Thread pbhagavatula
From: Pavan Nikhilesh Recent profiling revealed few hotspots in octeontx2 event device driver add prefetch hints to reduce stalls. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx2/otx2_worker.h | 1 + drivers/event/octeontx2/otx2_worker_dual.c | 1 + 2 files changed, 2 insertion

Re: [dpdk-dev] [dpdk-techboard] [PATCH 0/6] remove a few example applications

2019-10-23 Thread Hemant Agrawal
Series- Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] net/bnxt: fix mbuf free when clearing Tx queue

2019-10-23 Thread Ajit Khaparde
On Wed, Oct 23, 2019 at 10:27 AM Lance Richardson < lance.richard...@broadcom.com> wrote: > When freeing pending transmit mbufs, use rte_pktmbuf_free_seg() > instead of rte_pktmbuf_free(), otherwise linked mbufs may be freed > more than once. > > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Pavan Nikhilesh Bhagavatula
>Pavan Nikhilesh Bhagavatula writes: > >>>Pavan Nikhilesh Bhagavatula writes: >>> >> > >> >Any review? >> > >> >Are we missing an update in the unit test to catch this issue? >> >Thanks. >> >> We actually caught it in a unit test >> >test_reciprocal_division >

[dpdk-dev] [PATCH v2 2/2] net/octeontx2: add support to parse higig2 hdr

2019-10-23 Thread kirankumark
From: Kiran Kumar K Adding support to parse higig2 header in RTE flow for octeontx2. And added devargs to configure port for higig2. Signed-off-by: Kiran Kumar K --- V2 Changes: * Fixed checkpatch issue doc/guides/nics/octeontx2.rst | 2 ++ drivers/common/octeontx2/hw/otx2_npc.h |

[dpdk-dev] [PATCH v2 1/2] net/octeontx2: add support to enable switch type

2019-10-23 Thread kirankumark
From: Kiran Kumar K Adding support to configure specific switch types like high2 and dsa on a port. When this switch type is configured, it is expected that all the traffic on that port should be of specific type only. Signed-off-by: Kiran Kumar K --- V2 Changes: * Fixed checkpatch issue doc/

[dpdk-dev] [pull-request] next-crypto 19.11 rc1

2019-10-23 Thread Akhil Goyal
The following changes since commit ae783b42c4935d013ccec3f4625c51ec9ed234be: build: print out dependency names for clarity (2019-10-23 16:41:06 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 08a9ac4fe660fa0ecce3b31af5

[dpdk-dev] [PATCH 2/2] net/octeontx2: add support to parse higig2 hdr

2019-10-23 Thread kirankumark
From: Kiran Kumar K Adding support to parse higig2 header in RTE flow for octeontx2. And added devargs to configure port for higig2. Change-Id: I6931c2905f90a841c2638251bdfa1e63c7d676e6 Signed-off-by: Kiran Kumar K --- doc/guides/nics/octeontx2.rst | 2 ++ drivers/common/octeontx2/h

Re: [dpdk-dev] [dpdk-techboard] [PATCH 0/6] remove a few example applications

2019-10-23 Thread Stephen Hemminger
On Thu, 3 Oct 2019 14:19:12 +0100 Bruce Richardson wrote: > As discussed by the DPDK technical board e.g. [1][2] and on the DPDK > mailing list [3], we have a lot of example applications shipped with > DPDK - a number which increases with each DPDK release, and not all of > which are probably ne

[dpdk-dev] [PATCH 1/2] net/octeontx2: add support to enable switch type

2019-10-23 Thread kirankumark
From: Kiran Kumar K Adding support to configure specific switch types like high2 and dsa on a port. When this switch type is configured, it is expected that all the traffic on that port should be of specific type only. Change-Id: I41c47c4f8d844666cd6afe20a60397b83908e2f4 Signed-off-by: Kiran Kum

Re: [dpdk-dev] [PATCH 6/6] doc: close up gaps in sample app guide table

2019-10-23 Thread Thomas Monjalon
03/10/2019 15:19, Bruce Richardson: > Following the removal of some sample applications, close up the gaps > introduced in the table so that it is formatted nicely for the next > release. > > Signed-off-by: Bruce Richardson I don't think we should maintain such table. Either it is a normal list,

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Aaron Conole
Pavan Nikhilesh Bhagavatula writes: >>Pavan Nikhilesh Bhagavatula writes: >> > > > >Any review? > > > >Are we missing an update in the unit test to catch this issue? > >Thanks. > > We actually caught it in a unit test > >test_reciprocal_division We had th

Re: [dpdk-dev] [PATCH v2] mbuf: support dynamic fields and flags

2019-10-23 Thread Wang, Haiyue
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Wednesday, October 23, 2019 23:00 > To: Olivier Matz > Cc: Wang, Haiyue ; Ananyev, Konstantin > ; > dev@dpdk.org; Andrew Rybchenko ; Richardson, Bruce > ; Jerin Jacob Kollanukkaran ; > Wiles, Keith

Re: [dpdk-dev] [PATCH] build: print out dependency names for clarity

2019-10-23 Thread Bruce Richardson
On Wed, Oct 23, 2019 at 04:40:28PM +0200, Thomas Monjalon wrote: > 18/10/2019 18:54, Burakov, Anatoly: > > On 19-Sep-19 4:07 PM, Bruce Richardson wrote: > > > To help developers to get the correct dependency name e.g. when creating a > > > new example that depends on a specific component, print out

Re: [dpdk-dev] [PATCH] eal/reciprocal: fix off by one when divisor is 32bit

2019-10-23 Thread Pavan Nikhilesh Bhagavatula
>Pavan Nikhilesh Bhagavatula writes: > > >Any review? > >Are we missing an update in the unit test to catch this issue? >Thanks. We actually caught it in a unit test >test_reciprocal_division >>> >>>We had this problem since the very start then. >>> >>>Both

  1   2   3   >