Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF

2019-07-25 Thread Zhao1, Wei
Ok. > -Original Message- > From: Zhang, Qi Z > Sent: Friday, July 26, 2019 12:55 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: RE: [PATCH v3] net/ixgbe: fix Reta size for VF > > > > > -Original Message- > > From: Zhao1, Wei > > Sent: Friday, July 26, 2019 9

Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-07-25 Thread Shally Verma
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 25, 2019 11:22 PM > To: Shally Verma ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju Athreya > > Subject: RE: [d

[dpdk-dev] [PATCH] common/octeontx2: fix to prevent STP instruction fissure

2019-07-25 Thread jerinj
From: Jerin Jacob OTX2 AP core can sometimes fissure STP instructions when it is more optimal to send such writes into the pipeline as 2 separate instructions. However registers should be excluded from such optimization. This commit ensures that no CSR write is ever fissured by introducing zero c

[dpdk-dev] [PATCH] net/ice: fix LLDP forward

2019-07-25 Thread Wang Ying A
The patch fix the issue that lldp packet can't be forwarded to host. Fixes: 59d151de6673 ("net/ice: stop LLDP by default") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- drivers/net/ice/ice_ethdev.c | 46 +++- 1 file changed, 45 insertions(+), 1 delet

Re: [dpdk-dev] [PATCH v3] eal: pick IOVA as PA if IOMMU is not available

2019-07-25 Thread Stojaczyk, Dariusz
> -Original Message- > From: Burakov, Anatoly > Sent: Thursday, July 25, 2019 1:06 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Kovacevic, Marko > ; Stojaczyk, Dariusz > ; tho...@monjalon.net; > david.march...@redhat.com; jer...@marvell.com > Subject: [PATCH v3] eal: pick IOVA as PA if IOMM

Re: [dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF

2019-07-25 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Friday, July 26, 2019 9:38 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH v3] net/ixgbe: fix Reta size for VF > > Filling correct reta table size at ixgbevf_dev_info_get, so reta table update > w

Re: [dpdk-dev] [PATCH] net/i40e: fix flow double mark action error check

2019-07-25 Thread Zhang, Qi Z
> -Original Message- > From: Ergin, Mesut A > Sent: Friday, July 26, 2019 5:51 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Van Haaren, Harry ; Ergin, > Mesut A > Subject: [PATCH] net/i40e: fix flow double mark action error check > > This commit fixes an issue with the erro

Re: [dpdk-dev] [PATCH v2] net/iavf: fix endless loop

2019-07-25 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Thursday, July 25, 2019 8:47 PM > To: Zhang, Qi Z > Cc: Lu, Wenzhuo ; Wu, Jingjing > ; Yao, Lei ; dev@dpdk.org; > sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix endless loop > > On 07/25, Qi Zhang wrote: > >Change lo

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread Hyong Youb Kim (hyonkim)
> -Original Message- > From: John Daley (johndale) > Sent: Friday, July 26, 2019 5:26 AM > To: Ferruh Yigit > Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) > Subject: RE: [PATCH] net/enic: retain previous message logging > > Ok, lets NAK this patch. See comment inline. > Thanks, > John > [

Re: [dpdk-dev] [DPDK] net/e1000: fix buffer overrun while i219 processing DMA transactions

2019-07-25 Thread Zhao1, Wei
Acked-by: Wei Zhao > -Original Message- > From: Zhang, Xiao > Sent: Monday, July 8, 2019 9:37 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Zhao1, Wei ; > Zhang, Xiao > Subject: [DPDK] net/e1000: fix buffer overrun while i219 processing DMA > transactions > > Intel® 100/200 Series Chipset

Re: [dpdk-dev] [PATCH 8/8] net/vhost: do not count unsent packets as errors

2019-07-25 Thread Tiwei Bie
On Thu, Jul 25, 2019 at 11:14:28AM +0200, David Marchand wrote: > missed_pkts reflects the number of packets that the driver did not manage > to send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them

Re: [dpdk-dev] [PATCH 4/8] net/virtio: remove unused Tx error counter

2019-07-25 Thread Tiwei Bie
On Thu, Jul 25, 2019 at 11:14:24AM +0200, David Marchand wrote: > This Tx counter has never been used. > > Fixes: 9658d17da27b ("virtio: maintain stats per queue") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- > drivers/net/virtio/virtio_ethdev.c | 3 --- > 1 file changed, 3 del

[dpdk-dev] [PATCH v3] net/ixgbe: fix Reta size for VF

2019-07-25 Thread Wei Zhao
Filling correct reta table size at ixgbevf_dev_info_get, so reta table update will be supported for VF port. For X540_vf and 82599_vf, since they don't support reta table update, set reta size to 0. Cc: sta...@dpdk.org Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info") Signe

[dpdk-dev] [PATCH v2 2/2] app/testpmd: add symmetric toeplitz hash support

2019-07-25 Thread simei
From: Simei Su This patch adds command line support for Symmetric Toeplitz hash configuration. Signed-off-by: Simei Su --- app/test-pmd/cmdline.c | 12 +--- app/test-pmd/cmdline_flow.c | 12 +++- doc/guides/testpmd_app_ug/testpmd_funcs.rst |

[dpdk-dev] [PATCH v2 0/2] add symmetric toeplitz hash support

2019-07-25 Thread simei
From: Simei Su This v2 patch rebase to 19.08-rc2. [PATCH v2 1/2] ethdev: add new hash function "Symmetric Toeplitz" supported by hardware. [PATCH v2 2/2] app/testpmd: add command line support for symmetric toeplitz hash configuration. Simei Su (2): ethdev: add symmetric toeplitz hash support

[dpdk-dev] [PATCH v2 1/2] ethdev: add symmetric toeplitz hash support

2019-07-25 Thread simei
From: Simei Su Currently, there are DEFAULT,TOEPLITZ and SIMPLE_XOR hash function. To support symmetric hash by rte_flow RSS action, this patch adds new hash function "Symmetric Toeplitz" which is supported by some hardware. Signed-off-by: Simei Su --- lib/librte_ethdev/rte_flow.h | 1 + 1 fil

Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter

2019-07-25 Thread Ye Xiaolong
On 07/25, David Marchand wrote: >On Thu, Jul 25, 2019 at 5:49 PM Ye Xiaolong wrote: >> >> On 07/25, David Marchand wrote: >> >This Tx counter is now unused. >> > >> >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release >> >consistent") >> >> err_pkts seems not introduced by this com

[dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

2019-07-25 Thread simei
From: Simei Su This RFC reserves several bits as input set selection from bottom of the 64 bits. The flow type is combined with input set to represent rss types. Correct the input set mask to align with the definition in rte_ethdev.h. for example: ETH_RSS_IPV4 | ETH_RSS_INSET_L3_SRC: hash on

Re: [dpdk-dev] [PATCH 1/4] net/bnxt: fix extended port counter statistics

2019-07-25 Thread Santoshkumar Karanappa Rastapur
On Thu, Jul 25, 2019 at 1:09 PM Somnath Kotur wrote: > +Santosh > > On Thu, Jul 25, 2019 at 12:52 PM David Marchand > wrote: > >> On Thu, Jul 25, 2019 at 7:05 AM Somnath Kotur >> wrote: >> > >> > From: Santoshkumar Karanappa Rastapur >> > >> > We were trying to fill in more rx extended stats t

Re: [dpdk-dev] [PATCH v3 0/3] Multiseg fixes for pcap pmd

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 8:24 PM, David Marchand wrote: > Here are some fixes caught while looking at oerrors statistics for this > driver. > The second patch can be seen as a revert or a followup of [1]. > > 1: https://git.dpdk.org/dpdk/commit/?id=49a0a2ffd5db > > Changelog since v2: > - coding style fixes

[dpdk-dev] [PATCH] doc: update release note for i40e support for MARK+RSS

2019-07-25 Thread Mesut Ali Ergin
Signed-off-by: Mesut Ali Ergin --- doc/guides/rel_notes/release_19_08.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index c9bd3ce..6b07a28 100644 --- a/doc/guides/rel_notes/release_19_08.rst +++ b/doc

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread David Christensen
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

[dpdk-dev] [PATCH] net/i40e: fix flow double mark action error check

2019-07-25 Thread Mesut Ali Ergin
This commit fixes an issue with the error checking in flow MARK action. Previously, (ANY + MARK) would fail, as the (mark_spec == 0) condition would cause an early error return, however really it is (mark_spec != 0) that should cause the early error return. Flipping the binary comparison corrects

[dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-25 Thread Michael Santana
This patch reduces the memory footprint of tables for the unit test. Lower memory footprint means the test now passes when trying to allocate the tables. Signed-off-by: Michael Santana --- app/test/test_table_tables.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/te

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-25 Thread John Daley (johndale)
Ok, lets NAK this patch. See comment inline. Thanks, John > -Original Message- > From: Ferruh Yigit > Sent: Thursday, July 25, 2019 3:07 AM > To: John Daley (johndale) > Cc: dev@dpdk.org > Subject: Re: [PATCH] net/enic: retain previous message logging > > On 7/25/2019 3:46 AM, John Dale

[dpdk-dev] [PATCH v3 0/3] Multiseg fixes for pcap pmd

2019-07-25 Thread David Marchand
Here are some fixes caught while looking at oerrors statistics for this driver. The second patch can be seen as a revert or a followup of [1]. 1: https://git.dpdk.org/dpdk/commit/?id=49a0a2ffd5db Changelog since v2: - coding style fixes in patch3, - added acks, Changelog since v1: - comments fro

[dpdk-dev] [PATCH v3 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-25 Thread David Marchand
Two cores can send multi segment packets on two different pcap ports. Because of this, we can't have one single buffer to linearize packets. Use rte_pktmbuf_read() to copy the packet into a buffer on the stack and remove eth_pcap_gather_data() when necessary (if the mbuf is contiguous, rte_pktmbuf

[dpdk-dev] [PATCH v3 2/3] net/pcap: fix transmit return count in error conditions

2019-07-25 Thread David Marchand
When a packet cannot be transmitted, the driver is supposed to free this packet and report it as handled. This is to prevent the application from retrying to send the same packet and ending up in a liveloop since the driver will never manage to send it. Fixes: 49a0a2ffd5db ("net/pcap: fix possible

[dpdk-dev] [PATCH v3 1/3] net/pcap: fix Rx with small buffers

2019-07-25 Thread David Marchand
If the pkt pool contains only buffers smaller than the default headroom, then the driver will compute an invalid buffer size (negative value cast to an uint16_t). Rely on the mbuf api to check how much space is available in the mbuf. Fixes: 6eb0ae218a98 ("pcap: fix mbuf allocation") Cc: sta...@dpd

Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors

2019-07-25 Thread David Marchand
On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: > > On 7/25/2019 10:14 AM, David Marchand wrote: > > err_pkts reflects the number of packets that the driver did not manage to > > send. > > This is a temporary situation, those packets are not freed and the > > application can still retry to sen

Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter

2019-07-25 Thread David Marchand
On Thu, Jul 25, 2019 at 5:49 PM Ye Xiaolong wrote: > > On 07/25, David Marchand wrote: > >This Tx counter is now unused. > > > >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release > >consistent") > > err_pkts seems not introduced by this commit? This commit removed the only place

Re: [dpdk-dev] [PATCH] eal: pick IOVA as PA if IOMMU is not available

2019-07-25 Thread Thomas Monjalon
Jeu 25 juil 2019, à 10:05, David Marchand a écrit : > On Wed, Jul 24, 2019 at 6:46 PM Anatoly Burakov > wrote: > > > > When IOMMU is not available, /sys/kernel/iommu_groups will not be > > populated. This is happening since at least 3.6 when VFIO support > > was added. If the directory is empty, E

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread David Christensen
On Thu, Jul 25, 2019 at 05:29:03PM +0100, hgovindh wrote: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@cavi

Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-07-25 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Thursday, July 25, 2019 6:52 PM > To: Kusztal, ArkadiuszX ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju A

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Thursday, July 25, 2019 10:16 PM > To: hgovindh > Cc: Remy Horton ; Marko Kovacevic > ; Ori Kam ; Pablo de > Lara ; Radu Nicolau > ; Akhil Goyal ; Tomasz > Kantecki ; dev@dpdk.org; > maciej.cze...@caviumnetworks.com; s

[dpdk-dev] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-25 Thread Fiona Trahe
Clarify the corner case with incompressible data whereby the output can actually be greater than the uncompressed data. Signed-off-by: Fiona Trahe --- lib/librte_compressdev/rte_comp.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/lib/librte_compressdev/rte_comp.h

Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-07-25 Thread Shally Verma
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Thursday, July 25, 2019 3:08 PM > To: Shally Verma ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju Athreya > > Subject: RE: [dp

Re: [dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Bruce Richardson
On Thu, Jul 25, 2019 at 05:29:03PM +0100, hgovindh wrote: > Fix unaligned memory access when reading IPv6 header which > leads to segmentation fault by changing aligned memory read > to unaligned memory read. > > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > Cc: maciej

Re: [dpdk-dev] x552 transmit issue and rte_ethtool - rte_ethtool_get_regs()

2019-07-25 Thread Bly, Mike
Konstantin, After digging a bit further, we discovered our custom test setup was inadvertently running two threads calling the same transmit sequence, thus wedging the NIC. While this reproduced the DD not ready symptoms we are chasing, it is not a valid reproduction of what our application is

[dpdk-dev] [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [PATCH 7/8] net/ring: do not count unsent packets as errors

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 10:14 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage > to send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. >

Re: [dpdk-dev] [PATCH 6/8] net/memif: do not count unsent packets as errors

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 10:14 AM, David Marchand wrote: > n_err reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. > >

Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 10:14 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. '

Re: [dpdk-dev] [PATCH 3/8] net/null: remove unused Tx error counter

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 10:14 AM, David Marchand wrote: > This Tx counter has never been used. > > Fixes: c743e50c475f ("null: new poll mode driver") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/8] net/af_packet: remove unused Rx counter

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 10:14 AM, David Marchand wrote: > This Rx counter has never been used. > > Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices") > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2 0/4] bnxt patches

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 5:59 AM, Somnath Kotur wrote: > This set contains bug fixes for commits that made it into > 19.08, so it's imperative that these go into 19.08 as well > > Please apply > > Kalesh AP (3): > net/bnxt: fix to use chimp hwrm channel for few commands > net/bnxt: fix endianness issue >

[dpdk-dev] [PATCH] examples/rxtx_callbacks: fix HW timestamp enable

2019-07-25 Thread Harman Kalra
Offloafing Rx timestamp is a device capability than queue capability. Hence the logic to enable HW timestamp via DEV_RX_OFFLOAD_TIMESTAMP flag should be before device configuration. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: barbe...@kth.se Signed-off-by: Harman Kal

Re: [dpdk-dev] [PATCH 2/8] net/af_xdp: remove unused Tx counter

2019-07-25 Thread Ye Xiaolong
On 07/25, David Marchand wrote: >This Tx counter is now unused. > >Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent") err_pkts seems not introduced by this commit? > >Signed-off-by: David Marchand >--- > drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- > 1 file changed, 2

[dpdk-dev] [PATCH] doc: release note for the IPsec Security Gateway application

2019-07-25 Thread Bernard Iremonger
Update release notes for changes to the IPsec Security Gateway application Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_19_08.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19_08.rst index 7

[dpdk-dev] [PATCH] net/octeontx2: fix PTP enable via Rx ofload flags

2019-07-25 Thread Harman Kalra
Earlier implementation for enabling ptp via RX offload flag was causing segmentation fault as it was getting executed in the device configuration stage where RX and TX queues were not configured. As in the ptp enable process rx queues are used for mbuf setup while tx queues are used for send descri

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-25 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, July 25, 2019 3:39 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com; Mcnamara, John > > Cc: Iremonger, Bernard > Subject: [PATCH v3] doc: release note for the IPsec library > > Update release notes fo

Re: [dpdk-dev] [PATCH v2 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 1:04 PM, David Marchand wrote: > Two cores can send multi segment packets on two different pcap ports. > Because of this, we can't have one single buffer to linearize packets. > > Use rte_pktmbuf_read() to copy the packet into a buffer on the stack > and remove eth_pcap_gather_data()

Re: [dpdk-dev] [PATCH v2 2/3] net/pcap: fix transmit return count in error conditions

2019-07-25 Thread Ferruh Yigit
On 7/25/2019 1:04 PM, David Marchand wrote: > When a packet cannot be transmitted, the driver is supposed to free this > packet and report it as handled. > This is to prevent the application from retrying to send the same packet > and ending up in a liveloop since the driver will never manage to se

[dpdk-dev] [PATCH 19.11 4/4] drivers: remove duplicated compiler flags

2019-07-25 Thread Bruce Richardson
Now that -Wextra, and other warning flags are standard in the build, remove any duplication in driver build specifications. Signed-off-by: Bruce Richardson --- drivers/net/fm10k/base/meson.build | 2 +- drivers/net/mlx4/meson.build| 1 - drivers/net/mlx5/meson.build| 1 - driver

[dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-25 Thread Bernard Iremonger
Update release notes for changes to the IPsec library. Signed-off-by: Bernard Iremonger --- changes in v3: revised content doc/guides/rel_notes/release_19_08.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_19

[dpdk-dev] [PATCH 19.11 3/4] build: enable extra warnings for meson build

2019-07-25 Thread Bruce Richardson
While meson always adds -Wall flag to C compiles, the make build adds extra warning flags that are not present in the meson build. This addresses that shortcoming by adding additional warning flags to our builds. The one omission is the -Wcast-align flag, which though present in make gcc builds, gi

[dpdk-dev] [PATCH 19.11 2/4] raw/ifpga: remove unneeded compiler flags

2019-07-25 Thread Bruce Richardson
The warning disable flags for the base driver code were copy-pasted from another source, and are actually unnecessary for this driver. Therefore remove them. Signed-off-by: Bruce Richardson --- drivers/raw/ifpga_rawdev/base/meson.build | 11 --- 1 file changed, 11 deletions(-) diff --gi

[dpdk-dev] [PATCH 19.11 1/4] build: allow compile with stricter fallthrough warnings

2019-07-25 Thread Bruce Richardson
DPDK currently compiles with implicit-fallthrough=2 warning level. With gcc -Wextra flag, the default level is 3, so some minor changes are needed to support this in DPDK. Signed-off-by: Bruce Richardson --- drivers/net/bonding/rte_eth_bond_pmd.c | 3 ++- drivers/net/fm10k/base/meson.build |

[dpdk-dev] [PATCH 19.11 0/4] synchronise meson warnings with make

2019-07-25 Thread Bruce Richardson
The warnings used when building DPDK with make were stricter than those used with meson, so this patchset aligns the two as far as is possible, while also adding in -Wextra as a general compile flag. The one difference is that with "make" we allow different flags for GCC and clang, while with meso

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-25 Thread Kusztal, ArkadiuszX
Hi All, > > > I believe there are couple of issues with this patch. > > > > > > Are these experimental APIs? I believe they were made stable this > > > release and I'm not sure if it is a right practice to edit an API > > > without deprecation notice after it is made stable. Especially now > > > t

[dpdk-dev] [PATCH v2] examples/ptpclient: fix delay request message

2019-07-25 Thread Harman Kalra
Observed an issue with the length and domain number of the delay request message sent out by the client. Due to which delay response from master was not received. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Cc: sta...@dpdk.org Signed-off-by: Harman Kalra --- examples/ptpc

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Burakov, Anatoly
On 25-Jul-19 3:01 PM, Lipiec, Herakliusz wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole Sent: Thursday, July 25, 2019 2:28 PM hgovindh writes: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to

Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

2019-07-25 Thread Dybkowski, AdamX
Hi Fiona. > -Original Message- > From: Trahe, Fiona > Sent: Thursday, 25 July, 2019 15:56 > To: Dybkowski, AdamX ; dev@dpdk.org; > akhil.go...@nxp.com > Cc: Trahe, Fiona > Subject: RE: [PATCH] test/compress: fix coverity warnings > > Hi Adam, > > > -Original Message- > > From: D

[dpdk-dev] [PATCH] examples/ptpclient: fix delay request message

2019-07-25 Thread Harman Kalra
Observed an issue with the length and domain number of the delay request message sent out by the client. Due to which delay response from master was not received. Fixes: ab129e9065a5 ("examples/ptpclient: add minimal PTP client") Change-Id: I1031fa630e97709818c4b440e1e5fdc31205ab9c Signed-off-by:

[dpdk-dev] [PATCH v4 0/3] Small usability improvements for devbind

2019-07-25 Thread Anatoly Burakov
Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: ana

[dpdk-dev] [PATCH v4 3/3] usertools/devbind: print all errors to stderr

2019-07-25 Thread Anatoly Burakov
Bring consistency to error messages and output them to stderr. Als, whenever the script tells the user to "check usage", don't tell the user to do it and just display usage instead. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 58 ++- 1 file

[dpdk-dev] [PATCH v4 2/3] usertools/devbind: check if module is loaded before binding

2019-07-25 Thread Anatoly Burakov
Currently, if an attempt is made to bind a device to a driver that is not loaded, a confusing and misleading error message appears. Fix it so that, before binding to the driver, we actually check if it is loaded in the kernel first. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py |

[dpdk-dev] [PATCH v4 1/3] usertools/devbind: add error on forgetting to specify driver

2019-07-25 Thread Anatoly Burakov
A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but people who know how devbind works. Fix this by checking if the driver string is actually a valid device string.

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Govindharajan, Hariprasad
-Original Message- From: Burakov, Anatoly Sent: Thursday, July 25, 2019 3:01 PM To: Aaron Conole ; Govindharajan, Hariprasad Cc: Remy Horton ; Kovacevic, Marko ; Ori Kam ; Richardson, Bruce ; De Lara Guarch, Pablo ; Nicolau, Radu ; Akhil Goyal ; Kantecki, Tomasz ; dev@dpdk.org; st

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Lipiec, Herakliusz
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aaron Conole > Sent: Thursday, July 25, 2019 2:28 PM > hgovindh writes: > > > Fix unaligned memory access when reading IPv6 header which leads to > > segmentation fault by changing aligned memory read to unaligned memory > > read. > > > >

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Burakov, Anatoly
On 25-Jul-19 2:27 PM, Aaron Conole wrote: hgovindh writes: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@

Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

2019-07-25 Thread Trahe, Fiona
Hi Adam, > -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, July 23, 2019 11:54 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] test/compress: fix coverity warnings > > CID 340857: Null pointer dereferences (NULL_RETURNS) >

[dpdk-dev] [PATCH v3 3/3] usertools/devbind: print all errors to stderr

2019-07-25 Thread Anatoly Burakov
Bring consistency to error messages and output them to stderr. Als, whenever the script tells the user to "check usage", don't tell the user to do it and just display usage instead. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 58 ++- 1 file

[dpdk-dev] [PATCH v3 2/3] usertools/devbind: check if module is loaded before binding

2019-07-25 Thread Anatoly Burakov
Currently, if an attempt is made to bind a device to a driver that is not loaded, a confusing and misleading error message appears. Fix it so that, before binding to the driver, we actually check if it is loaded in the kernel first. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py |

[dpdk-dev] [PATCH v3 1/3] usertools/devbind: add error on forgetting to specify driver

2019-07-25 Thread Anatoly Burakov
A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but people who know how devbind works. Fix this by checking if the driver string is actually a valid device string.

[dpdk-dev] [PATCH v3 0/3] Small usability improvements for devbind

2019-07-25 Thread Anatoly Burakov
Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: ana

[dpdk-dev] [PATCH v2 1/3] usertools/devbind: add error on forgetting to specify driver

2019-07-25 Thread Anatoly Burakov
A common user error is to forget driver to which the PCI devices should be bound to. Currently, the error message in this case looks unhelpful misleading and indecipherable to anyone but people who know how devbind works. Fix this by checking if the driver string is actually a valid device string.

[dpdk-dev] [PATCH v2 3/3] usertools/devbind: print all errors to stderr

2019-07-25 Thread Anatoly Burakov
Bring consistency to error messages and output them to stderr. Als, whenever the script tells the user to "check usage", don't tell the user to do it and just display usage instead. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py | 58 ++- 1 file

[dpdk-dev] [PATCH v2 0/3] Small usability improvements for devbind

2019-07-25 Thread Anatoly Burakov
Over the course of using devbind, i find myself frequently bumping up against two common errors (with the assumption being that i'm not the only person who hits these errors). First happens when i forget to specify the driver. The error message in this case looks something like the following: ana

[dpdk-dev] [PATCH v2 2/3] usertools/devbind: check if module is loaded before binding

2019-07-25 Thread Anatoly Burakov
Currently, if an attempt is made to bind a device to a driver that is not loaded, a confusing and misleading error message appears. Fix it so that, before binding to the driver, we actually check if it is loaded in the kernel first. Signed-off-by: Anatoly Burakov --- usertools/dpdk-devbind.py |

[dpdk-dev] [PATCH v4 2/2] vhost: Add vhost-user-blk example which support inflight

2019-07-25 Thread JinYu
A vhost-user-blk example that support inflight feature. It uses the new APIs that introduced in the first patch, so It can show how there APIs work to support inflight feature. Signed-off-by: Jin Yu --- V1 - add the case. V2 - add the rte_vhost prefix. V3 - add packed ring support --- examples/v

[dpdk-dev] [PATCH v4 1/2] vhost: support inflight share memory protocol feature

2019-07-25 Thread JinYu
This patch introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Firstly, qemu uses VHOST_USER_GET_INFLIGHT_FD to get the shared buffer from backend. Then qemu should send it back through VHOST_USER_S

[dpdk-dev] [PATCH v4 0/2] *** vhost support inflight share memory protocol feature ***

2019-07-25 Thread JinYu
This patches introduces two new messages VHOST_USER_GET_INFLIGHT_FD and VHOST_USER_SET_INFLIGHT_FD to support transferring a shared buffer between qemu and backend. Now It can both support split and packed ring. The example code show how these API work. JinYu (2): vhost: support inflight share

Re: [dpdk-dev] [PATCH] examples/l3fwd: fix unaligned memory access

2019-07-25 Thread Aaron Conole
hgovindh writes: > Fix unaligned memory access when reading IPv6 header which > leads to segmentation fault by changing aligned memory read > to unaligned memory read. > > Bugzilla ID: 279 > Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") > Cc: maciej.cze...@caviumnetworks.com > Cc: sta...@

Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning

2019-07-25 Thread Trahe, Fiona
Including Sunila, the zlib PMD maintainer. > -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, July 24, 2019 9:43 AM > To: dev@dpdk.org; Trahe, Fiona ; > shally.ve...@caviumnetworks.com > Cc: Dybkowski, AdamX > Subject: [PATCH] compress/zlib: fix coverity warning > > Add mi

[dpdk-dev] [PATCH v2] doc: release note for the IPsec library

2019-07-25 Thread Bernard Iremonger
Update release notes for changes to the IPsec library. Signed-off-by: Bernard Iremonger --- changes in v2: revised content. doc/guides/rel_notes/release_19_08.rst | 8 1 file changed, 8 insertions(+) diff --git a/doc/guides/rel_notes/release_19_08.rst b/doc/guides/rel_notes/release_1

Re: [dpdk-dev] [PATCH v7 1/1] app/test-compress-perf: provide more detailed report

2019-07-25 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Wednesday, July 24, 2019 2:55 PM > To: dev@dpdk.org; Trahe, Fiona > Cc: Trybula, ArturX ; Dybkowski, AdamX > > Subject: [PATCH v7 1/1] app/test-compress-perf: provide more detailed report > > From: Artur Trybula > > This patch a

[dpdk-dev] [RFC] ethdev: extend RSS offload types

2019-07-25 Thread simei
From: Simei Su This RFC reserves several bits as input set selection from bottom of the 64 bits. The flow type is combined with input set to represent rss types. for example: ETH_RSS_IPV4 | ETH_RSS_L3_SRC_ONLY: hash on src ip address only ETH_RSS_IPV4_UDP | ETH_RSS_L4_DST_ONLY: hash on s

Re: [dpdk-dev] [dpdk-stable] [PATCH v2 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-25 Thread David Marchand
On Thu, Jul 25, 2019 at 2:05 PM David Marchand wrote: > > Two cores can send multi segment packets on two different pcap ports. > Because of this, we can't have one single buffer to linearize packets. > > Use rte_pktmbuf_read() to copy the packet into a buffer on the stack > and remove eth_pcap_ga

[dpdk-dev] [PATCH v2 2/3] net/pcap: fix transmit return count in error conditions

2019-07-25 Thread David Marchand
When a packet cannot be transmitted, the driver is supposed to free this packet and report it as handled. This is to prevent the application from retrying to send the same packet and ending up in a liveloop since the driver will never manage to send it. Fixes: 49a0a2ffd5db ("net/pcap: fix possible

[dpdk-dev] [PATCH v2 1/3] net/pcap: fix Rx with small buffers

2019-07-25 Thread David Marchand
If the pkt pool contains only buffers smaller than the default headroom, then the driver will compute an invalid buffer size (negative value cast to an uint16_t). Rely on the mbuf api to check how much space is available in the mbuf. Fixes: 6eb0ae218a98 ("pcap: fix mbuf allocation") Cc: sta...@dpd

[dpdk-dev] [PATCH v2 3/3] net/pcap: fix concurrent multiseg packet transmits

2019-07-25 Thread David Marchand
Two cores can send multi segment packets on two different pcap ports. Because of this, we can't have one single buffer to linearize packets. Use rte_pktmbuf_read() to copy the packet into a buffer on the stack and remove eth_pcap_gather_data() when necessary (if the mbuf is contiguous, rte_pktmbuf

[dpdk-dev] [PATCH v2 0/3] Multiseg fixes for pcap pmd

2019-07-25 Thread David Marchand
Here are some fixes caught while looking at oerrors statistics for this driver. The second patch can be seen as a revert or a followup of [1]. 1: https://git.dpdk.org/dpdk/commit/?id=49a0a2ffd5db Changelog since v1: - comments from Ferruh on patch2, - little simplification in patch3, -- David M

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-25 Thread Shally Verma
> -Original Message- > From: Akhil Goyal > Sent: Thursday, July 25, 2019 5:13 PM > To: Shally Verma ; Anoob Joseph > ; Ayuj Verma > Cc: arkadiuszx.kusz...@intel.com; Sunila Sahu ; Kanaka > Durga Kotamarthy ; dev@dpdk.org; Fiona > Trahe > Subject: RE: [PATCH v1 0/2] declare crypto asym

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-25 Thread Akhil Goyal
> > Hi Akhil > > > > > Hi Anoob/Shally > > > > > > > > > > Hi Ayuj, > > > > > > > > I believe there are couple of issues with this patch. > > > > > > > > Are these experimental APIs? I believe they were made stable this > > > > release and I'm not sure if it is a right practice to edit an API

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-25 Thread Shally Verma
Hi Akhil > -Original Message- > From: Akhil Goyal > Sent: Thursday, July 25, 2019 4:58 PM > To: Anoob Joseph ; Shally Verma > ; Ayuj Verma > Cc: arkadiuszx.kusz...@intel.com; Sunila Sahu ; Kanaka > Durga Kotamarthy ; dev@dpdk.org; Fiona > Trahe > Subject: RE: [PATCH v1 0/2] declare cryp

Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable

2019-07-25 Thread Akhil Goyal
Hi Anoob/Shally > > > > Hi Ayuj, > > > > I believe there are couple of issues with this patch. > > > > Are these experimental APIs? I believe they were made stable this release > > and I'm not sure if it is a right practice to edit an API without > > deprecation > > notice after it is made stable

[dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-07-25 Thread Hemant Agrawal
When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws compilation error virtio_ethdev.c:1851:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’ RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM < sizeof(struct virtio_net_hdr_mrg_rxbuf)); This patch change it into run-time check. Reported as

[dpdk-dev] [PATCH BUG 335 1/3] net/dpaa: fix compilation error with 0 headroom

2019-07-25 Thread Hemant Agrawal
When using RTE_PKTMBUF_HEADROOM as 0, dpaa driver throws compilation error error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" This patch change it into run-time check. Reported as: https://bugs.dpdk.org/show_bug.cgi?id=335 Fixes: ff9e112d7870 ("net/dpaa: add NXP DPAA PMD driver skel

[dpdk-dev] [PATCH BUG 335 2/3] bus/fslmc: fix compilation error with 0 headroom

2019-07-25 Thread Hemant Agrawal
When using RTE_PKTMBUF_HEADROOM as 0, dpaa driver throws compilation error error "Annotation requirement is more than RTE_PKTMBUF_HEADROOM" This patch change it into run-time check. Reported as: https://bugs.dpdk.org/show_bug.cgi?id=335 Fixes: beb2a7865dda ("bus/fslmc: define hardware annotation

  1   2   >