On 7/25/2019 10:14 AM, David Marchand wrote:
> err_pkts reflects the number of packets that the driver did not manage to
> send.
> This is a temporary situation, those packets are not freed and the
> application can still retry to send them later.
> Hence, we can't count them as transmit failed.
'err_pkts' seems calculated wrong both in Rx & Tx and KNI PMD, looks like we can
remove it completely, what do you think?
>
> Fixes: 75e2bc54c018 ("net/kni: add KNI PMD")
> Cc: sta...@dpdk.org
>
> Signed-off-by: David Marchand <david.march...@redhat.com>
> ---
> drivers/net/kni/rte_eth_kni.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c
> index 9e0c6bd..8026566 100644
> --- a/drivers/net/kni/rte_eth_kni.c
> +++ b/drivers/net/kni/rte_eth_kni.c
> @@ -270,7 +270,6 @@ eth_kni_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
> unsigned long rx_packets_total = 0, rx_bytes_total = 0;
> unsigned long tx_packets_total = 0, tx_bytes_total = 0;
> struct rte_eth_dev_data *data = dev->data;
> - unsigned long tx_packets_err_total = 0;
> unsigned int i, num_stats;
> struct pmd_queue *q;
>
> @@ -292,14 +291,12 @@ eth_kni_stats_get(struct rte_eth_dev *dev, struct
> rte_eth_stats *stats)
> stats->q_obytes[i] = q->tx.bytes;
> tx_packets_total += stats->q_opackets[i];
> tx_bytes_total += stats->q_obytes[i];
> - tx_packets_err_total += q->tx.err_pkts;
> }
>
> stats->ipackets = rx_packets_total;
> stats->ibytes = rx_bytes_total;
> stats->opackets = tx_packets_total;
> stats->obytes = tx_bytes_total;
> - stats->oerrors = tx_packets_err_total;
>
> return 0;
> }
>
