>
> Hi Akhil
>
> >
> > Hi Anoob/Shally
> >
> > > >
> > > > Hi Ayuj,
> > > >
> > > > I believe there are couple of issues with this patch.
> > > >
> > > > Are these experimental APIs? I believe they were made stable this
> > > > release and I'm not sure if it is a right practice to edit an API
> > > > without deprecation notice after it is made stable. Especially now
> > > > that RC2 is done. @Akhil, what is your take on this?
> > > > [Shally] These are experimental still, hence no deprecation notice.
> > > > We checked about it with Fiona, Akhil before.
> > >
> > > [Anoob] In the patch, the edited APIs doesn't have experimental tag. I
> > > leave it to Akhil's judgement on this.
> > >
> > The API is experimental. Check the .map file.
> >
> > But these kind of patches cannot go in 1908 release, as we have already
> > tagged it for RC2.
> > We need to defer this change for 19.11 release.
> >
> [Shally] Well. Cant do anything if we have missed deadline here. Right now
> its up
> for feedback.
> Meanwhile if we get any agreement and window gets open for nearest release,
> then please consider it.
library changes cannot go beyond RC2 unless it is a fix for some issue.
>
> > One more issue that I see in this patch. QAT also uses these APIs, so it
> > shall
> > also be modified along with openssl.
> >
> [Shally] We assume QAT changes will be done by QAT maintainer, once they
> review and approve this change.
>
Patch 1/2 will break the compilation for QAT and openssl.
All changes should be part of a single patch (both for QAT and openssl).
If somebody is modifying the common code, then it should not atleast break the
compilation.
Check the following commit.
http://git.dpdk.org/next/dpdk-next-crypto/commit/?id=186b14d6850654eb84a8ae9ea29b736f0ba5e093
-Akhil
