Re: [dpdk-dev] [EXT] Re: ABI and inline functions

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, April 18, 2019 12:21 AM > To: Jerin Jacob Kollanukkaran > Cc: Bruce Richardson ; Honnappa Nagarahalli > ; dev@dpdk.org; Ananyev, Konstantin > ; tho...@monjalon.net; Ray Kinsella > ; nd > Subject: [EXT] Re: [dpdk-dev] ABI

[dpdk-dev] [PATCH] net/i40e: fix print of not supported admin queue msg

When launch testpmd with VF and quit testpmd, there'll be lots of messages "i40evf_handle_aq_msg(): Request 0 is not supported yet", which are triggered during VF reset and VF needn't do anything. So cancel alarm handler before VF reset to ignore the admin queue messages. Fixes: e0e6a7f2154e ("net

[dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE

Enable CLEARPBA bit is required by ice NIC of A0/A1 version to enable Tx and Rx queue interrupt. Also enable CLEARPBA bit does no impact on IAVF behaviour when be hosted by other devices, so we can make it as default. Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") Cc: sta...@dpdk.org Signed

[dpdk-dev] [PATCH v2] crypto/octeontx: use distinct metabuf pool for each queue

The metabuf pool is shared across all queue pairs belonging to the PMD. In order to prevent one queue pair from starving another, use a distinct mempool for each queue pair. Fixes: 273487f7b381 ("crypto/octeontx: add global resource init") Signed-off-by: Anoob Joseph --- v2: * Mail server conver

Re: [dpdk-dev] [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

Hi Yongseok, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:28 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch > > On

Re: [dpdk-dev] [PATCH 8/9] net/mlx5: add Forward Database table type

Hi Yongseok, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:16 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 8/9] net/mlx5: add Forward Database table type > > On Sun, Apr

Re: [dpdk-dev] [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs

Hi Yongseok, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:00 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs > > On Sun, Ap

Re: [dpdk-dev] [PATCH v2 2/4] meson: change default cache line size for armv8

> > Currently, the cache line size of armv8 CPUs having Implementor ID of 0x41 is > 64 bytes. I guess you meant to say 128 bytes > > Signed-off-by: Yongseok Koh > --- > > v2: > * introduce flags_arm replacing flags_generic instead of using the extra flags > > config/arm/meson.build | 7 +

Re: [dpdk-dev] [PATCH 6/9] net/mlx5: add transfer attribute to matcher

Hi Yongseok, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 3:39 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 6/9] net/mlx5: add transfer attribute to matcher > > On Sun, Ap

Re: [dpdk-dev] [PATCH 5/9] net/mlx5: add port ID item to Direct Verbs

Hi Yongseok, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 3:20 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 5/9] net/mlx5: add port ID item to Direct Verbs > > On Sun, Apr

Re: [dpdk-dev] [PATCH 4/9] net/mlx5: add validation for Direct Rule E-Switch

Hi Koh, PSB > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 3:00 AM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH 4/9] net/mlx5: add validation for Direct Rule E-Switch > > On Sun, Ap

Re: [dpdk-dev] ABI and inline functions

> > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: > > Hello, > > There was a conversation [1] in the context of RCU library. I thought > > it needs participation from broader audience. Summary for the context > > (please look at [1] for full details) > > > > Thanks for

Re: [dpdk-dev] [PATCH v1] lib/crypto: fix alphabetical ordering of headers

Hi Ayuj, Akhil, Fiona, Shally, I think there are couple of issues with this patch. The real issue here is the dependency of rte_crypto_asym.h on rte_crypto_sym.h. If rte_crypto_asym.h doesn't include all the headers it uses, every file which includes rte_crypto_asym.h will have to include rte_c

[dpdk-dev] [PATCH] crypto/octeontx: use distinct metabuf pool for each queue

The metabuf pool is shared across all queue pairs belonging to the PMD. In order to prevent one queue pair from starving another, use a distinct mempool for each queue pair. Fixes: 273487f7b381 ("crypto/octeontx: add global resource init") Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_

[dpdk-dev] [Bug 256] Transmit or receive packets use the bond MAC is failed when switch backup port to active

https://bugs.dpdk.org/show_bug.cgi?id=256 Bug ID: 256 Summary: Transmit or receive packets use the bond MAC is failed when switch backup port to active Product: DPDK Version: 18.11 Hardware: All OS: All

[dpdk-dev] [PATCH v2 2/4] meson: change default cache line size for armv8

Currently, the cache line size of armv8 CPUs having Implementor ID of 0x41 is 64 bytes. Signed-off-by: Yongseok Koh --- v2: * introduce flags_arm replacing flags_generic instead of using the extra flags config/arm/meson.build | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --

[dpdk-dev] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64 Fixes: bd77f2d64c44 ("event/octeontx: build with meson") Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc:

[dpdk-dev] [PATCH v2 4/4] meson: add Mellanox BlueField cross-compile config

Mellanox BlueField is armv8 CPU having cortex-a72. The implementor ID is 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). Signed-off-by: Yongseok Koh Acked-by: Jerin Jacob --- config/arm/arm64_bluefield_linux_gcc | 16 1 file changed, 16 insertions(+) create mode

[dpdk-dev] [PATCH v2 3/4] net/mlx: fix library search in meson build

If MLNX_OFED is installed, there's no .pc file installed for libraries and dependency() can't find libraries by pkg-config. By adding fallback of using cc.find_library(), libraries are properly located. Fixes: e30b4e566f47 ("build: improve dependency handling") Cc: bl...@debian.org Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH 1/4] meson: disable octeontx for buggy compilers on arm64

Please disregard this one. Sent by mistake. Thanks, Yongseok > On Apr 17, 2019, at 6:40 PM, Yongseok Koh wrote: > > Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler > error" for aarch64 > > Fixes: bd77f2d64c44 ("event/octeontx: build with meson") > Fixes: 4f760550a093

[dpdk-dev] [PATCH 1/4] meson: disable octeontx for buggy compilers on arm64

Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64 Fixes: bd77f2d64c44 ("event/octeontx: build with meson") Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc:

Re: [dpdk-dev] [PATCH 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

On Sun, Apr 14, 2019 at 09:12:37PM +, Ori Kam wrote: > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/mlx5/mlx5_flow_dv

[dpdk-dev] [PATCH] net/ice: fix coverity issues

Fix the issues reported by Coverity check, "Null-checking vsi suggests that it may be null, but it has already been dereferenced on all paths leading to the check." Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") Fixes: ff963bfa7cb1 ("net/ice: support RSS") Cc: sta...@dpdk.org Signed-off-by: We

Re: [dpdk-dev] [PATCH 8/9] net/mlx5: add Forward Database table type

On Sun, Apr 14, 2019 at 09:12:36PM +, Ori Kam wrote: > Actions like encap/decap, modify header require setting the flow table > type. Until now we supported only Nic RX and Nic TX, this commits adds > the support for FDB table type for those actions. > > Signed-off-by: Ori Kam > --- > driver

Re: [dpdk-dev] [BUG] net/af_xdp: Current code can only create one af_xdp device

Hi, Markus On 04/17, Markus Theil wrote: >I tested the new af_xdp based device on the current master branch and >noticed, that the usage of static mempool names allows only for the >creation of a single af_xdp vdev. If a second vdev of the same type gets >created, the mempool allocation fails. Th

Re: [dpdk-dev] [PATCH 7/9] net/mlx5: add port ID action to Direct Verbs

On Sun, Apr 14, 2019 at 09:12:35PM +, Ori Kam wrote: > This commits adds the port ID action to DV steering. Poor title and commit message. Don't you add translation of the action? Thanks, Yongseok > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/

Re: [dpdk-dev] [PATCH 6/9] net/mlx5: add transfer attribute to matcher

On Sun, Apr 14, 2019 at 09:12:34PM +, Ori Kam wrote: > In current implementation the DV steering supported only NIC steering. > This commit adds the transfer attribute in order to create a matcher > on the FDB tabels. > > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/mlx5_flow.c| 1 +

[dpdk-dev] [PATCH] eal: promote some experimental functions as stable

The function rte_eal_cleanup() was introduced more than one year ago, in DPDK 18.02. It is no longer experimental, allowing pdump, proc-info and hotplug_mp apps to not need any experimental API. The function rte_ctrl_thread_create() was introduced one year ago in DPDK 18.05. It is no longer experi

Re: [dpdk-dev] [PATCH 5/9] net/mlx5: add port ID item to Direct Verbs

On Sun, Apr 14, 2019 at 09:12:33PM +, Ori Kam wrote: > Adds the port ID item to the DV steering code. > > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/mlx5_flow_dv.c | 86 > ++--- > 1 file changed, 63 insertions(+), 23 deletions(-) > > diff --git a/dr

[dpdk-dev] [PATCH] net/mlx5: replace a port lookup with ethdev API

Looking for an ethdev port is better (and more efficient) with an ethdev API than an EAL one. Signed-off-by: Thomas Monjalon --- drivers/net/mlx5/mlx5_mr.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c ind

Re: [dpdk-dev] [PATCH 4/9] net/mlx5: add validation for Direct Rule E-Switch

On Sun, Apr 14, 2019 at 09:12:32PM +, Ori Kam wrote: > Add validation logic for E-Switch using Direct Rules. > > Signed-off-by: Ori Kam > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_ethdev.c | 39 +++ > drivers/net/mlx5/mlx5_flow.h| 5 + > drivers/net/m

[dpdk-dev] [PATCH 2/2] ethdev: promote function for port count as stable

The function rte_eth_dev_count_total() was introduced one year ago in the release 18.05. It can be declared non experimental in 19.05. Signed-off-by: Thomas Monjalon --- lib/librte_ethdev/rte_ethdev.c | 2 +- lib/librte_ethdev/rte_ethdev.h | 2 +- lib/librte_ethdev/rte_ethdev

[dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

Some port iterations are manually checking against RTE_ETH_DEV_UNUSED instead of using the iterators based on rte_eth_find_next(). A new macro RTE_ETH_FOREACH_VALID_DEV() is introduced, but kept private because there should be no need of iterating over all devices in the API. The public iterators

Re: [dpdk-dev] [PATCH 0/6] build: fix build for arm64

> On Apr 17, 2019, at 1:06 PM, Thomas Monjalon wrote: > > 13/04/2019 01:24, Yongseok Koh: >> This patchset depends on >> "meson: add infra to support machine specific flags" [1] >> >> [1] >> https://eur03.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatches.dpdk.org%2Fpatch%2F52606%2F&dat

Re: [dpdk-dev] [PATCH v4] build: use generic march on arm64 when using 'default' machine

20/03/2019 14:18, luca.bocca...@gmail.com: > From: Luca Boccassi > > When building for generic distribution we need a stable baseline > architecture, or depending on the build worker the result will vary. > > Force the default flags if the user explicitly sets machine=default > at configuration

Re: [dpdk-dev] [PATCH 0/6] build: fix build for arm64

> > 13/04/2019 01:24, Yongseok Koh: > > This patchset depends on > > "meson: add infra to support machine specific flags" [1] > > > > [1] http://patches.dpdk.org/patch/52606/ > > > > Yongseok Koh (6): > > meson: disable octeontx for buggy compilers on arm64 > > meson: change default cache line

Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

14/01/2019 14:41, Luca Boccassi: > Document the new value, as it's useful for distributions and users > who need to use a stable baseline -march > > Signed-off-by: Luca Boccassi > Reviewed-by: Christian Ehrhardt > --- > +NOTE: machine=default will use the minimum required -march on all > archit

Re: [dpdk-dev] [PATCH 0/6] build: fix build for arm64

13/04/2019 01:24, Yongseok Koh: > This patchset depends on > "meson: add infra to support machine specific flags" [1] > > [1] http://patches.dpdk.org/patch/52606/ > > Yongseok Koh (6): > meson: disable octeontx for buggy compilers on arm64 > meson: change default cache line size for cortex-a7

[dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

According to RTE flow the action order should be the order that the actions were given. In the case of modify actions the position of the action was always last. This commit solves this issue by saving the position of the first modify action, and then adds to this position the pointer to the modif

Re: [dpdk-dev] [PATCH v5 0/2] Timer library changes

15/04/2019 23:41, Erik Gabriel Carrillo: > This patch series modifies the timer library in such a way that > structures that used to be statically allocated in a process's data > segment are now allocated in shared memory. As these structures contain > lists of timers, new APIs are introduced that

Re: [dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value

Acked-by: Rami Rosen

Re: [dpdk-dev] ABI and inline functions

On Wed, 17 Apr 2019 17:46:34 + Jerin Jacob Kollanukkaran wrote: > > -Original Message- > > From: dev On Behalf Of Bruce Richardson > > Sent: Wednesday, April 17, 2019 2:07 PM > > To: Honnappa Nagarahalli > > Cc: dev@dpdk.org; Stephen Hemminger ; > > Ananyev, Konstantin ; tho...@monj

[dpdk-dev] [PATCH] bus/vmbus: fix resource leak on error

If secondary process attempt to mmap the resource resulted in the wrong address, then it would leave behind the bad mmap. Coverity issue: 337675, 337664 Signed-off-by: Stephen Hemminger --- drivers/bus/vmbus/linux/vmbus_uio.c | 4 +++- drivers/bus/vmbus/vmbus_common_uio.c | 4 +++- 2 files chan

Re: [dpdk-dev] ABI and inline functions

> -Original Message- > From: dev On Behalf Of Bruce Richardson > Sent: Wednesday, April 17, 2019 2:07 PM > To: Honnappa Nagarahalli > Cc: dev@dpdk.org; Stephen Hemminger ; > Ananyev, Konstantin ; tho...@monjalon.net; > Ray Kinsella ; nd > Subject: Re: [dpdk-dev] ABI and inline functions

Re: [dpdk-dev] [PATCH v2 2/7] net/atlantic: enable macsec configuration

On 4/17/2019 4:45 PM, Igor Russkikh wrote: > From: Pavel Belous > > This is a driver side of macsec configuration routines. > It fills in config structures and sends requests to FW > for configuration activities. > > We declare macsec offload bits in DPDK offload capabilities. > > Also update d

Re: [dpdk-dev] [PATCH v5 1/2] timer: allow timer management in shared memory

15/04/2019 23:41, Erik Gabriel Carrillo: > --- a/lib/librte_timer/Makefile > +++ b/lib/librte_timer/Makefile > +CFLAGS += -DALLOW_EXPERIMENTAL_API You forgot the same for meson: allow_experimental_apis = true

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

On Wed, 17 Apr 2019 02:36:27 +0200 Thomas Monjalon wrote: > As stated in the deprecation notice from December 2016, > "the legacy filter API, including rte_eth_dev_filter_supported(), > rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHERTYPE, > FLEXIBLE, SYN, NTUPLE, TUNNEL, FDIR, HA

Re: [dpdk-dev] ABI and inline functions

On Wed, 17 Apr 2019 09:36:38 +0100 Bruce Richardson wrote: > > > > Coming to 1), I think DPDK cannot provide ABI compatibility unless all the > > inline functions are converted to normal functions and symbol versioning is > > done for those (not bothering about performance). > > > I disagre

Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd

On 4/17/2019 3:02 PM, David Marchand wrote: > On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye > wrote: > > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested

Re: [dpdk-dev] [PATCH] devargs: remove experimental from APIs

05/04/2019 10:17, Gaëtan Rivet: > On Thu, Apr 04, 2019 at 10:10:15AM -0700, Stephen Hemminger wrote: > > On Thu, 4 Apr 2019 11:45:45 + > > Hemant Agrawal wrote: > > > > > These APIs are available in DPDK for last 4 releases > > > and used by multiple drivers. > > > > > > Cc: gaetan.ri...@6wi

Re: [dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

On Wed, Apr 17, 2019 at 06:17:06PM +0200, Thomas Monjalon wrote: > 09/04/2019 12:55, Bruce Richardson: > > --- a/devtools/test-meson-builds.sh > > +++ b/devtools/test-meson-builds.sh > > -set -o pipefail > > +# this option gives an error on BSD > > +if [ "`uname`" = "Linux" ] ; then > > + set -o

Re: [dpdk-dev] [EXT] [PATCH 5/6] build: add option for armv8 crypto extension

On Apr 15, 2019, at 1:13 PM, Honnappa Nagarahalli wrote: Subject: [EXT] [PATCH 5/6] build: add option for armv8 crypto extension CONFIG_RTE_MACHINE="armv8a" +CONFIG_RTE_ENABLE_ARMV8_CRYPTO=y >>> >>> This approach is not scalable. Even, it is not good for BlueField as

Re: [dpdk-dev] [PATCH] build: automatically create windows exports file

13/04/2019 00:56, Anand Rawat: > On 4/12/2019 1:29 AM, Bruce Richardson wrote: > > Rather than having a separate version.map file for linux/BSD and an > > exports definition file for windows for each library, generate the > > latter from the former automatically at build time. > > > > Signed-off-b

Re: [dpdk-dev] [PATCH v2 0/5] small cleanup and fixes

09/04/2019 12:55, Bruce Richardson: > Made some small changes to meson to shorten the code and increase > readability. While testing, found a number of issues on FreeBSD builds, > which are fixed in this set too. > > Bruce Richardson (5): > build: simplify subdirectory detection for EAL > buil

Re: [dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

09/04/2019 12:55, Bruce Richardson: > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > -set -o pipefail > +# this option gives an error on BSD > +if [ "`uname`" = "Linux" ] ; then > + set -o pipefail > +fi I think this is a bash option. We may require bash at the top

[dpdk-dev] [PATCH v2] cryptodev: add an option to support both iv and J0 for GCM

This patch adds an option to support both IV (of all supported sizes) and J0 when using Galois Counter Mode of crypto operation. Signed-off-by: Arek Kusztal --- Note: This patch is intended for 19.08 release lib/librte_cryptodev/rte_crypto_sym.h | 37 ++- 1 file

[dpdk-dev] [PATCH v2 6/7] net/atlantic: bump internal driver version

Version is synced with internal Aquantia's driver versioning Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atlantic/atl_common.h b/drivers/net/atlantic/atl_common.h

[dpdk-dev] [PATCH v2 7/7] net/atlantic: public experimental macsec API

Add public visible macsec API functions. These are wrappers over internal configuration routines, validating and converting port no into dev pointer Signed-off-by: Igor Russkikh --- drivers/net/atlantic/Makefile | 1 + drivers/net/atlantic/meson.build | 1 + driv

[dpdk-dev] [PATCH v2 5/7] net/atlantic: implement macsec statistics

From: Pavel Belous We add extra xstat fields to include macsec counters and stats Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 82 +-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/net/atl

[dpdk-dev] [PATCH v2 4/7] net/atlantic: interrupt handling of macsec events

From: Pavel Belous MACSEC should be configured only after link up event, thus we use link interrupt to file an alarm for configuration. FW also uses link interrupt line to indicate incoming events from MACSEC. These may include key expiration, packet counter wrap, etc. We pass these events to th

[dpdk-dev] [PATCH v2 3/7] net/atlantic: macsec firmware interface

From: Pavel Belous Implementation of firmware interface for macsec configuration. Structure with config data is written into FW memory, then we trigger FW to execute the request and wait for result. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_types.h

[dpdk-dev] [PATCH v2 2/7] net/atlantic: enable macsec configuration

From: Pavel Belous This is a driver side of macsec configuration routines. It fills in config structures and sends requests to FW for configuration activities. We declare macsec offload bits in DPDK offload capabilities. Also update documentation with feature matrix for the enabled feature. Si

[dpdk-dev] [PATCH v2 0/7] add MACSEC hw offload to atlantic PMD

This patchset implements MACSEC hardware offload configuration in Atlantic PMD via experimental PMD API. There is an agreement to work on 19.08 timeframe for the generic MACSEC API inside of rte_security. v2 changes: - Removed public API changes for macsec, leave only PMD experimental API for M

[dpdk-dev] [PATCH v2 1/7] net/atlantic: macsec hardware structures declaration

From: Pavel Belous Here we define hardware and software configuration structures for macsec interface. MACSEC itself is implemented in Phy module, but its configuration is done via firmware interface Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_types.h

Re: [dpdk-dev] [PATCH] cryptodev: add an option to support both iv and J0 for GCM

Hi Fiona, > [Fiona] IVs greater than 16 bytes can be used, right? If so change to "a > minimum of 16 bytes must be >allocated". Same below. [AK] - yes, this comment may be misleading, of course it means 16 bytes minimum. This is because of legacy reasons, i.e. aesni-gcm once had formation of p

Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd

On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > >> This patchset provides some fixes to af_xdp pmd, at first, I just added >> a simple error handling when Tx queue allocation fails, then David >> suggested a better way to do it and pointed out the inconsistent

Re: [dpdk-dev] [EXT] Re: [RFC 3/3] ci: enable tests on non-arm platforms

> -Original Message- > From: Aaron Conole > Sent: Wednesday, April 17, 2019 6:10 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 3/3] ci: enable tests on non-arm platforms > > -

Re: [dpdk-dev] [PATCH v4 4/4] net/af_xdp: fix typos in Rx function

Acked-by: Rami Rosen

[dpdk-dev] [PATCH] lib/bitratestats: fix unchecked return value

Checking the return value of rte_metrics_update_values, if failed returning that value. Coverity had picked up that that the return value wasn't being checked. Coverity issue: 336863 Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Cc: remy.hor...@intel.com Signed-off-by: Andrius S

Re: [dpdk-dev] [PATCH 0/3] fix test-meson-builds for older distros

11/04/2019 10:48, Luca Boccassi: > On Wed, 2019-04-10 at 21:52 +0100, Bruce Richardson wrote: > > In order to ensure good test coverage, we sometimes need to run > > builds > > on distros with older compilers, such as gcc 4.8 on RHEL/Centos 7. > > This > > patchset does a small amount of clean-up t

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers

On Wed, Apr 17, 2019 at 04:59:53PM +0200, Thomas Monjalon wrote: > 10/04/2019 22:52, Bruce Richardson: > > if either gcc or clang are missing, skip doing those builds. > > This allows a setup to only do, e.g. gcc tests. > > > > CC: sta...@dpdk.org > > Signed-off-by: Bruce Richardson > > --- > > -

Re: [dpdk-dev] [dpdk-stable] [PATCH 1/3] devtools/test-meson-builds: skip missing compilers

10/04/2019 22:52, Bruce Richardson: > if either gcc or clang are missing, skip doing those builds. > This allows a setup to only do, e.g. gcc tests. > > CC: sta...@dpdk.org > Signed-off-by: Bruce Richardson > --- > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > # sha

[dpdk-dev] [PATCH 8/8] ipc: fix net/mlx5 memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 7/8] ipc: fix net/mlx4 memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH v3] net/bonding: fix potential out of bounds read

Add validation to pointer constructed from the IPv4 header length in order to prevent malformed packets from generating a potential out of bounds memory read. Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- v2: add fixes lines

[dpdk-dev] [PATCH 6/8] ipc: fix tap pmd memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 5/8] ipc: fix pdump memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 4/8] ipc: fix vfio memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 3/8] ipc: fix vdev memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 2/8] ipc: fix hotplug memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

[dpdk-dev] [PATCH 1/8] ipc: fix rte_mp_request_sync memleak

When sending multiple requests, rte_mp_request_sync can succeed sending a few of those requests, but then fail on a later one and in the end return with rc=-1. The upper layers - e.g. device hotplug - currently handles this case as if no messages were sent and no memory for response buffers was all

Re: [dpdk-dev] [PATCH v2] net/bonding: fix potential out of bounds read

On 4/17/2019 10:33 AM, Radu Nicolau wrote: > Add validation to pointer constructed from the IPv4 header length > in order to prevent malformed packets from generating a potential > out of bounds memory read. > > Fixes: 09150784a776 ("net/bonding: burst mode hash calculation") > Cc: sta...@dpdk.org

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

17/04/2019 15:39, Ananyev, Konstantin: > In general, I still think that sync primitives better to stay inlined - there > is no much point to create ones > and then figure out that no-one using them because they are too slow. > Though if there is no real perf difference between inlined and normal -

Re: [dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd

On Wed, Apr 17, 2019 at 3:55 PM Xiaolong Ye wrote: > This patchset provides some fixes to af_xdp pmd, at first, I just added > a simple error handling when Tx queue allocation fails, then David > suggested a better way to do it and pointed out the inconsistent issue > of reserve/submit ops (for T

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

> > > > > > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I > > > > > > > > > > > > > think you need to get rid of almost all use of > > > > > > > > > > > > > inline and visible structures. Yes it might be > > > > > > > > > > > > > marginally slower, but you tha

[dpdk-dev] [PATCH v4 0/4] some fixes for AF_XDP pmd

This patchset provides some fixes to af_xdp pmd, at first, I just added a simple error handling when Tx queue allocation fails, then David suggested a better way to do it and pointed out the inconsistent issue of reserve/submit ops (for Tx queue) and peek/release ops (for Rx queue), the third patch

[dpdk-dev] [PATCH v4 2/4] net/af_xdp: specify minimal and maximal MTU

Properly report mtu capability in port device info. Reported-by: David Marchand Reviewed-by: David Marchand Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_et

[dpdk-dev] [PATCH v4 1/4] net/af_xdp: enqueue buf ring when allocate Tx queue fails

When it fails to allocate enough slots in Tx queue for transmitting packets, we need to return the dequeued addrs to buf ring. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reviewed-by: David Marchand Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + 1 file c

[dpdk-dev] [PATCH v4 3/4] net/af_xdp: make reserve/submit peek/release consistent

As David pointed out, if we reserve N slots for Tx, but only submit n slots, we would end up with an incorrect opinion of the number of available slots later, we also would get wrong idx when we call xsk_ring_prod__reserve next time. It also applies to xsk_ring_cons__peek()/xsk_ring_cons__release()

[dpdk-dev] [PATCH v4 4/4] net/af_xdp: fix typos in Rx function

We should use ETH_AF_XDP_RX_BATCH_SIZE in Rx function rather than ETH_AF_XDP_TX_BATCH_SIZE. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Reported-by: David Marchand Reviewed-by: David Marchand Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 4 ++-- 1 file chan

[dpdk-dev] [PATCH v4 2/2] examples/ipsec-secgw/test: fix inline test scripts

Remove workaround in tun_aesgcm_defs.sh and trs_aesgcm_defs.sh to get around the bug where the first inbound packet is dropped for inline crypto. Fixes: 929784452094 ("examples/ipsec-secgw: add scripts for functional test") Cc: sta...@dpdk.org Signed-off-by: Bernard Iremonger Acked-by: Konstanti

[dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

Inline crypto installs a flow rule in the NIC. This flow rule must be installed before the first inbound packet is received. The create_session() function installs the flow rule. Refactor ipsec-secgw.c, sa.c, ipsec.h and ipsec.c to create sessions at startup to fix the issue of the first packet b

[dpdk-dev] [PATCH v4 0/2] examples/ipsec-secgw: fix 1st pkt dropped

This patchset fixes the issue of the first inbound packet being dropped for inline crypto. Changes in v4: -- Fix indentation at line 173 in ipsec.c to solve compile error on ARM. Changes in v3: -- The previous refactoring of the create_session() function has been dropped.

Re: [dpdk-dev] [PATCH v5 1/3] rcu: add RCU library supporting QSBR mechanism

> > > > > > > > > > > > > > > > > > > > > > > > After evaluating long term API/ABI issues, I think > > > > > > > > > > > > you need to get rid of almost all use of inline and > > > > > > > > > > > > visible structures. Yes it might be marginally > > > > > > > > > > > > slower, but you thank me >

Re: [dpdk-dev] [PATCH v3 1/4] net/af_xdp: enqueue buf ring when allocate Tx queue fails

On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye wrote: > >> When it fails to allocate enough slots in Tx queue for transmitting >> packets, we need to return the dequeued addrs to buf ring. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >> >> Signed-of

Re: [dpdk-dev] [PATCH v3 2/4] net/af_xdp: specify minimal and maximal MTU

On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye wrote: > >> Since AF_XDP pmd doesn't support multi segment, we need to add a valid >> check in eth_dev_mtu_set. >> > >How about: >Properly report mtu capability in port device info. Sounds better. > > >Reported-by: Dav

Re: [dpdk-dev] [PATCH] cryptodev: add an option to support both iv and J0 for GCM

Hi Akhil, Yes, it's intended for 19.08 > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 17, 2019 12:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; De Lara Guarch, Pablo > > Subject: RE: [PATCH] cryptodev: add an option to

Re: [dpdk-dev] [EXT] RE: [PATCH v3 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

> > > + rte_eth_dev_rss_hash_conf_get(sa->portid, > > > + &rss_conf); > > > + for (i = 0, j = 0; i < eth_dev->data->nb_rx_queues; > > > + ++i) > > > + if (eth_dev->dat

Re: [dpdk-dev] [PATCH v3 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 17, 2019 12:52 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin > Cc: sta...@dpdk.org > Subject: RE: [PATCH v3 1/2] examples/ipsec-secgw: fix 1st packet dropped > for

Re: [dpdk-dev] [RFC 3/3] ci: enable tests on non-arm platforms

Jerin Jacob Kollanukkaran writes: >> -Original Message- >> From: dev On Behalf Of Aaron Conole >> Sent: Friday, March 29, 2019 10:53 PM >> To: dev@dpdk.org >> Subject: [dpdk-dev] [RFC 3/3] ci: enable tests on non-arm platforms >> >> When building under Travis (or another linux CI servic

  1   2   >