On 04/17, David Marchand wrote: >On Wed, Apr 17, 2019 at 11:02 AM Xiaolong Ye <xiaolong...@intel.com> wrote: > >> When it fails to allocate enough slots in Tx queue for transmitting >> packets, we need to return the dequeued addrs to buf ring. >> >> Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") >> >> Signed-off-by: Xiaolong Ye <xiaolong...@intel.com> >> --- >> drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c >> b/drivers/net/af_xdp/rte_eth_af_xdp.c >> index 007a1c6b4..5cc643ce2 100644 >> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c >> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c >> @@ -276,6 +276,7 @@ eth_af_xdp_tx(void *queue, struct rte_mbuf **bufs, >> uint16_t nb_pkts) >> >> if (xsk_ring_prod__reserve(&txq->tx, nb_pkts, &idx_tx) != nb_pkts) >> { >> kick_tx(txq); >> + rte_ring_enqueue_bulk(umem->buf_ring, addrs, nb_pkts, >> NULL); >> return 0; >> } >> >> -- >> 2.17.1 >> > >When there is no change, please keep Review tags from previous versions. > >Reviewed-by: David Marchand <david.march...@redhat.com>
Got it, will add your review tag in next version. Thanks, Xiaolong > >-- >David Marchand