On 4/17/2019 4:45 PM, Igor Russkikh wrote: > From: Pavel Belous <pavel.bel...@aquantia.com> > > This is a driver side of macsec configuration routines. > It fills in config structures and sends requests to FW > for configuration activities. > > We declare macsec offload bits in DPDK offload capabilities. > > Also update documentation with feature matrix for the > enabled feature. > > Signed-off-by: Pavel Belous <pavel.bel...@aquantia.com> > Signed-off-by: Igor Russkikh <igor.russk...@aquantia.com>
<...> > @@ -698,6 +700,205 @@ atl_dev_reset(struct rte_eth_dev *dev) > return ret; > } > > +static int > +atl_dev_configure_macsec(struct rte_eth_dev *dev) The build is broken in this patch [1] because static function defined but not used, indeed this is similar for other functions but they don't cause a build error since they are not static. It can be good to add the APIs using these functions and functions in same patch. [1] .../dpdk/drivers/net/atlantic/atl_ethdev.c:704:1: error: ‘atl_dev_configure_macsec’ defined but not used [-Werror=unused-function] atl_dev_configure_macsec(struct rte_eth_dev *dev) ^~~~~~~~~~~~~~~~~~~~~~~~
