[dpdk-dev] Does lthread_cond_wait need a mutex?

2018-07-17 Thread wubenqing
Hi~ Reference: http://doc.dpdk.org/guides-18.05/sample_app_ug/performance_thread.html?highlight=lthread The L-thread subsystem provides a set of functions that are logically equivalent to the corresponding functions offered by the POSIX pthread library. I think there is a bug with pth

Re: [dpdk-dev] [PATCH] test: ensure EAL flags autotest works properly on BSD

2018-07-17 Thread Zhao, MeijuanX
-Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Anatoly Burakov Sent: Tuesday, July 17, 2018 12:34 AM To: dev@dpdk.org Cc: Liu, Yu Y ; Richardson, Bruce ; Ananyev, Konstantin ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH] test: ensure EAL flags autotest works pro

[dpdk-dev] [PATCH] doc: update the enic guide and features

2018-07-17 Thread John Daley
From: Hyong Youb Kim Make a few updates in preparation for 18.08. - Use SPDX - Add 1400 series VIC adapters to supported models - Describe the VXLAN port number - Expand the description for ig-vlan-rewrite - Add inner RSS and checksum to the features Signed-off-by: Hyong Youb Kim Reviewed-by: J

[dpdk-dev] [PATCH v2] net/enic: pick the right Rx handler after changing MTU

2018-07-17 Thread John Daley
From: Hyong Youb Kim enic_set_mtu always reverts to the default Rx handler after changing MTU. Try to use the simpler, non-scatter handler in this case as well. Fixes: 35e2cb6a1795 ("net/enic: add simple Rx handler") Signed-off-by: Hyong Youb Kim Reviewed-by: John Daley --- v2: remember to ac

[dpdk-dev] [PATCH 2/2] test/hash: fix potential memory leak

2018-07-17 Thread Pablo de Lara
In the multiwriter test, if "found" array allocation failed, the memory of "keys" array, which was successfully allocated could not be freed, since by this time, tbl_multiwriter_test_params.keys was not set to this array, which is the pointer freed when finishing the test or when a failure happens.

[dpdk-dev] [PATCH 1/2] test/hash: fix multiwriter with non consecutive cores

2018-07-17 Thread Pablo de Lara
When non consecutive cores are passed into the test application, the distribution of the keys that each thread needs to insert is not correct, since it assumes that there are no cores skipped between the master core and the worker core. Fixes: be856325cba3 ("hash: add scalable multi-writer inserti

[dpdk-dev] [PATCH] examples/l2fwd-crypto: fix session mempool size

2018-07-17 Thread Pablo de Lara
The session mempool size for this application depends on the number of crypto devices that are capable of performing the operation given by the parameters on the app. However, previously this calculation was done before all devices were checked, resulting in an incorrect number of sessions require

[dpdk-dev] [PATCH] mempool: check for invalid args on creation

2018-07-17 Thread Pablo de Lara
Currently, a mempool can be created if the number of objects is zero or the size of these is zero. In these scenarios, rte_mempool_create should return NULL, as the mempool created is useless. Signed-off-by: Pablo de Lara --- lib/librte_mempool/rte_mempool.c | 12 1 file changed, 12

[dpdk-dev] [PATCH v2] librte_ethdev: improve description for port name api

2018-07-17 Thread Jasvinder Singh
Improve description of api used to get port name from port id or vice-versa. Signed-off-by: Jasvinder Singh --- v2 - fixed checkpatch warning lib/librte_ethdev/rte_ethdev.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/

[dpdk-dev] [PATCH 2/2] compression/qat: add sgl feature

2018-07-17 Thread Fiona Trahe
This patch add sgl feature to QAT compression PMD Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- config/common_base | 1 + config/rte_config.h | 1 + doc/guides/compressdevs/features/qat.ini | 3 +++ doc/guides/compressdevs/qat_comp.rs

[dpdk-dev] [PATCH 1/2] common/qat: add sgl header

2018-07-17 Thread Fiona Trahe
This patch refactors the sgl struct so it includes a flexible array of flat buffers as sym and compress PMDs can have different size sgls. Signed-off-by: Tomasz Jozwiak Signed-off-by: Fiona Trahe --- drivers/common/qat/qat_common.c | 53 ++--- drivers/common/

[dpdk-dev] [PATCH] eal: fix bitmap documentation

2018-07-17 Thread Jerin Jacob
n_bits comes as first argument, align doxygen comment. n_bit need to not be multiple of 512 as n_bits are rounding to RTE_BITMAP_CL_BIT_SIZE. Fixes: 14456f59e9f7 ("doc: fix doxygen warnings in QoS API") Fixes: de3cfa2c9823 ("sched: initial import") Cc: sta...@dpdk.org Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v3] test: fix incorrect return types

2018-07-17 Thread Reshma Pattan
UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: jasvinder.si...@intel.com CC: bernard.iremon...@intel.com CC: sta...@dpdk.org Signed-off-by: Reshma Pattan Reviewed-by: Anatol

Re: [dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-17 Thread santosh
On Tuesday 17 July 2018 08:03 PM, Pavan Nikhilesh wrote: > Prefetch mbuf pointer instead of wqe when SSO receives pkt from PKI. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Santosh Shukla

[dpdk-dev] [PATCH] librte_ethdev: improve description for port name api

2018-07-17 Thread Jasvinder Singh
Imporve description of api used to get port name from port id or vice-versa. Signed-off-by: Jasvinder Singh --- lib/librte_ethdev/rte_ethdev.h | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h

[dpdk-dev] [PATCH v5 09/10] mk: update make targets for classified testcases

2018-07-17 Thread Reshma Pattan
Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the above classified groups. Test ca

[dpdk-dev] [PATCH v5 08/10] autotest: update autotest test case list

2018-07-17 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy Reviewed-by: Anatoly Burakov --- test/test/autotest_data.py | 350 +

[dpdk-dev] [PATCH v5 10/10] mk: remove unnecessary make rules of test

2018-07-17 Thread Reshma Pattan
make rule test-basic is duplicate of test rule. removed unused test-mempool and test-ring make rules. Fixes: a3df7f8d9c ("mk: rename test related rules") Fixes: a3df7f8d9c ("mk: rename test related rules") CC: sta...@dpdk.org CC: ferruh.yi...@intel.com Signed-off-by: Reshma Pattan --- mk/rte.sd

[dpdk-dev] [PATCH v5 06/10] autotest: remove autotest grouping

2018-07-17 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v5 07/10] autotest: properly parallelize unit tests

2018-07-17 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v5 05/10] autotest: improve filtering

2018-07-17 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v5 03/10] autotest: make autotest runner python 2/3 compliant

2018-07-17 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v5 04/10] autotest: visually separate different test categories

2018-07-17 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v5 02/10] autotest: fix invalid code on reports

2018-07-17 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v5 01/10] autotest: fix printing

2018-07-17 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v5 00/10] Make unit tests great again

2018-07-17 Thread Reshma Pattan
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memor

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-17 Thread Ferruh Yigit
On 7/17/2018 2:04 PM, Ori Kam wrote: > Hi, > > PSB > > Thanks, > Ori > >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Tuesday, July 17, 2018 12:57 PM >> To: Ori Kam ; Xu, Rosen ; >> dev@dpdk.org >> Cc: sta...@dpdk.org; Gilmore, Walter E ; Qi >> Zhang

[dpdk-dev] [PATCH] mem: fix static analysis warning

2018-07-17 Thread Anatoly Burakov
Technically, single file segments codepath will never get triggered when using in-memory mode, because EAL prohibits mixing these two options at initialization time. However, code analyzers do not know that, and some will complain about either using uninitialized variables, or trying to do operatio

Re: [dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 3:34 PM > To: Pattan, Reshma ; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: Re: [PATCH v4 9/9] mk: update make targets for classified testcases > > On 17-

Re: [dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 3:40 PM > To: Pattan, Reshma ; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: Re: [PATCH v4 9/9] mk: update make targets for classified testcases > > +DUMPL

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix compilation for rdma-core v19

2018-07-17 Thread Christian Ehrhardt
On Thu, Jul 12, 2018 at 12:57 PM Shahaf Shuler wrote: > Thursday, July 12, 2018 1:54 PM, Ori Kam: > > Subject: RE: [PATCH] net/mlx5: fix compilation for rdma-core v19 > > > > > > The flow counter support introduced by commit 9a761de8ea14 ("net/mlx5: > > > flow counter support") was intend to work

Re: [dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 2:15 PM, Reshma Pattan wrote: Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different tar

[dpdk-dev] [PATCH] event/octeontx: prefetch mbuf instead of wqe

2018-07-17 Thread Pavan Nikhilesh
Prefetch mbuf pointer instead of wqe when SSO receives pkt from PKI. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/ssovf_worker.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/octeontx/ssovf_worker.h b/drivers/event/octeontx/ssovf_worker.h index d

[dpdk-dev] [PATCH] app/eventdev: use proper teardown sequence

2018-07-17 Thread Pavan Nikhilesh
Use proper teardown sequence when SIGINT is caught to prevent eventdev from going into undefined state. Signed-off-by: Pavan Nikhilesh --- app/test-eventdev/evt_main.c | 6 +- app/test-eventdev/test_pipeline_common.c | 1 - 2 files changed, 5 insertions(+), 2 deletions(-) diff -

Re: [dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 2:15 PM, Reshma Pattan wrote: Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different tar

Re: [dpdk-dev] [PATCH v2 2/2] librte_ip_frag: add mbuf counter

2018-07-17 Thread Ananyev, Konstantin
Hi Alex, Sorry for delay in reply. > > >> There might be situations (kind of attack when a lot of > >> fragmented packets are sent to a dpdk application in order > >> to flood the fragmentation table) when no additional mbufs > >> must be added to the fragmentations table since it already > >> co

Re: [dpdk-dev] [PATCH] maintainers: update for szedata2 PMD

2018-07-17 Thread Jan Remeš
On Tue, Jul 17, 2018 at 3:52 PM, Matej Vido wrote: > > I will no longer be maintaining szedata2 PMD. Jan will take over this > role. > > Signed-off-by: Matej Vido > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 227e32

Re: [dpdk-dev] [PATCH] ip_frag: extend rte_ipv6_frag_get_ipv6_fragment_header()

2018-07-17 Thread Ananyev, Konstantin
Hi Cody, > > Hi, > > > Just a generic thought - might be worse to move functions that parse ipv6 > > header extentions > > and related strcutures into rte_net. > > I am sure they might be reused by some other code. > > Sorry, I am misunderstanding. Do you mean it might be better to move > stru

[dpdk-dev] [PATCH] maintainers: update for szedata2 PMD

2018-07-17 Thread Matej Vido
I will no longer be maintaining szedata2 PMD. Jan will take over this role. Signed-off-by: Matej Vido --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 227e32c..43b0a3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -617,7 +617,7 @

Re: [dpdk-dev] [PATCH v2] test: fix incorrect return types

2018-07-17 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 1:58 PM > To: Pattan, Reshma ; dev@dpdk.org > Cc: Singh, Jasvinder ; Iremonger, Bernard > ; sta...@dpdk.org > Subject: Re: [PATCH v2] test: fix incorrect return types > > > > @@ -871,32 +871,32 @@ test_flow_

[dpdk-dev] [Bug 73] In a multi-process setup, secondary processes fail to receive any packet

2018-07-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=73 Bug ID: 73 Summary: In a multi-process setup, secondary processes fail to receive any packet Product: DPDK Version: 18.02 Hardware: x86 OS: Linux Status:

[dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Reshma Pattan
Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the above classified groups. Test ca

[dpdk-dev] [PATCH v4 8/9] autotest: update autotest test case list

2018-07-17 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy Reviewed-by: Anatoly Burakov --- test/test/autotest_data.py | 350 +

[dpdk-dev] [PATCH v4 7/9] autotest: properly parallelize unit tests

2018-07-17 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v4 5/9] autotest: improve filtering

2018-07-17 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v4 6/9] autotest: remove autotest grouping

2018-07-17 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v4 1/9] autotest: fix printing

2018-07-17 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v4 2/9] autotest: fix invalid code on reports

2018-07-17 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v4 4/9] autotest: visually separate different test categories

2018-07-17 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-17 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v4 0/9] Make unit tests great again

2018-07-17 Thread Reshma Pattan
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memor

[dpdk-dev] [PATCH] vhost: fix buffer length calculation

2018-07-17 Thread Tiwei Bie
Fixes: fd68b4739d2c ("vhost: use buffer vectors in dequeue path") Reported-by: Yinan Wang Signed-off-by: Tiwei Bie --- lib/librte_vhost/virtio_net.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2b

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-17 Thread Ori Kam
Hi, PSB Thanks, Ori > -Original Message- > From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, July 17, 2018 12:57 PM > To: Ori Kam ; Xu, Rosen ; > dev@dpdk.org > Cc: sta...@dpdk.org; Gilmore, Walter E ; Qi > Zhang > Subject: Re: [dpdk-dev] [PATCH] examples/flow_filterin

Re: [dpdk-dev] [PATCH v2] test: fix incorrect return types

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 1:39 PM, Reshma Pattan wrote: UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Also replace one instance of setting the ret value from -ENOMEM to TEST_FAILED, in order to return correct value to autotest. Fixes: 9c9befea4f

Re: [dpdk-dev] [PATCH v2 3/6] compress/octeontx: add xform and stream create support

2018-07-17 Thread Verma, Shally
>-Original Message- >From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com] >Sent: 14 July 2018 03:55 >To: Verma, Shally >Cc: dev@dpdk.org; Athreya, Narayana Prasad >; Challa, Mahipal >; Gupta, Ashish ; Gupta, >Ashish ; Sahu, >Sunila >Subject: RE: [PATCH v2 3/6] compress

[dpdk-dev] [PATCH v2] test: fix incorrect return types

2018-07-17 Thread Reshma Pattan
UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Also replace one instance of setting the ret value from -ENOMEM to TEST_FAILED, in order to return correct value to autotest. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: j

Re: [dpdk-dev] [PATCH] app/testpmd: fix logically dead code

2018-07-17 Thread Iremonger, Bernard
> -Original Message- > From: Laatz, Kevin > Sent: Tuesday, July 17, 2018 11:34 AM > To: dev@dpdk.org > Cc: Singh, Jasvinder ; Iremonger, Bernard > ; Laatz, Kevin > Subject: [PATCH] app/testpmd: fix logically dead code > > Remove logically dead code, tm_port_rate cannot be greater than > U

[dpdk-dev] [PATCH v4 7/9] autotest: properly parallelize unit tests

2018-07-17 Thread Reshma Pattan
Now that everything else is in place, we can run unit tests in a different fashion to what they were running as before. Previously, we had all autotests as part of groups (largely obtained through trial and error) to ensure parallel execution while still limiting amounts of memory used by those tes

[dpdk-dev] [PATCH v4 6/9] autotest: remove autotest grouping

2018-07-17 Thread Reshma Pattan
Previously, all autotests were grouped into (seemingly arbitrary) groups. The goal was to run all tests in parallel (so that autotest finishes faster), but we couldn't just do it willy-nilly because DPDK couldn't allocate and free hugepages on-demand, so we had to find autotest groupings that could

[dpdk-dev] [PATCH v4 4/9] autotest: visually separate different test categories

2018-07-17 Thread Reshma Pattan
Help visually identify parallel vs. non-parallel autotests. Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index f6b669a2e..d9d5f7a97 100644 ---

[dpdk-dev] [PATCH v4 5/9] autotest: improve filtering

2018-07-17 Thread Reshma Pattan
Improve code for filtering test groups. Also, move reading binary symbols into filtering stage, so that tests that are meant to be skipped are never attempted to be executed in the first place. Before running tests, print out any tests that were skipped because they weren't compiled. Cc: sta...@dp

[dpdk-dev] [PATCH v4 9/9] mk: update make targets for classified testcases

2018-07-17 Thread Reshma Pattan
Makefiles are updated with new test case lists. Test cases are classified as - P1 - Main test cases, P2 - Cryptodev/driver test cases, P3 - Perf test cases which takes longer than 10s, P4 - Logging/Dump test cases. Makefile is updated with different targets for the above classified groups. Test ca

[dpdk-dev] [PATCH v4 8/9] autotest: update autotest test case list

2018-07-17 Thread Reshma Pattan
Autotest is enhanced with additional test cases being added to autotest_data.py Removed non existing PCI autotest. Cc: sta...@dpdk.org Signed-off-by: Reshma Pattan Signed-off-by: Jananee Parthasarathy Reviewed-by: Anatoly Burakov --- test/test/autotest_data.py | 350 +

[dpdk-dev] [PATCH v4 1/9] autotest: fix printing

2018-07-17 Thread Reshma Pattan
Previously, printing was done using tuple syntax, which caused output to appear as a tuple as opposed to being one string. Fix this by using addition operator instead. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: An

[dpdk-dev] [PATCH v4 2/9] autotest: fix invalid code on reports

2018-07-17 Thread Reshma Pattan
There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Cc: sta..

[dpdk-dev] [PATCH v4 3/9] autotest: make autotest runner python 2/3 compliant

2018-07-17 Thread Reshma Pattan
Autotest runner was still using python 2-style print syntax. Fix it by importing print function from the future, and fix the calls to be python-3 style. Fixes: 54ca545dce4b ("make python scripts python2/3 compliant") Cc: john.mcnam...@intel.com Cc: sta...@dpdk.org Signed-off-by: Anatoly Burakov

[dpdk-dev] [PATCH v4 0/9] Make unit tests great again

2018-07-17 Thread Reshma Pattan
Previously, unit tests were running in groups. There were technical reasons why that was the case (mostly having to do with limiting memory), but it was hard to maintain and update the autotest script. In 18.05, limiting of memory at DPDK startup was no longer necessary, as DPDK allocates memor

[dpdk-dev] [PATCH] app/testpmd: fix logically dead code

2018-07-17 Thread Kevin Laatz
Remove logically dead code, tm_port_rate cannot be greater than UINT32_MAX. Coverity issue: 302846 Fixes: 0ad778b398c6 ("app/testpmd: rework softnic forward mode") Signed-off-by: Kevin Laatz --- app/test-pmd/softnicfwd.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/test-pmd/softnic

Re: [dpdk-dev] [PATCH v4] test: add sample functions for packet forwarding

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 11:00 AM, Jananee Parthasarathy wrote: Add sample test functions for packet forwarding. These can be used for unit test cases for LatencyStats and BitrateStats libraries. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan --- v4: Updated retu

Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 10:45 AM, Pattan, Reshma wrote: Hi, -Original Message- From: Burakov, Anatoly Sent: Tuesday, July 17, 2018 10:23 AM To: Pattan, Reshma ; tho...@monjalon.net; dev@dpdk.org Cc: Parthasarathy, JananeeX M ; sta...@dpdk.org Subject: Re: [PATCH v3 8/9] autotest: update autotest t

Re: [dpdk-dev] [PATCH v4] vfio: fix workaround of BAR0 mapping

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 9:22 AM, Takeshi Yoshimura wrote: The workaround of BAR0 mapping gives up and immediately returns an error if it cannot map around the MSI-X. However, recent version of VFIO allows MSIX mapping (*). I fixed not to return immediately but try mapping. In old Linux, mmap just fails and

[dpdk-dev] [PATCH v4] test: add sample functions for packet forwarding

2018-07-17 Thread Jananee Parthasarathy
Add sample test functions for packet forwarding. These can be used for unit test cases for LatencyStats and BitrateStats libraries. Signed-off-by: Chaitanya Babu Talluri Reviewed-by: Reshma Pattan Acked-by: Reshma Pattan --- v4: Updated return value as TEST_FAILED instead of -1 v3: Used same po

Re: [dpdk-dev] [PATCH] examples/flow_filtering: add rte_fdir_conf initialization

2018-07-17 Thread Ferruh Yigit
On 7/17/2018 6:15 AM, Ori Kam wrote: > Sorry for the late response, > >> -Original Message- >> From: Xu, Rosen [mailto:rosen...@intel.com] >> Sent: Thursday, July 12, 2018 9:23 AM >> To: Ori Kam ; dev@dpdk.org >> Cc: Yigit, Ferruh ; sta...@dpdk.org; Gilmore, Walter >> E >> Subject: RE: [d

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-17 Thread Stojaczyk, DariuszX
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 4:17 PM > To: Stojaczyk, DariuszX ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] memory: fix alignment in > eal_get_virtual_area() > > On 16-Jul-18 3:01 PM, Burakov, Anatoly wrote: > > On

Re: [dpdk-dev] [PATCH] mem: fix alignment of requested virtual areas

2018-07-17 Thread Stojaczyk, DariuszX
> -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 4:57 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yao, Lei A ; Stojaczyk, DariuszX > ; sta...@dpdk.org > Subject: [PATCH] mem: fix alignment of requested virtual areas > > The original code did not align any

Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-17 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 10:23 AM > To: Pattan, Reshma ; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list > > On 17-Jul-18

Re: [dpdk-dev] [Bug 72] Unable to install dpdk on arm64

2018-07-17 Thread Shreyansh Jain
On Tuesday 17 July 2018 01:26 PM, bugzi...@dpdk.org wrote: https://bugs.dpdk.org/show_bug.cgi?id=72 Bug ID: 72 Summary: Unable to install dpdk on arm64 Product: DPDK Version: unspecified Hardware: ARM OS: Linux

Re: [dpdk-dev] [PATCH] test: fix incorrect return types

2018-07-17 Thread Burakov, Anatoly
On 16-Jul-18 5:58 PM, Reshma Pattan wrote: UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") CC: jasvinder.si...@intel.com CC: bernard.iremon...@intel.com CC: sta...@dpdk.org Sign

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 10:22 AM, Xu, Qian Q wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly Sent: Monday, July 16, 2018 10:01 PM To: Stojaczyk, DariuszX ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] memory: fix alignment in eal

Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-17 Thread Burakov, Anatoly
On 17-Jul-18 10:18 AM, Pattan, Reshma wrote: Hi, -Original Message- From: Burakov, Anatoly Sent: Monday, July 16, 2018 4:16 PM To: Pattan, Reshma ; tho...@monjalon.net; dev@dpdk.org Cc: Parthasarathy, JananeeX M ; sta...@dpdk.org Subject: Re: [PATCH v3 8/9] autotest: update autotest tes

Re: [dpdk-dev] [PATCH] memory: fix alignment in eal_get_virtual_area()

2018-07-17 Thread Xu, Qian Q
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > Sent: Monday, July 16, 2018 10:01 PM > To: Stojaczyk, DariuszX ; dev@dpdk.org > Cc: sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] memory: fix alignment in > eal_get_virtual_area() > > On 1

[dpdk-dev] [PATCH v6 1/2] librte_lpm: Improve performance of the delete and add functions

2018-07-17 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance Rework the lpm6 rule subsystem and replace current rules algorithm complexity O(n) with hashtables which allow dealing with large (50k) rule sets. Signed-off-by: Alex Kiselev --- lib/Makefile | 2 +- lib/librte_lpm/Makefile| 2 +- lib/l

[dpdk-dev] [PATCH v6 2/2] librte_lpm: Improve performance of the delete and add functions

2018-07-17 Thread Alex Kiselev
librte_lpm: Improve lpm6 performance There is no need to rebuild the whole LPM tree when a rule is deleted. This patch addresses this issue introducing new delete operation. Signed-off-by: Alex Kiselev --- lib/librte_lpm/rte_lpm6.c | 712 ++ 1 file ch

Re: [dpdk-dev] [PATCH v3 8/9] autotest: update autotest test case list

2018-07-17 Thread Pattan, Reshma
Hi, > -Original Message- > From: Burakov, Anatoly > Sent: Monday, July 16, 2018 4:16 PM > To: Pattan, Reshma ; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M ; > sta...@dpdk.org > Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list > > > > +{

[dpdk-dev] [PATCH v4] vfio: fix workaround of BAR0 mapping

2018-07-17 Thread Takeshi Yoshimura
The workaround of BAR0 mapping gives up and immediately returns an error if it cannot map around the MSI-X. However, recent version of VFIO allows MSIX mapping (*). I fixed not to return immediately but try mapping. In old Linux, mmap just fails and returns the same error as the code before my fix

Re: [dpdk-dev] [PATCH v3] vfio: fix workaround of BAR0 mapping

2018-07-17 Thread Takeshi Yoshimura
2018-07-13 20:08 GMT+09:00 Burakov, Anatoly : > On 13-Jul-18 12:00 PM, Burakov, Anatoly wrote: >> >> On 13-Jul-18 11:11 AM, Takeshi Yoshimura wrote: >>> >>> The workaround of BAR0 mapping gives up and immediately returns an >>> error if it cannot map around the MSI-X. However, recent version >>> of

Re: [dpdk-dev] [PATCH v3] test: add sample functions for packet forwarding

2018-07-17 Thread Pattan, Reshma
Hi > -Original Message- > From: Parthasarathy, JananeeX M > Sent: Monday, July 16, 2018 5:01 PM > To: dev@dpdk.org > Cc: Horton, Remy ; Pattan, Reshma > ; Parthasarathy, JananeeX M > ; Chaitanya Babu, TalluriX > > Subject: [PATCH v3] test: add sample functions for packet forwarding > > A

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms

2018-07-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, July 16, 2018 9:26 AM > To: ankur.dwiv...@cavium.com; Doherty, Declan > Cc: dev@dpdk.org; De Lara Guarch, Pablo ; > sta...@dpdk.org > Subject: [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms > > When perf

Re: [dpdk-dev] [PATCH v2] test/compress: add scatter-gather tests

2018-07-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Monday, July 16, 2018 10:31 AM > To: Daly, Lee ; Trahe, Fiona ; > ashish.gu...@caviumnetworks.com; shally.ve...@caviumnetworks.com > Cc: dev@dpdk.org; De Lara Guarch, Pablo > Subject: [PATCH v2] test/compress: add scatter-gather

Re: [dpdk-dev] [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms

2018-07-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Tuesday, July 17, 2018 9:04 AM > To: De Lara Guarch, Pablo > Subject: RE: [PATCH] examples/l2fwd-crypto: fix digest with AEAD algorithms > > > > From: Dwivedi, Ankur [mailto:ankur.dwiv...@cavium.com] > Sent: Tuesday, July 17,

[dpdk-dev] [Bug 72] Unable to install dpdk on arm64

2018-07-17 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=72 Bug ID: 72 Summary: Unable to install dpdk on arm64 Product: DPDK Version: unspecified Hardware: ARM OS: Linux Status: CONFIRMED Severity: normal Priority

Re: [dpdk-dev] [PATCH v4 2/5] vhost: use buffer vectors in dequeue path

2018-07-17 Thread Wang, Yinan
Hi Maxime, vhost user + virtio-net VM2VM TSO performance test can work well on dpdk v18.05. But during our performance test with v18.08-rc1, we found a regression in the VM2VM test case. When using iperf or netperf, the server VM will hang/crash. After the bisection, I found it's caused by y