Hi, > -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 3:34 PM > To: Pattan, Reshma <reshma.pat...@intel.com>; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M <jananeex.m.parthasara...@intel.com>; > sta...@dpdk.org > Subject: Re: [PATCH v4 9/9] mk: update make targets for classified testcases > > On 17-Jul-18 2:15 PM, Reshma Pattan wrote: > > Makefiles are updated with new test case lists. > > Test cases are classified as - > > P1 - Main test cases, > > P2 - Cryptodev/driver test cases, > > P3 - Perf test cases which takes longer than 10s, > > P4 - Logging/Dump test cases. > > > > Makefile is updated with different targets for the above classified > > groups. > > Test cases for different targets are listed accordingly. > > > > Cc: sta...@dpdk.org > > > > Signed-off-by: Jananee Parthasarathy > > <jananeex.m.parthasara...@intel.com> > > Reviewed-by: Reshma Pattan <reshma.pat...@intel.com> > > --- > > mk/rte.sdkroot.mk | 4 ++-- > > mk/rte.sdktest.mk | 33 +++++++++++++++++++++++++++------ > > 2 files changed, 29 insertions(+), 8 deletions(-) > > > > diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk index > > f43cc7829..ea3473ebf 100644 > > --- a/mk/rte.sdkroot.mk > > +++ b/mk/rte.sdkroot.mk > > @@ -68,8 +68,8 @@ config defconfig showconfigs showversion > showversionum: > > cscope gtags tags etags: > > $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T > > > > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf > > coverage -test test-basic test-fast test-ring test-mempool test-perf > > coverage: > > +.PHONY: test test-basic test-fast test-ring test-mempool test-perf > > +coverage test-drivers test-dump test test-basic test-fast test-ring test- > mempool test-perf coverage test-drivers test-dump: > > I'm probably missing something, but i can only see definitions for coverage, > test-fast, test-perf, test-drivers and test-dump. > > What is the difference between test and test-basic, and what is test- > mempool? If they are unused, they should be removed. >
test-mempool was there from legacy though it is not useful after looking at the make file. Will remove. make test : this runs all the UTs that are there in autotest_data.py make test-basic: it is same as make test. Will remove test-mempool and make test-basic then in a separate patch. Thanks, Reshma