[dpdk-dev] [PATCH] mempool: check for invalid args on creation

[Pablo de Lara]

Currently, a mempool can be created if the number of
objects is zero or the size of these is zero.
In these scenarios, rte_mempool_create should return NULL,
as the mempool created is useless.

Signed-off-by: Pablo de Lara <pablo.de.lara.gua...@intel.com>
---
 lib/librte_mempool/rte_mempool.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c
index 8c8b9f809..8c9573f1a 100644
--- a/lib/librte_mempool/rte_mempool.c
+++ b/lib/librte_mempool/rte_mempool.c
@@ -916,6 +916,18 @@ rte_mempool_create_empty(const char *name, unsigned n, 
unsigned elt_size,
 
        mempool_list = RTE_TAILQ_CAST(rte_mempool_tailq.head, rte_mempool_list);
 
+       /* asked for zero items */
+       if (n == 0) {
+               rte_errno = EINVAL;
+               return NULL;
+       }
+
+       /* asked for zero-sized elements */
+       if (elt_size == 0) {
+               rte_errno = EINVAL;
+               return NULL;
+       }
+
        /* asked cache too big */
        if (cache_size > RTE_MEMPOOL_CACHE_MAX_SIZE ||
            CALC_CACHE_FLUSHTHRESH(cache_size) > n) {
-- 
2.14.4