>-----Original Message-----
>From: De Lara Guarch, Pablo [mailto:pablo.de.lara.gua...@intel.com]
>Sent: 14 July 2018 03:55
>To: Verma, Shally <shally.ve...@cavium.com>
>Cc: dev@dpdk.org; Athreya, Narayana Prasad 
><narayanaprasad.athr...@cavium.com>; Challa, Mahipal
><mahipal.cha...@cavium.com>; Gupta, Ashish <ashish.gu...@cavium.com>; Gupta, 
>Ashish <ashish.gu...@cavium.com>; Sahu,
>Sunila <sunila.s...@cavium.com>
>Subject: RE: [PATCH v2 3/6] compress/octeontx: add xform and stream create 
>support
>
>External Email
>
>> -----Original Message-----
>> From: Shally Verma [mailto:shally.ve...@caviumnetworks.com]
>> Sent: Monday, July 2, 2018 5:55 PM
>> To: De Lara Guarch, Pablo <pablo.de.lara.gua...@intel.com>
>> Cc: dev@dpdk.org; pathr...@caviumnetworks.com;
>> mcha...@caviumnetworks.com; Ashish Gupta
>> <ashish.gu...@caviumnetworks.com>; Ashish Gupta
>> <ashish.gu...@caviumnetworks.com>; Sunila Sahu
>> <sunila.s...@caviumnetworks.com>
>> Subject: [PATCH v2 3/6] compress/octeontx: add xform and stream create
>> support
>>
>> From: Ashish Gupta <ashish.gu...@caviumnetworks.com>
>>
>> implement private xform and stream create ops
>>
>> Signed-off-by: Ashish Gupta <ashish.gu...@caviumnetworks.com>
>> Signed-off-by: Shally Verma <shally.ve...@caviumnetworks.com>
>> Signed-off-by: Sunila Sahu <sunila.s...@caviumnetworks.com>
>> ---
>
>...
>
>>
>> +static int
>> +zip_pmd_stream_create(struct rte_compressdev *dev,
>> +             const struct rte_comp_xform *xform, void **stream) {
>
>Do you support stateful ops? If you don't, this should not be implemented, I 
>think (or should return -ENOTSUP).
For us non-shareable priv_xform are equivalent to stream, so priv_xform_create 
falls back to stream_create . However, I see your point  so to reflect stateful 
not supported, we will set stream_create function pointer = NULL in pmd_ops.

Thanks
Shally

Reply via email to