Hi, > -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, July 17, 2018 10:23 AM > To: Pattan, Reshma <reshma.pat...@intel.com>; tho...@monjalon.net; > dev@dpdk.org > Cc: Parthasarathy, JananeeX M <jananeex.m.parthasara...@intel.com>; > sta...@dpdk.org > Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list > > On 17-Jul-18 10:18 AM, Pattan, Reshma wrote: > > Hi, > > > >> -----Original Message----- > >> From: Burakov, Anatoly > >> Sent: Monday, July 16, 2018 4:16 PM > >> To: Pattan, Reshma <reshma.pat...@intel.com>; tho...@monjalon.net; > >> dev@dpdk.org > >> Cc: Parthasarathy, JananeeX M <jananeex.m.parthasara...@intel.com>; > >> sta...@dpdk.org > >> Subject: Re: [PATCH v3 8/9] autotest: update autotest test case list > >> > >> > >>> + { > >>> + "Name": "Set rxtx mode", > >>> + "Command": "set_rxtx_mode", > >>> + "Func": default_autotest, > >>> + "Report": None, > >>> + }, > >>> + { > >>> + "Name": "Set rxtx anchor", > >>> + "Command": "set_rxtx_anchor", > >>> + "Func": default_autotest, > >>> + "Report": None, > >>> + }, > >>> + { > >>> + "Name": "Set rxtx sc", > >>> + "Command": "set_rxtx_sc", > >>> + "Func": default_autotest, > >>> + "Report": None, > >>> + }, > >> > >> The above three tests don't look like autotests to me. I have no idea > >> what they are for, but either they need a special function, or they > >> need to be taken out. > >> > > > > These commands needs to be run manually from test cmd prompt to > various set rxtx mode, rxtx rate and rxtx direction . > > These can be used to verify pmd perf test with vaiours set of above values. > > > > So this can be removed from autotest. > > We do have PMD perf tests in the script - do they call these functions? > If they are required for PMD autotests, maybe PMD autotests deserve a > special test function calling these commands before running the tests? > > (if they also work without these commands, then we can perhaps postpone > this to 18.11) >
I ran pmd perf test manually and it passes without having to use above set_rxtx commands. Thanks, Reshma