[dpdk-dev] [PATCH] eventdev: change port_id to uint16_t

2018-05-07 Thread Lei
From: yao >From 17.11, port_id is changed from uint8_t to uint16_t.But in eventdev, it still use the old fashion. This patch fix this issue. Signed-off-by: Lei Yao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/lib

Re: [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access

2018-05-07 Thread Zhao1, Wei
Hi, zhang qi This fix patch to DPDK.or is also useful for igb flex byte core dump issue. I have validation it. But there is some patch check warning. https://dpdk.org/dev/patchwork/patch/39417/ > -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 7, 2018 5:51 PM > To: adrien.

Re: [dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam

2018-05-07 Thread Tomasz Duszynski
On Mon, May 07, 2018 at 02:19:42PM +, De Lara Guarch, Pablo wrote: > > > > -Original Message- > > From: Tomasz Duszynski [mailto:t...@semihalf.com] > > Sent: Friday, April 27, 2018 8:15 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo ; > > d...@marvell.com; Tomasz Duszynski ; Nata

[dpdk-dev] [PATCH 08/18] drivers: net: nfp: fix buffer overflow in fw_name

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c: In function ‘nfp_pf_pci_probe’: /home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:3160:23: error: ‘%s’ directive writing up to 99 bytes into a region of size 76 [-Werror=format-overflow=] sprintf(fw_name, "%s/%s.nffw", DEFAULT_FW_PATH, s

[dpdk-dev] [PATCH 12/18] drivers: net: sfc: fix another strncpy size and NUL

2018-05-07 Thread Andy Green
--- drivers/net/sfc/sfc_ethdev.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index e9bb283e0..bd5f17f33 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -662,10 +662,13 @@

[dpdk-dev] [PATCH 14/18] drivers: net: vdev: fix 3 x strncpy misuse

2018-05-07 Thread Andy Green
--- drivers/net/vdev_netvsc/vdev_netvsc.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c index c11794137..c36ec0f9a 100644 --- a/drivers/net/vdev_netvsc/vdev_netvsc.c +++ b/drivers/net/

[dpdk-dev] [PATCH 17/18] app: test-bbdev: strcpy ok for allocated string

2018-05-07 Thread Andy Green
--- app/test-bbdev/test_bbdev_vector.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index addef0572..5ad2a6535 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vector.

[dpdk-dev] [PATCH 18/18] app: test-bbdev: strcpy ok for allocated string 2

2018-05-07 Thread Andy Green
--- app/test-bbdev/test_bbdev_vector.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-bbdev/test_bbdev_vector.c index 5ad2a6535..373f94984 100644 --- a/app/test-bbdev/test_bbdev_vector.c +++ b/app/test-bbdev/test_bbdev_vecto

[dpdk-dev] [PATCH 09/18] drivers: net: qede: fix strncpy constant and NUL

2018-05-07 Thread Andy Green
--- drivers/net/qede/base/ecore_int.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index f43781ba4..c809d84ef 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/drivers/net/qede/base/ecore

[dpdk-dev] [PATCH 11/18] drivers:net:sfc: fix strncpy length

2018-05-07 Thread Andy Green
--- drivers/net/sfc/sfc_ethdev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index e42d55350..e9bb283e0 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -742,7 +742,7 @@ sfc_xstat

[dpdk-dev] [PATCH 07/18] drivers: net: nfp: don't memcpy out of source range

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfp_net.c:669:2: error: ‘memcpy’ forming offset [5, 6] is out of the bounds [0, 4] of object ‘tmp’ with type ‘uint32_t’ {aka ‘unsigned int’} [-Werror=array-bounds] memcpy(&hw->mac_addr[0], &tmp, sizeof(struct ether_addr)); --- drivers/net/nfp/nfp_net.

[dpdk-dev] [PATCH 16/18] app: fix sprintf overrun bug

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/app/proc-info/main.c: In function ‘nic_xstats_display’: /home/agreen/projects/dpdk/app/proc-info/main.c:495:45: error: ‘%s’ directive writing up to 255 bytes into a region of size between 165 and 232 [-Werror=format-overflow=] sprintf(buf, "PUTVAL %s/dpdkstat-port.

[dpdk-dev] [PATCH 15/18] test-pmd: can't find include

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/app/test-pmd/cmdline.c:64:10: fatal error: rte_pmd_dpaa.h: No such file or directory #include ^~~~ --- app/test-pmd/Makefile |1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/Makefile b/app/test-pmd/Makefile index 60ae9b9c1..a0f

[dpdk-dev] [PATCH 13/18] drivers: net: vdev: readlink inputs cannot be aliased

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/vdev_netvsc/vdev_netvsc.c:335:2: error: passing argument 2 to restrict-qualified parameter aliases with argument 1 [-Werror=restrict] ret = readlink(buf, buf, size); ^~~ --- drivers/net/vdev_netvsc/vdev_netvsc.c |7 --- 1 file changed, 4 inserti

[dpdk-dev] [PATCH 05/18] drivers: net: nfp: nfpcore: fix strncpy misuse

2018-05-07 Thread Andy Green
--- drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c b/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c index 4e6c66624..9f6704a7f 100644 --- a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c +++ b

[dpdk-dev] [PATCH 10/18] drivers: net: qede: fix broken strncpy

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function ‘qed_slowpath_start’: /home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ output may be truncated copying 12 bytes from a string of length 127 [-Werror=stringop-truncation] strncpy((char *)drv_ver

[dpdk-dev] [PATCH 06/18] drivers: net: nfp: nfpcore fix off-by-one and no NUL on strncpy use

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/nfp/nfpcore/nfp_resource.c:76:2: error: ‘strncpy’ output may be truncated copying 8 bytes from a string of length 8 [-Werror=stringop-truncation] strncpy(name_pad, res->name, sizeof(name_pad)); --- drivers/net/nfp/nfpcore/nfp_resource.c |6 +++--- 1 f

[dpdk-dev] [PATCH 03/18] drivers: bus: dpaa: fix inconsistent struct alignment

2018-05-07 Thread Andy Green
The actual descriptor for qm_mr_entry is 64-byte aligned. But the original code plays a trick, and puts a u8 common to the three descriptor subtypes in the union afterwards outside their structure definitions. Unfortunately since they compose a struct qm_fd with alignment 8, this trick destroys t

[dpdk-dev] [PATCH 04/18] drivers: net: axgbe: fix broken eeprom string comp

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/drivers/net/axgbe/axgbe_phy_impl.c:576:6: error: ‘__builtin_memcmp_eq’ reading 16 bytes from a region of size 9 [-Werror=stringop-overflow=] if (memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_NAME], ^ AXG

[dpdk-dev] [PATCH 02/18] drivers: bus: pci: fix strncpy dangerous code

2018-05-07 Thread Andy Green
In function ‘pci_get_kernel_driver_by_path’, inlined from ‘pci_scan_one.isra.1’ at /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:317:8: /home/agreen/projects/dpdk/drivers/bus/pci/linux/pci.c:57:3: error: ‘strncpy’ specified bound depends on the length of the source argument [-Werror

[dpdk-dev] [PATCH 00/18] Fix build on gcc8 and various bugs

2018-05-07 Thread Andy Green
The following series gets current master able to build on Fedora 28 + x86_64 using gcc 8.0.1. There were a number of build-breaking problems, mostly around correct string processing but all of them reflecting some issue in the code. Of the two major issues, one around struct alignment in dpaa I t

[dpdk-dev] [PATCH 01/18] lib: ret_table: workaround hash function cast error

2018-05-07 Thread Andy Green
/home/agreen/projects/dpdk/lib/librte_table/rte_table_hash_cuckoo.c:110:16: error: cast between incompatible function types from ‘rte_table_hash_op_hash’ {aka ‘long unsigned int (*)(void *, void *, unsigned int, long unsigned int)’} to ‘uint32_t (*)(const void *, uint32_t, uint32_t)’ {aka ‘uns

Re: [dpdk-dev] [PATCH] net/virtio-user: fix feature setting with vhost-net backend

2018-05-07 Thread Tiwei Bie
On Mon, May 07, 2018 at 02:50:06PM +0800, Jiayu Hu wrote: > Currently, when the backend is vhost-net, which implies > virtio-user works in client mode, virtio-user is assigned > to the default feature VIRTIO_USER_SUPPORTED_FEATURES. > However, virtio-user should request features from the > backend

Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error

2018-05-07 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Zhang, Qi Z > Sent: Monday, May 7, 2018 2:40 PM > To: Zhao1, Wei; dev@dpdk.org > Cc: adrien.mazarg...@6wind.com > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS key array error > > > -Original Message

Re: [dpdk-dev] [PATCH 3/5] net/mlx5: add new Memory Region support

2018-05-07 Thread Yongseok Koh
On Sun, May 06, 2018 at 05:53:18AM -0700, Shahaf Shuler wrote: > Hi Koh, > > Huge work. It takes (and will take) me some time to process. > In the meanwhile find some small comments. > > As this design heavily relies on synchronization (cache flush) between the > control thread and the data pat

Re: [dpdk-dev] [PATCH] net/e1000: add minimum support for Broadcom 54616 PHY

2018-05-07 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Thursday, January 18, 2018 8:40 AM > To: Chas Williams > Cc: dev@dpdk.org; skh...@vmware.com; Charles (Chas) Williams; Chas > Williams > Subject: Re: [dpdk-dev] [PATCH] net/e1000: add minimum s

Re: [dpdk-dev] [PATCH v2] net/ixgbe: Add API to update SBP bit

2018-05-07 Thread Zhang, Helin
> -Original Message- > From: Shweta Choudaha [mailto:shweta.choud...@gmail.com] > Sent: Tuesday, April 10, 2018 11:43 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo; Ananyev, Konstantin; Zhang, Helin; Yigit, Ferruh; > shweta.choud...@att.com > Subject: [PATCH v2] net/ixgbe: Add API to update SBP

Re: [dpdk-dev] [PATCH v5] net/i40e: fix disabling promiscuous mode

2018-05-07 Thread Zhang, Helin
> -Original Message- > From: Xu, Rosen > Sent: Saturday, April 28, 2018 7:39 PM > To: dev@dpdk.org > Cc: Zhang, Helin; Zhang, Qi Z; Wu, Jingjing; sta...@dpdk.org > Subject: [PATCH v5] net/i40e: fix disabling promiscuous mode > > v5 updates: > === > - Modificate some comments for

Re: [dpdk-dev] [PATCH v2] net/i40e: fix missing some offload capabilities

2018-05-07 Thread Zhang, Helin
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 2, 2018 1:40 PM > To: Wu, Yanglong; dev@dpdk.org > Cc: Zhang, Helin; Dai, Wei > Subject: RE: [PATCH v2] net/i40e: fix missing some offload capabilities > > > -Original Message- > > From: Wu, Yanglong > > Sent: Saturd

Re: [dpdk-dev] [PATCH 2/2] net/vhost: insert/strip VLAN header in software

2018-05-07 Thread Yao, Lei A
Hi, Jan For this patch, I find it will break the VM2VM Iperf test as it clear the of_flags. "bufs[i]->ol_flags = 0;" Could you have a check on this? The test step to reproduce this issue: 1. Lauch testpmd with two vhost-user port, using IO fwd mode testpmd -c 0xe -n 4 --socket-mem 1024,1024 \ --l

[dpdk-dev] [PATCH v3 2/2] net/tap: support TSO (TCP Segment Offload)

2018-05-07 Thread Ophir Munk
This commit implements TCP segmentation offload in TAP. librte_gso library is used to segment large TCP payloads (e.g. packets of 64K bytes size) into smaller MTU size buffers. By supporting TSO offload capability in software a TAP device can be used as a failsafe sub device and be paired with anot

[dpdk-dev] [PATCH v3 0/2] TAP TSO

2018-05-07 Thread Ophir Munk
v1: - Initial release v2: - Fixing cksum errors - TCP segment size refers to TCP payload size (not including l2,l3,l4 headers) v3: - Bug fixing in case input mbuf is segmented - Following review comments by Raslan Darawsha This patch implements TAP TSO (TSP segmentation offload) in SW. It uses

[dpdk-dev] [PATCH v3 1/2] net/tap: calculate checksums of multi segs packets

2018-05-07 Thread Ophir Munk
Prior to this commit IP/UDP/TCP checksum offload calculations were skipped in case of a multi segments packet. This commit enables TAP checksum calculations for multi segments packets. The only restriction is that the first segment must contain headers of layers 3 (IP) and 4 (UDP or TCP) Reviewed-

Re: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for reference counters

2018-05-07 Thread Yongseok Koh
> On May 5, 2018, at 11:37 PM, Shahaf Shuler wrote: > > Thursday, May 3, 2018 2:17 AM, Yongseok Koh: >> Subject: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for >> reference counters >> >> Remove debug messages when getting an object. When releasing an object, >> debug message will be

[dpdk-dev] [PATCH v2 1/1] test: fix build with GCC 4.8.5

2018-05-07 Thread Erik Gabriel Carrillo
Build errors occur on CentOS 7 with GCC 4.8.5 20150623 in the event_timer_adapter_test autotest; the -Werror=missing-field-initializers option causes the compiler to emit messages like "error: missing initializer for field ‘priority’ of ‘struct ’" in several places. Add -Wno-missing-field-initiali

Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5

2018-05-07 Thread Carrillo, Erik G
> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, May 4, 2018 11:55 PM > To: Carrillo, Erik G > Cc: jerin.ja...@caviumnetworks.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 1/1] test: fix build with GCC 4.8.5 > > On Fri, 4 May 2018

Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: free eth dev port in case of error

2018-05-07 Thread Yongseok Koh
On Mon, May 07, 2018 at 06:10:33PM +0300, Raslan Darawsheh wrote: Please refine the title. No use of 'eth dev...' > If something went wrong in mlx5 pci prop need to free the eth_dev > that was previously allocated during the port setup. Shouldn't it be sent to stable branches if it is a bug? >

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
Hi Yongseok, Thx for your review. But I already sent a V2 for this patch which handles the redundant goto that I had. But still missing the fix for title. I'll submit a v3 tomorrow with a fixed title. Kindest regards Raslan Darawsheh From: Yongseok Koh Sent: Mo

Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Yongseok Koh
> On May 7, 2018, at 5:18 AM, Raslan Darawsheh wrote: Please don't use PMD/code specific words in the title. I suggest: net/mlx5: fix double free on error handling > When attr_ctx is NULL it will attempt to free the list of devices twice. > So, changing it to be freed in error handling

Re: [dpdk-dev] [v3, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

2018-05-07 Thread Akhil Goyal
On 5/6/2018 12:17 AM, Abhinandan Gujjar wrote: Signed-off-by: Abhinandan Gujjar --- drivers/event/sw/sw_evdev.c| 13 +++ lib/librte_eventdev/rte_eventdev.c | 25 + lib/librte_eventdev/rte_eventdev.h | 54 ++ lib/librte_eventdev/rte_eventdev_pmd.h | 187 +++

[dpdk-dev] [PATCH v2] net/failsafe: fix starting failsafe with invalid MAC

2018-05-07 Thread Raslan Darawsheh
hotplug alarm is the mechanism used to initialize the failsafe process (trying to reconfigure all failsafe sub devices every few seconds.) When starting failsafe with a MAC option, and giving it an invalid MAC address this will lead to a NULL pointer for the dev private field. Then when the hotplu

[dpdk-dev] [PATCH v2 2/2] net/mlx5: free eth dev port in case of error

2018-05-07 Thread Raslan Darawsheh
If something went wrong in mlx5 pci prop need to free the eth_dev that was previously allocated during the port setup. Signed-off-by: Raslan Darawsheh --- v2 changes: Reword the commit log. --- --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/m

[dpdk-dev] [PATCH v2 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
When attr_ctx is NULL it will attempt to free the list of devices twice. Avoid double freeing the list by directly going to error handling. Fixes: 771fa900 ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- v2 changes: Better

Re: [dpdk-dev] [PATCH v2] crypto/mrvl: rename PMD to mvsam

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Tomasz Duszynski [mailto:t...@semihalf.com] > Sent: Friday, April 27, 2018 8:15 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > d...@marvell.com; Tomasz Duszynski ; Natalie Samsonov > > Subject: [PATCH v2] crypto/mrvl: rename PMD to mvsam > > Picking a

Re: [dpdk-dev] Compiling DPDK with CentOS6

2018-05-07 Thread Thomas Monjalon
07/05/2018 09:15, Shahar Salzman: > OK, we are building dpdk from sources, used version 16.07, but would like to > upgrade to a newer version in order to be inline with spdk master. > > On the supported OS page RHEL6.5 is mentioned as supported (uses the 4.4.X > gcc collection), is the page outd

Re: [dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue pairs to 2

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of De Lara Guarch, Pablo > Sent: Friday, April 20, 2018 5:00 PM > To: Akhil Goyal ; Hemant Agrawal > ; dev@dpdk.org > Cc: Nipun Gupta > Subject: Re: [dpdk-dev] [PATCH 4/4] crypto/dpaa_sec: update maximum queue > pai

Re: [dpdk-dev] [PATCH 02/13] doc/turbo_sw: update Wireless Baseband Device documentation

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kamil Chalupnik > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [dpdk-dev] [PATCH 02/13] doc/turbo_sw: update Wireless Bas

Re: [dpdk-dev] [PATCH 09/13] bbdev: measure offload cost

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 09/13] bbdev: measure offload cost > ... > --- a/lib/librte_bbdev/rte_bbdev.h > +++ b/lib/lib

Re: [dpdk-dev] [PATCH 08/13] app/bbdev: update test vectors names

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 08/13] app/bbdev: update test vectors names > > From: KamilX Chalupnik > > Update test vector

Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter

2018-05-07 Thread Jerin Jacob
-Original Message- > Date: Mon, 7 May 2018 18:02:04 +0530 > From: Akhil Goyal > To: Jerin Jacob , Abhinandan Gujjar > > CC: hemant.agra...@nxp.com, akhil.go...@nxp.com, dev@dpdk.org, > narender.vang...@intel.com, nikhil@intel.com, gage.e...@intel.com > Subject: Re: [dpdk-dev] [v3,1/

Re: [dpdk-dev] [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-16 16]

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 05/13] baseband/turbo_sw: scalling input LLR to range [-16 16] What is LLR? It is worth expandi

Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter

2018-05-07 Thread Akhil Goyal
Hi Jerin, Abhinandan, Overall the patch looks good. But one comment on block diagram for OP_NEW mode functioning. The comment was also made on previous version but it looks the intent was misunderstood. On 5/7/2018 3:05 PM, Jerin Jacob wrote: -Original Message- Date: Sun, 6 May 2018

[dpdk-dev] [PATCH] driver/octeontx: disable PMD for buggy compilers

2018-05-07 Thread Pavan Nikhilesh
Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64. Signed-off-by: Pavan Nikhilesh --- mk/toolchain/gcc/rte.toolchain-compat.mk | 8 1 file changed, 8 insertions(+) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.t

Re: [dpdk-dev] [v3, 5/5] doc: add event crypto adapter documentation

2018-05-07 Thread Jerin Jacob
-Original Message- > Date: Sun, 6 May 2018 00:17:10 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [PATCH 04/13] baseband/turbo_sw: memcpy changed or removed from driver

2018-05-07 Thread De Lara Guarch, Pablo
> -Original Message- > From: Chalupnik, KamilX > Sent: Thursday, April 26, 2018 2:30 PM > To: dev@dpdk.org > Cc: Mokhtar, Amr ; De Lara Guarch, Pablo > ; Chalupnik, KamilX > > Subject: [PATCH 04/13] baseband/turbo_sw: memcpy changed or removed from > driver > It is not clear what this

[dpdk-dev] [PATCH 2/2] net/mlx5: add free for eth dev port in case of error

2018-05-07 Thread Raslan Darawsheh
in case of errors need to free the eth_dev port that was allocated during the port setup. Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d34076b..63c94ad 100644 --- a/driver

[dpdk-dev] [PATCH 1/2] net/mlx5: fix multiple free issue when attr ctx is NULL

2018-05-07 Thread Raslan Darawsheh
When attr_ctx is NULL it will attempt to free the list of devices twice. So, changing it to be freed in error handling only. Fixes: 771fa900 ("mlx5: introduce new driver for Mellanox ConnectX-4 adapters") Cc: sta...@dpdk.org Signed-off-by: Raslan Darawsheh --- drivers/net/mlx5/mlx5.c | 3 ++- 1

[dpdk-dev] [PATCH] net/failsafe: fix starting failsafe with invalid MAC

2018-05-07 Thread Raslan Darawsheh
When starting failsafe with mac option, and giving it an invalid MAC. It will cause a segmentation fault due to the hotplug_alarm installed on an invalid subdev. Fixes: a46f8d58 ("net/failsafe: add fail-safe PMD") Signed-off-by: Raslan Darawsheh --- drivers/net/failsafe/failsafe.c | 4 +++- 1 fi

Re: [dpdk-dev] [PATCH net-next v4 0/4] set ixgbe/ixgbevf EITR for performance

2018-05-07 Thread Tonghao Zhang
Hi Ferruh, Qi: This version is ok ? On Sat, Apr 28, 2018 at 11:03 AM, wrote: > From: Tonghao Zhang > > v4: for reducing config options, remove the config option and use the > default value defined in header file. Remove the patch: > http://dpdk.org/dev/patchwork/patch/36433 > > reba

Re: [dpdk-dev] [PATCH 3/3] net/mlx5: add Multi-Packet Rx support

2018-05-07 Thread Shahaf Shuler
Hi Koh, Nice work. Please see some comments. Thursday, May 3, 2018 2:21 AM, Yongseok Koh: > Subject: [dpdk-dev] [PATCH 3/3] net/mlx5: add Multi-Packet Rx support > > Multi-Packet Rx Queue (MPRQ a.k.a Striding RQ) can further save PCIe > bandwidth by posting a single large buffer for multiple pa

Re: [dpdk-dev] [v3,4/5] test: add event crypto adapter auto-test

2018-05-07 Thread Jerin Jacob
-Original Message- > Date: Sun, 6 May 2018 00:17:09 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

Re: [dpdk-dev] [v3, 2/5] eventdev: add APIs and PMD callbacks for crypto adapter

2018-05-07 Thread Jerin Jacob
-Original Message- > Date: Sun, 6 May 2018 00:17:07 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

[dpdk-dev] [PATCH] app/testpmd: fix invalid memory access

2018-05-07 Thread Qi Zhang
When calulate memory size of an RTE_FLOW_ITEM_TYPE_RAW 's mask mask->length is not the real size of binary pattern, it should take spec->length, or memory size will be over counted (0x) and invalid memory be access during following memcpy. Fixes: d0ad8648b1c5 ("app/testpmd: fix RSS flow action

Re: [dpdk-dev] [v3,1/5] eventdev: introduce event crypto adapter

2018-05-07 Thread Jerin Jacob
-Original Message- > Date: Sun, 6 May 2018 00:17:06 +0530 > From: Abhinandan Gujjar > To: jerin.ja...@caviumnetworks.com, hemant.agra...@nxp.com, > akhil.go...@nxp.com, dev@dpdk.org > CC: narender.vang...@intel.com, abhinandan.guj...@intel.com, > nikhil@intel.com, gage.e...@intel.com

[dpdk-dev] [PATCH v1] net/tap: fix isolation mode toggling

2018-05-07 Thread Ophir Munk
Running testpmd command "flow isolae 0" (i.e. disabling flow isolation) followed by command "flow isolate 1" (i.e. enabling flow isolation) may result in a TAP error: PMD: Kernel refused TC filter rule creation (17): File exists Root cause analysis: when disabling flow isolation we keep the loca

Re: [dpdk-dev] [PATCH v2] mempool: fix alignment of memzone length when populating

2018-05-07 Thread Andrew Rybchenko
On 05/07/2018 11:18 AM, Olivier Matz wrote: When populating a mempool with the default function, if there is not enough virtually contiguous memory for the whole mempool, it will be populated with several chunks. A chunk of the maximum available length is requested with: mz = rte_memzone_rese

[dpdk-dev] [PATCH v2] mempool: fix alignment of memzone length when populating

2018-05-07 Thread Olivier Matz
When populating a mempool with the default function, if there is not enough virtually contiguous memory for the whole mempool, it will be populated with several chunks. A chunk of the maximum available length is requested with: mz = rte_memzone_reserve_aligned(..., len=0, ..., align=x) If align

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-05-07 Thread Zhao1, Wei
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Friday, May 4, 2018 5:45 PM > To: Zhao1, Wei > Cc: Peng, Yuan ; dev@dpdk.org; Xu, Qian Q > ; Liu, Yu Y ; Lu, Wenzhuo > ; Wu, Jingjing > Subject: Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-05-07 Thread Peng, Yuan
Hi Adrien, I configure the command as: testpmd> flow create 0 ingress pattern end actions rss types udp end queues 5 end / end Flow rule #0 created The rule can be set successfully. It seems like you have added several parameter to the feature, and modified the command format. testpmd> flow crea

Re: [dpdk-dev] [PATCH v6 07/16] ethdev: flatten RSS configuration in flow API

2018-05-07 Thread Peng, Yuan
Hi Adrien, The third problem which use ixgbe NIC: I add " key_len 0 types ip udp end " to the command "flow create 0 ingress pattern end actions rss queues 5 6 7 end / end" It shows: testpmd> flow create 0 ingress pattern end actions rss queues 5 6 7 end / key_len 0 types ip udp end / end Bad ar

Re: [dpdk-dev] [PATCH v7] ethdev: check Rx/Tx offloads

2018-05-07 Thread Dai, Wei
Thanks to Shuler and Ferruh for your feedback and guidance. PMD at least has these 2 options with this patch: a). If PMD doesn't want to make much more changes, it still can do "[rt]x_conf->offloads |= dev->data->dev_conf.rxmode.offloads;" in the beginning of its specific queue_setup( ) and ju

Re: [dpdk-dev] Compiling DPDK with CentOS6

2018-05-07 Thread Shahar Salzman
OK, we are building dpdk from sources, used version 16.07, but would like to upgrade to a newer version in order to be inline with spdk master. On the supported OS page RHEL6.5 is mentioned as supported (uses the 4.4.X gcc collection), is the page outdated? From