/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c: In function 
‘qed_slowpath_start’:
/home/agreen/projects/dpdk/drivers/net/qede/qede_main.c:307:3: error: ‘strncpy’ 
output may be truncated copying 12 bytes from a string of length 127 
[-Werror=stringop-truncation]
   strncpy((char *)drv_version.name, (const char *)params->name,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    MCP_DRV_VER_STR_SIZE - 4);
    ~~~~~~~~~~~~~~~~~~~~~~~~~
---
 drivers/net/qede/qede_main.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index 2333ca073..243851da6 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -305,7 +305,8 @@ static int qed_slowpath_start(struct ecore_dev *edev,
                    (params->drv_rev << 8) | (params->drv_eng);
                /* TBD: strlcpy() */
                strncpy((char *)drv_version.name, (const char *)params->name,
-                       MCP_DRV_VER_STR_SIZE - 4);
+                       sizeof(drv_version.name) - 1);
+               drv_version.name[sizeof(drv_version.name) - 1] = '\0';
                rc = ecore_mcp_send_drv_version(hwfn, hwfn->p_main_ptt,
                                                &drv_version);
                if (rc) {

Reply via email to