> On May 5, 2018, at 11:37 PM, Shahaf Shuler <shah...@mellanox.com> wrote: > > Thursday, May 3, 2018 2:17 AM, Yongseok Koh: >> Subject: [dpdk-dev] [PATCH 1/5] net/mlx5: trim debug messages for >> reference counters >> >> Remove debug messages when getting an object. When releasing an object, >> debug message will be printed only if the object is really freed. >> >> Signed-off-by: Yongseok Koh <ys...@mellanox.com> >> --- > > Only one general comment as you are making some order here. > > I think it will be better to be explicit in the logging. Saying when new > object is created: > "port %u new <obj type> ...<pointer> .. for queue ... " > > No need for the refcnt as it is obviously 0. > > And when object is destroyed: > "port %u <obj type>.. <pointer> ... for queue... is destroyed"
I'd rather drop this patch. This is Nelio's code and he might still want to keep it. As he is now OOO, we can't hear from him. This patch is nothing but cleanup. Thanks, Yongseok
