> -----Original Message-----
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Kamil Chalupnik
> Sent: Thursday, April 26, 2018 2:30 PM
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokh...@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.gua...@intel.com>; Chalupnik, KamilX
> <kamilx.chalup...@intel.com>
> Subject: [dpdk-dev] [PATCH 02/13] doc/turbo_sw: update Wireless Baseband
> Device documentation
> 
> From: KamilX Chalupnik <kamilx.chalup...@intel.com>
> 
> Update the documentation describing Wireless Baseband Device:
> - device capabilities updated
> - input/output data buffers description added
> - details about implementation of turbo encode/decode
>   operation added
> 
> Signed-off-by: Kamil Chalupnik <kamilx.chalup...@intel.com>
> ---

...

> 
> @@ -216,7 +216,10 @@ relation to Turbo Encoding and Decoding operations.
>                      RTE_BBDEV_TURBO_SUBBLOCK_DEINTERLEAVE |
>                      RTE_BBDEV_TURBO_POS_LLR_1_BIT_IN |
>                      RTE_BBDEV_TURBO_NEG_LLR_1_BIT_IN |
> -                    RTE_BBDEV_TURBO_CRC_TYPE_24B,
> +                    RTE_BBDEV_TURBO_CRC_TYPE_24B |
> +                    RTE_BBDEV_TURBO_DEC_TB_CRC_24B_KEEP |
> +                    RTE_BBDEV_TURBO_EARLY_TERMINATION,
> +                .max_llr_modulus = 16,

This is added in a later patch, so I suggest either leave this patch to the end 
of the patchset
Or add this in the patch introducing it.

Also, could you reorder the patchset, so patches targeting the same component 
goes together?
Keep the first one, and then patches affecting the library/driver go first, 
then the apps and finally documentation.

Thanks,
Pablo

Reply via email to