Re: Review Request 14075: Added new test for Load balancing rules in a VPC

5b5a617544fb8160b9429a24f1aa943e04d4f98a) - Sheng Yang On Sept. 18, 2013, 2:28 p.m., Ashutosh Kelkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14058/#review26402 --- Please test it before submit. - Sheng Yang On Sept. 18, 2013, 2

Re: com.cloud.exception.InsufficientServerCapacityException what wrong?

Log is needed to tell what's wrong. Basically it means you don't have enough resources(host or network or storage) to deploy the vm. --Sheng On Tue, Sep 24, 2013 at 12:27 AM, Jake.liu wrote: >DeployDestination dest; > try { > dest = _dpMgr.planDeployment(vmProfile, pla

[PROPOSAL] Site-to-site VPN between two virtual routers

Hi, I'd like to propose "site-to-site VPN between VRs" as a new feature for CloudStack 4.3. Basically the VPC's site-to-site VPN currently only support to access remote peer which is a hardware VPN gateway. This feature would extend the support to other CloudStack VRs, which enabled CloudStack ne

Re: [DISCUSS] Release Managers for future ACS releases - enhacement

I think one way is, we can just enable the default assigner(maintainer) for components in Jira. The components can be break down into further smaller parts, to make sure one guy's work is not big. And the maintainer for the different components can communicate(just like RM did) to assign the bug(or

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > th

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > th

Re: Review Request 14058: Including tests for VPC VM Lifecycle on Tagged hosts

> On Sept. 26, 2013, 1:30 a.m., Sheng Yang wrote: > > Please test it before submit. > > Ashutosh Kelkar wrote: > The tests have been tested and run correctly. There is a manual step > needed in setup for these tests - Adding host tags to the hosts which is why > th

Re: [DISCUSS] Components in JIRA and bug assignment

+1 to the approach. One basic rule for component maintainer to assign the ticket, can be: Fix your own code. If the bug is introduced by a certain commit(etc, using 'git blame'), it would go to the committer to fix or revert it, unless someone else volunteer to fix it. Of course sometime it wouldn

Re: why are RvR routers not HA

Yes it's mostly an implementation issue. We evaluated the situation and think it's too complex and too much effort to enable HA plus VRRP, so we decide to drop HA to simply and make things more stable. Here are some reference of how RvR works, hope it would help. https://cwiki.apache.org/confluen

Re: Review Request 15047: Add support for multiple networks in the 'per account' source nat type setting

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15047/#review27795 --- Ship it! Ship It! - Sheng Yang On Oct. 29, 2013, 8:24 p.m

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review27794 --- Ship it! Ship It! - Sheng Yang On Oct. 29, 2013, 8:52 p.m

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

> On Oct. 30, 2013, 5:34 p.m., Sheng Yang wrote: > > Ship It! No shipping for now. Sorry, press the wrong one. I meant to ship the other patch. Will, since it's a big change, could you send out a notice to the community about this merge? Tha

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

> On Oct. 30, 2013, 5:34 p.m., Sheng Yang wrote: > > Ship It! > > Sheng Yang wrote: > No shipping for now. > > Sorry, press the wrong one. I meant to ship the other patch. > > Will, since it's a big change, could you send out a notice t

Re: [Merge] Palo Alto Networks firewall integration to master

Nice work Will! I've checked the code, it included the UI part and unit test as well. Really impressed! Just one comment: you can git-format-patch to generate the patch. It would includes author and description information automatically, which is easier for applying. +1! --Sheng On Thu, Oct

Re: [Merge] Palo Alto Networks firewall integration to master

Sure, I would be glad to commit it for 4.3 release. --Sheng On Mon, Nov 4, 2013 at 8:19 AM, Chip Childers wrote: > On Mon, Nov 04, 2013 at 10:59:30AM -0500, Will Stevens wrote: > > Well its not in master yet. That is the intent of this thread... > > > > I can definitely do some testing for the

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

> On Nov. 4, 2013, 10:44 p.m., Sheng Yang wrote: > > Hi Will, > > > > I think you need to rebase the patch to the latest MASTER, the current > > patch cannot apply to MASTER now. > > > > Also, you can add description to the patch(e.g. the description

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

, the current patch cannot apply to MASTER now. Also, you can add description to the patch(e.g. the description you added in the review board) - Sheng Yang On Nov. 1, 2013, 9:10 p.m., Will Stevens wrote: > > --- > T

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#review28280 --- Ship it! Ship It! - Sheng Yang On Nov. 6, 2013, 3:42 a.m., Will

Re: Review Request 15050: Add Palo Alto Networks Firewall Integration

> On Nov. 6, 2013, 6:08 p.m., Sheng Yang wrote: > > Ship It! Committed to MASTER. Thank you Will! - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15050/#re

Re: [Merge] Palo Alto Networks firewall integration to master

Looks good to me. Applied to MASTER branch. Thanks! --Sheng On Tue, Nov 5, 2013 at 7:51 PM, Will Stevens wrote: > @Sheng: This should be ready to go now. I built the patch from tonight's > master and I included a more detailed commit message as you requested. Let > me know if you have any

Re: [Merge] Palo Alto Networks firewall integration to master

From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On > > Behalf Of Will Stevens > > Sent: Wednesday, November 06, 2013 10:15 AM > > To: dev@cloudstack.apache.org > > Subject: Re: [Merge] Palo Alto Networks firewall integration to master > > > > Great! Thank y

Re: [Merge] Palo Alto Networks firewall integration to master

Thu, Nov 7, 2013 at 1:46 PM, Sheng Yang wrote: > > > Fixed. > > > > --Sheng > > > > > > On Thu, Nov 7, 2013 at 10:23 AM, Animesh Chaturvedi < > > animesh.chaturv...@citrix.com> wrote: > > > > > Fails RAT on > >

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

Hi Daan, I think your patch is completely wrong. The BroadcastDomainType.getValue() would accept format of URI, not the number. I don't think your change would work, either in code or by semantic. I think your commit would break all elements your code touched. The current assumption of vlanId an

Re: SRX inline with VR

Hi Geoff, Currently we don't support VR as load balancing alone, there are some VR limitations need to be solved. I think the current plan is to fix it in Felton. --Sheng On Fri, Nov 8, 2013 at 6:19 AM, Geoff Higginbottom < geoff.higginbot...@shapeblue.com> wrote: > All, > > > > Is it possibl

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

equirement and am happy to discuss better implementations and the > >scope of validity of vlan-ids and broadcast uris but the feature it > >fulfills is very needed (and works). > > > >kind regards, > >Daan > > > >On Fri, Nov 8, 2013 at 1:35 AM, Sheng Yang wr

Re: Commit 25c8cee01a450ee924fe108cafe54b046485ab2b broke Vmware on Master

ms you want to make sure vlan is numeric and let BroadcastDomainType.getValue() accept it(which would only accept URI)? I don't think that would work. --Sheng On Fri, Nov 8, 2013 at 10:15 AM, Sheng Yang wrote: > Hi Daan, > > Your commit has broken BOTH VMware and JuniperSRX, and these

Re: SRX inline with VR

Sorry, I meant the CloudStack major release after 4.3... Got mixed up a little bit... --Sheng On Fri, Nov 8, 2013 at 9:57 AM, Sheng Yang wrote: > Hi Geoff, > > Currently we don't support VR as load balancing alone, there are some VR > limitations need to be solved. I think th

Regarding the ssl key store change

Hi Wei, I found this change in the MASTER. commit 57ba367f3c985e80ea1b34267e298b481a353298 Author: Wei Zhou Date: Thu Nov 7 11:09:06 2013 +0100 CLOUDSTACK-5042: change cloud.keystore to cloudmanagementserver.keystore and install it (cherry picked from commit de448ec4792eda5b47d79b26e9cb8c

Re: Regarding the ssl key store change

> > Wei ZHOU > > Innovation Engineer Cloud, LeaseWeb B.V. > > w.z...@leaseweb.com > > > > *From:* Sheng Yang [mailto:sh...@yasker.org] > *Sent:* 09 November 2013 01:27 > *To:* Wei Zhou; > *Subject:* Regarding the ssl key store change > > > > Hi W

Re: SRX inline with VR

t; on its own" > > Regards > > Geoff Higginbottom > > D: +44 20 3603 0542 | S: +44 20 3603 0540 | M: +447968161581 > > geoff.higginbot...@shapeblue.com > > -Original Message- > From: Sheng Yang [mailto:sh...@yasker.org] > Sent: 08 November 2013

Re: Coverage Analysis: Few Issues

Hi Will, Could you check on Palo Alto's duplicate api commands? They suppose to be merged as one command I think. BTW, how can this works? Did it broke SRX? --Sheng On Thu, Nov 14, 2013 at 2:55 AM, Santhosh Edukulla < santhosh.eduku...@citrix.com> wrote: > Team, > > While running code coverag

Re: Coverage Analysis: Few Issues

time. I was under the impression that >> I was supposed to override those commands. Once I got things working I did >> not go back over this, so I am sure I can improve this aspect of the plugin. >> >> Thanks, >> >> Will >> >> >> >

Re: [ACS421] Closing Resolved defects

ix done and close these defects > > Reporter Total > Grand Total77 > angeline shen6 > Sailaja Mada 6 > Prachi Damle 4 > Rayees Namathponnan4 > Sheng Yang 4 > Chandan Purushothama 3 > Likitha Shett

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

/#comment42876> I think it's wrong here. Firewall is only firewall, it won't and shouldn't response to the ICMP or other request, unless port forwarding or static nat rule configured. - Sheng Yang On May 20, 2013

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

OK, I would just go ahead and merge it. --Sheng On Thu, May 16, 2013 at 8:03 PM, Hiroaki KAWAI wrote: > +1 > > I'm sorry that I could not make time to respond. > I'll catch up after the merge. > > > (2013/05/17 3:57), Chip Childers wrote: > >> On Thu, May 16, 2013 at 06:55:30PM +, Chiradeep

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review20799 --- Ship it! Shipped. PVLAN migration support shipped with it. - Sheng

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

> On May 20, 2013, 7 p.m., Sheng Yang wrote: > > plugins/network-elements/juniper-srx/src/com/cloud/network/resource/JuniperSrxResource.java, > > line 854 > > <https://reviews.apache.org/r/11224/diff/2/?file=293966#file293966line854> > > > > I

Re: Review Request: Fixed SRX icmp firewall rule configuration issue

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11224/#review20857 --- I am fine with "Ship it". - Sheng Yang On May 20, 2013

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

se ovs command explicitly. > > Signed-off-by: Hiroaki KAWAI > > > - ASF > > On May 27th, 2013, 1:46 a.m., Hiroaki Kawai wrote: > Review request for cloudstack, Sheng Yang and Hugo Trippaers. > By Hiroaki Kawai. > > *Updated May 27, 2013, 1:46 a.m.* > Descripti

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

On Tue, May 28, 2013 at 11:17 PM, Hiroaki KAWAI wrote: > Hi, > > Thank you for comments; > > > (2013/05/29 9:32), Sheng Yang wrote: > >> I saw it a bit late... >> >> But I just found it need to depends on >> agent.properties: network.bridge.type=**op

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

On Wed, May 29, 2013 at 12:09 AM, Hugo Trippaers < htrippa...@schubergphilis.com> wrote: > > > > -Original Message- > > From: Hiroaki KAWAI [mailto:ka...@stratosphere.co.jp] > > Sent: Wednesday, May 29, 2013 8:39 AM > > To: Sheng Yang > > Cc:

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

On Wed, May 29, 2013 at 2:59 PM, Hugo Trippaers < htrippa...@schubergphilis.com> wrote: > > > Sent from my iPhone > > On 29 mei 2013, at 22:29, "Sheng Yang" wrote: > > On Wed, May 29, 2013 at 12:09 AM, Hugo Trippaers < > htrippa...@schubergphilis.com

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

On Wed, May 29, 2013 at 5:24 PM, Hiroaki KAWAI wrote: > HI, > To make clear I'd like note: > > 1. openvswich is available in distros, both in > Ubuntu 13.04 and Fedora 18 > > 2. brcompat is removed in openvswitch v1.10.0 > Please have a look at > http://openvswitch.org/**releases/NEWS-1.10.0

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

On Wed, May 29, 2013 at 8:57 PM, Hiroaki KAWAI wrote: > (2013/05/30 9:28), Sheng Yang wrote: > >> 3. some tutorial on Ubuntu below: >> > -snip- > >> --**__--- >> >> >> >> Probably we need a wiki for that

Re: Test halting build every now and then

I tried to look into this, but it's really hard for me to reproduce it(I've run the case for 50 times and no show of the issue). The bash command I used is: for i in {1..50}; do mvn -Dtest=NioTest test -pl utils; done >From the log, it looks like server is up but client didn't connect to the serv

Re: Test halting build every now and then

Eclipse didn't complain for me. BTW: I am using Linux as development environment. --Sheng On Wed, Jun 12, 2013 at 1:48 PM, Daan Hoogland wrote: > Macosx? > Eclipse? > > I will try on windows sometime soon (with wireless). > > -Original Message- > F

Re: Test halting build every now and then

re.com> wrote: > In my case, I see it when running > > mvn -P developer,systemvm clean install > > from the Terminal in Mac OS X. > > Removing clean seems to give it a better shoot at not halting. > > > On Wed, Jun 12, 2013 at 3:11 PM, Sheng Yang wrote: > > >

Re: Git question about applying patch files

You should use git-rebase rather than git-merge if the patches are in relatively small numbers. I doubt git-format-patch would get the correct result if your patches are not the top commits. So you maybe want: git checkout master git pull git checkout solidfire_plugin git rebase master git format

Re: Git question about applying patch files

Well, base on your situation, seems only thing you can do is use git-merge to merge your branch back to master. But since you're not a committer, so you cannot push (merged) master directly. Some time people would create another remote repo and ask for pull. But that's for very big changes mostly.

Re: SRX Integration Issues.

It looks like a string issue of Java itself. What exactly failed on test.xml? --Sheng On Fri, Jun 14, 2013 at 9:55 AM, Sean Truman wrote: > I am using untagged VLAN on my public side. It's failing on the test.xml > looking for trust group! > > Sean > > On Jun 14, 2013, at 11:51 AM, Jayapal Red

Re: SRX Integration Issues.

ng, plus it's all over > SSL so I cannot see the traffic being passed using tcpdump. > > Sean > > On Jun 14, 2013, at 12:54 PM, Sheng Yang wrote: > > > It looks like a string issue of Java itself. What exactly failed on > > test.xml? > > > > --Sheng > &

Re: SRX Integration Issues.

0 PM, Sean Truman wrote: > > > Looking through the source their isn't much logging, plus it's all over > > SSL so I cannot see the traffic being passed using tcpdump. > > > > Sean > > > > On Jun 14, 2013, at 12:54 PM, Sheng Yang wrote: >

Re: Bugs on Master

Could you check if following commit fixed your problem? It's checked in 3 hours ago. commit 4b2eb18cfc82093640b2cb6c47c0378e69b9f8a2 Author: Jessica Wang Date: Fri Jun 14 14:17:50 2013 -0700 CLOUDSTACK-2981: UI - create network offering - fix a bug that provider dropdown always bounced bac

Baremetal re-enabling

Hi, Due to absent of Frank, I've tried to make sure Baremetal wouldn't miss 4.2. So for the last a few days work, I am able to re-enable baremetal for master. It turn out the change is not big, and most of it just compose of revert of previous change, and I fixed some issues brought by the new fe

Re: Baremetal re-enabling

ed changes are merged > back in as well? In case they were dropped at some point. > > -Alena. > > On 6/18/13 1:53 PM, "Sheng Yang" wrote: > > >Hi, > > > >Due to absent of Frank, I've tried to make sure Baremetal wouldn't miss > >4.2. So

Re: Baremetal re-enabling

On Tue, Jun 18, 2013 at 2:59 PM, Alena Prokharchyk < alena.prokharc...@citrix.com> wrote: > On 6/18/13 2:44 PM, "Sheng Yang" wrote: > > >It seems no change has been done for db upgrade part(no reverting I > >meant). > > > >If it's incorrec

Re: Baremetal re-enabling

Done DB upgrading code, and tested. I've created a new branch baremetal-4.2 for review. --Sheng On Tue, Jun 18, 2013 at 3:16 PM, Sheng Yang wrote: > On Tue, Jun 18, 2013 at 2:59 PM, Alena Prokharchyk < > alena.prokharc...@citrix.com> wrote: > >> On 6/18/13 2:

Re: CLOUDSTACK-2534 - Automation Blocker

Committed a fix and later found it's not right. The correct key file is at: /var/cloudstack/management/.ssh/id_rsa, which owned by user cloud and has 600 permission. --Sheng On Tue, Jun 18, 2013 at 3:37 PM, Rayees Namathponnan < rayees.namathpon...@citrix.com> wrote: > Hi All, > > Is some poss

Review Request: Re-enabling baremetal for 4.2/master

https://issues.apache.org/jira/browse/CLOUDSTACK-1610 https://issues.apache.org/jira/browse/CLOUDSTACK-1618 https://issues.apache.org/jira/browse/CLOUDSTACK-1614 https://issues.apache.org/jira/browse/CLOUDSTACK-1440 Thanks, Sheng Yang

[Review Request] Re-enabling baremetal on master

Hi, I've created the https://reviews.apache.org/r/11977/ for review. The branch re-enabled the baremetal for master. And all major bugs are cleaned. https://issues.apache.org/jira/browse/CLOUDSTACK-1610 https://issues.apache.org/jira/browse/CLOUDSTACK-1618 https://issues.apache.org/jira/browse/C

Re: [Review Request] Re-enabling baremetal on master

On Wed, Jun 19, 2013 at 11:24 AM, Chip Childers wrote: > On Wed, Jun 19, 2013 at 11:00:33AM -0700, Sheng Yang wrote: > > Hi, > > > > I've created the https://reviews.apache.org/r/11977/ for review. The > > branch re-enabled the baremetal for master.

Some commands didn't show up in the marvin test API

Hi, I just found out that some commands (e.g. AddBaremetalHostCmd, AddBaremetalKickStartPxeCmd) didn't show in the marvin's API(tools/marvin/marvin/cloudstackAPI), make it hard for me to write marvin test case for them. The baremetal function is disabled for master but these commands are still th

Re: [Review Request] Re-enabling baremetal on master

Hi, I've updated baremetal-4.2 branch, added integration test for some of baremetal related APIs, also fixed a bunch of baremetal API issues exposed by the testing. Thanks! --Sheng On Wed, Jun 19, 2013 at 11:41 AM, Chip Childers wrote: > On Wed, Jun 19, 2013 at 11:36:11AM -0700, Sh

Re: [Review Request] Re-enabling baremetal on master

> > Nice! I'm glad the feature has the benefit of tests now. Thanks for > > doing this Sheng! > > > > David - are you comfortable with this, and will you now +1 the feature? > > > > On Thu, Jun 20, 2013 at 9:55 PM, Sheng Yang wrote: > > > Hi,

Re: [ACS42] Three weeks to code freeze

There is one thing need attention: https://issues.apache.org/jira/browse/CLOUDSTACK-3434 Would involve lock mechanism improvement in the VR which has potential big impact. I am planning to check-in the improvement soon(likely this weekend). --Sheng On Tue, Jul 9, 2013 at 7:59 PM, Animesh Chatu

Re: Review Request 12251: Incorporating the review comments given by Alena and Sheng

nfig would modify the file as well. - Sheng Yang On July 13, 2013, 2:33 p.m., bharat kumar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 12517: Fix checks for already existing primary and secondary pvlan id on vmware DVS in pvlan setup

> On July 15, 2013, 11:08 p.m., Sheng Yang wrote: > > Ship It! Committed to the 4.2/MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12517/#re

Re: Review Request 12517: Fix checks for already existing primary and secondary pvlan id on vmware DVS in pvlan setup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12517/#review23188 --- Ship it! Ship It! - Sheng Yang On July 15, 2013, 10:41 p.m

[ACS411] Fix for CLOUDSTACK-3540

Hi, Please cherry-pick the following commit from MASTER(it's already in MASTER and 4.2 branch): commit 9fe1a2b9fabcc655ef4f2db0e384e9953fc9d691 Author: Sheng Yang Date: Mon Jul 15 18:00:11 2013 -0700 CLOUDSTACK-3540: Fix edithosts.sh to prevent removing active dhcp entries IP

Re: Modify Site-to-Site VPN interface to include ID/FQQN capabilites

Hi Ian, I've implemented the S2S vpn, but at this memory I am focus on 4.2 release, so I am afraid I don't have much time for new feature. But you can file a Jira ticket anyway, and probably somebody interested in it in the community would take it. Java is not hard. :) Please make sure you would

Re: [ACS411] Fix for CLOUDSTACK-3540

Done. Thanks! --Sheng On Mon, Jul 15, 2013 at 6:30 PM, Chip Childers wrote: > The branch is free for you to push stuff into. Feel free. > > On Jul 15, 2013, at 9:06 PM, Sheng Yang wrote: > > > Hi, > > > > Please cherry-pick the following commit from MASTER(it

Re: Review Request 12566: Fix NPE when getting resource count

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12566/#review23208 --- Ship it! Ship It! - Sheng Yang On July 16, 2013, 1:43 a.m

Re: Review Request 12566: Fix NPE when getting resource count

> On July 16, 2013, 11:13 p.m., Sheng Yang wrote: > > Ship It! Committed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12566/#re

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

/VmwareStorageProcessor.java <https://reviews.apache.org/r/12612/#comment47079> need proper indent server/src/com/cloud/template/TemplateManagerImpl.java <https://reviews.apache.org/r/12612/#comment47081> How can this happen?? Add Min Chen in reviewer. - Sheng Yang On July 17,

Is it possible for reviewer to add other reviewers in the reviewboard?

Or only submitter can modify it? I find it would be useful if we identify the people who need to review it after it's submitted. --Sheng

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

Created https://issues.apache.org/jira/browse/INFRA-6561 --Sheng On Wed, Jul 17, 2013 at 3:06 PM, Chip Childers wrote: > Open an infra jira issue to get added permissions for reviewboard. > > > On Wed, Jul 17, 2013 at 6:02 PM, Sheng Yang wrote: > > > Or only submitter can

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

> On July 17, 2013, 12:24 a.m., Sheng Yang wrote: > > server/src/com/cloud/template/TemplateManagerImpl.java, line 999 > > <https://reviews.apache.org/r/12612/diff/1/?file=322288#file322288line999> > > > > How can this happen?? Add Min Chen in revie

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/#review23347 --- Ship it! Ship It! - Sheng Yang On July 17, 2013, 11:54 p.m

Re: Review Request 12612: Fix NPE when attaching vmware-tools iso to guest VM on ESX

> On July 17, 2013, 11:57 p.m., Sheng Yang wrote: > > Ship It! Pushed to MASTER and 4.2 Thanks! -Sheng - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12612/#re

Re: Review Request 12716: Fix for NPE

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#review23385 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 2:10 a.m

Re: Is it possible for reviewer to add other reviewers in the reviewboard?

We need some mechanism to help on review board. Sometime the people didn't know who to ask for review and sometime committer push the code they didn't familiar with. I decided to spend much more time on reviewing code during 4.2 release period, trying to make sure I would review everything on netw

Re: Review Request 12716: Fix for NPE

> On July 18, 2013, 3:54 p.m., Sheng Yang wrote: > > Ship It! Pushed to 4.2 and MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12716/#re

Re: Review Request 12744: Removed unused classes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#review23444 --- Ship it! Ship It! - Sheng Yang On July 18, 2013, 8:51 p.m

Re: Review Request 12744: Removed unused classes

> On July 18, 2013, 10:42 p.m., Sheng Yang wrote: > > Ship It! Pushed to MASTER. - Sheng --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12744/#re

Re: Review Request 12743: removed unused class and related test utils

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12743/ --- (Updated July 18, 2013, 10:53 p.m.) Review request for cloudstack and Kelven Ya

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

Daan, Bharat thinks your fix caused a block bug https://issues.apache.org/jira/browse/CLOUDSTACK-3589? Could you check it? --Sheng On Thu, Jul 18, 2013 at 9:52 AM, Bharat Kumar wrote: > Hi Dann, > > The bug fix > https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commitdiff;h=b903262df5

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

at and he would provide a patch soon to revert the DnsMasqConfigurator, and use bash scripts to do the necessary substitute instead. I think any potential change to dnsmasq config command need to wait for it. --Sheng On Fri, Jul 19, 2013 at 5:54 PM, Sheng Yang wrote: > Daan, > > Bharat thi

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

Add Daan's gmail. --Sheng On Fri, Jul 19, 2013 at 6:32 PM, Sheng Yang wrote: > Daan, I've checked the code, the issue is, original code Bharat > wrote(generated dnsmasq.conf) cannot deal with VPC. e.g. the VPC router > wouldn't listen on eth0 and eth1, but non-vpc r

Re: master unstable with CLOUDSTACK-3682/3683

CLOUDSTACK-3682: NPE in BridgeVifDriver causing systemvm startup failure in KVM https://issues.apache.org/jira/browse/CLOUDSTACK-3682 Agent log excerpt: Jul 19 22:25:24 apache-81-3.fmt.vmops.com local1: 2013-07-20 05:25:24,952 WARN [cloud.agent.Agent] (agentRequest-Handler-1:null) Caught: Jul 19

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

h the different nics? > > > On Sat, Jul 20, 2013 at 3:32 AM, Sheng Yang wrote: > > > Daan, I've checked the code, the issue is, original code Bharat > > wrote(generated dnsmasq.conf) cannot deal with VPC. e.g. the VPC router > > wouldn't listen o

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

osed to only generate a dnsmasq.conf for vpc-router-vm's. not > > guestnetwork-vm's. I am happy to look at it, but have no overview of the > > issue yet. Should a sepperate dnsmasq.conf instance be created for vpc > > routers to deal with the different nics? > > > &g

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

n Hoogland wrote: > So if I understand your mail correctly, a VpcDnsMasqConfigurator should be > created to be used in configDnsMasq in VpcVirtualApplienceManagerImpl, > instead of the one used now? > > > On Sun, Jul 21, 2013 at 6:01 PM, Sheng Yang wrote: > > > Hi Daan, &

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

eak > integration last week, did it? So a newer patch needs to be reverted, no? > The problem might be cumulative due to more then one commit, in which case > a role forward might be the quickest way to go. > > > On Sun, Jul 21, 2013 at 6:15 PM, Sheng Yang wrote: > > > I

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

the future? --Sheng On Sun, Jul 21, 2013 at 9:28 AM, Sheng Yang wrote: > Sorry, the integration test of VPC has been failed for quite some time, I > just found this issue after fixing some other issues in the integration > test... > > --Sheng > > > > On Sun, Jul 21,

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

I've got into at least two exceptions lately. They made me skeptic. --Sheng On Sun, Jul 21, 2013 at 10:38 AM, David Nalley wrote: > On Sun, Jul 21, 2013 at 12:52 PM, Sheng Yang wrote: > > And it's also my fault on this issue because I didn't look at the patch > &g

Re: Regarding the BLOCKER bug Cloudstack-3589 VM created from VPC network is not getting IP

After talking with Daan, we decided to revert the commit for now. After Bharat complete the rewrite of dnsmasqconfigurator in bash script. A new patch would be committed to fix CLOUDSTACK-3357 before the code freeze, --Sheng On Sun, Jul 21, 2013 at 9:52 AM, Sheng Yang wrote: > And it

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

s://reviews.apache.org/r/12810/#comment47557> This is wrong. It cannot fail silently. The return result should be $result, rather than $?. should be: unlock_exit $result $lock $locked patches/systemvm/debian/config/root/dnsmasq.sh <ht

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

> On July 22, 2013, 10:23 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 54 > > <https://reviews.apache.org/r/12810/diff/2/?file=324528#file324528line54> > > > > You don't need so complicate way to find dns is enabled or

Re: Review Request 12810: DnsMasqConfigurator need to be rewrite in bash script

e overriding here would cover the fact that it's failed to apply the new config. It's in much better shape than previous edition. Please do more testing, e.g. VPC, multiple guest network for user VM. It's likely we can get it in tomorrow. Thanks! - Sheng Yang On

  1   2   3   4   >