----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12566/#review23208 -----------------------------------------------------------
Ship it! Ship It! - Sheng Yang On July 16, 2013, 1:43 a.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12566/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 1:43 a.m.) > > > Review request for cloudstack, Chip Childers, Kelven Yang, Sateesh > Chodapuneedi, and Sheng Yang. > > > Bugs: CLOUDSTACK-3514 > > > Repository: cloudstack-git > > > Description > ------- > > This fix is for an NPE encountered during automation test runs. The NPE > showed up in the code that queries resource counts by domain/account id. I > was unable to reproduce this in manual testing, but the code definitely needs > to be changed to protect against the NPE, so I'm submitting this patch > nevertheless. If it is checked in, QA can proceed with their testing. Hence > requesting that this patch be checked in. > > > Diffs > ----- > > server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java b5c060d > > Diff: https://reviews.apache.org/r/12566/diff/ > > > Testing > ------- > > Issue non-reproducible during manual testing. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
