> On July 22, 2013, 10:23 p.m., Sheng Yang wrote: > > patches/systemvm/debian/config/root/dnsmasq.sh, line 54 > > <https://reviews.apache.org/r/12810/diff/2/?file=324528#file324528line54> > > > > You don't need so complicate way to find dns is enabled or not. Just > > check /var/cache/cloud/cmdline for entry " dns1", " dns2"(remember add > > leading space to avoid ip6dns) > > > > And if cmdline contained "useextdns=true", then dns1/dns2 should be > > used directly in such case. You don't need to check eth0 ip is dns or not. > > > > In fact I don't think you need to add dhcp-option=tag:xxx,6,xxx for dns > > server of every range you added. You should able to use the original > > dhcp-option=6,xxx to cover all the cases. It should by default cover > > everything. > > bharat kumar wrote: > Hi sheng, > > in case if useextndns is not true we have to add the routerip > corresponding to each subnet so we need to add the option like this > dhcp-option=tag:xxx,6,xxx. > >
Yes, you're right. dhcp-option=6,xxx only apply to useextdns. - Sheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/#review23649 ----------------------------------------------------------- On July 23, 2013, 1:07 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12810/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 1:07 p.m.) > > > Review request for cloudstack, Alena Prokharchyk and Sheng Yang. > > > Bugs: CLOUDSTACK-3694 > > > Repository: cloudstack-git > > > Description > ------- > > https://issues.apache.org/jira/browse/CLOUDSTACK-3694 > > wrote the dnsmasq config in bash instead of creating the config file in java > and overwriting. > > > Diffs > ----- > > core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > 0b26220 > core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df > patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 > patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > c7f487e > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > f80d4b6 > scripts/vm/hypervisor/xenserver/vmops f8c0253 > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 6c0f7a1 > > Diff: https://reviews.apache.org/r/12810/diff/ > > > Testing > ------- > > Tested on old master using xenserver. > Could not test on the latest one as it is broken. > > > Thanks, > > bharat kumar > >
