We need some mechanism to help on review board. Sometime the people didn't know who to ask for review and sometime committer push the code they didn't familiar with.
I decided to spend much more time on reviewing code during 4.2 release period, trying to make sure I would review everything on network part, and also change reviewer(potentially follow up) to ensure the expert on the certain area has a chance to take a look at the code before the patch checked in. Let's see how it would go... --Sheng On Thu, Jul 18, 2013 at 9:18 AM, Prasanna Santhanam <t...@apache.org> wrote: > On Thu, Jul 18, 2013 at 06:07:48PM +0200, Daan Hoogland wrote: > > this has been kind of bugging me too. Along with unanswered questions on > > teh list by newbees like me. As we all depend on volunteers and > > conculeagues I don't really see a solution but reporting on outstanding > > reviews and maybe unanswered questions. The latter can only be done > > manually though, as it is really hard to automatically determine that a > > mail requires reply. I kept track of the unanswered mails for one week > > after ccc13. It were six that I didn't have time to gain knowledge to > > answer. This is not extreme, but still may be a waste as some of the > posing > > people might have been thrown of the cloudstack track by them. Hugo said > he > > had a script querying the review board for old reviews and an automated > > report on that would be easier. I know all you guru's do your best but a > > weekly report, keeping us all conscious might help. > > > Yes - Rohit wrote the script and I send it sometimes before things > like freeze/deadlines to alert the community but everyone's like ... > meh. > > https://github.com/vogxn/RBTool (that's the tool) > > We should also have IRC alerts via ASFBot for every rb request posted > and merged. I was going to work on this with Humbeedoh (INFRA) but am > yet to get to it. Feel free to pick it up - ASFBot is written in Lua. > > If you can't convince the people, try write tools around it eh? > > > > As you might have guessed this is me volunteering to keep track of > > unanswered questions for a few weeks. As we go along good ideas on how to > > improve our way might spring up. /me is an optimist at rare occasions. > > I rant and go do the postive thing hoping for it to be picked up. > Guess that makes me an optimist :) > > -- > Prasanna., > > ------------------------ > Powered by BigRock.com > >
