[Blocker] KVM host goes into disconnected state when MS is restarted

2015-09-18 Thread Raja Pullela
Hi, Filed a blocker - https://issues.apache.org/jira/browse/CLOUDSTACK-8883 All the KVM BVTs - Basic/Adv installations are failing due to this defect - the reason being automation process involves restarting MS and the Hosts go into a disconnected state. As a result, SSVM/CPVMs doesn't get dep

Fwd: OpenSource.com and promoting Apache

2015-09-18 Thread Erik Weber
For those who doesn't pay attention to or follows ComDev/the committers list. This is an excellent opportunity to promote Apache CloudStack (and your $dayjob if applicable) if anyone want to write a piece :-) -- Erik -- Forwarded message -- From: Rich Bowen Date: Thu, Sep 17, 2

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141377920 -1 to this PR as I am not able to follow how the change is related to the bug. Also this is going to impact any HV having VM changes outside of CS like Vmware an

[GitHub] cloudstack pull request: Pass LbProtocol down to the HAProxyConfig...

2015-09-18 Thread insom
GitHub user insom opened a pull request: https://github.com/apache/cloudstack/pull/848 Pass LbProtocol down to the HAProxyConfigurator This will let us specify a new load balancer protocol (tcp-proxy) which enables HAProxy's `send-proxy` functionality. `send-proxy` /

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-09-18 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/849 Cloudstack-8816 some of the events do not have resource uuids The key objects in the context map are sometimes String and sometimes object. This causes missing uuids when an entity put in the c

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141403050 @koushik-das I am perfectly fine with not putting this code in but I don't understand that you don't follow how it is related to the bug reported. The logs supp

[GitHub] cloudstack pull request: CLOUDSTACK-8826: XenServer - Use device i...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/792#discussion_r39839158 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -3407,6 +3390,18 @@ public void h

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141407138 @koushik-das @DaanHoogland unless we have a "better" solution I would like to go with @anshul1886 suggested fix. It seems the best way not breaking anything else.

[GitHub] cloudstack pull request: CLOUDSTACK-8656: tests ignoring exception...

2015-09-18 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/850 CLOUDSTACK-8656: tests ignoring exceptions final few ignored exceptions supplied with log messages. You can merge this pull request into a Git repository by running: $ git pull https:/

[GitHub] cloudstack pull request: Cloudstack-8816 some of the events do not...

2015-09-18 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/849#discussion_r39843941 --- Diff: api/src/org/apache/cloudstack/context/CallContext.java --- @@ -90,7 +90,13 @@ public void putContextParameter(Object key, Object value) {

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread koushik-das
Github user koushik-das commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141418450 @DaanHoogland As per logs attached in bug VR reboot happened due to out-of-band movement from one host to another and not due to power report missing. H

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141421211 @koushik-das about the bug probably not being in 4.6 i agree. @resmo I understood that the router was rebooted while you set the reboot on out of band flag t

Re: jenkins disk full ?

2015-09-18 Thread Pierre-Luc Dion
Hi, Srikanteswararao (or any one having access to jenkins server), do you think you could do some more magic here? We ran out of space again on the master jenkins server for j.bac.o. Thanks, PL On Mon, Jun 1, 2015 at 4:26 PM, Pierre-Luc Dion wrote: > thanks Srikanteswararao, it worked and

Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Raja Pullela
Hi, We have been having steady rate of blocker issues/breakages. I am proposing to see if we can get to a 100% passrate on BVTs by next Friday, Sep 25th or sooner. Once we reach 100% passrate, we should closely monitor BVTs and back out commits that we think have broken BVTs. I will report the

Re: Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Daan Hoogland
Raja, great initiative. I don't think we should wait with the back out part unitll we are at 100%. We can start backing out any commit that reduces the pass rate in any way right now. €0,02 On Fri, Sep 18, 2015 at 1:55 PM, Raja Pullela wrote: > Hi, > > We have been having steady rate of blocker

Re: Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Boris Schrijver
Hi, Good idea! I'll pickup CLOUDSTACK-8883! Best regards, Boris Schrijver TEL: +31633784542 MAIL: bo...@pcextreme.nl > > On September 18, 2015 at 1:59 PM Daan Hoogland > wrote: > > > Raja, great initiative. I don't think we should wait with the back out > part > unitll we are

RE: Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Raja Pullela
cool, thanks Boris and Daan! I agree on the back out part... but we need to be sure that a particular commit is the issue. Let us see! -Original Message- From: Boris Schrijver [mailto:bo...@pcextreme.nl] Sent: Friday, September 18, 2015 5:34 PM To: dev Subject: Re: Proposal to get

Re: Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Remi Bergsma
Hi Raja, Let’s think of a way to get the BVT score on any PR that is opened. Then we know if there’s a problem introduced in a PR before merge, instead of after. We need to automate this, or else we keep having the same issues. We can meet online somewhere next week to discuss our approach? I

Re: Proposal to get to 100% passrate on BVTs

2015-09-18 Thread Raja Pullela
Sure Remi, let us do on Monday... I agree, date needs to be realistic. As long as we close on the blockers quickly - fixing or backing out a commit that caused it, we should be able to hit the deadlines. > On Sep 18, 2015, at 5:44 PM, Remi Bergsma wrote: > > Hi Raja, > > Let’s think of a

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141482058 @koushik-das @anshul1886 the grace period is not going to work. updat_time is not getting updated. We really need to fix the statemachine --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread mlsorensen
Github user mlsorensen commented on the pull request: https://github.com/apache/cloudstack/pull/801#issuecomment-141502048 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

Re: jenkins disk full ?

2015-09-18 Thread David Nalley
I freed up a little bit of space, but we'll have to do something different in the long term. --David On Fri, Sep 18, 2015 at 7:37 AM, Pierre-Luc Dion wrote: > Hi, > > Srikanteswararao (or any one having access to jenkins server), do you think > you could do some more magic here? We ran out of s

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39894855 --- Diff: plugins/network-elements/nuage-vsp/pom.xml --- @@ -28,6 +28,13 @@ 4.6.0-SNAPSHOT ../../pom.xml + + +

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895038 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/UpdateNuageVspDeviceCommand.java --- @@ -0,0 +1,42 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895255 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java --- @@ -0,0 +1,137 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895295 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ImplementVspCommand.java --- @@ -0,0 +1,137 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895353 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ApplyAclRuleVspCommand.java --- @@ -19,31 +19,45 @@ package com.

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895331 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/element/ShutDownVpcVspCommand.java --- @@ -25,11 +25,13 @@ String _d

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895401 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java --- @@ -28,23 +28,27 @@ String _nicMacAdd

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895422 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java --- @@ -33,16 +34,23 @@ String _netwo

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895754 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java --- @@ -36,14 +37,26 @@ String _vmU

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895682 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java --- @@ -33,16 +34,23 @@ String _netwo

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895798 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/TrashNetworkVspCommand.java --- @@ -26,14 +26,18 @@ String _domainUui

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895772 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ReserveVmInterfaceVspCommand.java --- @@ -36,14 +37,26 @@ String _vmU

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895856 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java --- @@ -0,0 +1,54 @@ +// +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39895992 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/GetClientDefaultsAnswer.java --- @@ -0,0 +1,54 @@ +// +// Licensed

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896098 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/SupportedApiVersionCommand.java --- @@ -0,0 +1,42 @@ +// +// Licens

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896161 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java --- @@ -0,0 +1,37 @@ +// +// Licensed to the Apa

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896222 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java --- @@ -0,0 +1,65 @@ +// +// Licensed to the Ap

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896282 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainCommand.java --- @@ -0,0 +1,65 @@ +// +// Licensed to the Ap

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896295 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncDomainAnswer.java --- @@ -0,0 +1,37 @@ +// +// Licensed to the Apa

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896434 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java --- @@ -17,38 +17,33 @@ // under the Licens

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896365 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java --- @@ -0,0 +1,49 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896344 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdAnswer.java --- @@ -0,0 +1,49 @@ +// +// Licensed to

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896480 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java --- @@ -17,38 +17,33 @@ // under the Licens

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896513 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java --- @@ -17,38 +17,33 @@ // under the Licens

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896636 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/AddNuageVspDeviceCmd.java --- @@ -41,6 +29,17 @@ import com.cloud.network.N

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896665 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/DeleteNuageVspDeviceCmd.java --- @@ -38,6 +28,15 @@ import com.cloud.except

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896720 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/ListNuageVspDevicesCmd.java --- @@ -42,6 +28,18 @@ import com.cloud.network

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896708 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/IssueNuageVspResourceRequestCmd.java --- @@ -53,6 +36,21 @@ import com.clou

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896799 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/UpdateNuageVspDeviceCmd.java --- @@ -0,0 +1,180 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39896732 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/api/commands/UpdateNuageVspDeviceCmd.java --- @@ -0,0 +1,180 @@ +// +// Licensed to t

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39898685 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -129,6 +145,18 @@ AgentManager _agentMgr

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39898784 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -196,6 +227,20 @@ public boolean implement(Networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39898871 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -196,6 +227,20 @@ public boolean implement(Networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39898949 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -395,31 +510,23 @@ public IpDeployer getIpDeploye

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899078 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -205,6 +250,75 @@ public boolean implement(Networ

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899186 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -395,31 +510,23 @@ public IpDeployer getIpDeploye

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899414 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -395,31 +510,23 @@ public IpDeployer getIpDeploye

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899393 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -370,7 +485,7 @@ public boolean applyStaticNats(N

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899765 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899741 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899784 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39899929 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r3995 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39900040 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -454,6 +563,80 @@ protected boolean applyACLRules

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39900272 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java --- @@ -493,6 +676,15 @@ protected boolean isL3Network(L

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39900388 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +131,97 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901557 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +131,97 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901746 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901764 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901691 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -129,66 +131,97 @@ public Network design(Ne

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901809 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39901880 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902120 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902256 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902273 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -201,51 +234,82 @@ public NicProfile alloca

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902362 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -255,43 +319,22 @@ protected boolean canHan

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902380 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -255,43 +319,22 @@ protected boolean canHan

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902498 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -322,35 +383,57 @@ public void shutdown(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902671 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -322,35 +383,57 @@ public void shutdown(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902797 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902767 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -322,35 +383,57 @@ public void shutdown(Net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902808 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902801 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39902902 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903111 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903296 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java --- @@ -358,19 +441,22 @@ private String getVirtua

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903426 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java --- @@ -19,37 +19,66 @@ package com.cloud.net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903493 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java --- @@ -19,37 +19,66 @@ package com.cloud.net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903522 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManager.java --- @@ -19,37 +19,66 @@ package com.cloud.net

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903696 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903745 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903815 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39903824 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39904007 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39904125 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39904211 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39904637 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -152,53 +226,181 @@ public NuageVspDeviceVO

[GitHub] cloudstack pull request: CLOUDSTACK-8832 : Update Nuage VSP plugin...

2015-09-18 Thread jburwell
Github user jburwell commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/801#discussion_r39904829 --- Diff: plugins/network-elements/nuage-vsp/src/com/cloud/network/manager/NuageVspManagerImpl.java --- @@ -285,60 +507,341 @@ public boolean deleteNua

  1   2   >