Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39896434
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/sync/SyncNuageVspCmsIdCommand.java
---
@@ -17,38 +17,33 @@
// under the License.
//
-package com.cloud.agent.api.guru;
+package com.cloud.agent.api.sync;
import com.cloud.agent.api.Command;
-public class ReleaseVmVspCommand extends Command {
+public class SyncNuageVspCmsIdCommand extends Command {
- String _networkUuid;
- String _vmUuid;
- String _vmInstanceName;
+ public enum SyncType { AUDIT, AUDIT_ONLY, REGISTER, UNREGISTER }
- public ReleaseVmVspCommand(String networkUuid, String vmUuid, String
vmInstanceName) {
- super();
- this._networkUuid = networkUuid;
- this._vmUuid = vmUuid;
- this._vmInstanceName = vmInstanceName;
- }
+ SyncType _syncType;
+ String _nuageVspCmsId;
--- End diff --
Why aren't these attributes declared private? It doesn't appear to modified
outside of the constructor. Why aren't they declared final as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
