Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39895422
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/ImplementNetworkVspCommand.java
---
@@ -33,16 +34,23 @@
String _networkName;
String _networkCidr;
String _networkGateway;
+ Long _networkAclId;
+ List<String> _dnsServers;
+ List<String> _gatewaySystemIds;
String _networkUuid;
boolean _isL3Network;
+ boolean _isVpc;
+ boolean _isSharedNetwork;
String _vpcName;
String _vpcUuid;
boolean _defaultEgressPolicy;
- Collection<String> _ipAddressRange;
+ Collection<String[]> _ipAddressRange;
+ String _domainTemplateName;
--- End diff --
Why aren't these attributes declared ``private``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
