Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39898871
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -196,6 +227,20 @@ public boolean implement(Network network,
NetworkOffering offering, DeployDestin
ResourceUnavailableException, InsufficientCapacityException {
s_logger.debug("Entering NuageElement implement function for
network " + network.getDisplayText() + " (state " + network.getState() + ")");
+ if (network.getVpcId() != null) {
+ List<NetworkACLItemVO> rules;
+ if (network.getNetworkACLId() != null) {
+ rules =
_networkACLItemDao.listByACL(network.getNetworkACLId());
+ } else {
+ rules = new ArrayList<NetworkACLItemVO>(1);
--- End diff --
Why is a ``List`` of length 1 being created here? If it should be empty,
please use ``Collections.emptyList()``. Otherwise, it feels like a leaking
abstraction.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
