Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39900272
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -493,6 +676,15 @@ protected boolean isL3Network(Long offeringId) {
||
_ntwkOfferingSrvcDao.areServicesSupportedByNetworkOffering(offeringId,
Service.StaticNat);
}
+ private String getPreConfiguredDomainTemplateName(Network network,
NetworkOffering networkOffering) {
+ if (network.getVpcId() != null) {
+ return
_configDao.getValue(NuageVspManager.NuageVspVpcDomainTemplateName.key());
+ } else if (networkOffering.getGuestType() ==
Network.GuestType.Shared) {
+ return
_configDao.getValue(NuageVspManager.NuageVspSharedNetworkDomainTemplateName.key());
+ }
+ return
_configDao.getValue(NuageVspManager.NuageVspIsolatedNetworkDomainTemplateName.key());
--- End diff --
Why not set a local variable with the value to passed into
``_configDao.getValue(..)`` to make the method more concise and DRY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
