Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/801#discussion_r39895401
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/guru/DeallocateVmVspCommand.java
---
@@ -28,23 +28,27 @@
String _nicMacAddress;
String _nicIp4Address;
boolean _isL3Network;
+ boolean _isSharedNetwork;
String _vpcUuid;
String _networksDomainUuid;
String _vmInstanceName;
String _vmUuid;
+ boolean _isExpungingState;
--- End diff --
Why aren't these attributes declared ``private``?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
