Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review25215 --- Ship it! With no open issues and all review items processed i'm shi

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 15, 2013, 7:53 a.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 13, 2013, 1:58 p.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 9, 2013, 5:23 p.m., Toshiaki Hatano wrote: > > api/src/com/cloud/network/Networks.java, line 172 > > > > > > Why don't we merge getValueFrom() and getValue()? > > > > public String getValue(URI uri)

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 9, 2013, 5:23 p.m., Toshiaki Hatano wrote: > > api/src/com/cloud/network/Networks.java, line 172 > > > > > > Why don't we merge getValueFrom() and getValue()? > > > > public String getValue(URI uri)

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24925 --- api/src/com/cloud/network/Networks.java

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 8, 2013, 11:51 a.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 8, 2013, 11:16 a.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 12849: added backwards compatibility code to Networks enums

Donal, The mix of vlan:// and is one of the issues i had to deal with doing this. The vlan not being handled by my first patch correctly is why this second one was made. for vlans it reverts what I did before. What is it you are seeing? And how does it relate to the BroadcastDomainType? The code

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 79 > > > > > > I don't quite understand this part. Why "//" is missing in this case? > > Who would require "//" and who

Re: Review Request 12849: added backwards compatibility code to Networks enums

Chiradeep, Sheng, Can you guys have a look at this? I cleaned up a bit with Davids guidance. thanks, Daan On Wed, Aug 7, 2013 at 11:40 AM, daan Hoogland wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12849/ > Review request for cloudsta

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 7, 2013, 9:40 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24787 --- Three minor comments, but my main concerns are addressed by this dif

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 147 > > > > > > No reference of getTypeOf(URI) in the code? this code supplies facilities for features that are being

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 7, 2013, 8:50 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 79 > > > > > > I don't quite understand this part. Why "//" is missing in this case? > > Who would require "//" and who

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 7, 2013, 8:38 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

Sheng, Some of this code will be used in a feature allowing vpc gateways to be plugged to sdn networks and to allow multiple gateways to share that network. I am using that in a hack on 4.1.1 and porting the code to master now, bit by bit so to speak. This is why you see some functions that seem n

Re: Review Request 12849: added backwards compatibility code to Networks enums

Hi Dave, I see what you mean by colons wouldn't be allowed. Nothing changed but I went for this solution for consistency (over backward compatibility). I will change again. Let me get to work first. nice working around the globe;) Daan On Wed, Aug 7, 2013 at 3:57 AM, Sheng Yang wrote: >Th

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 135 > > > > > > I think by following the previous case, it should be > > URI(scheme,value.toString()) rather than "nul

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 135 > > > > > > I think by following the previous case, it should be > > URI(scheme,value.toString()) rather than "nul

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 6, 2013, 11:40 p.m., Sheng Yang wrote: > > api/src/com/cloud/network/Networks.java, line 135 > > > > > > I think by following the previous case, it should be > > URI(scheme,value.toString()) rather than "nul

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On Aug. 7, 2013, 1:10 a.m., Dave Cahill wrote: > > api/src/com/cloud/network/Networks.java, line 135 > > > > > > Sheng, not sure if you caught the conversation around breaking > > backwards compatibility, but it exp

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24766 --- Replied to Sheng's comments. api/src/com/cloud/network/Networks.ja

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24756 --- api/src/com/cloud/network/Networks.java

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 6, 2013, 2:25 p.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 6, 2013, 2:07 p.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24720 --- As discussed on IRC Daan's aim is to allow using URIs of type lswitc

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 6, 2013, 10:41 a.m.) Review request for cloudstack, Chiradeep Vit

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24710 --- api/src/com/cloud/network/Networks.java

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 6, 2013, 9:16 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- (Updated Aug. 5, 2013, 9:57 a.m.) Review request for cloudstack, Chiradeep Vitt

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review24161 --- I tested this patch locally, VLAN isolated advanced zone with 1 KVM

Re: Review Request 12849: added backwards compatibility code to Networks enums

> On July 23, 2013, 12:30 p.m., Koushik Das wrote: > > api/src/com/cloud/network/Networks.java, line 225 > > > > > > Why only Vlan in case of IsolationType and Vlan, Storage and Mido in > > the case of BroadcastDomain

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review23686 --- api/src/com/cloud/network/Networks.java

Re: Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/#review23683 --- Review 12849 PASSED the build test The url of build cloudstack-maste

Review Request 12849: added backwards compatibility code to Networks enums

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12849/ --- Review request for cloudstack and Koushik Das. Repository: cloudstack-git Des